[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697360#comment-14697360
]
Hervé Boutemy edited comment on MPIR-234 at 8/14/15 4:53 PM:
-
bq. NIT: those checkout instructions do not checkout the branch that the report
was generated from
I already did that in MPIR-291, available in MPIR 2.8
the only mising part is that, in MPIR-290, I don't display {{cd
maven-surefire/surefire-api}}
was (Author: hboutemy):
bq. NIT: those checkout instructions do not checkout the branch that the report
was generated from
if already did that in MPIR-291, available in MPIR 2.8
the only mising part is that, in MPIR-290, I don't display {{cd
maven-surefire/surefire-api}}
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698029#comment-14698029
]
Chris Graham edited comment on MPIR-234 at 8/15/15 2:16 AM:
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out bthat module/b.
Perhaps I was not clear, or you missed my point.
Which is: In some SCM's checking out a sub module, it is impossible. It's an
all or nothing operation, not a cherry picking one.
So there should be a Source Repository for sub-modules.
No there should not. Or, at best, it is only meaningful for those SCM's that
can support it.
All you are doing in your example is cloning the bentire repo/b [you cann't
not] and then checking out (-b) the branch. How is this a sub module?
was (Author: chrisgwarp):
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out bthat module/b.
Perhaps I was not clear, or you missed by point.
Which is: In some SCM's checking out a sub module, it is impossible. It's an
all or nothing operation, not a cherry picking one.
So there should be a Source Repository for sub-modules.
No there should not. Or, at best, it is only meaningful for those SCM's that
can support it.
All you are doing in your example is cloning the bentire repo/b [you cann't
not] and then checking out (-b) the branch. How is this a sub module?
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681545#comment-14681545
]
Stephen Connolly edited comment on MPIR-234 at 8/11/15 9:49 AM:
Well in general I see the SCM section being inherited as being an indication
that the module is intended to be checked out with the parent and not
independently.
Now there are some differences... for example when somebody includes
{{project.artifactId}}
was (Author: stephenc):
Well in general I see the SCM section being inherited as being an indication
that the module is intended to be checked out with the parent and not
independently.
Now there are some differences... for example when somebody includes {{
${project.artifactId} }}
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682341#comment-14682341
]
Robert Scholte edited comment on MPIR-234 at 8/11/15 7:31 PM:
--
The more I think about it, the more I like the idea of [~stephenc].
- No scm specific logic in Maven core.
- Relying on the scm of the parent isn't always correct. Instead only a moduled
pom can calculate the actual connection for its modules.
- For the m-release-p it'll be much easier: no scm on the execution root, then
it is not a valid release root. This will prevent a lot of issues when starting
a new Maven project which fail when tagging due to incorrect inheritance.
This is actually one of the things I tried to fix with maven-project-utils'
[ScmUtils.java|http://svn.apache.org/viewvc/maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/ScmUtils.java?view=markup].
If we want to expose the connection for submodules like now is done for svn, we
could adjust the pom.xml during a release: all poms are touched anyway and
m-release-p already has the required scm dependency so the calculation should
be simple.
was (Author: rfscholte):
The more I think about it, the more I like the idea of [~stephenc].
- No scm specific logic in Maven core.
- Relying on the scm of the parent isn't always correct. Instead only a moduled
pom can calculate the actual connection for its modules.
- For the m-release-p it'll be much easier: no scm on the execution root, then
it is not a valid release root. This will prevent a lot of issues when starting
a new Maven project which fail when tagging due to incorrect inheritance.
This is actually one of the things I tried to fix with maven-project-utils'
[ScmUtils.java|http://svn.apache.org/viewvc/maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/ScmUtils.java?view=markup].
If we want to expose the connection for submodules like now is done for svn, we
could adjust the pom.xml during a release: all poms are touched anyway and
m-release-p already has the required scm dependency so the calculation should
be simple.
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692588#comment-14692588
]
Hervé Boutemy edited comment on MPIR-234 at 8/12/15 12:07 AM:
--
I don't understand the idea of report configuration
but I completely agree with the idea of scm configuration that should be
necessary only for release root
and of course, no scm specific logic in Maven core
and that's what we get with extended git scm url
it's a general contract that should be enforcer for every supported scm
(http://maven.apache.org/scm/scms-overview.html ): scm url should support going
from a parent to a child Maven module by adding the path to the url
in fact, our svn documentation saying
{{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository}}
IMHO has always been misleading: it should probably be
{{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository/path_inside_repository}}
the difference between svn and scms causing issues currently is that the
separation between path_to_repository and path_inside_repository is really
enforced: hence the separator that has to be added to clearly mark the
difference
was (Author: hboutemy):
I don't understand the idea of scm configuration
but I completely agree with the idea of scm configuration that should be
necessary only for release root
and of course, no scm specific logic in Maven core
and that's what we get with extended git scm url
it's a general contract that should be enforcer for every supported scm
(http://maven.apache.org/scm/scms-overview.html ): scm url should support going
from a parent to a child Maven module by adding the path to the url
in fact, our svn documentation saying
{{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository}}
IMHO has always been misleading: it should probably be
{{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository/path_inside_repository}}
the difference between svn and scms causing issues currently is that the
separation between path_to_repository and path_inside_repository is really
enforced: hence the separator that has to be added to clearly mark the
difference
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679150#comment-14679150
]
Michael Osipov edited comment on MPIR-234 at 8/9/15 1:48 PM:
-
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho). Maven can be shipped with Git and Subverion
extensions by default.
was (Author: michael-o):
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho).
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679150#comment-14679150
]
Michael Osipov edited comment on MPIR-234 at 8/9/15 1:48 PM:
-
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho). Maven can be shipped with Git and Subversion
extensions by default.
was (Author: michael-o):
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho). Maven can be shipped with Git and Subverion
extensions by default.
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
