[jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
[ http://jira.codehaus.org/browse/MNG-643?page=comments#action_45044 ] Dan Tran commented on MNG-643: -- It woks big thanks both KrisBravo and John Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Priority: Critical Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 2 hours Time Spent: 2 hours Remaining: 0 minutes m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
I'm happy to hear that! Thanks for the testing Dan. -- Kris Bravo Corridor Software, Inc. http://www.corridor-software.us [ http://jira.codehaus.org/browse/MNG-643?page=comments#action_45044 ] Dan Tran commented on MNG-643: -- It woks big thanks both KrisBravo and John Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Priority: Critical Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 2 hours Time Spent: 2 hours Remaining: 0 minutes - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Glad to hear it, and thanks for the testing, Dan. - -j Dan Tran (JIRA) wrote: | [ http://jira.codehaus.org/browse/MNG-643?page=comments#action_45044 ] | | Dan Tran commented on MNG-643: | -- | | It woks big thanks both KrisBravo and John | | |Support includes and excludes for the source and testSource directories. | | | Key: MNG-643 | URL: http://jira.codehaus.org/browse/MNG-643 | Project: Maven 2 |Type: Improvement | Components: maven-plugins |Versions: 2.0-alpha-3 | Environment: jdk 1.4.x, gentoo linux |Reporter: Corridor Software Developer |Assignee: John Casey |Priority: Critical | Fix For: 2.0-beta-1 | Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch | |Original Estimate: 2 hours | Time Spent: 2 hours |Remaining: 0 minutes | |m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. |Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: |1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. |2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. |3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. |4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. |5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. |In an effort to avoid breaking the existing pom format, the following tags would be supported: | sourceDirectory../../src/java/sourceDirectory |xor | source | directory../../src/java/directory | includes | include**/package/*.java/include | /includes | excludes | exclude**/*Test.java/exclude | /excludes | /source |and | testSourceDirectory../../src/java/testSourceDirectory |xor | testSource | directory../../src/java/directory | includes | include**/*Test.java/include | /includes | /testSource |This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. |The change creates a path for deprecating the existing format later if desired. |The change would not break existing pom.xml files. |If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. | | -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFDC2eXK3h2CZwO/4URAsO4AJ4p8NnN2/f0TH0O2uDwAWZV4Bg78ACeKpJ9 6pwW5SVtgOBxBjTGNXLwp9o= =Ulgq -END PGP SIGNATURE- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
[ http://jira.codehaus.org/browse/MNG-643?page=comments#action_44971 ] Dan Tran commented on MNG-643: -- John, I did apply patch locally. Then use the feature in a precompile step, in validation phase, to compile a few java files, and uses the class files to run my java2iiop. This step works, However, at the compile phase, the plugin seem to think i no longer have any file to compile ( empty source root ) and skip the rest -Dan Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Priority: Critical Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 2 hours Remaining: 2 hours m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
Can I take a look at your pom as well? Interested in knowing more about what you are doing and how the include/exclude change affects it. Kris On Mon, 2005-08-22 at 16:12 -0500, Dan Tran (JIRA) wrote: [ http://jira.codehaus.org/browse/MNG-643?page=comments#action_44971 ] Dan Tran commented on MNG-643: -- John, I did apply patch locally. Then use the feature in a precompile step, in validation phase, to compile a few java files, and uses the class files to run my java2iiop. This step works, However, at the compile phase, the plugin seem to think i no longer have any file to compile ( empty source root ) and skip the rest -Dan Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Priority: Critical Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 2 hours Remaining: 2 hours m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
[ http://jira.codehaus.org/browse/MNG-643?page=comments#action_45002 ] John Casey commented on MNG-643: Applied patch manually, since the compiler plugin had changed noticeably (line positions, mainly) since the patch was produced. Also, introduced two ITs, it0055 and it0056 to test the inclusions/exclusions for the compile and testCompile mojos. it0056 is meant to test the case where the compile mojo is bound to two different phases in two executions (one of which is implied by the lifecycle). Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Priority: Critical Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 2 hours Time Spent: 2 hours Remaining: 0 minutes m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
[ http://jira.codehaus.org/browse/MNG-643?page=comments#action_44754 ] Dan Tran commented on MNG-643: -- will it has implication of generated source where we add addition dir to source root?? In the case of generate-sources phase, are we able set exclude/include as well? Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 1 week Remaining: 1 week m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-643) Support includes and excludes for the source and testSource directories.
[ http://jira.codehaus.org/browse/MNG-643?page=comments#action_44765 ] Corridor Software Developer commented on MNG-643: - Dan Tran: Assuming the generated-source directory is added to the source path for the compile goal, then yes, the filter will apply to the generated source files as well. I need to update this patch once more per a discussion with Brett regarding the layout of the configuration items. He'd prefer to consolidate the configuration with includes, excludes, testIncludes, and testExcludes. The updated format is on my other computer but I'll post it with the new patch code. Support includes and excludes for the source and testSource directories. Key: MNG-643 URL: http://jira.codehaus.org/browse/MNG-643 Project: Maven 2 Type: Improvement Components: maven-plugins Versions: 2.0-alpha-3 Environment: jdk 1.4.x, gentoo linux Reporter: Corridor Software Developer Assignee: John Casey Fix For: 2.0-beta-1 Attachments: FilterCriteriaForCompilerPlugin.patch, FilterCriteriaForCompilerPlugin.patch Original Estimate: 1 week Remaining: 1 week m2 currently supports FileSets in resources and testResources which allow for the inclusion and exclusion of files based on a pattern. Users may benefit from having this functionality in the source and testSource directory definitions as well. Here are some scenarios: 1) a volative package of java files may be excluded from a build to permit developers to continue building the other source files without having to delete or resolve issues for the problem files. 2) Source files and test source files may be kept in the same source tree in the same manner that resources and testResources may currently be kept in a single directory. 3) The change will allow for a parent pom.xml which applies a custom plugin against all source files for subprojects (modules) and subprojects which only compile subsets of these files to all point at the same directory. 4) Some development environments keep their source files in a single directory regardless of the deployment breakout. One reason is it isn't always obvious which artifact a particular source file is located in and consolidation eliminates the need to look around. 5) Elegant way of continuing to maintain Maven's one project one source set mantra in a multi-project environment without increasing the number of source directories. In an effort to avoid breaking the existing pom format, the following tags would be supported: sourceDirectory../../src/java/sourceDirectory xor source directory../../src/java/directory includes include**/package/*.java/include /includes excludes exclude**/*Test.java/exclude /excludes /source and testSourceDirectory../../src/java/testSourceDirectory xor testSource directory../../src/java/directory includes include**/*Test.java/include /includes /testSource This issue is NOT endorsing the support of multiple source directories. It would simply be possible to exclude some source files from the single directory. The change creates a path for deprecating the existing format later if desired. The change would not break existing pom.xml files. If a patch is not included with this issue, expect one soon. This f(x) is a blocker for our development environment because we have several critical tools which traverse all source files in a company project, not just a single artifact's files. So either support for multiple source directories by a parent project (ugh!) or filters on a single directory is a must have. I am currently working on the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
