Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Robert Scholte

I see. In that case Kristian is right: it's a bug.

Op Sun, 07 Jun 2015 19:33:03 +0200 schreef Karl Heinz Marbaise  
:



Hi,

i wasn't discussing what kind of entries / attributes whould be  
helpfull...
In my current builds i have much more information in there like groupId,  
artifactId, version, etc. This was more about ordering / adding  
supllemental entries if i have provided an MANIFEST.MF file...reusing  
it...


Kind regards
Karl Heinz Marbaise
On 6/7/15 7:17 PM, Robert Scholte wrote:

The following attributes are very handsome to be able to reproduce a
build based on sources

Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver

I've hit several projects which I had to rebuild and this gave me enough
info to do so.
You actually want Build-OS as well (if that exists), but asking 'kama'
for additional info when required will do the trick as well.
These values shouldn't be copied from the specified MANIFEST.MF, since
*this* archive has probably been built with other values.

best,
Robert


Op Sun, 07 Jun 2015 18:49:02 +0200 schreef Karl Heinz Marbaise
:


Sorry was too fast with my send button...

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1],
[2]...


If i create a MANIFEST.MF my own and let maven-jar-plugin take that
file via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it
will be extended by several entries:

My own file:

Manifest-Version: 1.0
Test: This is my MANUALLY CREATED MANIFEST FILE
Second: This is the second line.

After running through maven-jar-plugin you will get the following:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
and Build-Jdk entries. But nothing else if i use
my own MANIFEST.MF file.

Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
of the original entries which is based on the used implementation
(HashMap, Hashtable etc. which makes sense.

Wouldn't it be better to keep the original order of elements?

So based on what i can see we have handling of
manifest in maven-archiver component and in plexus-archiver ?



[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Karl Heinz Marbaise

Hi,

i wasn't discussing what kind of entries / attributes whould be helpfull...
In my current builds i have much more information in there like groupId, 
artifactId, version, etc. This was more about ordering / adding 
supllemental entries if i have provided an MANIFEST.MF file...reusing it...


Kind regards
Karl Heinz Marbaise
On 6/7/15 7:17 PM, Robert Scholte wrote:

The following attributes are very handsome to be able to reproduce a
build based on sources

Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver

I've hit several projects which I had to rebuild and this gave me enough
info to do so.
You actually want Build-OS as well (if that exists), but asking 'kama'
for additional info when required will do the trick as well.
These values shouldn't be copied from the specified MANIFEST.MF, since
*this* archive has probably been built with other values.

best,
Robert


Op Sun, 07 Jun 2015 18:49:02 +0200 schreef Karl Heinz Marbaise
:


Sorry was too fast with my send button...

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1],
[2]...


If i create a MANIFEST.MF my own and let maven-jar-plugin take that
file via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it
will be extended by several entries:

My own file:

Manifest-Version: 1.0
Test: This is my MANUALLY CREATED MANIFEST FILE
Second: This is the second line.

After running through maven-jar-plugin you will get the following:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
and Build-Jdk entries. But nothing else if i use
my own MANIFEST.MF file.

Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
of the original entries which is based on the used implementation
(HashMap, Hashtable etc. which makes sense.

Wouldn't it be better to keep the original order of elements?

So based on what i can see we have handling of
manifest in maven-archiver component and in plexus-archiver ?



[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Kristian Rosenvold
The sections should be preserved though, so that's definitely a bug.

K


2015-06-07 19:17 GMT+02:00 Robert Scholte :

> The following attributes are very handsome to be able to reproduce a build
> based on sources
>
> Built-By: kama
> Build-Jdk: 1.7.0_21
> Created-By: Apache Maven 3.1.1
> Archiver-Version: Plexus Archiver
>
> I've hit several projects which I had to rebuild and this gave me enough
> info to do so.
> You actually want Build-OS as well (if that exists), but asking 'kama' for
> additional info when required will do the trick as well.
> These values shouldn't be copied from the specified MANIFEST.MF, since
> *this* archive has probably been built with other values.
>
> best,
> Robert
>
>
> Op Sun, 07 Jun 2015 18:49:02 +0200 schreef Karl Heinz Marbaise <
> khmarba...@gmx.de>:
>
>
>  Sorry was too fast with my send button...
>>
>> Hi,
>>
>> at the moment i trying to dive into handling of MANIFEST.MF file [1],
>> [2]...
>>
>>
>> If i create a MANIFEST.MF my own and let maven-jar-plugin take that file
>> via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be
>> extended by several entries:
>>
>> My own file:
>>
>> Manifest-Version: 1.0
>> Test: This is my MANUALLY CREATED MANIFEST FILE
>> Second: This is the second line.
>>
>> After running through maven-jar-plugin you will get the following:
>>
>> Manifest-Version: 1.0
>> Second: This is the second line.
>> Test: This is my MANUALLY CREATED MANIFEST FILE
>> Built-By: kama
>> Build-Jdk: 1.7.0_21
>> Created-By: Apache Maven 3.1.1
>> Archiver-Version: Plexus Archiver
>>
>>
>> There are comming up two questions:
>>
>> 1. Does it make sense to add only Manifest-Version
>> and Build-Jdk entries. But nothing else if i use
>> my own MANIFEST.MF file.
>>
>> Based on what i have read on [3] it would make sense.
>>
>>
>> 2. Currently the handling internally does not kepp the order
>> of the original entries which is based on the used implementation
>> (HashMap, Hashtable etc. which makes sense.
>>
>> Wouldn't it be better to keep the original order of elements?
>>
>> So based on what i can see we have handling of
>> manifest in maven-archiver component and in plexus-archiver ?
>>
>>
>>
>> [1] https://issues.apache.org/jira/browse/MJAR-195
>> [2] https://issues.apache.org/jira/browse/MJAR-193
>> [3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Robert Scholte
The following attributes are very handsome to be able to reproduce a build  
based on sources


Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver

I've hit several projects which I had to rebuild and this gave me enough  
info to do so.
You actually want Build-OS as well (if that exists), but asking 'kama' for  
additional info when required will do the trick as well.
These values shouldn't be copied from the specified MANIFEST.MF, since  
*this* archive has probably been built with other values.


best,
Robert


Op Sun, 07 Jun 2015 18:49:02 +0200 schreef Karl Heinz Marbaise  
:



Sorry was too fast with my send button...

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1],  
[2]...



If i create a MANIFEST.MF my own and let maven-jar-plugin take that file  
via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be  
extended by several entries:


My own file:

Manifest-Version: 1.0
Test: This is my MANUALLY CREATED MANIFEST FILE
Second: This is the second line.

After running through maven-jar-plugin you will get the following:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
and Build-Jdk entries. But nothing else if i use
my own MANIFEST.MF file.

Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
of the original entries which is based on the used implementation
(HashMap, Hashtable etc. which makes sense.

Wouldn't it be better to keep the original order of elements?

So based on what i can see we have handling of
manifest in maven-archiver component and in plexus-archiver ?



[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Kristian Rosenvold
S; if you cannot add a class-path element to the manifest then ? You're
wrong.

Kristian


2015-06-07 19:09 GMT+02:00 Karl Heinz Marbaise :

> Hi Igor,
>
>
> On 6/7/15 6:57 PM, Igor Fedorenko wrote:
>
>> If I provide custom jar manifest, I expect the manifest to be used
>> as-is, without anything added, removed or reordered. Just my 2 kopecks.
>>
>>
> That's exactly what i would expect...but in all our components / plugins
> it works different
>
> About adding entries. I could understand that two entries like
> Manifest-version and Build-Jdk would be added (but may be best not by
> default) controlled by options...
>
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Karl Heinz Marbaise

Hi Igor,


On 6/7/15 6:57 PM, Igor Fedorenko wrote:

If I provide custom jar manifest, I expect the manifest to be used
as-is, without anything added, removed or reordered. Just my 2 kopecks.



That's exactly what i would expect...but in all our components / plugins 
it works different


About adding entries. I could understand that two entries like 
Manifest-version and Build-Jdk would be added (but may be best not by 
default) controlled by options...


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Kristian Rosenvold
The jar specification says explicitly that "Attributes which are not
understood are ignored."; I interpret this to mean it's ok for every man
and his dog to add values. Which I think means that you should expect your
*values* to win, not necessarily your particular file - there's an implicit
support for toolchain layering in the spec. Thats my 2 NOK.

Additionally it follows map semantics, last present value wins. When we
switched from the "old" plexus manifest to using the jdk manifest we "lost"
the ordering, since the jdk manifest class does not support ordering.

I have been trying to decide for myself if we're mostly talking about
people scratching their OCD and theoretical use cases here. To this date I
have yet to see anything that really convinces me otherwise.

Kristian




2015-06-07 18:57 GMT+02:00 Igor Fedorenko :

> If I provide custom jar manifest, I expect the manifest to be used
> as-is, without anything added, removed or reordered. Just my 2 kopecks.
>
> --
> Regards,
> Igor
>
> On Sun, Jun 7, 2015, at 12:50 PM, Karl Heinz Marbaise wrote:
> > On 6/7/15 6:49 PM, Karl Heinz Marbaise wrote:
> > > Sorry was too fast with my send button...
> > >
> > > Hi,
> > >
> > > at the moment i trying to dive into handling of MANIFEST.MF file [1],
> > > [2]...
> > >
> > >
> > > If i create a MANIFEST.MF my own and let maven-jar-plugin take that
> file
> > > via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be
> > > extended by several entries:
> > >
> > > My own file:
> > >
> > > Manifest-Version: 1.0
> > > Test: This is my MANUALLY CREATED MANIFEST FILE
> > > Second: This is the second line.
> > >
> > > After running through maven-jar-plugin you will get the following:
> > >
> > > Manifest-Version: 1.0
> > > Second: This is the second line.
> > > Test: This is my MANUALLY CREATED MANIFEST FILE
> > > Built-By: kama
> > > Build-Jdk: 1.7.0_21
> > > Created-By: Apache Maven 3.1.1
> > > Archiver-Version: Plexus Archiver
> > >
> > >
> > > There are comming up two questions:
> > >
> > > 1. Does it make sense to add only Manifest-Version
> > > and Build-Jdk entries. But nothing else if i use
> > > my own MANIFEST.MF file.
> > >
> > > Based on what i have read on [3] it would make sense.
> > >
> > >
> > > 2. Currently the handling internally does not kepp the order
> > > of the original entries which is based on the used implementation
> > > (HashMap, Hashtable etc. which makes sense.
> > >
> > > Wouldn't it be better to keep the original order of elements?
> > >
> > > So based on what i can see we have handling of
> > > manifest in maven-archiver component and in plexus-archiver ?
> >
> >
> > One more thing. If the MANIFEST contains sections these will be
> > broken...which is my opionion a real bug...
> >
> >
> > >
> > >
> > >
> > > [1] https://issues.apache.org/jira/browse/MJAR-195
> > > [2] https://issues.apache.org/jira/browse/MJAR-193
> > > [3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html
> > >
> > > Kind regards
> > > Karl Heinz Marbaise
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > >
> >
> >
> > Mit freundlichem Gruß
> > Karl-Heinz Marbaise
> > --
> > SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
> > Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
> > Hauptstrasse 177
> > 52146 Würselen   http://www.soebes.de
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Eric Lilja

Indeed, I would not expect to having my provided manifest modified at all.

On 2015-06-07 18:57, Igor Fedorenko wrote:

If I provide custom jar manifest, I expect the manifest to be used
as-is, without anything added, removed or reordered. Just my 2 kopecks.




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Igor Fedorenko
If I provide custom jar manifest, I expect the manifest to be used
as-is, without anything added, removed or reordered. Just my 2 kopecks.

-- 
Regards,
Igor

On Sun, Jun 7, 2015, at 12:50 PM, Karl Heinz Marbaise wrote:
> On 6/7/15 6:49 PM, Karl Heinz Marbaise wrote:
> > Sorry was too fast with my send button...
> >
> > Hi,
> >
> > at the moment i trying to dive into handling of MANIFEST.MF file [1],
> > [2]...
> >
> >
> > If i create a MANIFEST.MF my own and let maven-jar-plugin take that file
> > via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be
> > extended by several entries:
> >
> > My own file:
> >
> > Manifest-Version: 1.0
> > Test: This is my MANUALLY CREATED MANIFEST FILE
> > Second: This is the second line.
> >
> > After running through maven-jar-plugin you will get the following:
> >
> > Manifest-Version: 1.0
> > Second: This is the second line.
> > Test: This is my MANUALLY CREATED MANIFEST FILE
> > Built-By: kama
> > Build-Jdk: 1.7.0_21
> > Created-By: Apache Maven 3.1.1
> > Archiver-Version: Plexus Archiver
> >
> >
> > There are comming up two questions:
> >
> > 1. Does it make sense to add only Manifest-Version
> > and Build-Jdk entries. But nothing else if i use
> > my own MANIFEST.MF file.
> >
> > Based on what i have read on [3] it would make sense.
> >
> >
> > 2. Currently the handling internally does not kepp the order
> > of the original entries which is based on the used implementation
> > (HashMap, Hashtable etc. which makes sense.
> >
> > Wouldn't it be better to keep the original order of elements?
> >
> > So based on what i can see we have handling of
> > manifest in maven-archiver component and in plexus-archiver ?
> 
> 
> One more thing. If the MANIFEST contains sections these will be 
> broken...which is my opionion a real bug...
> 
> 
> >
> >
> >
> > [1] https://issues.apache.org/jira/browse/MJAR-195
> > [2] https://issues.apache.org/jira/browse/MJAR-193
> > [3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
> 
> 
> Mit freundlichem Gruß
> Karl-Heinz Marbaise
> -- 
> SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
> Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
> Hauptstrasse 177
> 52146 Würselen   http://www.soebes.de
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Karl Heinz Marbaise

On 6/7/15 6:49 PM, Karl Heinz Marbaise wrote:

Sorry was too fast with my send button...

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1],
[2]...


If i create a MANIFEST.MF my own and let maven-jar-plugin take that file
via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be
extended by several entries:

My own file:

Manifest-Version: 1.0
Test: This is my MANUALLY CREATED MANIFEST FILE
Second: This is the second line.

After running through maven-jar-plugin you will get the following:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
and Build-Jdk entries. But nothing else if i use
my own MANIFEST.MF file.

Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
of the original entries which is based on the used implementation
(HashMap, Hashtable etc. which makes sense.

Wouldn't it be better to keep the original order of elements?

So based on what i can see we have handling of
manifest in maven-archiver component and in plexus-archiver ?



One more thing. If the MANIFEST contains sections these will be 
broken...which is my opionion a real bug...







[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen   http://www.soebes.de

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Karl Heinz Marbaise

Sorry was too fast with my send button...

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1], [2]...


If i create a MANIFEST.MF my own and let maven-jar-plugin take that file 
via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be 
extended by several entries:


My own file:

Manifest-Version: 1.0
Test: This is my MANUALLY CREATED MANIFEST FILE
Second: This is the second line.

After running through maven-jar-plugin you will get the following:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
   and Build-Jdk entries. But nothing else if i use
   my own MANIFEST.MF file.

   Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
   of the original entries which is based on the used implementation
   (HashMap, Hashtable etc. which makes sense.

   Wouldn't it be better to keep the original order of elements?

   So based on what i can see we have handling of
   manifest in maven-archiver component and in plexus-archiver ?



[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



MANIFEST Handling in maven-jar-plugin / maven-archiver / plexus-archiver

2015-06-07 Thread Karl Heinz Marbaise

Hi,

at the moment i trying to dive into handling of MANIFEST.MF file [1], [2]...


If i create a MANIFEST.MF my own and let maven-jar-plugin take that file 
via useDefaultManifest (target/classes/META-INF/MANIFEST.MF) it will be 
extended by several entries:


My own file:

For example:

Manifest-Version: 1.0
Second: This is the second line.
Test: This is my MANUALLY CREATED MANIFEST FILE
Built-By: kama
Build-Jdk: 1.7.0_21
Created-By: Apache Maven 3.1.1
Archiver-Version: Plexus Archiver


There are comming up two questions:

1. Does it make sense to add only Manifest-Version
   and Build-Jdk entries. But nothing else if i use
   my own MANIFEST.MF file.

   Based on what i have read on [3] it would make sense.


2. Currently the handling internally does not kepp the order
   of the original entries which is based on the used implementation
   (HashMap, Hashtable etc. which makes sense.

   Wouldn't it be better to keep the original order of elements?





[1] https://issues.apache.org/jira/browse/MJAR-195
[2] https://issues.apache.org/jira/browse/MJAR-193
[3] https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org