Re: maven-shade-plugin question
Looking only at the log, both writers existed before it was promoted from the sandbox in 2007. Counter was introduced by Karl Heinz while refactoring. It could very well be there's a better solution for it right now. I would expect enough coverage by ITs to confirm that. Robert On 9-8-2021 16:35:13, Tamás Cservenák wrote: Howdy, re maven-shade-plugin's Java package org.apache.maven.plugins.shade.pom: 1. What is the goal of this code? As there are 3 classes in here, and Counter is used only by MavenJDOMWriter, while MavenJDOMWriter is used only by PomWriter, while PomWriter is used only by ShadeMojo (to write out dep reduced POM), but 2. ... the xpp3 writer is available as well, as maven-model is pulled in as direct dependency, 3. ... but moreover, the model-writer is there as well (true. as maven-core transitive dep) so, what is the reason these classes exist? Do I miss something? Thanks T
maven-shade-plugin question
Howdy, re maven-shade-plugin's Java package org.apache.maven.plugins.shade.pom: 1. What is the goal of this code? As there are 3 classes in here, and Counter is used only by MavenJDOMWriter, while MavenJDOMWriter is used only by PomWriter, while PomWriter is used only by ShadeMojo (to write out dep reduced POM), but 2. ... the xpp3 writer is available as well, as maven-model is pulled in as direct dependency, 3. ... but moreover, the model-writer is there as well (true. as maven-core transitive dep) so, what is the reason these classes exist? Do I miss something? Thanks T
Re: Maven shade plugin question
Thanks for reviewing and committing the patch. Could you also deploy a new snapshot build to the apache snapshot repository? Thanks, Trask On Sun, Nov 20, 2011 at 10:12 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Thanks so much for the response. I look forward to your review of the patch. I'm happy to re-write it taking a different approach if you see fit, so just shoot me your feedback. Thanks again. Trask On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies bimargul...@gmail.comwrote: Trask, No problem, but in the future feel free to send such a thing to the maven dev list. I'll look at your patch. Honestly, there's no one who is very reliably looking for new patches across many of the plugins, so a ping is a good idea. We generally don't release for only one patch, and we released recently, but if it fixes a howler and it would help you I'll try to also turn the crank. --benson On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Hi Benson, I hope you don't mind me emailing you directly. I noticed that you have made the last few contributions to the maven shade plugin. I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two ago. I just updated the jira ticket tonight with a second version of the patch. Is there anything I can do to help this patch get accepted into the maven shade plugin trunk? I'm happy to make any modifications to the patch that you would like to see, and I can provide more docs/examples/tests/explanations/etc if that will help. Thank you for your time. Sincerely, Trask Stalnaker
Re: Maven shade plugin question
Trask, No problem, but in the future feel free to send such a thing to the maven dev list. I'll look at your patch. Honestly, there's no one who is very reliably looking for new patches across many of the plugins, so a ping is a good idea. We generally don't release for only one patch, and we released recently, but if it fixes a howler and it would help you I'll try to also turn the crank. --benson On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Hi Benson, I hope you don't mind me emailing you directly. I noticed that you have made the last few contributions to the maven shade plugin. I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two ago. I just updated the jira ticket tonight with a second version of the patch. Is there anything I can do to help this patch get accepted into the maven shade plugin trunk? I'm happy to make any modifications to the patch that you would like to see, and I can provide more docs/examples/tests/explanations/etc if that will help. Thank you for your time. Sincerely, Trask Stalnaker - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Maven shade plugin question
Thanks so much for the response. I look forward to your review of the patch. I'm happy to re-write it taking a different approach if you see fit, so just shoot me your feedback. Thanks again. Trask On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies bimargul...@gmail.comwrote: Trask, No problem, but in the future feel free to send such a thing to the maven dev list. I'll look at your patch. Honestly, there's no one who is very reliably looking for new patches across many of the plugins, so a ping is a good idea. We generally don't release for only one patch, and we released recently, but if it fixes a howler and it would help you I'll try to also turn the crank. --benson On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Hi Benson, I hope you don't mind me emailing you directly. I noticed that you have made the last few contributions to the maven shade plugin. I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two ago. I just updated the jira ticket tonight with a second version of the patch. Is there anything I can do to help this patch get accepted into the maven shade plugin trunk? I'm happy to make any modifications to the patch that you would like to see, and I can provide more docs/examples/tests/explanations/etc if that will help. Thank you for your time. Sincerely, Trask Stalnaker
