Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Il mer 24 lug 2019, 10:02 Tibor Digana ha scritto: > Hi Enrico, > > Do we have a statement from vendors of PMD and/or Checkstyle libraries that > their rules would turn to platform independence? > I know there was a pull request on GitHub and a promis with the release (I > guess PMD). > Once we would have these libraries with modified default values in favor of > platform non-sensitive EOL rules, we would not have to apapt our > integration tests to platform. > I think that Checkstyle has been released and we should upgrade it. Enrico > Cheers > Tibor > > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > wrote: > > > I will get a windows box and try to reproduce. > > It is weird that on ASF Jenkins the build is passing even on windows > > > > Enrico > > > > -- Forwarded message - > > Da: Enrico Olivelli > > Date: mar 14 mag 2019, 13:58 > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > > To: Maven Developers List > > > > > > Eric and Tibor, > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > This is the "official" VOTE thread, here we have to decide if the staged > > artifacts are good to be released or not. > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > "stable" or there is any showstopper problem for the release. > > > > Let's move this discussion to a separate thread, something like > "Validation > > failures in Windows over current checkstyle plugin master branch") > > > > Enrico > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > mindcoo...@gmail.com> > > ha scritto: > > > > > Tried overriding line.separator when running using > -Dline.separator="\n", > > > but then the builds fails (early) in maven-plugin-plugin: > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > default-descriptor of goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > Requested line separator is invalid. -> [Help 1] > > > [ERROR] > > > [ERROR] To see the full stack trace of the errors, re-run Maven with > the > > -e > > > switch. > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > > [ERROR] > > > [ERROR] For more information about the errors and possible solutions, > > > please read the following articles: > > > [ERROR] [Help 1] > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > upgradeable...), but same error > > > > > > I also happened to notice this (probably unrelated, but wanted to bring > > it > > > to attention anyway so it can be fixed) warning: > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > [WARNING] > > > > > > Unexpected situation: destinationDirectory not defined in > > > maven-plugin-help.properties during help mojo source generation but > > > expected during XML descriptor generation. > > > [WARNING] Please check helpmojo goal version used in previous build > > phase. > > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > > clean > > > build at least once. > > > [WARNING] Trying default location: target\generated-sources\plugin > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > > wrote: > > > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > > dependencies, > > > > but that just brought an additional failure... (to > > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > > > I suppose the problem might be that the files has linux-style line > > breaks > > > > (this is desired for me, I don't want to convert to windows-style > line > > > > breaks locally), but the test think I should have windows-style line > > > > separators. It seems these files are generated by the tests because I > > > tried > > > > changing them to Windows style line breaks for re-running just to see > > if > > > > that would work, but those changes were overwritten) > > > > > > > > - Eric L > > > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > > wrote: > > > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > > try > > > >> the source zip, just cloned master) > > > >> > > > >> I tested on one of our corporate laptops: > > > >> Windows 10 > > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > > >> Maven 3.6.0 > > > >> Java 8 update 202 > > > >> > > > >> The build log says: > > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > > sun_checks.xml > > > >> ruleset. > > > >> [ERROR] > > > >> > > > > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > > >> [ERROR] > > > >> > > > > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Hi Enrico, Do we have a statement from vendors of PMD and/or Checkstyle libraries that their rules would turn to platform independence? I know there was a pull request on GitHub and a promis with the release (I guess PMD). Once we would have these libraries with modified default values in favor of platform non-sensitive EOL rules, we would not have to apapt our integration tests to platform. Cheers Tibor On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli wrote: > I will get a windows box and try to reproduce. > It is weird that on ASF Jenkins the build is passing even on windows > > Enrico > > -- Forwarded message - > Da: Enrico Olivelli > Date: mar 14 mag 2019, 13:58 > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > To: Maven Developers List > > > Eric and Tibor, > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > This is the "official" VOTE thread, here we have to decide if the staged > artifacts are good to be released or not. > > Feel free to cast a -1 if you think that the staged artifacts are not > "stable" or there is any showstopper problem for the release. > > Let's move this discussion to a separate thread, something like "Validation > failures in Windows over current checkstyle plugin master branch") > > Enrico > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > ha scritto: > > > Tried overriding line.separator when running using -Dline.separator="\n", > > but then the builds fails (early) in maven-plugin-plugin: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > default-descriptor of goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > Requested line separator is invalid. -> [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > upgradeable...), but same error > > > > I also happened to notice this (probably unrelated, but wanted to bring > it > > to attention anyway so it can be fixed) warning: > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > [WARNING] > > > > Unexpected situation: destinationDirectory not defined in > > maven-plugin-help.properties during help mojo source generation but > > expected during XML descriptor generation. > > [WARNING] Please check helpmojo goal version used in previous build > phase. > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > clean > > build at least once. > > [WARNING] Trying default location: target\generated-sources\plugin > > > > - Eric L > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > wrote: > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > dependencies, > > > but that just brought an additional failure... (to > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > I suppose the problem might be that the files has linux-style line > breaks > > > (this is desired for me, I don't want to convert to windows-style line > > > breaks locally), but the test think I should have windows-style line > > > separators. It seems these files are generated by the tests because I > > tried > > > changing them to Windows style line breaks for re-running just to see > if > > > that would work, but those changes were overwritten) > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > wrote: > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > try > > >> the source zip, just cloned master) > > >> > > >> I tested on one of our corporate laptops: > > >> Windows 10 > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > >> Maven 3.6.0 > > >> Java 8 update 202 > > >> > > >> The build log says: > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > sun_checks.xml > > >> ruleset. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> > > >> These two files end with unix-style line breaks (as expected with my > > >> setup). > > >> > > >> - Eric L > > >> > > >> > > >> On Tue, May 14, 2019 at 8:10 AM Enrico Olivelli > > >> wrote: > > >> > > >>> Il lun 13 mag 2019, 23:48 Tibor Digana ha > > >>> scritto: > > >>> > > >>> > Robert, I did
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Robert> According to the ASF the -sources.zip are the official release, not the git tag That's right Robert>In this case you don't control the EOL, it is based on the OS of the release manager. Is it? I would disagree here. For instance, Apache JMeter produces both -src.zip (CRLF), and -src.tar.gz with LF-defaults for text files. Of course, one might take -src.tar.gz and try building it on Windows, however that is not like RM's machine controls EOL. On top of that, https://reproducible-builds.org/ is a thing, so it makes sense to be able to reproduce release files independent of the release manager (=producezips with the same sha512 on different OS) So both Git and the release script control the way the release is produced. Input data could contain both variations of the EOL styles by the way, which might be handy for EOL-targeted tests. That is Git repo could just contain a file with CRLF, and a file with LF. So would have the release zip. However I would agree some sort of the treatment should be baked into the test. Vladimir
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Keep in mind there's another important situation that you can't control it like this. According to the ASF the -sources.zip are the official release, not the git tag. This means that you should unpack the zip and be able to verify it on all OSes. In this case you don't control the EOL, it is based on the OS of the release manager. The only way to solve this is to generate files on the fly, or adjust them before testing. You won't see this issue with the CI server, only after a release and when verified with different OSes. thanks, Robert On 18-7-2019 14:49:02, Eric Lilja wrote: Ah, thanks Vladimir, that's even better. I was not 100% sure it would be possible to retain complete control over resulting line endings for those files, regardless of user git settings of stuff like autocrlf = true and whatnot, but it seems there is, that's great news. Thanks! - Eric L On Thu, Jul 18, 2019 at 2:00 PM Vladimir Sitnikov <> sitnikov.vladi...@gmail.com> wrote: > Eric>In that case, we should generate the test files (to > Eric>avoid git interfering), one with linux-style EOLs and one with > Eric>Windows-style EOLs and test with both. > > You'd better have those files under Git control, and you could just specify > .gitattributes so the LF file is always LF, and CRLF file is always CRLF. > > That is way simpler than generation of the file(s), and it is way easier to > understand by humans > > Vladimir >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Ah, thanks Vladimir, that's even better. I was not 100% sure it would be possible to retain complete control over resulting line endings for those files, regardless of user git settings of stuff like autocrlf = true and whatnot, but it seems there is, that's great news. Thanks! - Eric L On Thu, Jul 18, 2019 at 2:00 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Eric>In that case, we should generate the test files (to > Eric>avoid git interfering), one with linux-style EOLs and one with > Eric>Windows-style EOLs and test with both. > > You'd better have those files under Git control, and you could just specify > .gitattributes so the LF file is always LF, and CRLF file is always CRLF. > > That is way simpler than generation of the file(s), and it is way easier to > understand by humans > > Vladimir >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Eric>In that case, we should generate the test files (to Eric>avoid git interfering), one with linux-style EOLs and one with Eric>Windows-style EOLs and test with both. You'd better have those files under Git control, and you could just specify .gitattributes so the LF file is always LF, and CRLF file is always CRLF. That is way simpler than generation of the file(s), and it is way easier to understand by humans Vladimir
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Hi Enrico! If I remember correctly, a number of weeks ago I tried using Checkstyle 8.21 with maven-checkstyle-plugin (I had simply cloned the maven-checkstyle-plugin repository) and it did solve the problem with the test case discussed in this thread. However, as I recall there was another, unrelated, test that started failing with Checkstyle 8.21, which I did not investigate. I haven't tried Checkstyle 8.22, which has been released since. Additionally, we could be a bit more ambitious in the file-should-end-with-newline-test, if we also want to verify it's indeed platform-agnostic now. In that case, we should generate the test files (to avoid git interfering), one with linux-style EOLs and one with Windows-style EOLs and test with both. I might give it a go to uplift Checkstyle to 8.22 and possibly expand the test as outlined above if you think it sounds like a reasonable proposition - Eric L On Wed, Jul 17, 2019 at 1:32 PM Enrico Olivelli wrote: > Il mer 17 lug 2019, 13:28 Eric Lilja ha scritto: > > > I believe, if we instead upgrade to Checkstyle 8.21 or later, we don't > need > > to do any of those alternative approaches. > > > > https://github.com/checkstyle/checkstyle/issues/4073 > > > Eric > I think it is the best idea > Do you have cycles to give it a try? > > Enrico > > > > > > > - Eric L > > > > > > On Wed, Jul 17, 2019 at 1:20 PM Vladimir Sitnikov < > > sitnikov.vladi...@gmail.com> wrote: > > > > > Robert>A clone from Git succeeds, but the sources.zip fails. > > > Robert>The files in the zip are generated on a unix system, so all EOLs > > in > > > text files are LF > > > Robert>... > > > Robert>The fix: add a setup.groovy to the IT and rewrite the java files > > > with OS specific EOLs > > > > > > Alternative approaches: > > > A) Provide both Linux (LF) and Windows (CRLF) source distributions > (e.g. > > > *.zip and *.tgz). > > > B) Specify "lineSeparator" explicitly. Then you could have both CRLF > and > > LF > > > files at the same time and verify if those work > > > C) Generate file at the build stage. If you generate it into target/ > > > directory, then you could generate the file with appropriate for the > > > platform enconding > > > D) Ensure the file is always in LF or CRLF by adding a relevant > > > .gitattributes entry > > > > > > Vladimir > > > > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Just in case: I see you seem to be battling against CRLF For instance: https://github.com/apache/maven-checkstyle-plugin/pull/16 Did you consider to add the relevant .gitattributes file to ensure Git converts the files automatically? With a proper .gitattributes file, it is just impossible to commit a file with "a wrong EOL". PS. I've came across this thread when Apache JMeter project noticed that Window-based builds were broken by https://issues.apache.org/jira/browse/INFRA-18383 Vladimir
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Il mer 17 lug 2019, 13:28 Eric Lilja ha scritto: > I believe, if we instead upgrade to Checkstyle 8.21 or later, we don't need > to do any of those alternative approaches. > > https://github.com/checkstyle/checkstyle/issues/4073 Eric I think it is the best idea Do you have cycles to give it a try? Enrico > > - Eric L > > > On Wed, Jul 17, 2019 at 1:20 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > Robert>A clone from Git succeeds, but the sources.zip fails. > > Robert>The files in the zip are generated on a unix system, so all EOLs > in > > text files are LF > > Robert>... > > Robert>The fix: add a setup.groovy to the IT and rewrite the java files > > with OS specific EOLs > > > > Alternative approaches: > > A) Provide both Linux (LF) and Windows (CRLF) source distributions (e.g. > > *.zip and *.tgz). > > B) Specify "lineSeparator" explicitly. Then you could have both CRLF and > LF > > files at the same time and verify if those work > > C) Generate file at the build stage. If you generate it into target/ > > directory, then you could generate the file with appropriate for the > > platform enconding > > D) Ensure the file is always in LF or CRLF by adding a relevant > > .gitattributes entry > > > > Vladimir > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
I believe, if we instead upgrade to Checkstyle 8.21 or later, we don't need to do any of those alternative approaches. https://github.com/checkstyle/checkstyle/issues/4073 - Eric L On Wed, Jul 17, 2019 at 1:20 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Robert>A clone from Git succeeds, but the sources.zip fails. > Robert>The files in the zip are generated on a unix system, so all EOLs in > text files are LF > Robert>... > Robert>The fix: add a setup.groovy to the IT and rewrite the java files > with OS specific EOLs > > Alternative approaches: > A) Provide both Linux (LF) and Windows (CRLF) source distributions (e.g. > *.zip and *.tgz). > B) Specify "lineSeparator" explicitly. Then you could have both CRLF and LF > files at the same time and verify if those work > C) Generate file at the build stage. If you generate it into target/ > directory, then you could generate the file with appropriate for the > platform enconding > D) Ensure the file is always in LF or CRLF by adding a relevant > .gitattributes entry > > Vladimir >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Robert>A clone from Git succeeds, but the sources.zip fails. Robert>The files in the zip are generated on a unix system, so all EOLs in text files are LF Robert>... Robert>The fix: add a setup.groovy to the IT and rewrite the java files with OS specific EOLs Alternative approaches: A) Provide both Linux (LF) and Windows (CRLF) source distributions (e.g. *.zip and *.tgz). B) Specify "lineSeparator" explicitly. Then you could have both CRLF and LF files at the same time and verify if those work C) Generate file at the build stage. If you generate it into target/ directory, then you could generate the file with appropriate for the platform enconding D) Ensure the file is always in LF or CRLF by adding a relevant .gitattributes entry Vladimir
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Yeah, sounds like a good idea to take full control of the line breaks in files, if they should be used to test line-break related features, since git might convert them on certain platforms if configured to do so (I tend to use Cygwin's git so I personally get unix-style line breaks). Looking forward to the next release of this plugin, thanks for your work on this and other things in the Maven ecosystem! - Eric L On Mon, May 27, 2019 at 10:35 PM Enrico Olivelli wrote: > Il lun 27 mag 2019, 22:27 Eric Lilja ha scritto: > > > I mean that we don't need to convert any line breaks in any files in > > maven-checkstyle-plugin for the ITs to work, if we use checkstyle 8.21. > > However, we could extend the tests for "file-ends-with-newline" to > > explicitly cover all valid combinations of > > system-line-break/file-line-break. Like if my system line break is > > windows-style and the file ends with unix-style line break, the test > should > > pass, and vice versa. This to let the tests actually showcase (and test, > > obviously) how the feature actually works from 8.21 onwards (look at the > > bugifx I linked previously: > > https://github.com/checkstyle/checkstyle/issues/4073) > > > > This is the work, gently carried on by 2 guys from Checkstyle community. > > https://github.com/apache/maven-checkstyle-plugin/pull/16 > > The idea is to convert a bunch of files to linux EOL. IIUC git is able to > convert EOL automatically on windows, so having a clear convention for all > of the files helps keeping an uniform way of dealing with this problem. > > The integration test about MCHECKSTYLE-54 has been changed in a way that > now it is testing only the issue and not other stuff (like incidentally was > checking for EOLs due to the usage of the default checkstyle rules) > > Thank you for continuing this discussion for the health of the project > > Enrico > > > > > > - Eric L > > > > On Mon, May 27, 2019 at 10:17 PM Eric Lilja > wrote: > > > > > Hi Enrico! Just out of curiosity, what do you mean by " We are also > > fixing > > > EOL in the checkstyle plugin code base"? No change in the plugin is > > > required with regards to EOLs to make tests pass, simply bump to > version > > > 8.21 of checkstyle itself (but there were two other errors, seemingly > not > > > related to EOL characters). Cheers! > > > > > > - Eric L > > > > > > On Mon, May 27, 2019 at 8:37 PM Enrico Olivelli > > > wrote: > > > > > >> Eric > > >> Thank you > > >> > > >> We are also fixing EOL in the checkstyle plugin code base > > >> > > >> Enrico > > >> > > >> > > >> > > >> Il lun 27 mag 2019, 11:34 Eric Lilja ha > scritto: > > >> > > >> > Just to inform you that this problem has been resolved in version > 8.21 > > >> of > > >> > checkstyle, which was just released, and I've confirmed the fix > works > > by > > >> > running the ITs on the checkstyle-plugin (checked out master on > > Cygwin). > > >> > There are two other failures, though (was one failure with 8.20 if I > > >> recall > > >> > correctly, apart from the EOL issue still present in that version). > > >> > > > >> > https://github.com/checkstyle/checkstyle/issues/4073 > > >> > > > >> > - Eric L > > >> > > > >> > On Thu, May 16, 2019 at 1:33 AM Tibor Digana < > tibordig...@apache.org> > > >> > wrote: > > >> > > > >> > > Enrico, I checked the Checkstyle rules again (default value = > > system) > > >> and > > >> > > Robert is right, please adjust the IT sources on the fly. > > >> > > Not sure why INFRA or Jenkins sets the Windows EOL to LF. > > >> > > Therefore we could not find this issue in version 3.0.0 (Jan 04) > > >> because > > >> > > the IT was created on Jan 17 and we run it on local Windows the > > first > > >> > time. > > >> > > > > >> > > The library is fine. I used several old versions of the plugin > > having > > >> > > identical results. > > >> > > Few links: > > >> > > > > >> > > > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile > > >> > > > > >> > > http://checkstyle.sourceforge.net/google_style.html > > >> > > > > >> > > > > >> > > > >> > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml > > >> > > > > >> > > > > >> > > > >> > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml > > >> > > > > >> > > I expected platform independence because my company used > > >> sun_checks.xml > > >> > on > > >> > > Windows with Unix EOL in Git/IDE without this problem. > > >> > > The company improved sun_checks.xml long time ago, so I realized > > that > > >> > later > > >> > > that it is slightly different XML and different experience. Sorry. > > >> > > Cheers > > >> > > Tibor17 > > >> > > > > >> > > > > >> > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli < > > eolive...@gmail.com> > > >> > > wrote: > > >> > > > > >> > > > I will get a windows box and try to reproduce. > > >> > > > It is weird that on ASF Jenkins the build is passing even on > > windows > > >> > > > > > >> > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Il lun 27 mag 2019, 22:27 Eric Lilja ha scritto: > I mean that we don't need to convert any line breaks in any files in > maven-checkstyle-plugin for the ITs to work, if we use checkstyle 8.21. > However, we could extend the tests for "file-ends-with-newline" to > explicitly cover all valid combinations of > system-line-break/file-line-break. Like if my system line break is > windows-style and the file ends with unix-style line break, the test should > pass, and vice versa. This to let the tests actually showcase (and test, > obviously) how the feature actually works from 8.21 onwards (look at the > bugifx I linked previously: > https://github.com/checkstyle/checkstyle/issues/4073) > This is the work, gently carried on by 2 guys from Checkstyle community. https://github.com/apache/maven-checkstyle-plugin/pull/16 The idea is to convert a bunch of files to linux EOL. IIUC git is able to convert EOL automatically on windows, so having a clear convention for all of the files helps keeping an uniform way of dealing with this problem. The integration test about MCHECKSTYLE-54 has been changed in a way that now it is testing only the issue and not other stuff (like incidentally was checking for EOLs due to the usage of the default checkstyle rules) Thank you for continuing this discussion for the health of the project Enrico > - Eric L > > On Mon, May 27, 2019 at 10:17 PM Eric Lilja wrote: > > > Hi Enrico! Just out of curiosity, what do you mean by " We are also > fixing > > EOL in the checkstyle plugin code base"? No change in the plugin is > > required with regards to EOLs to make tests pass, simply bump to version > > 8.21 of checkstyle itself (but there were two other errors, seemingly not > > related to EOL characters). Cheers! > > > > - Eric L > > > > On Mon, May 27, 2019 at 8:37 PM Enrico Olivelli > > wrote: > > > >> Eric > >> Thank you > >> > >> We are also fixing EOL in the checkstyle plugin code base > >> > >> Enrico > >> > >> > >> > >> Il lun 27 mag 2019, 11:34 Eric Lilja ha scritto: > >> > >> > Just to inform you that this problem has been resolved in version 8.21 > >> of > >> > checkstyle, which was just released, and I've confirmed the fix works > by > >> > running the ITs on the checkstyle-plugin (checked out master on > Cygwin). > >> > There are two other failures, though (was one failure with 8.20 if I > >> recall > >> > correctly, apart from the EOL issue still present in that version). > >> > > >> > https://github.com/checkstyle/checkstyle/issues/4073 > >> > > >> > - Eric L > >> > > >> > On Thu, May 16, 2019 at 1:33 AM Tibor Digana > >> > wrote: > >> > > >> > > Enrico, I checked the Checkstyle rules again (default value = > system) > >> and > >> > > Robert is right, please adjust the IT sources on the fly. > >> > > Not sure why INFRA or Jenkins sets the Windows EOL to LF. > >> > > Therefore we could not find this issue in version 3.0.0 (Jan 04) > >> because > >> > > the IT was created on Jan 17 and we run it on local Windows the > first > >> > time. > >> > > > >> > > The library is fine. I used several old versions of the plugin > having > >> > > identical results. > >> > > Few links: > >> > > > >> > > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile > >> > > > >> > > http://checkstyle.sourceforge.net/google_style.html > >> > > > >> > > > >> > > >> > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml > >> > > > >> > > > >> > > >> > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml > >> > > > >> > > I expected platform independence because my company used > >> sun_checks.xml > >> > on > >> > > Windows with Unix EOL in Git/IDE without this problem. > >> > > The company improved sun_checks.xml long time ago, so I realized > that > >> > later > >> > > that it is slightly different XML and different experience. Sorry. > >> > > Cheers > >> > > Tibor17 > >> > > > >> > > > >> > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli < > eolive...@gmail.com> > >> > > wrote: > >> > > > >> > > > I will get a windows box and try to reproduce. > >> > > > It is weird that on ASF Jenkins the build is passing even on > windows > >> > > > > >> > > > Enrico > >> > > > > >> > > > -- Forwarded message - > >> > > > Da: Enrico Olivelli > >> > > > Date: mar 14 mag 2019, 13:58 > >> > > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version > >> > 3.1.0 > >> > > > To: Maven Developers List > >> > > > > >> > > > > >> > > > Eric and Tibor, > >> > > > Thank you so much for your effort in testing Maven Checkstyle > >> Plugin. > >> > > > > >> > > > This is the "official" VOTE thread, here we have to decide if the > >> > staged > >> > > > artifacts are good to be released or not. > >> > > > > >> > > > Feel free to cast a -1 if you think that the staged artifacts are > >> not > >> > > > "stable" or there is any showstopper problem for the release. > >> > > > > >> > > > Let's move this
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
I mean that we don't need to convert any line breaks in any files in maven-checkstyle-plugin for the ITs to work, if we use checkstyle 8.21. However, we could extend the tests for "file-ends-with-newline" to explicitly cover all valid combinations of system-line-break/file-line-break. Like if my system line break is windows-style and the file ends with unix-style line break, the test should pass, and vice versa. This to let the tests actually showcase (and test, obviously) how the feature actually works from 8.21 onwards (look at the bugifx I linked previously: https://github.com/checkstyle/checkstyle/issues/4073) - Eric L On Mon, May 27, 2019 at 10:17 PM Eric Lilja wrote: > Hi Enrico! Just out of curiosity, what do you mean by " We are also fixing > EOL in the checkstyle plugin code base"? No change in the plugin is > required with regards to EOLs to make tests pass, simply bump to version > 8.21 of checkstyle itself (but there were two other errors, seemingly not > related to EOL characters). Cheers! > > - Eric L > > On Mon, May 27, 2019 at 8:37 PM Enrico Olivelli > wrote: > >> Eric >> Thank you >> >> We are also fixing EOL in the checkstyle plugin code base >> >> Enrico >> >> >> >> Il lun 27 mag 2019, 11:34 Eric Lilja ha scritto: >> >> > Just to inform you that this problem has been resolved in version 8.21 >> of >> > checkstyle, which was just released, and I've confirmed the fix works by >> > running the ITs on the checkstyle-plugin (checked out master on Cygwin). >> > There are two other failures, though (was one failure with 8.20 if I >> recall >> > correctly, apart from the EOL issue still present in that version). >> > >> > https://github.com/checkstyle/checkstyle/issues/4073 >> > >> > - Eric L >> > >> > On Thu, May 16, 2019 at 1:33 AM Tibor Digana >> > wrote: >> > >> > > Enrico, I checked the Checkstyle rules again (default value = system) >> and >> > > Robert is right, please adjust the IT sources on the fly. >> > > Not sure why INFRA or Jenkins sets the Windows EOL to LF. >> > > Therefore we could not find this issue in version 3.0.0 (Jan 04) >> because >> > > the IT was created on Jan 17 and we run it on local Windows the first >> > time. >> > > >> > > The library is fine. I used several old versions of the plugin having >> > > identical results. >> > > Few links: >> > > >> > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile >> > > >> > > http://checkstyle.sourceforge.net/google_style.html >> > > >> > > >> > >> https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml >> > > >> > > >> > >> https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml >> > > >> > > I expected platform independence because my company used >> sun_checks.xml >> > on >> > > Windows with Unix EOL in Git/IDE without this problem. >> > > The company improved sun_checks.xml long time ago, so I realized that >> > later >> > > that it is slightly different XML and different experience. Sorry. >> > > Cheers >> > > Tibor17 >> > > >> > > >> > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli >> > > wrote: >> > > >> > > > I will get a windows box and try to reproduce. >> > > > It is weird that on ASF Jenkins the build is passing even on windows >> > > > >> > > > Enrico >> > > > >> > > > -- Forwarded message - >> > > > Da: Enrico Olivelli >> > > > Date: mar 14 mag 2019, 13:58 >> > > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version >> > 3.1.0 >> > > > To: Maven Developers List >> > > > >> > > > >> > > > Eric and Tibor, >> > > > Thank you so much for your effort in testing Maven Checkstyle >> Plugin. >> > > > >> > > > This is the "official" VOTE thread, here we have to decide if the >> > staged >> > > > artifacts are good to be released or not. >> > > > >> > > > Feel free to cast a -1 if you think that the staged artifacts are >> not >> > > > "stable" or there is any showstopper problem for the release. >> > > > >> > > > Let's move this discussion to a separate thread, something like >> > > "Validation >> > > > failures in Windows over current checkstyle plugin master branch") >> > > > >> > > > Enrico >> > > > >> > > > >> > > > >> > > > >> > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < >> > > mindcoo...@gmail.com> >> > > > ha scritto: >> > > > >> > > > > Tried overriding line.separator when running using >> > > -Dline.separator="\n", >> > > > > but then the builds fails (early) in maven-plugin-plugin: >> > > > > [ERROR] Failed to execute goal >> > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >> > > > > (default-descriptor) on project maven-checkstyle-plugin: Execution >> > > > > default-descriptor of goal >> > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >> failed: >> > > > > Requested line separator is invalid. -> [Help 1] >> > > > > [ERROR] >> > > > > [ERROR] To see the full stack trace of the errors, re-run Maven >> with >> > > the >> > > > -e >>
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Hi Enrico! Just out of curiosity, what do you mean by " We are also fixing EOL in the checkstyle plugin code base"? No change in the plugin is required with regards to EOLs to make tests pass, simply bump to version 8.21 of checkstyle itself (but there were two other errors, seemingly not related to EOL characters). Cheers! - Eric L On Mon, May 27, 2019 at 8:37 PM Enrico Olivelli wrote: > Eric > Thank you > > We are also fixing EOL in the checkstyle plugin code base > > Enrico > > > > Il lun 27 mag 2019, 11:34 Eric Lilja ha scritto: > > > Just to inform you that this problem has been resolved in version 8.21 of > > checkstyle, which was just released, and I've confirmed the fix works by > > running the ITs on the checkstyle-plugin (checked out master on Cygwin). > > There are two other failures, though (was one failure with 8.20 if I > recall > > correctly, apart from the EOL issue still present in that version). > > > > https://github.com/checkstyle/checkstyle/issues/4073 > > > > - Eric L > > > > On Thu, May 16, 2019 at 1:33 AM Tibor Digana > > wrote: > > > > > Enrico, I checked the Checkstyle rules again (default value = system) > and > > > Robert is right, please adjust the IT sources on the fly. > > > Not sure why INFRA or Jenkins sets the Windows EOL to LF. > > > Therefore we could not find this issue in version 3.0.0 (Jan 04) > because > > > the IT was created on Jan 17 and we run it on local Windows the first > > time. > > > > > > The library is fine. I used several old versions of the plugin having > > > identical results. > > > Few links: > > > > > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile > > > > > > http://checkstyle.sourceforge.net/google_style.html > > > > > > > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml > > > > > > > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml > > > > > > I expected platform independence because my company used sun_checks.xml > > on > > > Windows with Unix EOL in Git/IDE without this problem. > > > The company improved sun_checks.xml long time ago, so I realized that > > later > > > that it is slightly different XML and different experience. Sorry. > > > Cheers > > > Tibor17 > > > > > > > > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > > > wrote: > > > > > > > I will get a windows box and try to reproduce. > > > > It is weird that on ASF Jenkins the build is passing even on windows > > > > > > > > Enrico > > > > > > > > -- Forwarded message - > > > > Da: Enrico Olivelli > > > > Date: mar 14 mag 2019, 13:58 > > > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version > > 3.1.0 > > > > To: Maven Developers List > > > > > > > > > > > > Eric and Tibor, > > > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > > > > > This is the "official" VOTE thread, here we have to decide if the > > staged > > > > artifacts are good to be released or not. > > > > > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > > > "stable" or there is any showstopper problem for the release. > > > > > > > > Let's move this discussion to a separate thread, something like > > > "Validation > > > > failures in Windows over current checkstyle plugin master branch") > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > > > mindcoo...@gmail.com> > > > > ha scritto: > > > > > > > > > Tried overriding line.separator when running using > > > -Dline.separator="\n", > > > > > but then the builds fails (early) in maven-plugin-plugin: > > > > > [ERROR] Failed to execute goal > > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > > > default-descriptor of goal > > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > > > Requested line separator is invalid. -> [Help 1] > > > > > [ERROR] > > > > > [ERROR] To see the full stack trace of the errors, re-run Maven > with > > > the > > > > -e > > > > > switch. > > > > > [ERROR] Re-run Maven using the -X switch to enable full debug > > logging. > > > > > [ERROR] > > > > > [ERROR] For more information about the errors and possible > solutions, > > > > > please read the following articles: > > > > > [ERROR] [Help 1] > > > > > > > > > > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > > > upgradeable...), but same error > > > > > > > > > > I also happened to notice this (probably unrelated, but wanted to > > bring > > > > it > > > > > to attention anyway so it can be fixed) warning: > > > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > > > [WARNING] > > > > > > > > > > Unexpected situation: destinationDirectory not
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Eric Thank you We are also fixing EOL in the checkstyle plugin code base Enrico Il lun 27 mag 2019, 11:34 Eric Lilja ha scritto: > Just to inform you that this problem has been resolved in version 8.21 of > checkstyle, which was just released, and I've confirmed the fix works by > running the ITs on the checkstyle-plugin (checked out master on Cygwin). > There are two other failures, though (was one failure with 8.20 if I recall > correctly, apart from the EOL issue still present in that version). > > https://github.com/checkstyle/checkstyle/issues/4073 > > - Eric L > > On Thu, May 16, 2019 at 1:33 AM Tibor Digana > wrote: > > > Enrico, I checked the Checkstyle rules again (default value = system) and > > Robert is right, please adjust the IT sources on the fly. > > Not sure why INFRA or Jenkins sets the Windows EOL to LF. > > Therefore we could not find this issue in version 3.0.0 (Jan 04) because > > the IT was created on Jan 17 and we run it on local Windows the first > time. > > > > The library is fine. I used several old versions of the plugin having > > identical results. > > Few links: > > > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile > > > > http://checkstyle.sourceforge.net/google_style.html > > > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml > > > > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml > > > > I expected platform independence because my company used sun_checks.xml > on > > Windows with Unix EOL in Git/IDE without this problem. > > The company improved sun_checks.xml long time ago, so I realized that > later > > that it is slightly different XML and different experience. Sorry. > > Cheers > > Tibor17 > > > > > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > > wrote: > > > > > I will get a windows box and try to reproduce. > > > It is weird that on ASF Jenkins the build is passing even on windows > > > > > > Enrico > > > > > > -- Forwarded message - > > > Da: Enrico Olivelli > > > Date: mar 14 mag 2019, 13:58 > > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version > 3.1.0 > > > To: Maven Developers List > > > > > > > > > Eric and Tibor, > > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > > > This is the "official" VOTE thread, here we have to decide if the > staged > > > artifacts are good to be released or not. > > > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > > "stable" or there is any showstopper problem for the release. > > > > > > Let's move this discussion to a separate thread, something like > > "Validation > > > failures in Windows over current checkstyle plugin master branch") > > > > > > Enrico > > > > > > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > > mindcoo...@gmail.com> > > > ha scritto: > > > > > > > Tried overriding line.separator when running using > > -Dline.separator="\n", > > > > but then the builds fails (early) in maven-plugin-plugin: > > > > [ERROR] Failed to execute goal > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > > default-descriptor of goal > > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > > Requested line separator is invalid. -> [Help 1] > > > > [ERROR] > > > > [ERROR] To see the full stack trace of the errors, re-run Maven with > > the > > > -e > > > > switch. > > > > [ERROR] Re-run Maven using the -X switch to enable full debug > logging. > > > > [ERROR] > > > > [ERROR] For more information about the errors and possible solutions, > > > > please read the following articles: > > > > [ERROR] [Help 1] > > > > > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > > upgradeable...), but same error > > > > > > > > I also happened to notice this (probably unrelated, but wanted to > bring > > > it > > > > to attention anyway so it can be fixed) warning: > > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > > [WARNING] > > > > > > > > Unexpected situation: destinationDirectory not defined in > > > > maven-plugin-help.properties during help mojo source generation but > > > > expected during XML descriptor generation. > > > > [WARNING] Please check helpmojo goal version used in previous build > > > phase. > > > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > > > clean > > > > build at least once. > > > > [WARNING] Trying default location: target\generated-sources\plugin > > > > > > > > - Eric L > > > > > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > > > wrote: > > > > > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > > > dependencies, > > > > > but that just brought an additional
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Just to inform you that this problem has been resolved in version 8.21 of checkstyle, which was just released, and I've confirmed the fix works by running the ITs on the checkstyle-plugin (checked out master on Cygwin). There are two other failures, though (was one failure with 8.20 if I recall correctly, apart from the EOL issue still present in that version). https://github.com/checkstyle/checkstyle/issues/4073 - Eric L On Thu, May 16, 2019 at 1:33 AM Tibor Digana wrote: > Enrico, I checked the Checkstyle rules again (default value = system) and > Robert is right, please adjust the IT sources on the fly. > Not sure why INFRA or Jenkins sets the Windows EOL to LF. > Therefore we could not find this issue in version 3.0.0 (Jan 04) because > the IT was created on Jan 17 and we run it on local Windows the first time. > > The library is fine. I used several old versions of the plugin having > identical results. > Few links: > > http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile > > http://checkstyle.sourceforge.net/google_style.html > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml > > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml > > I expected platform independence because my company used sun_checks.xml on > Windows with Unix EOL in Git/IDE without this problem. > The company improved sun_checks.xml long time ago, so I realized that later > that it is slightly different XML and different experience. Sorry. > Cheers > Tibor17 > > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > wrote: > > > I will get a windows box and try to reproduce. > > It is weird that on ASF Jenkins the build is passing even on windows > > > > Enrico > > > > -- Forwarded message - > > Da: Enrico Olivelli > > Date: mar 14 mag 2019, 13:58 > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > > To: Maven Developers List > > > > > > Eric and Tibor, > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > This is the "official" VOTE thread, here we have to decide if the staged > > artifacts are good to be released or not. > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > "stable" or there is any showstopper problem for the release. > > > > Let's move this discussion to a separate thread, something like > "Validation > > failures in Windows over current checkstyle plugin master branch") > > > > Enrico > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > mindcoo...@gmail.com> > > ha scritto: > > > > > Tried overriding line.separator when running using > -Dline.separator="\n", > > > but then the builds fails (early) in maven-plugin-plugin: > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > default-descriptor of goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > Requested line separator is invalid. -> [Help 1] > > > [ERROR] > > > [ERROR] To see the full stack trace of the errors, re-run Maven with > the > > -e > > > switch. > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > > [ERROR] > > > [ERROR] For more information about the errors and possible solutions, > > > please read the following articles: > > > [ERROR] [Help 1] > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > upgradeable...), but same error > > > > > > I also happened to notice this (probably unrelated, but wanted to bring > > it > > > to attention anyway so it can be fixed) warning: > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > [WARNING] > > > > > > Unexpected situation: destinationDirectory not defined in > > > maven-plugin-help.properties during help mojo source generation but > > > expected during XML descriptor generation. > > > [WARNING] Please check helpmojo goal version used in previous build > > phase. > > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > > clean > > > build at least once. > > > [WARNING] Trying default location: target\generated-sources\plugin > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > > wrote: > > > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > > dependencies, > > > > but that just brought an additional failure... (to > > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > > > I suppose the problem might be that the files has linux-style line > > breaks > > > > (this is desired for me, I don't want to convert to windows-style > line > > > > breaks locally), but the test think I should have windows-style line > > > > separators. It seems these files are generated by the tests because I > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Enrico, I checked the Checkstyle rules again (default value = system) and Robert is right, please adjust the IT sources on the fly. Not sure why INFRA or Jenkins sets the Windows EOL to LF. Therefore we could not find this issue in version 3.0.0 (Jan 04) because the IT was created on Jan 17 and we run it on local Windows the first time. The library is fine. I used several old versions of the plugin having identical results. Few links: http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile http://checkstyle.sourceforge.net/google_style.html https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml I expected platform independence because my company used sun_checks.xml on Windows with Unix EOL in Git/IDE without this problem. The company improved sun_checks.xml long time ago, so I realized that later that it is slightly different XML and different experience. Sorry. Cheers Tibor17 On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli wrote: > I will get a windows box and try to reproduce. > It is weird that on ASF Jenkins the build is passing even on windows > > Enrico > > -- Forwarded message - > Da: Enrico Olivelli > Date: mar 14 mag 2019, 13:58 > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > To: Maven Developers List > > > Eric and Tibor, > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > This is the "official" VOTE thread, here we have to decide if the staged > artifacts are good to be released or not. > > Feel free to cast a -1 if you think that the staged artifacts are not > "stable" or there is any showstopper problem for the release. > > Let's move this discussion to a separate thread, something like "Validation > failures in Windows over current checkstyle plugin master branch") > > Enrico > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > ha scritto: > > > Tried overriding line.separator when running using -Dline.separator="\n", > > but then the builds fails (early) in maven-plugin-plugin: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > default-descriptor of goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > Requested line separator is invalid. -> [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > upgradeable...), but same error > > > > I also happened to notice this (probably unrelated, but wanted to bring > it > > to attention anyway so it can be fixed) warning: > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > [WARNING] > > > > Unexpected situation: destinationDirectory not defined in > > maven-plugin-help.properties during help mojo source generation but > > expected during XML descriptor generation. > > [WARNING] Please check helpmojo goal version used in previous build > phase. > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > clean > > build at least once. > > [WARNING] Trying default location: target\generated-sources\plugin > > > > - Eric L > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > wrote: > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > dependencies, > > > but that just brought an additional failure... (to > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > I suppose the problem might be that the files has linux-style line > breaks > > > (this is desired for me, I don't want to convert to windows-style line > > > breaks locally), but the test think I should have windows-style line > > > separators. It seems these files are generated by the tests because I > > tried > > > changing them to Windows style line breaks for re-running just to see > if > > > that would work, but those changes were overwritten) > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > wrote: > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > try > > >> the source zip, just cloned master) > > >> > > >> I tested on one of our corporate laptops: > > >> Windows 10 > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > >> Maven 3.6.0 > > >> Java 8 update 202 > > >> > > >> The build log says: > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > sun_checks.xml > > >> ruleset. > > >> [ERROR] > > >> > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Robert, see this https://issues.apache.org/jira/browse/MCHECKSTYLE-376 The Git clone fails on Windows. Most probably our Jenkins is using LF EOL on Windows and not CRLF. We cannot hack Java files only to pass the IT. Why one or two ITs failed and the other dont. The IT has only one POM and two Java source files. This can be run without out IT mechanism just from CLI, and this fails the same way and I am sure this will happen to customer. We did something wrong or Checkstyle library? In real situations user projects use Git editor and IDEs using Unix EOL but the operating system is Windows. In such case the checkstyle becomes a blocker and their projects would never pass through. Checkstyle documentation all lists characers of EOL and they are all possible characters by default. The question is why the library behaves against the documentation. Bug? The rules are designed so that they are platform independent and EOL character is not mandatory but it is mandatory for a good parser of the text file. Which code is parsing the text files? On Wed, May 15, 2019 at 7:52 PM Robert Scholte wrote: > FYI, I'm on Windows (by default), just cmdline, so no powercommand or > gitbash or similar prompts. > A clone from Git succeeds, but the sources.zip fails. > The files in the zip are generated on a unix system, so all EOLs in text > files are LF > If I replace the EOL from unix to Windows the build succeeds. > This also explains why it succeeds on builds.a.o, there the EOLs are > always based on the OS due to the Auto Crlf convert option. > The fix: add a setup.groovy to the IT and rewrite the java files with OS > specific EOLs > > Robert > > On 14-5-2019 16:32:29, Enrico Olivelli wrote: > Thanks > I am able to reproduce the issue on a Windows box. > Still I can't understand why we aren't seeing problems on CI. > > Eric, > do you have cycles to create a JIRA and send a Pull request ? > We can fix it in master. > As Tibor said, I think this is not a blocker for the 3.1.0 release. > > Otherwise I will fix it when I have time, but not today > > > Thank you very much for reporting > Enrico > > > > Il giorno mar 14 mag 2019 alle ore 16:24 Enrico Olivelli > eolive...@gmail.com> ha scritto: > > > > > > > Il giorno mar 14 mag 2019 alle ore 14:34 Tibor Digana > > tibordig...@apache.org> ha scritto: > > > >> Two files in one IT are problematic but I don't think it is a problem > for > >> your release. > >> The CPD should be fixed and a method should be reused but again it is > not > >> a reason to interrupt the vote. > >> > >> One more question. Why did you "git push" the history from Maven Release > >> plugin? > >> This should be done after the vote because yet you do not know the vote > >> result. > >> > > > > Please explain better. > > I apologize if I did a mistake, but I can't understand your concern. > > > > I have used these commands: > > mvn release:clean > > mvn release:prepare > > mvn release:perform > > "Closed" the staged repository > > > > current master is 3.1.1-SNAPSHOT > > https://github.com/apache/maven-checkstyle-plugin > > > > tag is at: 3.1.0 > > > > > https://github.com/apache/maven-checkstyle-plugin/tree/maven-checkstyle-plugin-3.1.0 > > > > > > > > > > > > Enrico > > > > > > > >> > >> Cheers > >> Tibor > >> > >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > >> wrote: > >> > >> > I will get a windows box and try to reproduce. > >> > It is weird that on ASF Jenkins the build is passing even on windows > >> > > >> > Enrico > >> > > >> > -- Forwarded message - > >> > Da: Enrico Olivelli > >> > Date: mar 14 mag 2019, 13:58 > >> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version > 3.1.0 > >> > To: Maven Developers List > >> > > >> > > >> > Eric and Tibor, > >> > Thank you so much for your effort in testing Maven Checkstyle Plugin. > >> > > >> > This is the "official" VOTE thread, here we have to decide if the > staged > >> > artifacts are good to be released or not. > >> > > >> > Feel free to cast a -1 if you think that the staged artifacts are not > >> > "stable" or there is any showstopper problem for the release. > >> > > >> > Let's move this discussion to a separate thread, something like > >> "Validation > >> > failures in Windows over current checkstyle plugin master branch") > >> > > >> > Enrico > >> > > >> > > >> > > >> > > >> > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > >> mindcoo...@gmail.com> > >> > ha scritto: > >> > > >> > > Tried overriding line.separator when running using > >> -Dline.separator="\n", > >> > > but then the builds fails (early) in maven-plugin-plugin: > >> > > [ERROR] Failed to execute goal > >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > >> > > (default-descriptor) on project maven-checkstyle-plugin: Execution > >> > > default-descriptor of goal > >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > >> > > Requested line separator is invalid. -> [Help 1] > >> > > [ERROR] > >> > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
FYI, I'm on Windows (by default), just cmdline, so no powercommand or gitbash or similar prompts. A clone from Git succeeds, but the sources.zip fails. The files in the zip are generated on a unix system, so all EOLs in text files are LF If I replace the EOL from unix to Windows the build succeeds. This also explains why it succeeds on builds.a.o, there the EOLs are always based on the OS due to the Auto Crlf convert option. The fix: add a setup.groovy to the IT and rewrite the java files with OS specific EOLs Robert On 14-5-2019 16:32:29, Enrico Olivelli wrote: Thanks I am able to reproduce the issue on a Windows box. Still I can't understand why we aren't seeing problems on CI. Eric, do you have cycles to create a JIRA and send a Pull request ? We can fix it in master. As Tibor said, I think this is not a blocker for the 3.1.0 release. Otherwise I will fix it when I have time, but not today Thank you very much for reporting Enrico Il giorno mar 14 mag 2019 alle ore 16:24 Enrico Olivelli eolive...@gmail.com> ha scritto: > > > Il giorno mar 14 mag 2019 alle ore 14:34 Tibor Digana > tibordig...@apache.org> ha scritto: > >> Two files in one IT are problematic but I don't think it is a problem for >> your release. >> The CPD should be fixed and a method should be reused but again it is not >> a reason to interrupt the vote. >> >> One more question. Why did you "git push" the history from Maven Release >> plugin? >> This should be done after the vote because yet you do not know the vote >> result. >> > > Please explain better. > I apologize if I did a mistake, but I can't understand your concern. > > I have used these commands: > mvn release:clean > mvn release:prepare > mvn release:perform > "Closed" the staged repository > > current master is 3.1.1-SNAPSHOT > https://github.com/apache/maven-checkstyle-plugin > > tag is at: 3.1.0 > > https://github.com/apache/maven-checkstyle-plugin/tree/maven-checkstyle-plugin-3.1.0 > > > > > > Enrico > > > >> >> Cheers >> Tibor >> >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli >> wrote: >> >> > I will get a windows box and try to reproduce. >> > It is weird that on ASF Jenkins the build is passing even on windows >> > >> > Enrico >> > >> > -- Forwarded message - >> > Da: Enrico Olivelli >> > Date: mar 14 mag 2019, 13:58 >> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 >> > To: Maven Developers List >> > >> > >> > Eric and Tibor, >> > Thank you so much for your effort in testing Maven Checkstyle Plugin. >> > >> > This is the "official" VOTE thread, here we have to decide if the staged >> > artifacts are good to be released or not. >> > >> > Feel free to cast a -1 if you think that the staged artifacts are not >> > "stable" or there is any showstopper problem for the release. >> > >> > Let's move this discussion to a separate thread, something like >> "Validation >> > failures in Windows over current checkstyle plugin master branch") >> > >> > Enrico >> > >> > >> > >> > >> > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja >> mindcoo...@gmail.com> >> > ha scritto: >> > >> > > Tried overriding line.separator when running using >> -Dline.separator="\n", >> > > but then the builds fails (early) in maven-plugin-plugin: >> > > [ERROR] Failed to execute goal >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >> > > (default-descriptor) on project maven-checkstyle-plugin: Execution >> > > default-descriptor of goal >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: >> > > Requested line separator is invalid. -> [Help 1] >> > > [ERROR] >> > > [ERROR] To see the full stack trace of the errors, re-run Maven with >> the >> > -e >> > > switch. >> > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> > > [ERROR] >> > > [ERROR] For more information about the errors and possible solutions, >> > > please read the following articles: >> > > [ERROR] [Help 1] >> > > >> > >> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException >> > > >> > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff >> > > upgradeable...), but same error >> > > >> > > I also happened to notice this (probably unrelated, but wanted to >> bring >> > it >> > > to attention anyway so it can be fixed) warning: >> > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. >> > > [WARNING] >> > > >> > > Unexpected situation: destinationDirectory not defined in >> > > maven-plugin-help.properties during help mojo source generation but >> > > expected during XML descriptor generation. >> > > [WARNING] Please check helpmojo goal version used in previous build >> > phase. >> > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a >> > clean >> > > build at least once. >> > > [WARNING] Trying default location: target\generated-sources\plugin >> > > >> > > - Eric L >> > > >> > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja >> > wrote: >> > > >> > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Il mer 15 mag 2019, 17:44 Tibor Digana ha scritto: > @Enrico did you announce the Checkstyle team about our issue [1]? > What is going on with that? > [1]: https://issues.apache.org/jira/browse/MCHECKSTYLE-376 > Thx > Tibor17 > Not yet sorry. I have been busy today. Will do this evening Enrico > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > wrote: > > > I will get a windows box and try to reproduce. > > It is weird that on ASF Jenkins the build is passing even on windows > > > > Enrico > > > > -- Forwarded message - > > Da: Enrico Olivelli > > Date: mar 14 mag 2019, 13:58 > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > > To: Maven Developers List > > > > > > Eric and Tibor, > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > This is the "official" VOTE thread, here we have to decide if the staged > > artifacts are good to be released or not. > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > "stable" or there is any showstopper problem for the release. > > > > Let's move this discussion to a separate thread, something like > "Validation > > failures in Windows over current checkstyle plugin master branch") > > > > Enrico > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > mindcoo...@gmail.com> > > ha scritto: > > > > > Tried overriding line.separator when running using > -Dline.separator="\n", > > > but then the builds fails (early) in maven-plugin-plugin: > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > default-descriptor of goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > Requested line separator is invalid. -> [Help 1] > > > [ERROR] > > > [ERROR] To see the full stack trace of the errors, re-run Maven with > the > > -e > > > switch. > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > > [ERROR] > > > [ERROR] For more information about the errors and possible solutions, > > > please read the following articles: > > > [ERROR] [Help 1] > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > upgradeable...), but same error > > > > > > I also happened to notice this (probably unrelated, but wanted to bring > > it > > > to attention anyway so it can be fixed) warning: > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > [WARNING] > > > > > > Unexpected situation: destinationDirectory not defined in > > > maven-plugin-help.properties during help mojo source generation but > > > expected during XML descriptor generation. > > > [WARNING] Please check helpmojo goal version used in previous build > > phase. > > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > > clean > > > build at least once. > > > [WARNING] Trying default location: target\generated-sources\plugin > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > > wrote: > > > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > > dependencies, > > > > but that just brought an additional failure... (to > > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > > > I suppose the problem might be that the files has linux-style line > > breaks > > > > (this is desired for me, I don't want to convert to windows-style > line > > > > breaks locally), but the test think I should have windows-style line > > > > separators. It seems these files are generated by the tests because I > > > tried > > > > changing them to Windows style line breaks for re-running just to see > > if > > > > that would work, but those changes were overwritten) > > > > > > > > - Eric L > > > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > > wrote: > > > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > > try > > > >> the source zip, just cloned master) > > > >> > > > >> I tested on one of our corporate laptops: > > > >> Windows 10 > > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > > >> Maven 3.6.0 > > > >> Java 8 update 202 > > > >> > > > >> The build log says: > > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > > sun_checks.xml > > > >> ruleset. > > > >> [ERROR] > > > >> > > > > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > > >> [ERROR] > > > >> > > > > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] > > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > > >> > > > >> These two files end with unix-style line breaks (as expected with my > > > >> setup). > > > >> > > > >> - Eric L > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
@Enrico did you announce the Checkstyle team about our issue [1]? What is going on with that? [1]: https://issues.apache.org/jira/browse/MCHECKSTYLE-376 Thx Tibor17 On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli wrote: > I will get a windows box and try to reproduce. > It is weird that on ASF Jenkins the build is passing even on windows > > Enrico > > -- Forwarded message - > Da: Enrico Olivelli > Date: mar 14 mag 2019, 13:58 > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > To: Maven Developers List > > > Eric and Tibor, > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > This is the "official" VOTE thread, here we have to decide if the staged > artifacts are good to be released or not. > > Feel free to cast a -1 if you think that the staged artifacts are not > "stable" or there is any showstopper problem for the release. > > Let's move this discussion to a separate thread, something like "Validation > failures in Windows over current checkstyle plugin master branch") > > Enrico > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > ha scritto: > > > Tried overriding line.separator when running using -Dline.separator="\n", > > but then the builds fails (early) in maven-plugin-plugin: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > default-descriptor of goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > Requested line separator is invalid. -> [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > upgradeable...), but same error > > > > I also happened to notice this (probably unrelated, but wanted to bring > it > > to attention anyway so it can be fixed) warning: > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > [WARNING] > > > > Unexpected situation: destinationDirectory not defined in > > maven-plugin-help.properties during help mojo source generation but > > expected during XML descriptor generation. > > [WARNING] Please check helpmojo goal version used in previous build > phase. > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > clean > > build at least once. > > [WARNING] Trying default location: target\generated-sources\plugin > > > > - Eric L > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > wrote: > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > dependencies, > > > but that just brought an additional failure... (to > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > I suppose the problem might be that the files has linux-style line > breaks > > > (this is desired for me, I don't want to convert to windows-style line > > > breaks locally), but the test think I should have windows-style line > > > separators. It seems these files are generated by the tests because I > > tried > > > changing them to Windows style line breaks for re-running just to see > if > > > that would work, but those changes were overwritten) > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > wrote: > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > try > > >> the source zip, just cloned master) > > >> > > >> I tested on one of our corporate laptops: > > >> Windows 10 > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > >> Maven 3.6.0 > > >> Java 8 update 202 > > >> > > >> The build log says: > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > sun_checks.xml > > >> ruleset. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> > > >> These two files end with unix-style line breaks (as expected with my > > >> setup). > > >> > > >> - Eric L > > >> > > >> > > >> On Tue, May 14, 2019 at 8:10 AM Enrico Olivelli > > >> wrote: > > >> > > >>> Il lun 13 mag 2019, 23:48 Tibor Digana ha > > >>> scritto: > > >>> > > >>> > Robert, I did *not* use the source zip. > > >>> > > > >>> > > >>> IMHO we should vote on the staged zip > > >>> > > >>> > > >>> > git clone > > https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin > > >>> > Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10 > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Thanks I am able to reproduce the issue on a Windows box. Still I can't understand why we aren't seeing problems on CI. Eric, do you have cycles to create a JIRA and send a Pull request ? We can fix it in master. As Tibor said, I think this is not a blocker for the 3.1.0 release. Otherwise I will fix it when I have time, but not today Thank you very much for reporting Enrico Il giorno mar 14 mag 2019 alle ore 16:24 Enrico Olivelli < eolive...@gmail.com> ha scritto: > > > Il giorno mar 14 mag 2019 alle ore 14:34 Tibor Digana < > tibordig...@apache.org> ha scritto: > >> Two files in one IT are problematic but I don't think it is a problem for >> your release. >> The CPD should be fixed and a method should be reused but again it is not >> a reason to interrupt the vote. >> >> One more question. Why did you "git push" the history from Maven Release >> plugin? >> This should be done after the vote because yet you do not know the vote >> result. >> > > Please explain better. > I apologize if I did a mistake, but I can't understand your concern. > > I have used these commands: > mvn release:clean > mvn release:prepare > mvn release:perform > "Closed" the staged repository > > current master is 3.1.1-SNAPSHOT > https://github.com/apache/maven-checkstyle-plugin > > tag is at: 3.1.0 > > https://github.com/apache/maven-checkstyle-plugin/tree/maven-checkstyle-plugin-3.1.0 > > > > > > Enrico > > > >> >> Cheers >> Tibor >> >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli >> wrote: >> >> > I will get a windows box and try to reproduce. >> > It is weird that on ASF Jenkins the build is passing even on windows >> > >> > Enrico >> > >> > -- Forwarded message - >> > Da: Enrico Olivelli >> > Date: mar 14 mag 2019, 13:58 >> > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 >> > To: Maven Developers List >> > >> > >> > Eric and Tibor, >> > Thank you so much for your effort in testing Maven Checkstyle Plugin. >> > >> > This is the "official" VOTE thread, here we have to decide if the staged >> > artifacts are good to be released or not. >> > >> > Feel free to cast a -1 if you think that the staged artifacts are not >> > "stable" or there is any showstopper problem for the release. >> > >> > Let's move this discussion to a separate thread, something like >> "Validation >> > failures in Windows over current checkstyle plugin master branch") >> > >> > Enrico >> > >> > >> > >> > >> > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < >> mindcoo...@gmail.com> >> > ha scritto: >> > >> > > Tried overriding line.separator when running using >> -Dline.separator="\n", >> > > but then the builds fails (early) in maven-plugin-plugin: >> > > [ERROR] Failed to execute goal >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >> > > (default-descriptor) on project maven-checkstyle-plugin: Execution >> > > default-descriptor of goal >> > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: >> > > Requested line separator is invalid. -> [Help 1] >> > > [ERROR] >> > > [ERROR] To see the full stack trace of the errors, re-run Maven with >> the >> > -e >> > > switch. >> > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> > > [ERROR] >> > > [ERROR] For more information about the errors and possible solutions, >> > > please read the following articles: >> > > [ERROR] [Help 1] >> > > >> > >> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException >> > > >> > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff >> > > upgradeable...), but same error >> > > >> > > I also happened to notice this (probably unrelated, but wanted to >> bring >> > it >> > > to attention anyway so it can be fixed) warning: >> > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. >> > > [WARNING] >> > > >> > > Unexpected situation: destinationDirectory not defined in >> > > maven-plugin-help.properties during help mojo source generation but >> > > expected during XML descriptor generation. >> > > [WARNING] Please check helpmojo goal version used in previous build >> > phase. >> > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a >> > clean >> > > build at least once. >> > > [WARNING] Trying default location: target\generated-sources\plugin >> > > >> > > - Eric L >> > > >> > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja >> > wrote: >> > > >> > > > I tried bumping checkstyle to 8.20, plus a few of the plexus >> > > dependencies, >> > > > but that just brought an additional failure... (to >> > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) >> > > > >> > > > I suppose the problem might be that the files has linux-style line >> > breaks >> > > > (this is desired for me, I don't want to convert to windows-style >> line >> > > > breaks locally), but the test think I should have windows-style line >> > > > separators. It seems these files are generated by the tests because >> I >> > > tried >> > > >
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Il giorno mar 14 mag 2019 alle ore 14:34 Tibor Digana < tibordig...@apache.org> ha scritto: > Two files in one IT are problematic but I don't think it is a problem for > your release. > The CPD should be fixed and a method should be reused but again it is not > a reason to interrupt the vote. > > One more question. Why did you "git push" the history from Maven Release > plugin? > This should be done after the vote because yet you do not know the vote > result. > Please explain better. I apologize if I did a mistake, but I can't understand your concern. I have used these commands: mvn release:clean mvn release:prepare mvn release:perform "Closed" the staged repository current master is 3.1.1-SNAPSHOT https://github.com/apache/maven-checkstyle-plugin tag is at: 3.1.0 https://github.com/apache/maven-checkstyle-plugin/tree/maven-checkstyle-plugin-3.1.0 Enrico > > Cheers > Tibor > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > wrote: > > > I will get a windows box and try to reproduce. > > It is weird that on ASF Jenkins the build is passing even on windows > > > > Enrico > > > > -- Forwarded message - > > Da: Enrico Olivelli > > Date: mar 14 mag 2019, 13:58 > > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > > To: Maven Developers List > > > > > > Eric and Tibor, > > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > > > This is the "official" VOTE thread, here we have to decide if the staged > > artifacts are good to be released or not. > > > > Feel free to cast a -1 if you think that the staged artifacts are not > > "stable" or there is any showstopper problem for the release. > > > > Let's move this discussion to a separate thread, something like > "Validation > > failures in Windows over current checkstyle plugin master branch") > > > > Enrico > > > > > > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < > mindcoo...@gmail.com> > > ha scritto: > > > > > Tried overriding line.separator when running using > -Dline.separator="\n", > > > but then the builds fails (early) in maven-plugin-plugin: > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > > default-descriptor of goal > > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > > Requested line separator is invalid. -> [Help 1] > > > [ERROR] > > > [ERROR] To see the full stack trace of the errors, re-run Maven with > the > > -e > > > switch. > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > > [ERROR] > > > [ERROR] For more information about the errors and possible solutions, > > > please read the following articles: > > > [ERROR] [Help 1] > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > > upgradeable...), but same error > > > > > > I also happened to notice this (probably unrelated, but wanted to bring > > it > > > to attention anyway so it can be fixed) warning: > > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > > [WARNING] > > > > > > Unexpected situation: destinationDirectory not defined in > > > maven-plugin-help.properties during help mojo source generation but > > > expected during XML descriptor generation. > > > [WARNING] Please check helpmojo goal version used in previous build > > phase. > > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > > clean > > > build at least once. > > > [WARNING] Trying default location: target\generated-sources\plugin > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > > wrote: > > > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > > dependencies, > > > > but that just brought an additional failure... (to > > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > > > I suppose the problem might be that the files has linux-style line > > breaks > > > > (this is desired for me, I don't want to convert to windows-style > line > > > > breaks locally), but the test think I should have windows-style line > > > > separators. It seems these files are generated by the tests because I > > > tried > > > > changing them to Windows style line breaks for re-running just to see > > if > > > > that would work, but those changes were overwritten) > > > > > > > > - Eric L > > > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > > wrote: > > > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > > try > > > >> the source zip, just cloned master) > > > >> > > > >> I tested on one of our corporate laptops: > > > >> Windows 10 > > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > > >> Maven 3.6.0 > > > >> Java 8 update 202 > > > >> > > > >> The build log says: > > > >> [INFO] There are 2 errors
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Since git settings may influence line separators when cloning and Checkstyle seems to want read line separator to match System.lineSeparator, maybe the test need to take full control back (from git) over the two files in the test, to have a fully deterministic test input files. - Eric L On Tue, May 14, 2019 at 4:18 PM Eric Lilja wrote: > Hi, I edited the wrong files before when I changed line breaks (edited > copies under target folder, silly me!). I changed the line separators to > Windows-style for the two files under MCHECKSTYLE-54 (Mcheckstyle54.java > and package.info) and the integration tests passes (expect for that other > failure, MCHECKSTYLE-70-multi-sourcefolder\pom.xml, when bumping Checkstyle > version to 8.20 I mentioned previously). > > Maybe your Windows node on Jenkins has git set-up to checkout files as > \r\n, and that's why it works there (assuming the job is indeed cloning). > > A question I now get in my mind how that Checkstyle feature should handle > the fact there is more than one type of line break (unfortunately) out > there, depending on OS... > > - Eric L > > > On Tue, May 14, 2019 at 3:08 PM Tibor Digana > wrote: > >> I wrote both files again, see the attachments (windows and Unix EOL). >> To be faster, I am running the command *mvn checkstyle:check* from the >> (IT target) path on my system >> c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\ >> >> No idea why the linux EOL file fails on Windows system. >> >> Cheers >> Tibor >> >> >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli >> wrote: >> >>> I will get a windows box and try to reproduce. >>> It is weird that on ASF Jenkins the build is passing even on windows >>> >>> Enrico >>> >>> -- Forwarded message - >>> Da: Enrico Olivelli >>> Date: mar 14 mag 2019, 13:58 >>> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 >>> To: Maven Developers List >>> >>> >>> Eric and Tibor, >>> Thank you so much for your effort in testing Maven Checkstyle Plugin. >>> >>> This is the "official" VOTE thread, here we have to decide if the staged >>> artifacts are good to be released or not. >>> >>> Feel free to cast a -1 if you think that the staged artifacts are not >>> "stable" or there is any showstopper problem for the release. >>> >>> Let's move this discussion to a separate thread, something like >>> "Validation >>> failures in Windows over current checkstyle plugin master branch") >>> >>> Enrico >>> >>> >>> >>> >>> Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < >>> mindcoo...@gmail.com> >>> ha scritto: >>> >>> > Tried overriding line.separator when running using >>> -Dline.separator="\n", >>> > but then the builds fails (early) in maven-plugin-plugin: >>> > [ERROR] Failed to execute goal >>> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >>> > (default-descriptor) on project maven-checkstyle-plugin: Execution >>> > default-descriptor of goal >>> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: >>> > Requested line separator is invalid. -> [Help 1] >>> > [ERROR] >>> > [ERROR] To see the full stack trace of the errors, re-run Maven with >>> the -e >>> > switch. >>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >>> > [ERROR] >>> > [ERROR] For more information about the errors and possible solutions, >>> > please read the following articles: >>> > [ERROR] [Help 1] >>> > >>> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException >>> > >>> > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff >>> > upgradeable...), but same error >>> > >>> > I also happened to notice this (probably unrelated, but wanted to >>> bring it >>> > to attention anyway so it can be fixed) warning: >>> > [INFO] java-annotations mojo extractor found 4 mojo descriptors. >>> > [WARNING] >>> > >>> > Unexpected situation: destinationDirectory not defined in >>> > maven-plugin-help.properties during help mojo source generation but >>> > expected during XML descriptor generation. >>> > [WARNING] Please check helpmojo goal version used in previous build >>> phase. >>> > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a >>> clean >>> > build at least once. >>> > [WARNING] Trying default location: target\generated-sources\plugin >>> > >>> > - Eric L >>> > >>> > On Tue, May 14, 2019 at 11:04 AM Eric Lilja >>> wrote: >>> > >>> > > I tried bumping checkstyle to 8.20, plus a few of the plexus >>> > dependencies, >>> > > but that just brought an additional failure... (to >>> > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) >>> > > >>> > > I suppose the problem might be that the files has linux-style line >>> breaks >>> > > (this is desired for me, I don't want to convert to windows-style >>> line >>> > > breaks locally), but the test think I should have windows-style line >>> > > separators. It seems these files are generated by the tests
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Hi, I edited the wrong files before when I changed line breaks (edited copies under target folder, silly me!). I changed the line separators to Windows-style for the two files under MCHECKSTYLE-54 (Mcheckstyle54.java and package.info) and the integration tests passes (expect for that other failure, MCHECKSTYLE-70-multi-sourcefolder\pom.xml, when bumping Checkstyle version to 8.20 I mentioned previously). Maybe your Windows node on Jenkins has git set-up to checkout files as \r\n, and that's why it works there (assuming the job is indeed cloning). A question I now get in my mind how that Checkstyle feature should handle the fact there is more than one type of line break (unfortunately) out there, depending on OS... - Eric L On Tue, May 14, 2019 at 3:08 PM Tibor Digana wrote: > I wrote both files again, see the attachments (windows and Unix EOL). > To be faster, I am running the command *mvn checkstyle:check* from the (IT > target) path on my system > c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\ > > No idea why the linux EOL file fails on Windows system. > > Cheers > Tibor > > > On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli > wrote: > >> I will get a windows box and try to reproduce. >> It is weird that on ASF Jenkins the build is passing even on windows >> >> Enrico >> >> -- Forwarded message - >> Da: Enrico Olivelli >> Date: mar 14 mag 2019, 13:58 >> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 >> To: Maven Developers List >> >> >> Eric and Tibor, >> Thank you so much for your effort in testing Maven Checkstyle Plugin. >> >> This is the "official" VOTE thread, here we have to decide if the staged >> artifacts are good to be released or not. >> >> Feel free to cast a -1 if you think that the staged artifacts are not >> "stable" or there is any showstopper problem for the release. >> >> Let's move this discussion to a separate thread, something like >> "Validation >> failures in Windows over current checkstyle plugin master branch") >> >> Enrico >> >> >> >> >> Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > > >> ha scritto: >> >> > Tried overriding line.separator when running using >> -Dline.separator="\n", >> > but then the builds fails (early) in maven-plugin-plugin: >> > [ERROR] Failed to execute goal >> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >> > (default-descriptor) on project maven-checkstyle-plugin: Execution >> > default-descriptor of goal >> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: >> > Requested line separator is invalid. -> [Help 1] >> > [ERROR] >> > [ERROR] To see the full stack trace of the errors, re-run Maven with >> the -e >> > switch. >> > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> > [ERROR] >> > [ERROR] For more information about the errors and possible solutions, >> > please read the following articles: >> > [ERROR] [Help 1] >> > >> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException >> > >> > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff >> > upgradeable...), but same error >> > >> > I also happened to notice this (probably unrelated, but wanted to bring >> it >> > to attention anyway so it can be fixed) warning: >> > [INFO] java-annotations mojo extractor found 4 mojo descriptors. >> > [WARNING] >> > >> > Unexpected situation: destinationDirectory not defined in >> > maven-plugin-help.properties during help mojo source generation but >> > expected during XML descriptor generation. >> > [WARNING] Please check helpmojo goal version used in previous build >> phase. >> > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a >> clean >> > build at least once. >> > [WARNING] Trying default location: target\generated-sources\plugin >> > >> > - Eric L >> > >> > On Tue, May 14, 2019 at 11:04 AM Eric Lilja >> wrote: >> > >> > > I tried bumping checkstyle to 8.20, plus a few of the plexus >> > dependencies, >> > > but that just brought an additional failure... (to >> > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) >> > > >> > > I suppose the problem might be that the files has linux-style line >> breaks >> > > (this is desired for me, I don't want to convert to windows-style line >> > > breaks locally), but the test think I should have windows-style line >> > > separators. It seems these files are generated by the tests because I >> > tried >> > > changing them to Windows style line breaks for re-running just to see >> if >> > > that would work, but those changes were overwritten) >> > > >> > > - Eric L >> > > >> > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja >> > wrote: >> > > >> > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't >> try >> > >> the source zip, just cloned master) >> > >> >> > >> I tested on one of our corporate laptops: >> > >> Windows 10 >> > >> Cygwin 64-bit (I use it to
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
I wrote both files again, see the attachments (windows and Unix EOL). To be faster, I am running the command *mvn checkstyle:check* from the (IT target) path on my system c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\ No idea why the linux EOL file fails on Windows system. Cheers Tibor On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli wrote: > I will get a windows box and try to reproduce. > It is weird that on ASF Jenkins the build is passing even on windows > > Enrico > > -- Forwarded message - > Da: Enrico Olivelli > Date: mar 14 mag 2019, 13:58 > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > To: Maven Developers List > > > Eric and Tibor, > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > This is the "official" VOTE thread, here we have to decide if the staged > artifacts are good to be released or not. > > Feel free to cast a -1 if you think that the staged artifacts are not > "stable" or there is any showstopper problem for the release. > > Let's move this discussion to a separate thread, something like "Validation > failures in Windows over current checkstyle plugin master branch") > > Enrico > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > ha scritto: > > > Tried overriding line.separator when running using -Dline.separator="\n", > > but then the builds fails (early) in maven-plugin-plugin: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > default-descriptor of goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > Requested line separator is invalid. -> [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > upgradeable...), but same error > > > > I also happened to notice this (probably unrelated, but wanted to bring > it > > to attention anyway so it can be fixed) warning: > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > [WARNING] > > > > Unexpected situation: destinationDirectory not defined in > > maven-plugin-help.properties during help mojo source generation but > > expected during XML descriptor generation. > > [WARNING] Please check helpmojo goal version used in previous build > phase. > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > clean > > build at least once. > > [WARNING] Trying default location: target\generated-sources\plugin > > > > - Eric L > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > wrote: > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > dependencies, > > > but that just brought an additional failure... (to > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > I suppose the problem might be that the files has linux-style line > breaks > > > (this is desired for me, I don't want to convert to windows-style line > > > breaks locally), but the test think I should have windows-style line > > > separators. It seems these files are generated by the tests because I > > tried > > > changing them to Windows style line breaks for re-running just to see > if > > > that would work, but those changes were overwritten) > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > wrote: > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > try > > >> the source zip, just cloned master) > > >> > > >> I tested on one of our corporate laptops: > > >> Windows 10 > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > >> Maven 3.6.0 > > >> Java 8 update 202 > > >> > > >> The build log says: > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > sun_checks.xml > > >> ruleset. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> > > >> These two files end with unix-style line breaks (as expected with my > > >> setup). > > >> > > >> - Eric L > > >> > > >> > > >> On Tue, May 14, 2019 at 8:10 AM Enrico Olivelli > > >> wrote: > > >> > > >>> Il lun 13 mag 2019, 23:48 Tibor Digana ha > > >>> scritto: > > >>> > > >>> > Robert, I did *not* use the source zip. > > >>> > > > >>>
Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)
Two files in one IT are problematic but I don't think it is a problem for your release. The CPD should be fixed and a method should be reused but again it is not a reason to interrupt the vote. One more question. Why did you "git push" the history from Maven Release plugin? This should be done after the vote because yet you do not know the vote result. Cheers Tibor On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli wrote: > I will get a windows box and try to reproduce. > It is weird that on ASF Jenkins the build is passing even on windows > > Enrico > > -- Forwarded message - > Da: Enrico Olivelli > Date: mar 14 mag 2019, 13:58 > Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 > To: Maven Developers List > > > Eric and Tibor, > Thank you so much for your effort in testing Maven Checkstyle Plugin. > > This is the "official" VOTE thread, here we have to decide if the staged > artifacts are good to be released or not. > > Feel free to cast a -1 if you think that the staged artifacts are not > "stable" or there is any showstopper problem for the release. > > Let's move this discussion to a separate thread, something like "Validation > failures in Windows over current checkstyle plugin master branch") > > Enrico > > > > > Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja > ha scritto: > > > Tried overriding line.separator when running using -Dline.separator="\n", > > but then the builds fails (early) in maven-plugin-plugin: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor > > (default-descriptor) on project maven-checkstyle-plugin: Execution > > default-descriptor of goal > > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: > > Requested line separator is invalid. -> [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > > http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > > > > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff > > upgradeable...), but same error > > > > I also happened to notice this (probably unrelated, but wanted to bring > it > > to attention anyway so it can be fixed) warning: > > [INFO] java-annotations mojo extractor found 4 mojo descriptors. > > [WARNING] > > > > Unexpected situation: destinationDirectory not defined in > > maven-plugin-help.properties during help mojo source generation but > > expected during XML descriptor generation. > > [WARNING] Please check helpmojo goal version used in previous build > phase. > > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a > clean > > build at least once. > > [WARNING] Trying default location: target\generated-sources\plugin > > > > - Eric L > > > > On Tue, May 14, 2019 at 11:04 AM Eric Lilja > wrote: > > > > > I tried bumping checkstyle to 8.20, plus a few of the plexus > > dependencies, > > > but that just brought an additional failure... (to > > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) > > > > > > I suppose the problem might be that the files has linux-style line > breaks > > > (this is desired for me, I don't want to convert to windows-style line > > > breaks locally), but the test think I should have windows-style line > > > separators. It seems these files are generated by the tests because I > > tried > > > changing them to Windows style line breaks for re-running just to see > if > > > that would work, but those changes were overwritten) > > > > > > - Eric L > > > > > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja > > wrote: > > > > > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't > try > > >> the source zip, just cloned master) > > >> > > >> I tested on one of our corporate laptops: > > >> Windows 10 > > >> Cygwin 64-bit (I use it to clone the repo and use Maven) > > >> Maven 3.6.0 > > >> Java 8 update 202 > > >> > > >> The build log says: > > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with > > sun_checks.xml > > >> ruleset. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> [ERROR] > > >> > > > src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] > > >> (misc) NewlineAtEndOfFile: File does not end with a newline. > > >> > > >> These two files end with unix-style line breaks (as expected with my > > >> setup). > > >> > > >> - Eric L > > >> > > >> > > >> On Tue, May 14, 2019 at 8:10 AM Enrico Olivelli > > >> wrote: > > >> > > >>> Il lun 13 mag 2019, 23:48 Tibor Digana ha > > >>> scritto: > > >>> > > >>> > Robert, I did *not* use the source zip. > > >>> > > > >>>
