Re: Second MNG-6957 (build/consumer part 2)

2020-12-13 Thread Robert Scholte
sure, give me sign when you're ready
On 13-12-2020 10:52:16, Michael Osipov  wrote:
Can your hold off for few more days? I'd like to run all ITs on my BSD
box, maybe it will uncover something. I am currently overloaded with the
likely upcoming hard lockdown here.

M

Am 2020-12-12 um 16:22 schrieb Robert Scholte:
> If there are no objections, I'll merge this probably Monday back to master.
> Most important to me is that the regression is fixed, further optimizations 
> and possible refactoring can be done afterwards.
>
> Robert
>
> On 28-11-2020 16:23:27, Robert Scholte wrote:
> Looking for reviewers to validate the PRs[1][2] for MNG-6957[3]
> As this is quite a huge commit touching an important part of the Maven 
> internals, I've recorded a video.[4]
> Maarten and Martin joined me to ask the critical questions to better 
> understand the technical details.
>
> thanks,
> Robert
>
> [1] https://github.com/apache/maven/pull/391
> [2] https://github.com/apache/maven-integration-testing/pull/82
> [3] https://issues.apache.org/jira/browse/MNG-6957
> [4] https://youtu.be/KDAmlNKZJto
>



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-6957 (build/consumer part 2)

2020-12-13 Thread Michael Osipov
Can your hold off for few more days? I'd like to run all ITs on my BSD 
box, maybe it will uncover something. I am currently overloaded with the 
likely upcoming hard lockdown here.


M

Am 2020-12-12 um 16:22 schrieb Robert Scholte:

If there are no objections, I'll merge this probably Monday back to master.
Most important to me is that the regression is fixed, further optimizations and 
possible refactoring can be done afterwards.

Robert

On 28-11-2020 16:23:27, Robert Scholte  wrote:
Looking for reviewers to validate the PRs[1][2] for MNG-6957[3]
As this is quite a huge commit touching an important part of the Maven 
internals, I've recorded a video.[4]
Maarten and Martin joined me to ask the critical questions to better understand 
the technical details.

thanks,
Robert

[1] https://github.com/apache/maven/pull/391
[2] https://github.com/apache/maven-integration-testing/pull/82
[3] https://issues.apache.org/jira/browse/MNG-6957
[4] https://youtu.be/KDAmlNKZJto





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Second MNG-6957 (build/consumer part 2)

2020-12-12 Thread Robert Scholte
If there are no objections, I'll merge this probably Monday back to master.
Most important to me is that the regression is fixed, further optimizations and 
possible refactoring can be done afterwards.

Robert

On 28-11-2020 16:23:27, Robert Scholte  wrote:
Looking for reviewers to validate the PRs[1][2] for MNG-6957[3]
As this is quite a huge commit touching an important part of the Maven 
internals, I've recorded a video.[4]
Maarten and Martin joined me to ask the critical questions to better understand 
the technical details.

thanks,
Robert

[1] https://github.com/apache/maven/pull/391
[2] https://github.com/apache/maven-integration-testing/pull/82
[3] https://issues.apache.org/jira/browse/MNG-6957
[4] https://youtu.be/KDAmlNKZJto