Re: Roadmap Maven 3.4.0
On 16 Jun 2016, at 8:42, Uwe Barthel wrote:
> The custom implementation could be placed in {maven.home}/lib/ext or maybe
> also as extension in .mvn/ per project.
Hmm, this is actually want I want to do ( re my post on problems with lifecycle
extensions ). But was told that ./mvn extensions should not change the
behaviour of the build. I guess this change is allowing for changing that idea
tho.
We have an extension in .mvn/extensions that loads/sets user properties to be
used in the pom, IntelliJ doesn't recognise any of those properties tho, so
resolution/project loading breaks. If you're going also change resolution via
a .mvn/extension.xml entry, quite possibly IntelliJ will ignore that as well.
Mark
--
Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt
signature.asc
Description: OpenPGP digital signature
Re: Roadmap Maven 3.4.0
Hi Michael,
> I have made several comments. Please review and update otherwise I cannot
> proceed on the merge.
I take a look.
Thats a lot of auto formatting things.
It’s quite difficult to manage these over different projects in Netbeans.
I'll fix that.
> Additionally, I am waiting for an answer to my question:
> The PR looks good as it does not change the default behavior. Though, I do
> not understand how it is supposed to solve the problem because your default
> impl of VersionRangeResultFilter does nothing. Are you going to add your
> custom implementation to {maven.home}/lib/ext?
That's Right.
Over the years there were more than one and opposing views how is the right
solution for resolving version range.
This PR give the possibility to use a strategy you like.
The default implementation must not be changed to give this PR a change to
merge (see comments at the PR).
The custom implementation could be placed in {maven.home}/lib/ext or maybe also
as extension in .mvn/ per project.
> Even if I would merge, the issue wouldn't be resolved. Is that correct?
More or less.
Now it provides an API to add a filter you like.
It could be the solution for this issue while we would not change the default
behaviour or provide different strategies in Maven core.
Adding a documentation and an example on this issue and everyone might
implement a solution he likes/needs.
-- barthel
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Roadmap Maven 3.4.0
Am 2016-06-14 um 22:46 schrieb Uwe Barthel:
Hi,
Is there a clear roadmap for version 3.4.0?
I ask, because these PRs: https://github.com/apache/maven/pull/70 (integration
tests: https://github.com/apache/maven-integration-testing/pull/14) for Item
https://issues.apache.org/jira/browse/MNG-3092.
This item lives around NINE years and these PRs are open since October 2015.
Michael O. and Jason have looked at the PR and, in my opinion, reviewed for a
merge.
This branch has no conflicts with the base branch.
Please give a clear statement as to whether the solution is accepted or not.
So I've the chance to close these PRs.
Are there any other open PRs for 3.4.0, where I might be able to help with a
review?
I have made several comments. Please review and update otherwise I
cannot proceed on the merge.
Additionally, I am waiting for an answer to my question:
The PR looks good as it does not change the default behavior. Though, I
do not understand how it is supposed to solve the problem because your
default impl of VersionRangeResultFilter does nothing. Are you going to
add your custom implementation to {maven.home}/lib/ext?
Even if I would merge, the issue wouldn't be resolved. Is that correct?
Michael
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Roadmap Maven 3.4.0
Am 2016-06-14 um 22:46 schrieb Uwe Barthel:
Hi,
Is there a clear roadmap for version 3.4.0?
I ask, because these PRs: https://github.com/apache/maven/pull/70 (integration
tests: https://github.com/apache/maven-integration-testing/pull/14) for Item
https://issues.apache.org/jira/browse/MNG-3092.
This item lives around NINE years and these PRs are open since October 2015.
Michael O. and Jason have looked at the PR and, in my opinion, reviewed for a
merge.
This branch has no conflicts with the base branch.
Please give a clear statement as to whether the solution is accepted or not.
So I've the chance to close these PRs.
Are there any other open PRs for 3.4.0, where I might be able to help with a
review?
Hi Uwe,
this is partially my bad -- I completely lost track of the PRs,
especially the long ones.
The PR looks good as it does not change the default behavior. Though, I
do not understand how it is supposed to solve the problem because your
default impl of VersionRangeResultFilter does nothing. Are you going to
add your custom implementation to {maven.home}/lib/ext?
I will merge locally, run ITs with and without patch and then push
during this week.
Michael
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Roadmap Maven 3.4.0
Hi Paul, > You can find the JIRA Maven Roadmap here: > https://issues.apache.org/jira/browse/MNG/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel Thanks for the link that I already know. I meant a roadmap in terms of a timeline. Is the number of items already fixed? -- barthel > On 14 Jun 2016, at 22:55, Paul Benedict wrote: > > You can find the JIRA Maven Roadmap here: > https://issues.apache.org/jira/browse/MNG/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel > > > Cheers, > Paul > > On Tue, Jun 14, 2016 at 3:46 PM, Uwe Barthel wrote: > >> Hi, >> >> Is there a clear roadmap for version 3.4.0? >> >> I ask, because these PRs: https://github.com/apache/maven/pull/70 >> (integration tests: >> https://github.com/apache/maven-integration-testing/pull/14) for Item >> https://issues.apache.org/jira/browse/MNG-3092. >> >> This item lives around NINE years and these PRs are open since October >> 2015. >> Michael O. and Jason have looked at the PR and, in my opinion, reviewed >> for a merge. >> This branch has no conflicts with the base branch. >> >> Please give a clear statement as to whether the solution is accepted or >> not. >> So I've the chance to close these PRs. >> >> Are there any other open PRs for 3.4.0, where I might be able to help with >> a review? >> >> -- barthel >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Roadmap Maven 3.4.0
You can find the JIRA Maven Roadmap here: https://issues.apache.org/jira/browse/MNG/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel Cheers, Paul On Tue, Jun 14, 2016 at 3:46 PM, Uwe Barthel wrote: > Hi, > > Is there a clear roadmap for version 3.4.0? > > I ask, because these PRs: https://github.com/apache/maven/pull/70 > (integration tests: > https://github.com/apache/maven-integration-testing/pull/14) for Item > https://issues.apache.org/jira/browse/MNG-3092. > > This item lives around NINE years and these PRs are open since October > 2015. > Michael O. and Jason have looked at the PR and, in my opinion, reviewed > for a merge. > This branch has no conflicts with the base branch. > > Please give a clear statement as to whether the solution is accepted or > not. > So I've the chance to close these PRs. > > Are there any other open PRs for 3.4.0, where I might be able to help with > a review? > > -- barthel > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Roadmap Maven 3.4.0
Hi, Is there a clear roadmap for version 3.4.0? I ask, because these PRs: https://github.com/apache/maven/pull/70 (integration tests: https://github.com/apache/maven-integration-testing/pull/14) for Item https://issues.apache.org/jira/browse/MNG-3092. This item lives around NINE years and these PRs are open since October 2015. Michael O. and Jason have looked at the PR and, in my opinion, reviewed for a merge. This branch has no conflicts with the base branch. Please give a clear statement as to whether the solution is accepted or not. So I've the chance to close these PRs. Are there any other open PRs for 3.4.0, where I might be able to help with a review? -- barthel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
