Re: git commit: Deprecate unused version of the project dependencies resovler in the core
when we deprecate somthing like this, we should add a hint on what to do
instead: we have a bunch of deprecated things without any idea on what to do
I don't know how we can fix the existing deprecations, but at least I'd like to
avoid adding more such dead-end deprecations
Regards,
Hervé
Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 963373726 - 9cc2caeb9
Deprecate unused version of the project dependencies resovler in the core
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb
Branch: refs/heads/master
Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f
Parents: 9633737
Author: Jason van Zyl ja...@tesla.io
Authored: Sat Jul 5 08:18:38 2014 -0400
Committer: Jason van Zyl ja...@tesla.io
Committed: Sat Jul 5 08:18:38 2014 -0400
--
.../java/org/apache/maven/DefaultProjectDependenciesResolver.java | 1 +
.../src/main/java/org/apache/maven/ProjectDependenciesResolver.java | 1 +
2 files changed, 2 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/maven-core/src/ma
in/java/org/apache/maven/DefaultProjectDependenciesResolver.java
-- diff
--git
a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java
b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java index d511d1d..3511d90 100644
---
a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java +++
b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java @@ -42,6 +42,7 @@ import
org.apache.maven.repository.RepositorySystem; import
org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+@Deprecated
@Component( role = ProjectDependenciesResolver.class )
public class DefaultProjectDependenciesResolver
implements ProjectDependenciesResolver
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/maven-core/src/ma
in/java/org/apache/maven/ProjectDependenciesResolver.java
-- diff
--git
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a index 7ae86fd..5a14b6f 100644
---
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a +++
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a @@ -28,6 +28,7 @@ import
org.apache.maven.artifact.resolver.ArtifactResolutionException; import
org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
+@Deprecated
public interface ProjectDependenciesResolver
{
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
+1, I often hit deprecated code without knowing what to use instead. A
hint would certainly help.
Robert
Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY
herve.bout...@free.fr:
when we deprecate somthing like this, we should add a hint on what to do
instead: we have a bunch of deprecated things without any idea on what
to do
I don't know how we can fix the existing deprecations, but at least I'd
like to
avoid adding more such dead-end deprecations
Regards,
Hervé
Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 963373726 - 9cc2caeb9
Deprecate unused version of the project dependencies resovler in the
core
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb
Branch: refs/heads/master
Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f
Parents: 9633737
Author: Jason van Zyl ja...@tesla.io
Authored: Sat Jul 5 08:18:38 2014 -0400
Committer: Jason van Zyl ja...@tesla.io
Committed: Sat Jul 5 08:18:38 2014 -0400
--
.../java/org/apache/maven/DefaultProjectDependenciesResolver.java |
1 +
.../src/main/java/org/apache/maven/ProjectDependenciesResolver.java |
1 +
2 files changed, 2 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/maven-core/src/ma
in/java/org/apache/maven/DefaultProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java
b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java index d511d1d..3511d90 100644
---
a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java +++
b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResol
ver.java @@ -42,6 +42,7 @@ import
org.apache.maven.repository.RepositorySystem; import
org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+@Deprecated
@Component( role = ProjectDependenciesResolver.class )
public class DefaultProjectDependenciesResolver
implements ProjectDependenciesResolver
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/maven-core/src/ma
in/java/org/apache/maven/ProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a index 7ae86fd..5a14b6f 100644
---
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a +++
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.jav
a @@ -28,6 +28,7 @@ import
org.apache.maven.artifact.resolver.ArtifactResolutionException; import
org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
+@Deprecated
public interface ProjectDependenciesResolver
{
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
The original Java deprecation guidelines were to
1) Include a since statement indicating at point the API was deprecated
2) include a statement pointing to the replacement API (or non-replacement
and reason for same).
On Sat, Jul 5, 2014 at 10:34 PM, Robert Scholte rfscho...@apache.org
wrote:
+1, I often hit deprecated code without knowing what to use instead. A
hint would certainly help.
Robert
Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY
herve.bout...@free.fr:
when we deprecate somthing like this, we should add a hint on what to do
instead: we have a bunch of deprecated things without any idea on what to
do
I don't know how we can fix the existing deprecations, but at least I'd
like to
avoid adding more such dead-end deprecations
Regards,
Hervé
Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 963373726 - 9cc2caeb9
Deprecate unused version of the project dependencies resovler in the core
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb
Branch: refs/heads/master
Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f
Parents: 9633737
Author: Jason van Zyl ja...@tesla.io
Authored: Sat Jul 5 08:18:38 2014 -0400
Committer: Jason van Zyl ja...@tesla.io
Committed: Sat Jul 5 08:18:38 2014 -0400
--
.../java/org/apache/maven/DefaultProjectDependenciesResolver.java |
1 +
.../src/main/java/org/apache/maven/ProjectDependenciesResolver.java |
1 +
2 files changed, 2 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/
maven-core/src/ma
in/java/org/apache/maven/DefaultProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java
b/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java index d511d1d..3511d90 100644
---
a/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java +++
b/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java @@ -42,6 +42,7 @@ import
org.apache.maven.repository.RepositorySystem; import
org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+@Deprecated
@Component( role = ProjectDependenciesResolver.class )
public class DefaultProjectDependenciesResolver
implements ProjectDependenciesResolver
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/
maven-core/src/ma
in/java/org/apache/maven/ProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a index 7ae86fd..5a14b6f 100644
---
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a +++
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a @@ -28,6 +28,7 @@ import
org.apache.maven.artifact.resolver.ArtifactResolutionException; import
org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
+@Deprecated
public interface ProjectDependenciesResolver
{
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
Generally when I use @Deprecate alone it means there is no replacement. But I
marked this change with that sentiment.
Right now I consider Maven to be and end user tool. The jumble of components we
have let leak to confuse most integrators I would not consider much of an API
or SPI. With 4.0.0 I'm pretty much going to shut most things down and be very
careful about what gets opened up again. I imagine 4.0.0 will be stable from a
functionality perspective but take a while to reach a final 4.0.0. I plan to do
the work in the 3.x line where I carefully collect everything that's deprecated
and document what's going to be removed. The new APIs will collect in the 3.x
line and I will use a tool to remove all the deprecated code to see the affect.
Effectively branching by abstraction which is a technique I prefer. I can also
see what APIs every plugin in Maven Central uses so that will give me some idea
about what to instruct plugin developers to do in order to update.
On Jul 5, 2014, at 8:44 AM, William Ferguson william.fergu...@xandar.com.au
wrote:
The original Java deprecation guidelines were to
1) Include a since statement indicating at point the API was deprecated
2) include a statement pointing to the replacement API (or non-replacement
and reason for same).
On Sat, Jul 5, 2014 at 10:34 PM, Robert Scholte rfscho...@apache.org
wrote:
+1, I often hit deprecated code without knowing what to use instead. A
hint would certainly help.
Robert
Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY
herve.bout...@free.fr:
when we deprecate somthing like this, we should add a hint on what to do
instead: we have a bunch of deprecated things without any idea on what to
do
I don't know how we can fix the existing deprecations, but at least I'd
like to
avoid adding more such dead-end deprecations
Regards,
Hervé
Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 963373726 - 9cc2caeb9
Deprecate unused version of the project dependencies resovler in the core
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb
Branch: refs/heads/master
Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f
Parents: 9633737
Author: Jason van Zyl ja...@tesla.io
Authored: Sat Jul 5 08:18:38 2014 -0400
Committer: Jason van Zyl ja...@tesla.io
Committed: Sat Jul 5 08:18:38 2014 -0400
--
.../java/org/apache/maven/DefaultProjectDependenciesResolver.java |
1 +
.../src/main/java/org/apache/maven/ProjectDependenciesResolver.java |
1 +
2 files changed, 2 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/
maven-core/src/ma
in/java/org/apache/maven/DefaultProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java
b/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java index d511d1d..3511d90 100644
---
a/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java +++
b/maven-core/src/main/java/org/apache/maven/
DefaultProjectDependenciesResol
ver.java @@ -42,6 +42,7 @@ import
org.apache.maven.repository.RepositorySystem; import
org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+@Deprecated
@Component( role = ProjectDependenciesResolver.class )
public class DefaultProjectDependenciesResolver
implements ProjectDependenciesResolver
http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/
maven-core/src/ma
in/java/org/apache/maven/ProjectDependenciesResolver.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a index 7ae86fd..5a14b6f 100644
---
a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a +++
b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.
jav
a @@ -28,6 +28,7 @@ import
org.apache.maven.artifact.resolver.ArtifactResolutionException; import
org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
+@Deprecated
public interface ProjectDependenciesResolver
{
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
Jason, for: 1) Include a since statement indicating at point the API was deprecated You didn't mention if you are against doing so or not. Do you find it of value for yourself and others? 2) include a statement pointing to the replacement API (or non-replacement and reason for same). Do you find it possible and useful to add a comment with the @Deprecated denoting just no replacement? e.g. With no direct replacement. Correct approach is . (not sure there is always a correct approach to mention if the context is too vague). I'm thinking since the hindsight is it never should have been exposed, leave suggestion(s) for follow up work as to where to go next, capturing the context change in mind at the point of deprecation. Or is it premature to do so with your in-progress work and will do so when complete? I like your plan Jason. I also like abstracting to eventually evolve/remove like that. PS I'm thankful you are back with a vengeance improving Maven core. On Sat, Jul 5, 2014 at 1:34 PM, Jason van Zyl ja...@takari.io wrote: Generally when I use @Deprecate alone it means there is no replacement. But I marked this change with that sentiment. Right now I consider Maven to be and end user tool. The jumble of components we have let leak to confuse most integrators I would not consider much of an API or SPI. With 4.0.0 I'm pretty much going to shut most things down and be very careful about what gets opened up again. I imagine 4.0.0 will be stable from a functionality perspective but take a while to reach a final 4.0.0. I plan to do the work in the 3.x line where I carefully collect everything that's deprecated and document what's going to be removed. The new APIs will collect in the 3.x line and I will use a tool to remove all the deprecated code to see the affect. Effectively branching by abstraction which is a technique I prefer. I can also see what APIs every plugin in Maven Central uses so that will give me some idea about what to instruct plugin developers to do in order to update. On Jul 5, 2014, at 8:44 AM, William Ferguson william.fergu...@xandar.com.au wrote: The original Java deprecation guidelines were to 1) Include a since statement indicating at point the API was deprecated 2) include a statement pointing to the replacement API (or non-replacement and reason for same). On Sat, Jul 5, 2014 at 10:34 PM, Robert Scholte rfscho...@apache.org wrote: +1, I often hit deprecated code without knowing what to use instead. A hint would certainly help. Robert Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY herve.bout...@free.fr: when we deprecate somthing like this, we should add a hint on what to do instead: we have a bunch of deprecated things without any idea on what to do I don't know how we can fix the existing deprecations, but at least I'd like to avoid adding more such dead-end deprecations Regards, Hervé Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit : Repository: maven Updated Branches: refs/heads/master 963373726 - 9cc2caeb9 Deprecate unused version of the project dependencies resovler in the core Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb Branch: refs/heads/master Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f Parents: 9633737 Author: Jason van Zyl ja...@tesla.io Authored: Sat Jul 5 08:18:38 2014 -0400 Committer: Jason van Zyl ja...@tesla.io Committed: Sat Jul 5 08:18:38 2014 -0400 -- .../java/org/apache/maven/DefaultProjectDependenciesResolver.java | 1 + .../src/main/java/org/apache/maven/ProjectDependenciesResolver.java | 1 + 2 files changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/ maven-core/src/ma in/java/org/apache/maven/DefaultProjectDependenciesResolver.java -- diff --git a/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java b/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java index d511d1d..3511d90 100644 --- a/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java +++ b/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java @@ -42,6 +42,7 @@ import org.apache.maven.repository.RepositorySystem; import org.codehaus.plexus.component.annotations.Component; import org.codehaus.plexus.component.annotations.Requirement; +@Deprecated @Component( role = ProjectDependenciesResolver.class
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
On Jul 5, 2014, at 3:16 PM, Jeff Jensen jeffjen...@upstairstechnology.com wrote: Jason, for: 1) Include a since statement indicating at point the API was deprecated You didn't mention if you are against doing so or not. Do you find it of value for yourself and others? Certainly can't hurt, so I added a comment as such for the last deprecation. 2) include a statement pointing to the replacement API (or non-replacement and reason for same). Do you find it possible and useful to add a comment with the @Deprecated denoting just no replacement? e.g. With no direct replacement. Correct approach is . (not sure there is always a correct approach to mention if the context is too vague). I'm thinking since the hindsight is it never should have been exposed, leave suggestion(s) for follow up work as to where to go next, capturing the context change in mind at the point of deprecation. Or is it premature to do so with your in-progress work and will do so when complete? I just noted in the last change it's something that has no direct replacement and shouldn't have really been part of a publicly supported API. I like your plan Jason. I also like abstracting to eventually evolve/remove like that. PS I'm thankful you are back with a vengeance improving Maven core. On Sat, Jul 5, 2014 at 1:34 PM, Jason van Zyl ja...@takari.io wrote: Generally when I use @Deprecate alone it means there is no replacement. But I marked this change with that sentiment. Right now I consider Maven to be and end user tool. The jumble of components we have let leak to confuse most integrators I would not consider much of an API or SPI. With 4.0.0 I'm pretty much going to shut most things down and be very careful about what gets opened up again. I imagine 4.0.0 will be stable from a functionality perspective but take a while to reach a final 4.0.0. I plan to do the work in the 3.x line where I carefully collect everything that's deprecated and document what's going to be removed. The new APIs will collect in the 3.x line and I will use a tool to remove all the deprecated code to see the affect. Effectively branching by abstraction which is a technique I prefer. I can also see what APIs every plugin in Maven Central uses so that will give me some idea about what to instruct plugin developers to do in order to update. On Jul 5, 2014, at 8:44 AM, William Ferguson william.fergu...@xandar.com.au wrote: The original Java deprecation guidelines were to 1) Include a since statement indicating at point the API was deprecated 2) include a statement pointing to the replacement API (or non-replacement and reason for same). On Sat, Jul 5, 2014 at 10:34 PM, Robert Scholte rfscho...@apache.org wrote: +1, I often hit deprecated code without knowing what to use instead. A hint would certainly help. Robert Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY herve.bout...@free.fr: when we deprecate somthing like this, we should add a hint on what to do instead: we have a bunch of deprecated things without any idea on what to do I don't know how we can fix the existing deprecations, but at least I'd like to avoid adding more such dead-end deprecations Regards, Hervé Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit : Repository: maven Updated Branches: refs/heads/master 963373726 - 9cc2caeb9 Deprecate unused version of the project dependencies resovler in the core Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb Branch: refs/heads/master Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f Parents: 9633737 Author: Jason van Zyl ja...@tesla.io Authored: Sat Jul 5 08:18:38 2014 -0400 Committer: Jason van Zyl ja...@tesla.io Committed: Sat Jul 5 08:18:38 2014 -0400 -- .../java/org/apache/maven/DefaultProjectDependenciesResolver.java | 1 + .../src/main/java/org/apache/maven/ProjectDependenciesResolver.java | 1 + 2 files changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/ maven-core/src/ma in/java/org/apache/maven/DefaultProjectDependenciesResolver.java -- diff --git a/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java b/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java index d511d1d..3511d90 100644 --- a/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java +++ b/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol
Re: git commit: Deprecate unused version of the project dependencies resovler in the core
thank you Jason Regards, Hervé Le samedi 5 juillet 2014 15:59:31 Jason van Zyl a écrit : On Jul 5, 2014, at 3:16 PM, Jeff Jensen jeffjen...@upstairstechnology.com wrote: Jason, for: 1) Include a since statement indicating at point the API was deprecated You didn't mention if you are against doing so or not. Do you find it of value for yourself and others? Certainly can't hurt, so I added a comment as such for the last deprecation. 2) include a statement pointing to the replacement API (or non-replacement and reason for same). Do you find it possible and useful to add a comment with the @Deprecated denoting just no replacement? e.g. With no direct replacement. Correct approach is . (not sure there is always a correct approach to mention if the context is too vague). I'm thinking since the hindsight is it never should have been exposed, leave suggestion(s) for follow up work as to where to go next, capturing the context change in mind at the point of deprecation. Or is it premature to do so with your in-progress work and will do so when complete? I just noted in the last change it's something that has no direct replacement and shouldn't have really been part of a publicly supported API. I like your plan Jason. I also like abstracting to eventually evolve/remove like that. PS I'm thankful you are back with a vengeance improving Maven core. On Sat, Jul 5, 2014 at 1:34 PM, Jason van Zyl ja...@takari.io wrote: Generally when I use @Deprecate alone it means there is no replacement. But I marked this change with that sentiment. Right now I consider Maven to be and end user tool. The jumble of components we have let leak to confuse most integrators I would not consider much of an API or SPI. With 4.0.0 I'm pretty much going to shut most things down and be very careful about what gets opened up again. I imagine 4.0.0 will be stable from a functionality perspective but take a while to reach a final 4.0.0. I plan to do the work in the 3.x line where I carefully collect everything that's deprecated and document what's going to be removed. The new APIs will collect in the 3.x line and I will use a tool to remove all the deprecated code to see the affect. Effectively branching by abstraction which is a technique I prefer. I can also see what APIs every plugin in Maven Central uses so that will give me some idea about what to instruct plugin developers to do in order to update. On Jul 5, 2014, at 8:44 AM, William Ferguson william.fergu...@xandar.com.au wrote: The original Java deprecation guidelines were to 1) Include a since statement indicating at point the API was deprecated 2) include a statement pointing to the replacement API (or non-replacement and reason for same). On Sat, Jul 5, 2014 at 10:34 PM, Robert Scholte rfscho...@apache.org wrote: +1, I often hit deprecated code without knowing what to use instead. A hint would certainly help. Robert Op Sat, 05 Jul 2014 14:32:14 +0200 schreef Hervé BOUTEMY herve.bout...@free.fr: when we deprecate somthing like this, we should add a hint on what to do instead: we have a bunch of deprecated things without any idea on what to do I don't know how we can fix the existing deprecations, but at least I'd like to avoid adding more such dead-end deprecations Regards, Hervé Le samedi 5 juillet 2014 12:19:01 jvan...@apache.org a écrit : Repository: maven Updated Branches: refs/heads/master 963373726 - 9cc2caeb9 Deprecate unused version of the project dependencies resovler in the core Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/9cc2caeb Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/9cc2caeb Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/9cc2caeb Branch: refs/heads/master Commit: 9cc2caeb9f54e44587e7642bb43592de7e177f4f Parents: 9633737 Author: Jason van Zyl ja...@tesla.io Authored: Sat Jul 5 08:18:38 2014 -0400 Committer: Jason van Zyl ja...@tesla.io Committed: Sat Jul 5 08:18:38 2014 -0400 - - .../java/org/apache/maven/DefaultProjectDependenciesResolver.java | 1 + .../src/main/java/org/apache/maven/ProjectDependenciesResolver.java | 1 + 2 files changed, 2 insertions(+) - - http://git-wip-us.apache.org/repos/asf/maven/blob/9cc2caeb/ maven-core/src/ma in/java/org/apache/maven/DefaultProjectDependenciesResolver.java - - diff --git a/maven-core/src/main/java/org/apache/maven/ DefaultProjectDependenciesResol ver.java b/maven-core/src/main/java/org/apache/maven/
