subject:"svn commit\: r1380105 \- in \/maven\/maven\-3\/trunk\: .\/ apache\-maven\/ maven\-core\/src\/main\/java\/org\/apache\/maven\/classrealm\/ maven\-embedder\/ maven\-embedder\/src\/main\/java\/org\/apache\/maven\/cli\/"

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-16 Thread Anders Hammar

No one is objecting on 3.1 so I'll bump the version on trunk.

/Anders

On Sat, Sep 15, 2012 at 11:30 AM, Olivier Lamy ol...@apache.org wrote:
 Ping

 --
 Olivier
 Le 10 sept. 2012 09:02, Olivier Lamy ol...@apache.org a écrit :


 Le 9 sept. 2012 15:44, Jason van Zyl ja...@tesla.io a écrit :
 
  I noted in the issue where the tool is and there's a standard Maven
 plugin page there. Probably as well documented as how to do it with Plexus
 :-)
 
 For sure and I agree on that :-) (as responsible of that fact too :-) )
 But as we always have  to learn from the past errors. It's probably time
 to take care of the cliché: maven doc sucks !

  I have a series of posts I'm writing which can be the basis of
 documentation.
 Great and will be perfect to have that too in maven.apache.org website
 (the page 
 http://maven.apache.org/developers/mojo-api-specification.htmllooks to be a 
 good candidate for that)
 
  Code here[1], and the documentation is here[2].
 
  [1]: https://github.com/sonatype/sisu-maven-plugin
  [2]: http://sonatype.github.com/sisu-maven-plugin/
 
  On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:
 
   2012/9/3  jvan...@apache.org:
   Author: jvanzyl
   Date: Mon Sep  3 01:07:31 2012
   New Revision: 1380105
  
   URL: http://svn.apache.org/viewvc?rev=1380105view=rev
   Log:
   o Enabled support and discovery of JSR-330 components
  
   o Added Slf4j logger factory to support generic JSR-330 logging
  
   o Exported Guice package for components that access Guice (or better
 it's injector) directly
  
   Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
  
   o use specific exports
  
   o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
  
   closes #3
  
 
  Thanks,
 
  Jason
 
  --
  Jason van Zyl
  Founder  CTO, Sonatype
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  -
 
  We know what we are, but know not what we may be.
 
-- Shakespeare
 
 
 
 
 

 --
 Olivier


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-16 Thread Kristian Rosenvold

We're still awaiting some test coverage on the new features. If I'm
doing the next release (which I've announced) I'll bump the version
number when the tests are in place. The next release is still a few
weeks off, so there should be plenty of time for that.

Kristian



2012/9/16 Anders Hammar and...@hammar.net:
 No one is objecting on 3.1 so I'll bump the version on trunk.

 /Anders

 On Sat, Sep 15, 2012 at 11:30 AM, Olivier Lamy ol...@apache.org wrote:
 Ping

 --
 Olivier
 Le 10 sept. 2012 09:02, Olivier Lamy ol...@apache.org a écrit :


 Le 9 sept. 2012 15:44, Jason van Zyl ja...@tesla.io a écrit :
 
  I noted in the issue where the tool is and there's a standard Maven
 plugin page there. Probably as well documented as how to do it with Plexus
 :-)
 
 For sure and I agree on that :-) (as responsible of that fact too :-) )
 But as we always have  to learn from the past errors. It's probably time
 to take care of the cliché: maven doc sucks !

  I have a series of posts I'm writing which can be the basis of
 documentation.
 Great and will be perfect to have that too in maven.apache.org website
 (the page 
 http://maven.apache.org/developers/mojo-api-specification.htmllooks to be a 
 good candidate for that)
 
  Code here[1], and the documentation is here[2].
 
  [1]: https://github.com/sonatype/sisu-maven-plugin
  [2]: http://sonatype.github.com/sisu-maven-plugin/
 
  On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:
 
   2012/9/3  jvan...@apache.org:
   Author: jvanzyl
   Date: Mon Sep  3 01:07:31 2012
   New Revision: 1380105
  
   URL: http://svn.apache.org/viewvc?rev=1380105view=rev
   Log:
   o Enabled support and discovery of JSR-330 components
  
   o Added Slf4j logger factory to support generic JSR-330 logging
  
   o Exported Guice package for components that access Guice (or better
 it's injector) directly
  
   Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
  
   o use specific exports
  
   o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
  
   closes #3
  
 
  Thanks,
 
  Jason
 
  --
  Jason van Zyl
  Founder  CTO, Sonatype
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  -
 
  We know what we are, but know not what we may be.
 
-- Shakespeare
 
 
 
 
 

 --
 Olivier


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-16 Thread Anders Hammar

Ok. I was just thinking as we've decided to go with 3.1 the version in
trunk should indicate that. But I'll leave it as 3.0.5-SNAPSHOT then.

/Anders

On Sun, Sep 16, 2012 at 8:23 PM, Kristian Rosenvold
kristian.rosenv...@gmail.com wrote:
 We're still awaiting some test coverage on the new features. If I'm
 doing the next release (which I've announced) I'll bump the version
 number when the tests are in place. The next release is still a few
 weeks off, so there should be plenty of time for that.

 Kristian



 2012/9/16 Anders Hammar and...@hammar.net:
 No one is objecting on 3.1 so I'll bump the version on trunk.

 /Anders

 On Sat, Sep 15, 2012 at 11:30 AM, Olivier Lamy ol...@apache.org wrote:
 Ping

 --
 Olivier
 Le 10 sept. 2012 09:02, Olivier Lamy ol...@apache.org a écrit :


 Le 9 sept. 2012 15:44, Jason van Zyl ja...@tesla.io a écrit :
 
  I noted in the issue where the tool is and there's a standard Maven
 plugin page there. Probably as well documented as how to do it with Plexus
 :-)
 
 For sure and I agree on that :-) (as responsible of that fact too :-) )
 But as we always have  to learn from the past errors. It's probably time
 to take care of the cliché: maven doc sucks !

  I have a series of posts I'm writing which can be the basis of
 documentation.
 Great and will be perfect to have that too in maven.apache.org website
 (the page 
 http://maven.apache.org/developers/mojo-api-specification.htmllooks to be 
 a good candidate for that)
 
  Code here[1], and the documentation is here[2].
 
  [1]: https://github.com/sonatype/sisu-maven-plugin
  [2]: http://sonatype.github.com/sisu-maven-plugin/
 
  On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:
 
   2012/9/3  jvan...@apache.org:
   Author: jvanzyl
   Date: Mon Sep  3 01:07:31 2012
   New Revision: 1380105
  
   URL: http://svn.apache.org/viewvc?rev=1380105view=rev
   Log:
   o Enabled support and discovery of JSR-330 components
  
   o Added Slf4j logger factory to support generic JSR-330 logging
  
   o Exported Guice package for components that access Guice (or better
 it's injector) directly
  
   Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
  
   o use specific exports
  
   o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
  
   closes #3
  
 
  Thanks,
 
  Jason
 
  --
  Jason van Zyl
  Founder  CTO, Sonatype
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  -
 
  We know what we are, but know not what we may be.
 
-- Shakespeare
 
 
 
 
 

 --
 Olivier


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-15 Thread Olivier Lamy

Ping

--
Olivier
Le 10 sept. 2012 09:02, Olivier Lamy ol...@apache.org a écrit :


 Le 9 sept. 2012 15:44, Jason van Zyl ja...@tesla.io a écrit :
 
  I noted in the issue where the tool is and there's a standard Maven
 plugin page there. Probably as well documented as how to do it with Plexus
 :-)
 
 For sure and I agree on that :-) (as responsible of that fact too :-) )
 But as we always have  to learn from the past errors. It's probably time
 to take care of the cliché: maven doc sucks !

  I have a series of posts I'm writing which can be the basis of
 documentation.
 Great and will be perfect to have that too in maven.apache.org website
 (the page http://maven.apache.org/developers/mojo-api-specification.htmllooks 
 to be a good candidate for that)
 
  Code here[1], and the documentation is here[2].
 
  [1]: https://github.com/sonatype/sisu-maven-plugin
  [2]: http://sonatype.github.com/sisu-maven-plugin/
 
  On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:
 
   2012/9/3  jvan...@apache.org:
   Author: jvanzyl
   Date: Mon Sep  3 01:07:31 2012
   New Revision: 1380105
  
   URL: http://svn.apache.org/viewvc?rev=1380105view=rev
   Log:
   o Enabled support and discovery of JSR-330 components
  
   o Added Slf4j logger factory to support generic JSR-330 logging
  
   o Exported Guice package for components that access Guice (or better
 it's injector) directly
  
   Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
  
   o use specific exports
  
   o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
  
   closes #3
  
 
  Thanks,
 
  Jason
 
  --
  Jason van Zyl
  Founder  CTO, Sonatype
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  -
 
  We know what we are, but know not what we may be.
 
-- Shakespeare
 
 
 
 
 

 --
 Olivier

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-10 Thread Olivier Lamy

Le 9 sept. 2012 15:44, Jason van Zyl ja...@tesla.io a écrit :

 I noted in the issue where the tool is and there's a standard Maven
plugin page there. Probably as well documented as how to do it with Plexus
:-)

For sure and I agree on that :-) (as responsible of that fact too :-) )
But as we always have  to learn from the past errors. It's probably time to
take care of the cliché: maven doc sucks !

 I have a series of posts I'm writing which can be the basis of
documentation.
Great and will be perfect to have that too in maven.apache.org website (the
page http://maven.apache.org/developers/mojo-api-specification.html looks
to be a good candidate for that)

 Code here[1], and the documentation is here[2].

 [1]: https://github.com/sonatype/sisu-maven-plugin
 [2]: http://sonatype.github.com/sisu-maven-plugin/

 On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:

  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better
it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
we'll do a bit of testing
 
  closes #3
 

 Thanks,

 Jason

 --
 Jason van Zyl
 Founder  CTO, Sonatype
 Founder,  Apache Maven
 http://twitter.com/jvanzyl
 -

 We know what we are, but know not what we may be.

   -- Shakespeare






--
Olivier

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-10 Thread Olivier Lamy

Perso due to this change I'm more for a 3.1 (it's just a matter of
jiras bulk change :-) )

2012/9/9 Robert Scholte rfscho...@apache.org:
 It looks to me the changes fit more a 3.0.5

 I always had in mind, that with the 3.1 we would make the pom-parser more
 strict meaning:
 - don't warn but fail for plugins without versions
 - don't warn but fail for duplicate dependency entries
 (there are probably more...)

 Robert


 Op Sun, 09 Sep 2012 12:31:06 +0200 schreef Anders Hammar
 and...@hammar.net:


 Anyone -1 of bumping to v3.1 for core?

 /Anders

 On Sat, Sep 8, 2012 at 9:39 AM, Stephen Connolly
 stephen.alan.conno...@gmail.com wrote:

 +1 on bump to 3.1

 On Friday, 7 September 2012, Anders Hammar wrote:

 I know. But there wasn't much visible change in v3.0 either. And I'm
 thinking that it would be easier to communicate a dependency on Maven
 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

 Version numbers are cheap. Why not bump and get some attention? :-)

 /Anders

 On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
  There are no visible user changes, so I don't think so. There aren't
 even any changes to integrators unless they want to use take advantage
 of
 the changes.
 
  On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
 
  Maybe this even should bump the version to v3.1?
 
  /Anders
 
  On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org
  wrote:
  Maybe I miss something but we don't have any associated jira entry
  for
  reference in release notes neither core it test.
  Do you have a bit of time for that ?
 
  Thanks
  --
  Olivier
  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or
  better
 it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways
  to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
 
  closes #3
 
  Added:
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:

 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 

 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31
  2012
  @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
/dependencies
 
build
 
  Modified:

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:

 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org




-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-10 Thread Dennis Lundberg

+1 for 3.1

On 2012-09-07 22:19, Anders Hammar wrote:
 I know. But there wasn't much visible change in v3.0 either. And I'm
 thinking that it would be easier to communicate a dependency on Maven
 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.
 
 Version numbers are cheap. Why not bump and get some attention? :-)
 
 /Anders
 
 On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
 There are no visible user changes, so I don't think so. There aren't even 
 any changes to integrators unless they want to use take advantage of the 
 changes.

 On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:

 Maybe this even should bump the version to v3.1?

 /Anders

 On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?

 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to 
 avoid this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll 
 do a bit of testing

 closes #3

 Added:

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies

   build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
 imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
 imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
 imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm 
 not sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some 
 testing needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a 
 standard JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
 }

 /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL:

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-10 Thread Stephen Connolly

+1 for 3.1

On 10 September 2012 21:19, Dennis Lundberg denn...@apache.org wrote:

 +1 for 3.1

 On 2012-09-07 22:19, Anders Hammar wrote:
  I know. But there wasn't much visible change in v3.0 either. And I'm
  thinking that it would be easier to communicate a dependency on Maven
  3.1+ than 3.0.5+ if some component utilizes the JSR330 support.
 
  Version numbers are cheap. Why not bump and get some attention? :-)
 
  /Anders
 
  On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
  There are no visible user changes, so I don't think so. There aren't
 even any changes to integrators unless they want to use take advantage of
 the changes.
 
  On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
 
  Maybe this even should bump the version to v3.1?
 
  /Anders
 
  On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
  Maybe I miss something but we don't have any associated jira entry for
  reference in release notes neither core it test.
  Do you have a bit of time for that ?
 
  Thanks
  --
  Olivier
  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better
 it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
 
  closes #3
 
  Added:
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
  
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
  @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
/dependencies
 
build
 
  Modified:
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  ---
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 (original)
  +++
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 Mon Sep  3 01:07:31 2012
  @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
  imports.put(
 org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm );
  imports.put(
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
  imports.put(
 org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm );
  +
  +// javax.inject, sisu-inject (JSR-330)
  +imports.put( javax.inject.*, coreRealm );
  +imports.put( javax.enterprise.inject.*, coreRealm );
  +imports.put( org.sonatype.inject.*, coreRealm );
  +imports.put( org.slf4j.*, coreRealm );
  +
  +// com.google
  +//
  +// We may potentially want to export these, but right now
 I'm not sure that anything Guice specific needs
  +// to be made available to plugin authors. If we find
 people are getting fancy and want to take advantage
  +// of Guice specifics we can expose that later. Really some
 testing needs to be done to see full hiding
  +// of Guice has any impact on what we may categorize as a
 standard JSR-330 based Tesla/Maven plugin.
  +//
  +// imports.put( com.google.inject.*, coreRealm );
  +// imports.put( com.google.inject.binder.*, coreRealm );
  +// imports.put( com.google.inject.matcher.*, coreRealm );
  +// imports.put( com.google.inject.name.*, coreRealm );
  +// imports.put( com.google.inject.spi.*, coreRealm );
  +// imports.put(

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Olivier Lamy

Cool.

I think core-it is mandatory too for such new feature !

2012/9/9 Jason van Zyl ja...@tesla.io:
 Here they are:

 https://jira.codehaus.org/browse/MNG-5343
 https://jira.codehaus.org/browse/MNG-5344

 On Sep 7, 2012, at 11:37 AM, Olivier Lamy wrote:

 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?

 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll 
 do a bit of testing

 closes #3

 Added:

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies

   build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
 imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
 imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
 imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some 
 testing needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
 }

 /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
   groupIdorg.sonatype.plexus/groupId
   artifactIdplexus-cipher/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-api/artifactId
 +

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Anders Hammar

Anyone -1 of bumping to v3.1 for core?

/Anders

On Sat, Sep 8, 2012 at 9:39 AM, Stephen Connolly
stephen.alan.conno...@gmail.com wrote:
 +1 on bump to 3.1

 On Friday, 7 September 2012, Anders Hammar wrote:

 I know. But there wasn't much visible change in v3.0 either. And I'm
 thinking that it would be easier to communicate a dependency on Maven
 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

 Version numbers are cheap. Why not bump and get some attention? :-)

 /Anders

 On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
  There are no visible user changes, so I don't think so. There aren't
 even any changes to integrators unless they want to use take advantage of
 the changes.
 
  On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
 
  Maybe this even should bump the version to v3.1?
 
  /Anders
 
  On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
  Maybe I miss something but we don't have any associated jira entry for
  reference in release notes neither core it test.
  Do you have a bit of time for that ?
 
  Thanks
  --
  Olivier
  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better
 it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
 
  closes #3
 
  Added:
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
  
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
  @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
/dependencies
 
build
 
  Modified:
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Robert Scholte


It looks to me the changes fit more a 3.0.5

I always had in mind, that with the 3.1 we would make the pom-parser more  
strict meaning:

- don't warn but fail for plugins without versions
- don't warn but fail for duplicate dependency entries
(there are probably more...)

Robert


Op Sun, 09 Sep 2012 12:31:06 +0200 schreef Anders Hammar  
and...@hammar.net:



Anyone -1 of bumping to v3.1 for core?

/Anders

On Sat, Sep 8, 2012 at 9:39 AM, Stephen Connolly
stephen.alan.conno...@gmail.com wrote:

+1 on bump to 3.1

On Friday, 7 September 2012, Anders Hammar wrote:


I know. But there wasn't much visible change in v3.0 either. And I'm
thinking that it would be easier to communicate a dependency on Maven
3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

Version numbers are cheap. Why not bump and get some attention? :-)

/Anders

On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
 There are no visible user changes, so I don't think so. There aren't
even any changes to integrators unless they want to use take advantage  
of

the changes.

 On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:

 Maybe this even should bump the version to v3.1?

 /Anders

 On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org  
wrote:
 Maybe I miss something but we don't have any associated jira entry  
for

 reference in release notes neither core it test.
 Do you have a bit of time for that ?

 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or  
better

it's injector) directly

 Widen export of Guice packages (not ideal, need to look into ways  
to

avoid this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms  
and

we'll do a bit of testing

 closes #3

 Added:

 
maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 
maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 
maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 
maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL:
http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff

==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31  
2012

 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies

   build

 Modified:
maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL:
http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Olivier Lamy

2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing

 closes #3

 Added:
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
/dependencies

build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
  imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
  imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
  imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some testing 
 needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
  }

  /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
groupIdorg.sonatype.plexus/groupId
artifactIdplexus-cipher/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-api/artifactId
 +/dependency
  !-- CLI --
  dependency
groupIdcommons-cli/groupId

 Modified: 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 ---

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Jason van Zyl

I noted in the issue where the tool is and there's a standard Maven plugin page 
there. Probably as well documented as how to do it with Plexus :-)

I have a series of posts I'm writing which can be the basis of documentation.

Code here[1], and the documentation is here[2].

[1]: https://github.com/sonatype/sisu-maven-plugin
[2]: http://sonatype.github.com/sisu-maven-plugin/

On Sep 9, 2012, at 8:35 AM, Olivier Lamy wrote:

 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105
 
 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components
 
 o Added Slf4j logger factory to support generic JSR-330 logging
 
 o Exported Guice package for components that access Guice (or better it's 
 injector) directly
 
 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)
 
 o use specific exports
 
 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing
 
 closes #3
 

Thanks,

Jason

--
Jason van Zyl
Founder  CTO, Sonatype
Founder,  Apache Maven
http://twitter.com/jvanzyl
-

We know what we are, but know not what we may be.

  -- Shakespeare

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-09 Thread Anders Hammar

Minds are, like rules, meant to be broken. :-) That could go into 3.2
just as well.

But, being the newest boy in town I won't push this too much.

/Anders

On Sun, Sep 9, 2012 at 1:12 PM, Robert Scholte rfscho...@apache.org wrote:
 It looks to me the changes fit more a 3.0.5

 I always had in mind, that with the 3.1 we would make the pom-parser more
 strict meaning:
 - don't warn but fail for plugins without versions
 - don't warn but fail for duplicate dependency entries
 (there are probably more...)

 Robert


 Op Sun, 09 Sep 2012 12:31:06 +0200 schreef Anders Hammar
 and...@hammar.net:

 Anyone -1 of bumping to v3.1 for core?

 /Anders

 On Sat, Sep 8, 2012 at 9:39 AM, Stephen Connolly
 stephen.alan.conno...@gmail.com wrote:

 +1 on bump to 3.1

 On Friday, 7 September 2012, Anders Hammar wrote:

 I know. But there wasn't much visible change in v3.0 either. And I'm
 thinking that it would be easier to communicate a dependency on Maven
 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

 Version numbers are cheap. Why not bump and get some attention? :-)

 /Anders

 On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
  There are no visible user changes, so I don't think so. There aren't
 even any changes to integrators unless they want to use take advantage
 of
 the changes.
 
  On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
 
  Maybe this even should bump the version to v3.1?
 
  /Anders
 
  On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org
  wrote:
  Maybe I miss something but we don't have any associated jira entry
  for
  reference in release notes neither core it test.
  Do you have a bit of time for that ?
 
  Thanks
  --
  Olivier
  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or
  better
 it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways
  to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
 
  closes #3
 
  Added:
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:

 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 

 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31
  2012
  @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
/dependencies
 
build
 
  Modified:

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:

 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-08 Thread Stephen Connolly

+1 on bump to 3.1

On Friday, 7 September 2012, Anders Hammar wrote:

 I know. But there wasn't much visible change in v3.0 either. And I'm
 thinking that it would be easier to communicate a dependency on Maven
 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

 Version numbers are cheap. Why not bump and get some attention? :-)

 /Anders

 On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
  There are no visible user changes, so I don't think so. There aren't
 even any changes to integrators unless they want to use take advantage of
 the changes.
 
  On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
 
  Maybe this even should bump the version to v3.1?
 
  /Anders
 
  On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
  Maybe I miss something but we don't have any associated jira entry for
  reference in release notes neither core it test.
  Do you have a bit of time for that ?
 
  Thanks
  --
  Olivier
  2012/9/3  jvan...@apache.org:
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better
 it's injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do a bit of testing
 
  closes #3
 
  Added:
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
  
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
  
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
  @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
/dependencies
 
build
 
  Modified:
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-08 Thread Jason van Zyl

Here they are:

https://jira.codehaus.org/browse/MNG-5343
https://jira.codehaus.org/browse/MNG-5344

On Sep 7, 2012, at 11:37 AM, Olivier Lamy wrote:

 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?
 
 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105
 
 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components
 
 o Added Slf4j logger factory to support generic JSR-330 logging
 
 o Exported Guice package for components that access Guice (or better it's 
 injector) directly
 
 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)
 
 o use specific exports
 
 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing
 
 closes #3
 
 Added:

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml
 
 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies
 
   build
 
 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
 imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
 imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
 imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some testing 
 needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
 }
 
 /**
 
 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
   groupIdorg.sonatype.plexus/groupId
   artifactIdplexus-cipher/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-api/artifactId
 +/dependency
 !-- CLI --
 dependency
   groupIdcommons-cli/groupId
 
 Modified:

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-07 Thread Olivier Lamy

Maybe I miss something but we don't have any associated jira entry for
reference in release notes neither core it test.
Do you have a bit of time for that ?

Thanks
--
Olivier
2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing

 closes #3

 Added:
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
/dependencies

build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
  imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
  imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
  imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some testing 
 needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
  }

  /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
groupIdorg.sonatype.plexus/groupId
artifactIdplexus-cipher/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-api/artifactId
 +/dependency
  !-- CLI --
  dependency
groupIdcommons-cli/groupId

 Modified: 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 URL:

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-07 Thread Anders Hammar

Maybe this even should bump the version to v3.1?

/Anders

On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?

 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing

 closes #3

 Added:
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
 maven/maven-3/trunk/apache-maven/pom.xml
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
/dependencies

build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
  imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
  imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
  imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some testing 
 needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
  }

  /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
groupIdorg.sonatype.plexus/groupId
artifactIdplexus-cipher/artifactId
  /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-api/artifactId
 +/dependency
  !-- CLI --
  dependency
groupIdcommons-cli/groupId

 Modified:

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-07 Thread Jason van Zyl

There are no visible user changes, so I don't think so. There aren't even any 
changes to integrators unless they want to use take advantage of the changes.

On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:

 Maybe this even should bump the version to v3.1?
 
 /Anders
 
 On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?
 
 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105
 
 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components
 
 o Added Slf4j logger factory to support generic JSR-330 logging
 
 o Exported Guice package for components that access Guice (or better it's 
 injector) directly
 
 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)
 
 o use specific exports
 
 o for now we will attempt to hide all of Guice in plugin realms and we'll 
 do a bit of testing
 
 closes #3
 
 Added:

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml
 
 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies
 
   build
 
 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
 imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
 imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
 imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some 
 testing needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
 }
 
 /**
 
 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/maven-embedder/pom.xml (original)
 +++ maven/maven-3/trunk/maven-embedder/pom.xml Mon Sep  3 01:07:31 2012
 @@ -70,6 +70,10 @@
   groupIdorg.sonatype.plexus/groupId
   artifactIdplexus-cipher/artifactId
 /dependency
 +

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-07 Thread Anders Hammar

I know. But there wasn't much visible change in v3.0 either. And I'm
thinking that it would be easier to communicate a dependency on Maven
3.1+ than 3.0.5+ if some component utilizes the JSR330 support.

Version numbers are cheap. Why not bump and get some attention? :-)

/Anders

On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl ja...@tesla.io wrote:
 There are no visible user changes, so I don't think so. There aren't even any 
 changes to integrators unless they want to use take advantage of the changes.

 On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:

 Maybe this even should bump the version to v3.1?

 /Anders

 On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy ol...@apache.org wrote:
 Maybe I miss something but we don't have any associated jira entry for
 reference in release notes neither core it test.
 Do you have a bit of time for that ?

 Thanks
 --
 Olivier
 2012/9/3  jvan...@apache.org:
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's 
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll 
 do a bit of testing

 closes #3

 Added:

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
maven/maven-3/trunk/apache-maven/pom.xml

 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
   groupIdorg.sonatype.aether/groupId
   artifactIdaether-connector-wagon/artifactId
 /dependency
 +dependency
 +  groupIdorg.slf4j/groupId
 +  artifactIdslf4j-nop/artifactId
 +/dependency
   /dependencies

   build

 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
 imports.put( org.codehaus.plexus.util.xml.pull.XmlPullParser, 
 coreRealm );
 imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm );
 imports.put( org.codehaus.plexus.util.xml.pull.XmlSerializer, 
 coreRealm );
 +
 +// javax.inject, sisu-inject (JSR-330)
 +imports.put( javax.inject.*, coreRealm );
 +imports.put( javax.enterprise.inject.*, coreRealm );
 +imports.put( org.sonatype.inject.*, coreRealm );
 +imports.put( org.slf4j.*, coreRealm );
 +
 +// com.google
 +//
 +// We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +// to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +// of Guice specifics we can expose that later. Really some 
 testing needs to be done to see full hiding
 +// of Guice has any impact on what we may categorize as a 
 standard JSR-330 based Tesla/Maven plugin.
 +//
 +// imports.put( com.google.inject.*, coreRealm );
 +// imports.put( com.google.inject.binder.*, coreRealm );
 +// imports.put( com.google.inject.matcher.*, coreRealm );
 +// imports.put( com.google.inject.name.*, coreRealm );
 +// imports.put( com.google.inject.spi.*, coreRealm );
 +// imports.put( com.google.inject.util.*, coreRealm );
 }

 /**

 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL:

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Mark Struberg

whats the reason for the slf4j bridge? 

This is kown to trash old plugins which use log4j because it clashes with it's 
namespace and only partly implements the log4j classes.

I personally ind slf4j nice, but for older projects which use commons-logging 
or log4j already (and where you cant fiddle around with their sources) this 
broke way too many things for me.
Why is this needed at all? Has nothing to do with JSR-330.

LieGrue,
strub




- Original Message -
 From: jvan...@apache.org jvan...@apache.org
 To: comm...@maven.apache.org
 Cc: 
 Sent: Monday, September 3, 2012 3:07 AM
 Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
 maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
 maven-embedder/src/main/java/org/apache/maven/cli/
 
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105
 
 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components
 
 o Added Slf4j logger factory to support generic JSR-330 logging
 
 o Exported Guice package for components that access Guice (or better it's 
 injector) directly
 
 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)
 
 o use specific exports
 
 o for now we will attempt to hide all of Guice in plugin realms and we'll do 
 a bit of testing
 
 closes #3
 
 Added:
     
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
     
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
     maven/maven-3/trunk/apache-maven/pom.xml
     
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
     maven/maven-3/trunk/maven-embedder/pom.xml
     
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
     maven/maven-3/trunk/pom.xml
 
 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
        groupIdorg.sonatype.aether/groupId
        artifactIdaether-connector-wagon/artifactId
      /dependency
 +    dependency
 +      groupIdorg.slf4j/groupId
 +      artifactIdslf4j-nop/artifactId
 +    /dependency
    /dependencies
 
    build
 
 Modified: 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  
 (original)
 +++ 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  
 Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
          imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm );
          imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm 
 );
          imports.put( 
 org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm );
 +
 +        // javax.inject, sisu-inject (JSR-330)
 +        imports.put( javax.inject.*, coreRealm );
 +        imports.put( javax.enterprise.inject.*, coreRealm );
 +        imports.put( org.sonatype.inject.*, coreRealm );
 +        imports.put( org.slf4j.*, coreRealm );
 +        
 +        // com.google
 +        //
 +        // We may potentially want to export these, but right now I'm not 
 sure that anything Guice specific needs
 +        // to be made available to plugin authors. If we find people are 
 getting fancy and want to take advantage
 +        // of Guice specifics we can expose that later. Really some testing 
 needs to be done to see full hiding
 +        // of Guice has any impact on what we may categorize as a standard 
 JSR-330 based Tesla/Maven plugin.
 +        //
 +        // imports.put( com.google.inject.*, coreRealm );
 +        // imports.put( com.google.inject.binder.*, coreRealm );
 +        // imports.put( com.google.inject.matcher.*, coreRealm );
 +        // imports.put( com.google.inject.name.*, coreRealm );
 +        // imports.put( com.google.inject.spi.*, coreRealm );
 +        // imports.put( com.google.inject.util.*, coreRealm );
      }
 
      /**
 
 Modified: maven/maven-3/trunk/maven-embedder/pom.xml
 URL: 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-embedder/pom.xml?rev=1380105r1=1380104r2=1380105view=diff

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Stephen Connolly

I'm not seeing log4j-over-slf4j in the dependency tree there at all... so
where is the bridge?

On 3 September 2012 08:10, Mark Struberg strub...@yahoo.de wrote:

 whats the reason for the slf4j bridge?

 This is kown to trash old plugins which use log4j because it clashes with
 it's namespace and only partly implements the log4j classes.

 I personally ind slf4j nice, but for older projects which use
 commons-logging or log4j already (and where you cant fiddle around with
 their sources) this broke way too many things for me.
 Why is this needed at all? Has nothing to do with JSR-330.

 LieGrue,
 strub




 - Original Message -
  From: jvan...@apache.org jvan...@apache.org
  To: comm...@maven.apache.org
  Cc:
  Sent: Monday, September 3, 2012 3:07 AM
  Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better it's
  injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and
 we'll do
  a bit of testing
 
  closes #3
 
  Added:
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
  maven/maven-3/trunk/apache-maven/pom.xml
 
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  maven/maven-3/trunk/maven-embedder/pom.xml
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
  maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:
 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
  @@ -83,6 +83,10 @@
 groupIdorg.sonatype.aether/groupId
 artifactIdaether-connector-wagon/artifactId
   /dependency
  +dependency
  +  groupIdorg.slf4j/groupId
  +  artifactIdslf4j-nop/artifactId
  +/dependency
 /dependencies
 
 build
 
  Modified:
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:
 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  ---
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
  +++
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
  @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
   imports.put(
  org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm );
   imports.put(
  org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm
  );
   imports.put(
  org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm );
  +
  +// javax.inject, sisu-inject (JSR-330)
  +imports.put( javax.inject.*, coreRealm );
  +imports.put( javax.enterprise.inject.*, coreRealm );
  +imports.put( org.sonatype.inject.*, coreRealm );
  +imports.put( org.slf4j.*, coreRealm );
  +
  +// com.google
  +//
  +// We may potentially want to export these, but right now I'm
 not
  sure that anything Guice specific needs
  +// to be made available to plugin authors. If we find people are
  getting fancy and want to take advantage
  +// of Guice specifics we can expose that later. Really some
 testing
  needs to be done to see full hiding
  +// of Guice has any impact on what we may categorize as a
 standard
  JSR-330 based Tesla/Maven plugin.
  +//
  +// imports.put( com.google.inject.*, coreRealm );
  +// imports.put( com.google.inject.binder.*, coreRealm );
  +// imports.put( com.google.inject.matcher.*, coreRealm );
  +// imports.put( com.google.inject.name.*, coreRealm );
  +// imports.put( com.google.inject.spi.*, coreRealm );
  +// imports.put( com.google.inject.util.*, coreRealm );
   }
 
   /**
 
  Modified

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Mark Struberg


 imports.put( org.slf4j.*, coreRealm );

To me this looks like any org.slf4j sub package would be exported. 

The whole goal of org.codehaus.plexus.logging.Logger was to shield the user 
from ANY specific logging framework. That way we could back the plexus Logger 
with any implementation the user wants. 


We already HAVE a logging bridge. Imo there is just no need to introduce 
another one!
To kind of hardcode this now to slf4j is frankly speaking nonsense imo.

But maybe I just missed the point? What is the reason for it? 


LieGrue,
strub



 From: Stephen Connolly stephen.alan.conno...@gmail.com
To: Maven Developers List dev@maven.apache.org; Mark Struberg 
strub...@yahoo.de 
Sent: Monday, September 3, 2012 10:42 AM
Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
maven-embedder/src/main/java/org/apache/maven/cli/
 

I'm not seeing log4j-over-slf4j in the dependency tree there at all... so 
where is the bridge?


On 3 September 2012 08:10, Mark Struberg strub...@yahoo.de wrote:

whats the reason for the slf4j bridge?

This is kown to trash old plugins which use log4j because it clashes with 
it's namespace and only partly implements the log4j classes.

I personally ind slf4j nice, but for older projects which use commons-logging 
or log4j already (and where you cant fiddle around with their sources) this 
broke way too many things for me.
Why is this needed at all? Has nothing to do with JSR-330.

LieGrue,
strub





- Original Message -
 From: jvan...@apache.org jvan...@apache.org
 To: comm...@maven.apache.org
 Cc:
 Sent: Monday, September 3, 2012 3:07 AM
 Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
 maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
 maven-embedder/src/main/java/org/apache/maven/cli/

 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105

 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components

 o Added Slf4j logger factory to support generic JSR-330 logging

 o Exported Guice package for components that access Guice (or better it's
 injector) directly

 Widen export of Guice packages (not ideal, need to look into ways to avoid 
 this)

 o use specific exports

 o for now we will attempt to hide all of Guice in plugin realms and we'll do
 a bit of testing

 closes #3

 Added:
    
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
    
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
 Modified:
     maven/maven-3/trunk/apache-maven/pom.xml
    
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
     maven/maven-3/trunk/maven-embedder/pom.xml
    
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
     maven/maven-3/trunk/pom.xml

 Modified: maven/maven-3/trunk/apache-maven/pom.xml
 URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 ==
 --- maven/maven-3/trunk/apache-maven/pom.xml (original)
 +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
 @@ -83,6 +83,10 @@
        groupIdorg.sonatype.aether/groupId
        artifactIdaether-connector-wagon/artifactId
      /dependency
 +    dependency
 +      groupIdorg.slf4j/groupId
 +      artifactIdslf4j-nop/artifactId
 +    /dependency
    /dependencies

    build

 Modified:
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 URL:
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 ==
 ---
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 (original)
 +++
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 Mon Sep  3 01:07:31 2012
 @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
          imports.put(
 org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm );
          imports.put(
 org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm
 );
          imports.put(
 org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm );
 +
 +        // javax.inject, sisu-inject (JSR-330)
 +        imports.put( javax.inject.*, coreRealm );
 +        imports.put( javax.enterprise.inject.*, coreRealm );
 +        imports.put( org.sonatype.inject.*, coreRealm );
 +        imports.put( org.slf4j.*, coreRealm );
 +       
 +        // com.google
 +        //
 +        // We may

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Stephen Connolly

On 3 September 2012 09:59, Mark Struberg strub...@yahoo.de wrote:

imports.put( org.slf4j.*, coreRealm );

To me this looks like any org.slf4j sub package would be exported.

slf4j is such a ubiquitous logging framework that it seems to me that it
would make sense to allow any plugins that have dependencies that use slf4j
to log through to maven.

The whole goal of org.codehaus.plexus.logging.Logger was to shield the
user from ANY specific logging framework. That way we could back the plexus
Logger with any implementation the user wants.

We already HAVE a logging bridge. Imo there is just no need to introduce
another one!

That is fine for plugin code, but why should *everyone* else have to
rewrite the same bridge from slf4j to our logging bridge?

And then that bridge routes back to slf4j?

To kind of hardcode this now to slf4j is frankly speaking nonsense imo.

Perhaps. I have concerns about slf4j API stability having seen some issues
with slf4j 1.5 vs 1.6 which I resolved and forgot about. A simpler approach
would be to produce a bridge dependency: slf4j-maven so that everyone that
has dependencies that use slf4j can trivially route their dependency
logging through to maven

But maybe I just missed the point? What is the reason for it?

Consider jetty:run... jetty sends its logging to slf4j... so to play
properly the plugin *should* be picking up those logs and routing them
through to Maven so that Maven's logging controls can correctly filter the
logs... now tomcat:run needs to do the same, etc

There is logging bridge madness all over the shop.

Logging bridges should be as close to the logger as possible, especially in
a short lived tool such as Maven, where the JVM may not have had a chance
to optimize out the bridge.

For server classes such as, e.g. MyFaces, the use of a bridge is less of an
issue as the JVM will optimize it out of the code since there is only one
trivial implementation and that can be in-lined and reduced away to a
direct call.

But a build tool that is invoking other 3rd party libs on a short lived
lifecycle will have a performance hit for the logging calls.

That is the argument for exposing directly.

The argument against is that slf4j's API sucks... though it sucks less than
any other logging api out there at the moment... there are still issues
with it ;-)

LieGrue,
strub

From: Stephen Connolly stephen.alan.conno...@gmail.com
To: Maven Developers List dev@maven.apache.org; Mark Struberg
strub...@yahoo.de
Sent: Monday, September 3, 2012 10:42 AM
Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./
apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

I'm not seeing log4j-over-slf4j in the dependency tree there at all... so
where is the bridge?

On 3 September 2012 08:10, Mark Struberg strub...@yahoo.de wrote:

whats the reason for the slf4j bridge?

This is kown to trash old plugins which use log4j because it clashes
with it's namespace and only partly implements the log4j classes.

I personally ind slf4j nice, but for older projects which use
commons-logging or log4j already (and where you cant fiddle around with
their sources) this broke way too many things for me.
Why is this needed at all? Has nothing to do with JSR-330.

LieGrue,
strub

- Original Message -
From: jvan...@apache.org jvan...@apache.org
To: comm...@maven.apache.org
Cc:
Sent: Monday, September 3, 2012 3:07 AM
Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./
apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Author: jvanzyl
Date: Mon Sep 3 01:07:31 2012
New Revision: 1380105

URL: http://svn.apache.org/viewvc?rev=1380105view=rev
Log:
o Enabled support and discovery of JSR-330 components

o Added Slf4j logger factory to support generic JSR-330 logging

o Exported Guice package for components that access Guice (or better
it's
injector) directly

Widen export of Guice packages (not ideal, need to look into ways to
avoid this)

o use specific exports

o for now we will attempt to hide all of Guice in plugin realms and
we'll do
a bit of testing

closes #3

Added:

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
Modified:
maven/maven-3/trunk/apache-maven/pom.xml

maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
maven/maven-3/trunk/maven-embedder/pom.xml

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
maven/maven-3/trunk/pom.xml

Modified: maven/maven-3/trunk/apache-maven/pom.xml
URL:

http

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Mark Struberg



 A simpler approach
 would be to produce a bridge dependency: slf4j-maven so that everyone that
 has dependencies that use slf4j can trivially route their dependency
 logging through to maven


+1 for taking this route. That would also allow us to adopt easily for future 
API changes. Been there, done that ...

LieGrue,
strub


 From: Stephen Connolly stephen.alan.conno...@gmail.com
To: Maven Developers List dev@maven.apache.org; Mark Struberg 
strub...@yahoo.de 
Sent: Monday, September 3, 2012 11:55 AM
Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
maven-embedder/src/main/java/org/apache/maven/cli/
 
On 3 September 2012 09:59, Mark Struberg strub...@yahoo.de wrote:


  imports.put( org.slf4j.*, coreRealm );

 To me this looks like any org.slf4j sub package would be exported.


slf4j is such a ubiquitous logging framework that it seems to me that it
would make sense to allow any plugins that have dependencies that use slf4j
to log through to maven.



 The whole goal of org.codehaus.plexus.logging.Logger was to shield the
 user from ANY specific logging framework. That way we could back the plexus
 Logger with any implementation the user wants.


 We already HAVE a logging bridge. Imo there is just no need to introduce
 another one!


That is fine for plugin code, but why should *everyone* else have to
rewrite the same bridge from slf4j to our logging bridge?

And then that bridge routes back to slf4j?


 To kind of hardcode this now to slf4j is frankly speaking nonsense imo.


Perhaps. I have concerns about slf4j API stability having seen some issues
with slf4j 1.5 vs 1.6 which I resolved and forgot about. A simpler approach
would be to produce a bridge dependency: slf4j-maven so that everyone that
has dependencies that use slf4j can trivially route their dependency
logging through to maven


 But maybe I just missed the point? What is the reason for it?


Consider jetty:run... jetty sends its logging to slf4j... so to play
properly the plugin *should* be picking up those logs and routing them
through to Maven so that Maven's logging controls can correctly filter the
logs... now tomcat:run needs to do the same, etc

There is logging bridge madness all over the shop.

Logging bridges should be as close to the logger as possible, especially in
a short lived tool such as Maven, where the JVM may not have had a chance
to optimize out the bridge.

For server classes such as, e.g. MyFaces, the use of a bridge is less of an
issue as the JVM will optimize it out of the code since there is only one
trivial implementation and that can be in-lined and reduced away to a
direct call.

But a build tool that is invoking other 3rd party libs on a short lived
lifecycle will have a performance hit for the logging calls.

That is the argument for exposing directly.

The argument against is that slf4j's API sucks... though it sucks less than
any other logging api out there at the moment... there are still issues
with it ;-)



 LieGrue,
 strub


 
  From: Stephen Connolly stephen.alan.conno...@gmail.com
 To: Maven Developers List dev@maven.apache.org; Mark Struberg 
 strub...@yahoo.de
 Sent: Monday, September 3, 2012 10:42 AM
 Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
 
 I'm not seeing log4j-over-slf4j in the dependency tree there at all... so
 where is the bridge?
 
 
 On 3 September 2012 08:10, Mark Struberg strub...@yahoo.de wrote:
 
 whats the reason for the slf4j bridge?
 
 This is kown to trash old plugins which use log4j because it clashes
 with it's namespace and only partly implements the log4j classes.
 
 I personally ind slf4j nice, but for older projects which use
 commons-logging or log4j already (and where you cant fiddle around with
 their sources) this broke way too many things for me.
 Why is this needed at all? Has nothing to do with JSR-330.
 
 LieGrue,
 strub
 
 
 
 
 
 - Original Message -
  From: jvan...@apache.org jvan...@apache.org
  To: comm...@maven.apache.org
  Cc:
  Sent: Monday, September 3, 2012 3:07 AM
  Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better
 it's
  injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
  o use

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Jason van Zyl


On Sep 3, 2012, at 5:55 AM, Stephen Connolly wrote:

 On 3 September 2012 09:59, Mark Struberg strub...@yahoo.de wrote:
 
 
 imports.put( org.slf4j.*, coreRealm );
 
 To me this looks like any org.slf4j sub package would be exported.
 
 
 slf4j is such a ubiquitous logging framework that it seems to me that it
 would make sense to allow any plugins that have dependencies that use slf4j
 to log through to maven.

That is my thinking. It's easy enough to plugin any default implementation, and 
the funnels for all the logging systems work well. Ideally we pick an 
implementation and put in the funnels for JDK and commons-logging and we're set 
indefinitely, I think.

 
 
 
 The whole goal of org.codehaus.plexus.logging.Logger was to shield the
 user from ANY specific logging framework. That way we could back the plexus
 Logger with any implementation the user wants.
 
 
 We already HAVE a logging bridge. Imo there is just no need to introduce
 another one!
 
 
 That is fine for plugin code, but why should *everyone* else have to
 rewrite the same bridge from slf4j to our logging bridge?
 
 And then that bridge routes back to slf4j?
 
 
 To kind of hardcode this now to slf4j is frankly speaking nonsense imo.
 
 
 Perhaps. I have concerns about slf4j API stability having seen some issues
 with slf4j 1.5 vs 1.6 which I resolved and forgot about. A simpler approach
 would be to produce a bridge dependency: slf4j-maven so that everyone that
 has dependencies that use slf4j can trivially route their dependency
 logging through to maven
 
 
 But maybe I just missed the point? What is the reason for it?
 
 
 Consider jetty:run... jetty sends its logging to slf4j... so to play
 properly the plugin *should* be picking up those logs and routing them
 through to Maven so that Maven's logging controls can correctly filter the
 logs... now tomcat:run needs to do the same, etc
 
 There is logging bridge madness all over the shop.
 
 Logging bridges should be as close to the logger as possible, especially in
 a short lived tool such as Maven, where the JVM may not have had a chance
 to optimize out the bridge.
 
 For server classes such as, e.g. MyFaces, the use of a bridge is less of an
 issue as the JVM will optimize it out of the code since there is only one
 trivial implementation and that can be in-lined and reduced away to a
 direct call.
 
 But a build tool that is invoking other 3rd party libs on a short lived
 lifecycle will have a performance hit for the logging calls.
 
 That is the argument for exposing directly.
 
 The argument against is that slf4j's API sucks... though it sucks less than
 any other logging api out there at the moment... there are still issues
 with it ;-)

I think it's the best and most reasonable choice which is why I added it. With 
the funnel support and being able to pick any default implementation I think it 
satisfies core requirements and is helpful for extensions.

 
 
 
 LieGrue,
 strub
 
 
 
 From: Stephen Connolly stephen.alan.conno...@gmail.com
 To: Maven Developers List dev@maven.apache.org; Mark Struberg 
 strub...@yahoo.de
 Sent: Monday, September 3, 2012 10:42 AM
 Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
 
 I'm not seeing log4j-over-slf4j in the dependency tree there at all... so
 where is the bridge?
 
 
 On 3 September 2012 08:10, Mark Struberg strub...@yahoo.de wrote:
 
 whats the reason for the slf4j bridge?
 
 This is kown to trash old plugins which use log4j because it clashes
 with it's namespace and only partly implements the log4j classes.
 
 I personally ind slf4j nice, but for older projects which use
 commons-logging or log4j already (and where you cant fiddle around with
 their sources) this broke way too many things for me.
 Why is this needed at all? Has nothing to do with JSR-330.
 
 LieGrue,
 strub
 
 
 
 
 
 - Original Message -
 From: jvan...@apache.org jvan...@apache.org
 To: comm...@maven.apache.org
 Cc:
 Sent: Monday, September 3, 2012 3:07 AM
 Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
 Author: jvanzyl
 Date: Mon Sep  3 01:07:31 2012
 New Revision: 1380105
 
 URL: http://svn.apache.org/viewvc?rev=1380105view=rev
 Log:
 o Enabled support and discovery of JSR-330 components
 
 o Added Slf4j logger factory to support generic JSR-330 logging
 
 o Exported Guice package for components that access Guice (or better
 it's
 injector) directly
 
 Widen export of Guice packages (not ideal, need to look into ways to
 avoid this)
 
 o use specific exports
 
 o for now we will attempt to hide all of Guice in plugin realms and
 we'll do
 a bit of testing
 
 closes #3
 
 Added:
 
 
 maven/maven-3/trunk/maven

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Jason van Zyl

I disagree and believe making another API is of little value, especially given 
the ubiquity of SLF4J.

Benefits:
- Ubiquity. SLF4J may not be perfect, but I doubt we'll make anything better
- Changes have been made in Sisu that allow SLF4J logger to be injectable (we 
would have to redo this work)
- M2E uses SLF4J successfully and we never had any problems. We also now get 
consistency through the most widely used Maven toolchain.
- There are many default implementations to choose from, including log4j
- All the bridges function which pretty much allows all the common frameworks 
to be utilized with no work on our side. This allows others to use whatever 
they like in their components, and we can absorb almost any component that 
exists using its
- If there are integration issues I'm sure Ceki will fix them. If there are 
examples of integrations I'd like to see the examples because I've never seen 
them personally.

Downsides:
- I'm sure users and integrators do not want to see another logging API
- No injectable loggers
- We would have to write all the bridges again to integrate all the other 
frameworks and I really don't see this as a valuable exercise. I have never 
seen integration issues with SLF4J in m2e or Nexus and they are fairly 
extensive programs.

In summary I see this as low value work with no real benefit to anyone.

At any rate I don't want to get in a religious debate about logging frameworks, 
i just want to most reasonable solution that exists without doing any work.

If we all agree SLF4J is not appropriate, let me know and I'll rollback my 
commit and change it.

On Sep 3, 2012, at 6:01 AM, Mark Struberg wrote:

 
 
 A simpler approach
 would be to produce a bridge dependency: slf4j-maven so that everyone that
 has dependencies that use slf4j can trivially route their dependency
 logging through to maven
 
 
 +1 for taking this route. That would also allow us to adopt easily for future 
 API changes. Been there, done that ...
 
 LieGrue,
 strub
 
 
 From: Stephen Connolly stephen.alan.conno...@gmail.com
 To: Maven Developers List dev@maven.apache.org; Mark Struberg 
 strub...@yahoo.de 
 Sent: Monday, September 3, 2012 11:55 AM
 Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ 
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ 
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
 On 3 September 2012 09:59, Mark Struberg strub...@yahoo.de wrote:
 
 
 imports.put( org.slf4j.*, coreRealm );
 
 To me this looks like any org.slf4j sub package would be exported.
 
 
 slf4j is such a ubiquitous logging framework that it seems to me that it
 would make sense to allow any plugins that have dependencies that use slf4j
 to log through to maven.
 
 
 
 The whole goal of org.codehaus.plexus.logging.Logger was to shield the
 user from ANY specific logging framework. That way we could back the plexus
 Logger with any implementation the user wants.
 
 
 We already HAVE a logging bridge. Imo there is just no need to introduce
 another one!
 
 
 That is fine for plugin code, but why should *everyone* else have to
 rewrite the same bridge from slf4j to our logging bridge?
 
 And then that bridge routes back to slf4j?
 
 
 To kind of hardcode this now to slf4j is frankly speaking nonsense imo.
 
 
 Perhaps. I have concerns about slf4j API stability having seen some issues
 with slf4j 1.5 vs 1.6 which I resolved and forgot about. A simpler approach
 would be to produce a bridge dependency: slf4j-maven so that everyone that
 has dependencies that use slf4j can trivially route their dependency
 logging through to maven
 
 
 But maybe I just missed the point? What is the reason for it?
 
 
 Consider jetty:run... jetty sends its logging to slf4j... so to play
 properly the plugin *should* be picking up those logs and routing them
 through to Maven so that Maven's logging controls can correctly filter the
 logs... now tomcat:run needs to do the same, etc
 
 There is logging bridge madness all over the shop.
 
 Logging bridges should be as close to the logger as possible, especially in
 a short lived tool such as Maven, where the JVM may not have had a chance
 to optimize out the bridge.
 
 For server classes such as, e.g. MyFaces, the use of a bridge is less of an
 issue as the JVM will optimize it out of the code since there is only one
 trivial implementation and that can be in-lined and reduced away to a
 direct call.
 
 But a build tool that is invoking other 3rd party libs on a short lived
 lifecycle will have a performance hit for the logging calls.
 
 That is the argument for exposing directly.
 
 The argument against is that slf4j's API sucks... though it sucks less than
 any other logging api out there at the moment... there are still issues
 with it ;-)
 
 
 
 LieGrue,
 strub
 
 
 
 From: Stephen Connolly stephen.alan.conno...@gmail.com
 To: Maven Developers List dev

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Igor Fedorenko


FWIW, we are using sfl4j and logback as part of m2e embedded maven
runtime for over a year now without any major issues. There was a
problem with older IBM JVMs [1], but it is fixed now in slf4j (and
in IBM code too, as far as I understand).

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=338252

--
Regards,
Igor


On 12-09-03 3:10 AM, Mark Struberg wrote:

whats the reason for the slf4j bridge?

This is kown to trash old plugins which use log4j because it clashes
with it's namespace and only partly implements the log4j classes.

I personally ind slf4j nice, but for older projects which use
commons-logging or log4j already (and where you cant fiddle around
with their sources) this broke way too many things for me. Why is
this needed at all? Has nothing to do with JSR-330.

LieGrue, strub 



- Original Message -

From: jvan...@apache.org jvan...@apache.org
To: comm...@maven.apache.org
Cc:
Sent: Monday, September 3, 2012 3:07 AM
Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
maven-embedder/src/main/java/org/apache/maven/cli/

Author: jvanzyl
Date: Mon Sep  3 01:07:31 2012
New Revision: 1380105

URL: http://svn.apache.org/viewvc?rev=1380105view=rev
Log:
o Enabled support and discovery of JSR-330 components

o Added Slf4j logger factory to support generic JSR-330 logging

o Exported Guice package for components that access Guice (or better it's
injector) directly

Widen export of Guice packages (not ideal, need to look into ways to avoid this)

o use specific exports

o for now we will attempt to hide all of Guice in plugin realms and we'll do
a bit of testing

closes #3

Added:

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
Modified:
 maven/maven-3/trunk/apache-maven/pom.xml

maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
 maven/maven-3/trunk/maven-embedder/pom.xml

maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 maven/maven-3/trunk/pom.xml

Modified: maven/maven-3/trunk/apache-maven/pom.xml
URL:
http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
==
--- maven/maven-3/trunk/apache-maven/pom.xml (original)
+++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
@@ -83,6 +83,10 @@
groupIdorg.sonatype.aether/groupId
artifactIdaether-connector-wagon/artifactId
  /dependency
+dependency
+  groupIdorg.slf4j/groupId
+  artifactIdslf4j-nop/artifactId
+/dependency
/dependencies

build

Modified:
maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
URL:
http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
==
---
maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
(original)
+++
maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
Mon Sep  3 01:07:31 2012
@@ -198,6 +198,26 @@ public class DefaultClassRealmManager
  imports.put(
org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm );
  imports.put(
org.codehaus.plexus.util.xml.pull.XmlPullParserException, coreRealm
);
  imports.put(
org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm );
+
+// javax.inject, sisu-inject (JSR-330)
+imports.put( javax.inject.*, coreRealm );
+imports.put( javax.enterprise.inject.*, coreRealm );
+imports.put( org.sonatype.inject.*, coreRealm );
+imports.put( org.slf4j.*, coreRealm );
+
+// com.google
+//
+// We may potentially want to export these, but right now I'm not
sure that anything Guice specific needs
+// to be made available to plugin authors. If we find people are
getting fancy and want to take advantage
+// of Guice specifics we can expose that later. Really some testing
needs to be done to see full hiding
+// of Guice has any impact on what we may categorize as a standard
JSR-330 based Tesla/Maven plugin.
+//
+// imports.put( com.google.inject.*, coreRealm );
+// imports.put( com.google.inject.binder.*, coreRealm );
+// imports.put( com.google.inject.matcher.*, coreRealm );
+// imports.put( com.google.inject.name.*, coreRealm );
+// imports.put( com.google.inject.spi.*, coreRealm );
+// imports.put( com.google.inject.util.*, coreRealm );
  }

  /**

Modified: maven

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

2012-09-03 Thread Mark Struberg

but you don't expose it to maven plugins, do you? I guess not, because it was 
not in the root realm classpath.

LieGrue,
strub




- Original Message -
 From: Igor Fedorenko i...@ifedorenko.com
 To: dev@maven.apache.org
 Cc: 
 Sent: Monday, September 3, 2012 2:25 PM
 Subject: Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ 
 maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ 
 maven-embedder/src/main/java/org/apache/maven/cli/
 
 FWIW, we are using sfl4j and logback as part of m2e embedded maven
 runtime for over a year now without any major issues. There was a
 problem with older IBM JVMs [1], but it is fixed now in slf4j (and
 in IBM code too, as far as I understand).
 
 [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=338252
 
 --
 Regards,
 Igor
 
 
 On 12-09-03 3:10 AM, Mark Struberg wrote:
  whats the reason for the slf4j bridge?
 
  This is kown to trash old plugins which use log4j because it clashes
  with it's namespace and only partly implements the log4j classes.
 
  I personally ind slf4j nice, but for older projects which use
  commons-logging or log4j already (and where you cant fiddle around
  with their sources) this broke way too many things for me. Why is
  this needed at all? Has nothing to do with JSR-330.
 
  LieGrue, strub 
 
 
 
  - Original Message -
  From: jvan...@apache.org jvan...@apache.org
  To: comm...@maven.apache.org
  Cc:
  Sent: Monday, September 3, 2012 3:07 AM
  Subject: svn commit: r1380105 - in /maven/maven-3/trunk: ./ 
 apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ 
 maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/
 
  Author: jvanzyl
  Date: Mon Sep  3 01:07:31 2012
  New Revision: 1380105
 
  URL: http://svn.apache.org/viewvc?rev=1380105view=rev
  Log:
  o Enabled support and discovery of JSR-330 components
 
  o Added Slf4j logger factory to support generic JSR-330 logging
 
  o Exported Guice package for components that access Guice (or better 
 it's
  injector) directly
 
  Widen export of Guice packages (not ideal, need to look into ways to 
 avoid this)
 
  o use specific exports
 
  o for now we will attempt to hide all of Guice in plugin realms and 
 we'll do
  a bit of testing
 
  closes #3
 
  Added:
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
  Modified:
       maven/maven-3/trunk/apache-maven/pom.xml
 
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
       maven/maven-3/trunk/maven-embedder/pom.xml
 
 
 maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
       maven/maven-3/trunk/pom.xml
 
  Modified: maven/maven-3/trunk/apache-maven/pom.xml
  URL:
 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  --- maven/maven-3/trunk/apache-maven/pom.xml (original)
  +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31 2012
  @@ -83,6 +83,10 @@
          groupIdorg.sonatype.aether/groupId
          artifactIdaether-connector-wagon/artifactId
        /dependency
  +    dependency
  +      groupIdorg.slf4j/groupId
  +      artifactIdslf4j-nop/artifactId
  +    /dependency
      /dependencies
 
      build
 
  Modified:
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  URL:
 
 http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105r1=1380104r2=1380105view=diff
 
 ==
  ---
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  (original)
  +++
 
 maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
  Mon Sep  3 01:07:31 2012
  @@ -198,6 +198,26 @@ public class DefaultClassRealmManager
            imports.put(
  org.codehaus.plexus.util.xml.pull.XmlPullParser, coreRealm 
 );
            imports.put(
  org.codehaus.plexus.util.xml.pull.XmlPullParserException, 
 coreRealm
  );
            imports.put(
  org.codehaus.plexus.util.xml.pull.XmlSerializer, coreRealm 
 );
  +
  +        // javax.inject, sisu-inject (JSR-330)
  +        imports.put( javax.inject.*, coreRealm );
  +        imports.put( javax.enterprise.inject.*, coreRealm 
 );
  +        imports.put( org.sonatype.inject.*, coreRealm );
  +        imports.put( org.slf4j.*, coreRealm );
  +
  +        // com.google
  +        //
  +        // We may potentially want to export these, but right now 
 I'm not
  sure that anything Guice specific needs
  +        // to be made available to plugin authors. If we

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/

29 matches

Site Navigation

Mail list logo

Footer information