[GitHub] [maven-artifact-transfer] slachiewicz merged pull request #54: Bump sisu.version from 0.3.4 to 0.3.5
slachiewicz merged pull request #54: URL: https://github.com/apache/maven-artifact-transfer/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
I'm trying an "exec:exec" approach https://github.com/apache/maven-wrapper/tree/it_run_mvnw the only tricky case is for source distribution type to download the wrapper that is not available on central perhaps I'll simply skip that one for now: we'll have time to improve later Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > In order to run proper IT test by maven-invoker-plugin we should provide > invoker.properties like: > > invoker.goals.1 = wraper:wrapper > > invoker.goals.2 = validate > invoker.mavenExecutable.2 = ./mvnw > invoker.os.family.2 = unix, mac > > invoker.goals.3 = validate > invoker.mavenExecutable.3 = ./mvnw.cmd > invoker.os.family.3 = windows > > but > - mavenExecutable - can be set on global configuration only > - invoker.os.family - not support indexing ... > > So first improvement on maven-invoker-plugin will be needed ... > or switch to another tools for IT testing > or try to complicate maven-invoker configuration - I don't sure if will be > posible > > I can take care about changes in maven-invoker-plugin if you wish > > pt., 10 gru 2021 o 11:03 Robert Scholte napisał(a): > > I need more time. > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > download the wrapper. > > now that the plugin and wrapper are combined in one project, the ITs are > > incomplete. > > They should call both the wrapper-goal and something like 'mvnw > > --version' to ensure it is working (this used to be done in > > maven-integration-testing) > > > > thanks, > > Robert > > > > -- Origineel bericht -- > > Van: "Hervé BOUTEMY" > > Aan: "Maven Developers List" > > Verzonden: 10-12-2021 08:08:57 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > >we now have 16 issues fixed, everything seems stable > > > > > >if nobody objects, I'll start a release over the week-end > > > > > >Regards, > > > > > >Hervé > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > ve> > > >> rsion=12350068 > > >> > > >> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Maybe mrm-maven-plugin can be used for mock Central for downloading wrapper. sob., 11 gru 2021 o 09:03 Hervé BOUTEMY napisał(a): > I'm trying an "exec:exec" approach > https://github.com/apache/maven-wrapper/tree/it_run_mvnw > > the only tricky case is for source distribution type to download the > wrapper > that is not available on central > > perhaps I'll simply skip that one for now: we'll have time to improve later > > Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > > In order to run proper IT test by maven-invoker-plugin we should provide > > invoker.properties like: > > > > invoker.goals.1 = wraper:wrapper > > > > invoker.goals.2 = validate > > invoker.mavenExecutable.2 = ./mvnw > > invoker.os.family.2 = unix, mac > > > > invoker.goals.3 = validate > > invoker.mavenExecutable.3 = ./mvnw.cmd > > invoker.os.family.3 = windows > > > > but > > - mavenExecutable - can be set on global configuration only > > - invoker.os.family - not support indexing ... > > > > So first improvement on maven-invoker-plugin will be needed ... > > or switch to another tools for IT testing > > or try to complicate maven-invoker configuration - I don't sure if will > be > > posible > > > > I can take care about changes in maven-invoker-plugin if you wish > > > > pt., 10 gru 2021 o 11:03 Robert Scholte > napisał(a): > > > I need more time. > > > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > > download the wrapper. > > > now that the plugin and wrapper are combined in one project, the ITs > are > > > incomplete. > > > They should call both the wrapper-goal and something like 'mvnw > > > --version' to ensure it is working (this used to be done in > > > maven-integration-testing) > > > > > > thanks, > > > Robert > > > > > > -- Origineel bericht -- > > > Van: "Hervé BOUTEMY" > > > Aan: "Maven Developers List" > > > Verzonden: 10-12-2021 08:08:57 > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > > > >we now have 16 issues fixed, everything seems stable > > > > > > > >if nobody objects, I'll start a release over the week-end > > > > > > > >Regards, > > > > > > > >Hervé > > > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > > >> Hi, > > > >> > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > >> > > > >>https://github.com/apache/maven-wrapper > > > >> > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > ve> > > > >> rsion=12350068 > > > >> > > > >> > > > >> Please test and review so we can do a release soon > > > >> > > > >> Regards, > > > >> > > > >> Hervé > > > >> > > > >> > > > >> > > > >> > - > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > >- > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
The improvements can still be applied. My understanding was that it was planned for the next Maven release. And that was 4 at the time .. however that changed and we have had no released maintained wrapper for two years now. Lets just move on with the release of the wrapper in Apache and then improve however desired. Manfred Robert Scholte wrote on 2021-12-11 04:43 (GMT -08:00): > It was marked for Maven 4, and part of the improvements was test > automation, which was now possible because it became part of Maven Core. > Even thought the code still exists in Maven Core, is has now become > useless. > > There hasn't been a real need for new releases of Maven Wrapper Plugin > until a range of Maven 3.8 started. > Maven Wrapper would have been another feature to attract developers to > Maven 4. > > And finally, I see that the donated code has been used as base, ignoring > all the effort done to improve that codebase done afterwards. > Hence my response that reliability is gone that was added after > donation. > > Robert > > -- Origineel bericht -- > Van: "Manfred Moser" > Aan: dev@maven.apache.org > Verzonden: 10-12-2021 20:58:33 > Onderwerp: Re: reviewing Maven Wrapper before releasing > >>I totally agree with finally just shipping this. We got this all donated about >>two years ago now and there is still nothing shipping. >> >>I used to just manually do the testing and thousands of projects are happy. I >>assume the new project is at least manually testing and works as before or >>better. Let's not wait nay more and let perfection get into our way. It surely >>is good enough for a release. >> >>The beauty is that if you find an issue.. you just ship again ... no reason to >>wait. >> >>manfred >> >>Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): >> >>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not >>> test, I just did not change anything using the general approach "people >>> were >>> happy before, just continue step by step improvements" :) >>> >>> reading the mvnw script (*nix), compiling+running the .java is executed >>> only >>> if >>> neither wget nor curl are available on your machine >>> >>> reading the mvnw.cmd, it seems .java is not supported >>> >>> looking at Git history confirms: >>>https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 >>> >>> >>> Don't hesitate to create a Jira issue and corresponding fix to add .java >>> support for Windows: future 3.1.0 will have one more fix over previous >>> 0.5.6 >>> >>> Regards, >>> >>> Hervé >>> >>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >>> >>> >>> >>> - >>> To unsubscribe, e-mail:
[GitHub] [maven-artifact-transfer] slachiewicz merged pull request #54: Bump sisu.version from 0.3.4 to 0.3.5
slachiewicz merged pull request #54: URL: https://github.com/apache/maven-artifact-transfer/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
