[GitHub] mesos pull request #294: FaultDomain, conventions for additional hierarchy.

2018-05-31 Thread vinodkone
Github user vinodkone commented on a diff in the pull request:

https://github.com/apache/mesos/pull/294#discussion_r192161678
  
--- Diff: include/mesos/mesos.proto ---
@@ -827,6 +827,18 @@ message ExecutorInfo {
  * in the same zone, in different zones in the same region, or in
  * different regions. Note that all masters in a given Mesos cluster
  * must be in the same region.
+ *
+ * Complex deployments may have additional levels of hierarchy: for 
example,
+ * multiple racks might be grouped together into "halls" and multiple DCs 
in
+ * the same geographical vicinity might be grouped together. As a 
convention,
+ * the recommended way to represent additional levels of hierarchy is via 
dot-
--- End diff --

We don't need to recommend "dot" right? It could be any delimiter that they 
choose to have? As far as Mesos is concerned, it doesn't matter.


---


[GitHub] mesos pull request #294: FaultDomain, conventions for additional hierarchy.

2018-05-30 Thread jdef
GitHub user jdef opened a pull request:

https://github.com/apache/mesos/pull/294

FaultDomain, conventions for additional hierarchy.

Added notes from the "Convention for Additional Hierarchy" of the original 
design doc: 
https://docs.google.com/document/d/1gEugdkLRbBsqsiFv3urRPRNrHwUC-i1HwfFfHR_MvC8/edit#heading=h.emfys1xszpir

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdef/mesos fault_domain_convention

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mesos/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit 7ad052cda2aa31c5fa51698b5fe566ffbdfcf5b6
Author: James DeFelice 
Date:   2018-05-30T21:43:27Z

FaultDomain, conventions for additional hierarchy.




---