[GitHub] incubator-metron issue #567: METRON-891: Changed Kafka API to Create a Kafka...

2017-05-10 Thread merrimanr
Github user merrimanr commented on the issue:

https://github.com/apache/incubator-metron/pull/567
  
Tested this with full dev and worked great.  I noticed some  tags snuck 
into a couple of the license headers.  I think Intellij does this when you 
reformat.  Not sure if people would have a problem with that or not.

Nice work +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #580: METRON-942 [NO MERGE UNTIL METRON-777] R...

2017-05-10 Thread ottobackwards
Github user ottobackwards closed the pull request at:

https://github.com/apache/incubator-metron/pull/580


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #546: METRON-886 ansible-docker : need to have...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/546


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #578: METRON-946 Full/Quick dev should default networ...

2017-05-10 Thread mattf-horton
Github user mattf-horton commented on the issue:

https://github.com/apache/incubator-metron/pull/578
  
and thanks for the quick check, @dlyle65535 .  In process to commit...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [MASTER BROKEN] Possible Issue in METRON.SPEC in master

2017-05-10 Thread Otto Fowler
As soon as my prepare-commit vagrant up finishes.  Knew it. lol



On May 10, 2017 at 08:45:02, Justin Leet (justinjl...@gmail.com) wrote:

PR is merged into master. Build should be good to go.

On Tue, May 9, 2017 at 6:23 PM, David Lyle  wrote:

> Ah, nothing zigged when it should have zagged on that end. There's
> something wrong on my end. The master I had was older than it should have
> been, not sure why yet, but I'll dig into it. In the meantime, the PR is
> up.
>
> -D...
>
>
> On Tue, May 9, 2017 at 5:58 PM, Otto Fowler 
> wrote:
>
> > I don’t think I said what I meant.
> > I meant that they could investigate what happened from logs etc. rather
> > than they would actually do any
> > git commits or history modifications.
> >
> >
> >
> > On May 9, 2017 at 17:45:03, David Lyle (dlyle65...@gmail.com) wrote:
> >
> > Seems like more trouble than it's worth. I have a patch in test now.
> >
> > On Tue, May 9, 2017 at 5:24 PM, Otto Fowler 
> > wrote:
> >
> > > I wonder if an INFRA ticket is in order?
> > > they can muck about with the git history.
> > >
> > >
> > >
> > > On May 9, 2017 at 17:19:34, David Lyle (dlyle65...@gmail.com) wrote:
> > >
> > > That's exactly what it is. Strangely, git didn't indicate I had a
merge
> > > conflict during the commit (?).
> > >
> > > Anyhoo- I'll push a pr shortly with both. Sorry for the trouble.
> > >
> > > -D...
> > >
> > >
> > > On Tue, May 9, 2017 at 5:04 PM, Matt Foley 
> > > wrote:
> > >
> > > > It was this commit: https://github.com/apache/
> incubator-metron/commit/
> > > > 8cf109da180ee9f80984b0408afed799fa6c7c43
> > > >
> > > > Looks like a case of simultaneous modification. Merging both is
> > probably
> > > > the trivially correct fix.
> > > >
> > > > On 5/9/17, 1:58 PM, "Otto Fowler"  wrote:
> > > >
> > > > %changelog
> > > > <<< HEAD
> > > > * Thu May 4 2017 Ryan Merriman  - 0.4.0
> > > > - Added REST
> > > > * Fri Apr 28 2017 Apache Metron  - 0.4.0
> > > > - Add Zeppelin Connection Report Dashboard
> > > > ===
> > > > * Tue May 2 2017 David Lyle  - 0.4.0
> > > > - Add Metron IP Report
> > > > >>> 1cace9ff29f31301d74fa6a7b2630d471452e985
> > > >
> > > >
> > > > too
> > > >
> > > > On May 9, 2017 at 16:51:53, Otto Fowler (ottobackwa...@gmail.com)
> > > > wrote:
> > > >
> > > > I just tried to merge in master, and got conflicts in metron.spec.
> > > > Which
> > > > is not unusual since spec files are awesome.
> > > > But I was sing a head>> commit>> set of comments, that was
> > > > weird.
> > > >
> > > > When I look at the actual code file in github on the web, the
> > > > statement is
> > > > actually in github. Like we did a commit of the conflict file
> > > >
> > > > <<< HEAD
> > > > %{metron_home}/config/zeppelin/metron/metron-connection-report.json
> > > > ===
> > > > %{metron_home}/config/zeppelin/metron/metron-ip-report.json
> > > > >>> 1cace9ff29f31301d74fa6a7b2630d471452e985
> > > >
> > > > So I don’t think the rpms are going to build off of this.
> > > >
> > > >
> > > >
> > >
> > >
> >
> >
>


[GitHub] incubator-metron pull request #576: METRON-945: Resolve merge conflict in me...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/576


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-10 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/incubator-metron/pull/560
  
+1 Looks good, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-10 Thread JonZeolla
Github user JonZeolla commented on the issue:

https://github.com/apache/incubator-metron/pull/560
  
I gave `brew cask install docker` another shot this morning and got it 
running no problem.  Updated the instructions per discussion with @nickwallen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---