Re: [VOTE] Apache Metron 0.4.0 release

[Ryan Merriman]

+1 (binding)

   - Verified Keys
   - Verified mvn clean install
   - Ran full dev and performed several smoke tests including:
  - tested several REST endpoints
  - verified data in ES
  - tested Management UI
  - verified Storm topologies in Storm UI
  - verified data in Kibana


On Fri, Jun 30, 2017 at 12:24 PM, Matt Foley  wrote:

> Hey all, we need more votes!
>
> So far we have 6 +1’s (including mine) and no 0’s or -1’s.
> BUT, only two are binding, ie from PMC members.
> Rules require 3 or more PMC member +1’s.  Could one more
> member please step up and vote?
>
> Thanks!
> --Matt
>
> On 6/29/17, 3:00 PM, "James Sirota"  wrote:
>
> +1 (Binding)
>
> * Verified Keys
> * Verified mvn clean install completed successfully
> * Verified AWS install of core via Mpack
>
>
> 29.06.2017, 09:14, "Justin Leet" :
> > +1 (Non-binding)
> >
> > * Verified Keys
> > * Verified mvn clean install completed successfully
> > * Ran full dev: saw data flow through, ran a couple of the REST
> APIs, and
> > opened up and clicked through a bit of the Management API.
> > * Examined site-book and didn't see any issues
> >
> > On Thu, Jun 29, 2017 at 11:46 AM, Casey Stella 
> wrote:
> >
> >>  +1 (binding)
> >>  * Verified keys
> >>  * Verified mvn build
> >>  * Verified unit and integration tests run
> >>  * Verified license check runs
> >>  * Verified fulldev spun up with smoketest
> >>
> >>  On Wed, Jun 28, 2017 at 8:10 PM, Anand Subramanian <
> >>  asubraman...@hortonworks.com> wrote:
> >>
> >>  > +1 (non-binding)
> >>  >
> >>  > * Brought up Metron stack on 12-node CentOS7 openstack cluster
> >>  > * Verify all services come up fine [PASS]
> >>  > * Bro, YAF and snort - ingest into respective kafka topics and
> write
> >>  > indices [PASS]
> >>  > * Add squid telemetry, ingest into kafka topic and write indices
> [PASS]
> >>  > * Metron YAF Zeppelin dashboard with sample ingested YAF data
> [PASS]
> >>  > * Management UI and REST Swagger UI sanity check [PASS]
> >>  >
> >>  >
> >>  > -Anand
> >>  >
> >>  >
> >>  >
> >>  >
> >>  >
> >>  > On 6/28/17, 12:06 AM, "Matt Foley"  wrote:
> >>  >
> >>  > >This is a call to vote on releasing this rc4 as “Apache Metron
> 0.4.0”.
> >>  > >(Note: this is rc4 because the release candidate needed to be
> modified
> >>  > with another commit after the rc3 tag was pushed to public.)
> >>  > >
> >>  > >Full list of changes in this release:
> >>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-
> RC4/RELEASE_NOTES
> >>  > >
> >>  > >The tag/commit to be voted upon is:
> >>  > >d52f574f8294e453ecad3871526858a0c3c2033d (tag
> apache-metron-0.4.0-rc4)
> >>  > >
> >>  > >The source archive being voted upon can be found here:
> >>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-
> >>  > RC4/apache-metron-0.4.0-rc4.tar.gz
> >>  > >and in github at:
> >>  > >https://github.com/apache/metron/tree/Metron_0.4.0
> >>  > >
> >>  > >Other release files, signatures and digests can be found here:
> >>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-RC4/KEYS
> >>  > >
> >>  > >The release artifacts are signed with the following key:
> >>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-RC4/KEYS
> >>  > >pub rsa4096/4169AA27ECB31663 2011-07-31 [SCEA]
> >>  > >Key fingerprint = 7854 36A7 8258 6B71 829C 67A0 4169 AA27 ECB3
> 1663
> >>  > >uid = Matthew Foley (CODE SIGNING KEY) 
> >>  > >
> >>  > >Please vote on releasing this package as Apache Metron 0.4.0.
> >>  > >When voting, please list the actions taken to verify the
> release.
> >>  > >
> >>  > >Recommended build validation and verification instructions are
> posted
> >>  > here:
> >>  > >https://cwiki.apache.org/confluence/display/METRON/
> Verifying+Builds
> >>  > >
> >>  > >This vote will be open for at least 72 hours. Please vote one
> of the
> >>  > following responses:
> >>  > >+1 Release this package as Apache Metron 0.4.0-RC4
> >>  > >0 No opinion
> >>  > >-1 Do not release this package because...
> >>  > >
> >>  > >Thank you,
> >>  > >--Matt
> >>  > >(your friendly release manager)
> >>  > >
> >>  > >
> >>  > >
> >>  >
>
> ---
> Thank you,
>
> James Sirota
> PPMC- Apache Metron (Incubating)
> jsirota AT apache DOT org
>
>
>
>

Re: [VOTE] Apache Metron 0.4.0 release

[Matt Foley]

Hey all, we need more votes!

So far we have 6 +1’s (including mine) and no 0’s or -1’s.
BUT, only two are binding, ie from PMC members.
Rules require 3 or more PMC member +1’s.  Could one more 
member please step up and vote?

Thanks!
--Matt

On 6/29/17, 3:00 PM, "James Sirota"  wrote:

+1 (Binding)

* Verified Keys
* Verified mvn clean install completed successfully
* Verified AWS install of core via Mpack


29.06.2017, 09:14, "Justin Leet" :
> +1 (Non-binding)
>
> * Verified Keys
> * Verified mvn clean install completed successfully
> * Ran full dev: saw data flow through, ran a couple of the REST APIs, and
> opened up and clicked through a bit of the Management API.
> * Examined site-book and didn't see any issues
>
> On Thu, Jun 29, 2017 at 11:46 AM, Casey Stella  wrote:
>
>>  +1 (binding)
>>  * Verified keys
>>  * Verified mvn build
>>  * Verified unit and integration tests run
>>  * Verified license check runs
>>  * Verified fulldev spun up with smoketest
>>
>>  On Wed, Jun 28, 2017 at 8:10 PM, Anand Subramanian <
>>  asubraman...@hortonworks.com> wrote:
>>
>>  > +1 (non-binding)
>>  >
>>  > * Brought up Metron stack on 12-node CentOS7 openstack cluster
>>  > * Verify all services come up fine [PASS]
>>  > * Bro, YAF and snort - ingest into respective kafka topics and write
>>  > indices [PASS]
>>  > * Add squid telemetry, ingest into kafka topic and write indices 
[PASS]
>>  > * Metron YAF Zeppelin dashboard with sample ingested YAF data [PASS]
>>  > * Management UI and REST Swagger UI sanity check [PASS]
>>  >
>>  >
>>  > -Anand
>>  >
>>  >
>>  >
>>  >
>>  >
>>  > On 6/28/17, 12:06 AM, "Matt Foley"  wrote:
>>  >
>>  > >This is a call to vote on releasing this rc4 as “Apache Metron 
0.4.0”.
>>  > >(Note: this is rc4 because the release candidate needed to be 
modified
>>  > with another commit after the rc3 tag was pushed to public.)
>>  > >
>>  > >Full list of changes in this release:
>>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-RC4/RELEASE_NOTES
>>  > >
>>  > >The tag/commit to be voted upon is:
>>  > >d52f574f8294e453ecad3871526858a0c3c2033d (tag 
apache-metron-0.4.0-rc4)
>>  > >
>>  > >The source archive being voted upon can be found here:
>>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-
>>  > RC4/apache-metron-0.4.0-rc4.tar.gz
>>  > >and in github at:
>>  > >https://github.com/apache/metron/tree/Metron_0.4.0
>>  > >
>>  > >Other release files, signatures and digests can be found here:
>>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-RC4/KEYS
>>  > >
>>  > >The release artifacts are signed with the following key:
>>  > >https://dist.apache.org/repos/dist/dev/metron/0.4.0-RC4/KEYS
>>  > >pub rsa4096/4169AA27ECB31663 2011-07-31 [SCEA]
>>  > >Key fingerprint = 7854 36A7 8258 6B71 829C 67A0 4169 AA27 ECB3 1663
>>  > >uid = Matthew Foley (CODE SIGNING KEY) 
>>  > >
>>  > >Please vote on releasing this package as Apache Metron 0.4.0.
>>  > >When voting, please list the actions taken to verify the release.
>>  > >
>>  > >Recommended build validation and verification instructions are posted
>>  > here:
>>  > >https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds
>>  > >
>>  > >This vote will be open for at least 72 hours. Please vote one of the
>>  > following responses:
>>  > >+1 Release this package as Apache Metron 0.4.0-RC4
>>  > >0 No opinion
>>  > >-1 Do not release this package because...
>>  > >
>>  > >Thank you,
>>  > >--Matt
>>  > >(your friendly release manager)
>>  > >
>>  > >
>>  > >
>>  >

--- 
Thank you,

James Sirota
PPMC- Apache Metron (Incubating)
jsirota AT apache DOT org

[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

[ottobackwards]

Github user ottobackwards closed the pull request at:

https://github.com/apache/metron/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: METRON-1004 Build improvements are in master

[Michael Miklavcic]

My branch before your changes
Ran for 49 min 59 sec

My branch after
Ran for 26 min 51 sec

You guys are my hero, great job!

Best,
Mike


On Fri, Jun 30, 2017 at 8:11 AM, Justin Leet  wrote:

> METRON-1004 was made to address several issues we were having with the
> Travis builds.  Specifically that the builds went on too long.
>
> After the merge into master, builds should be more consistent, stable, and
> take about 25-30 minutes.
>
> Please merge master into PRs if you are experiencing issues getting stable
> Travis builds.  Feel free to reach out to me if any assistance is needed.
>
> A short summary of the highlights.
>
> * Moving Travis to a VM build, which improves stability and lowers variance
> across builds
> * Reusing test infrastructure across tests, to avoid spinup/spindown costs
> * A variety of tests have been refactored for performance.  For example,
> the parser tests have been modified to be less full integration test for
> each individual parser.
> * Hopefully stopping the infamous Storm slot issue that killed builds.
> * Fixing an intermittent bug involving a Spring interaction with Kafka.
>
> See https://github.com/apache/metron/pull/624 for more details.
>

METRON-1004 Build improvements are in master

[Justin Leet]

METRON-1004 was made to address several issues we were having with the
Travis builds.  Specifically that the builds went on too long.

After the merge into master, builds should be more consistent, stable, and
take about 25-30 minutes.

Please merge master into PRs if you are experiencing issues getting stable
Travis builds.  Feel free to reach out to me if any assistance is needed.

A short summary of the highlights.

* Moving Travis to a VM build, which improves stability and lowers variance
across builds
* Reusing test infrastructure across tests, to avoid spinup/spindown costs
* A variety of tests have been refactored for performance.  For example,
the parser tests have been modified to be less full integration test for
each individual parser.
* Hopefully stopping the infamous Storm slot issue that killed builds.
* Fixing an intermittent bug involving a Spring interaction with Kafka.

See https://github.com/apache/metron/pull/624 for more details.

[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/586
  
+1. I'm good with the most recent changes, pending Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/586
  
Should be good to go now, pending Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #586: METRON-508 [DO NOT MERGE UNTIL METRON-1004] Expand Elasti...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/586
  
@JonZeolla 1004 is in, but there's been a few changes in, so I'd ask that 
you double check that things still line up as expected.  I'm going to look back 
through the changes this morning on here this morning, now that Travis actually 
works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #624: METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

[merrimanr]

Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/624
  
+1.  Really nice job guys.  Looking forward to working builds again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125037580
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I agree with everything that's been said


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403

[GitHub] metron issue #624: METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/624
  
I am +1 on these changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: METRON-1004: Travis CI - Job Exceeded Maximum Time...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125009044
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -148,6 +150,15 @@ public void stop() {
 
   @Before
   public void setup() throws Exception {
+runner = new ComponentRunner.Builder()
+.withComponent("kafka", kafkaWithZKComponent)
+.withCustomShutdownOrder(new String[]{"kafka"})
+.build();
+try {
+  runner.start();
+} catch (UnableToStartException e) {
+  e.printStackTrace();
--- End diff --

I forgot this was in a run().  I changed it to a runtime exception, like 
you originally suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125007939
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

no, I think we've done enough.  We, honestly, need a test guidance document 
similar to the parser testing document that I created as part of this ticket.  
It's become evident from this exercise that we can provide some over-arching 
guidance here to limit the probability of us arriving in this situation again.  
But that's a follow-on, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125007493
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I'm going to add a comment specifically pointing to that ticket, and noting 
that this test is an outlier in terms of how we actually test.

@cestella Is there anything else in particular that you'd like to see in 
order to at least mitigate risk of propagating test issues like this until we 
upgrade spring?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

[iraghumitra]

Github user iraghumitra commented on the issue:

https://github.com/apache/metron/pull/620
  
@merrimanr sounds good I will map the field's as they are today. Can you 
take another pass at it and let me know if it looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124998536
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I looked at it a bit this morning and @justinleet is right, it's not easily 
done.  I'm not super happy about spinning up and down components per test-case 
considering the bulk of this PR has been around removing exactly that.  That 
being said, the test is ~20s, so I'm not going to lose any sleep over it on 
that regard.

I think the part that I don't like most is the mixture of semantics between 
Spring's wiring of components and JUnit's setting up of components that we 
can't mix and match.  It leaves a muddle, frankly:
* If someone needs more heavy-weight components in other tests in this 
project, they will be *forced* into spinning up and down infrastructure per 
test-case, which has proven costly and was a prominent thing that we targeted 
in this PR for removal.
* Our approach leaves us doing component reuse in a way that is neither 
standard based on the other components *nor* standard based on spring, which is 
confusing and will inevitably lead to inefficient and confusing tests.

There is evidently a fix from spring 
[here](https://github.com/spring-projects/spring-kafka/issues/194) and I'm 
creating [METRON-1009](https://issues.apache.org/jira/browse/METRON-1009) to 
capture the reversion of this unit test and uptaking the fix provided by spring.

@merrimanr is right, it's not a requirement to get this perfect as long as 
we've removed the intermittent nature of the test failure (and I feel we have). 
 It's not so bad that I am -1, but it's ugly, confusing and it will lead to 
errors in the future IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/624
  
NC


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---