[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125172735
  
--- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec 
---
@@ -274,6 +276,23 @@ This package installs the Metron Indexing files
 %{metron_home}/config/zeppelin/metron/metron-ip-report.json
 %{metron_home}/config/zeppelin/metron/metron-connection-volume-report.json
 
+# 
~~


--- End diff --

I still can't see what you mean, I will take your word for it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

2017-07-01 Thread JonZeolla
Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/586
  
I spotted a duplicate in taking a scan of the template, so I ran `grep '": 
{' 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template
 | sort | uniq -c | grep -v 1` to make sure that was the only one.  I fixed it 
and pushed things up, along with other minor tweaks - Travis was successful so 
I plan to merge soon.  I also put some thoughts for a follow-on PR in 
[METRON-1010](https://issues.apache.org/jira/browse/METRON-1010).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125172441
  
--- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec 
---
@@ -274,6 +276,23 @@ This package installs the Metron Indexing files
 %{metron_home}/config/zeppelin/metron/metron-ip-report.json
 %{metron_home}/config/zeppelin/metron/metron-connection-volume-report.json
 
+# 
~~


--- End diff --

See [here](https://github.com/ottobackwards/metron/pull/4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125169385
  
--- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec 
---
@@ -274,6 +276,23 @@ This package installs the Metron Indexing files
 %{metron_home}/config/zeppelin/metron/metron-ip-report.json
 %{metron_home}/config/zeppelin/metron/metron-connection-volume-report.json
 
+# 
~~


--- End diff --

I don't have that in my editor, do you have it in vim or something?  or is 
it just from what you see on the web?

line 279?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #627: METRON-1007 ambari integration for metron-management

2017-07-01 Thread JonZeolla
Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/627
  
+1 via inspection, pending my final outstanding comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125169079
  
--- Diff: metron-platform/metron-management/README.md ---
@@ -244,10 +244,12 @@ The functions are split roughly into a few sections:
   * Returns: The String representation of the enrichment config
 
 ## Deployment Instructions
-
-Deployment is as simple as dropping the jar created by this project into
-`$METRON_HOME/lib` and starting the Stellar shell via
-`$METRON_HOME/bin/stellar`
+* Ambari
--- End diff --

ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125169027
  
--- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec 
---
@@ -274,6 +276,23 @@ This package installs the Metron Indexing files
 %{metron_home}/config/zeppelin/metron/metron-ip-report.json
 %{metron_home}/config/zeppelin/metron/metron-connection-volume-report.json
 
+# 
~~


--- End diff --

I am sorry I don't know what you mean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron pull request #627: METRON-1007 ambari integration for metron-manageme...

2017-07-01 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request:

https://github.com/apache/metron/pull/627#discussion_r125166333
  
--- Diff: metron-platform/metron-management/README.md ---
@@ -244,10 +244,12 @@ The functions are split roughly into a few sections:
   * Returns: The String representation of the enrichment config
 
 ## Deployment Instructions
-
-Deployment is as simple as dropping the jar created by this project into
-`$METRON_HOME/lib` and starting the Stellar shell via
-`$METRON_HOME/bin/stellar`
+* Ambari
--- End diff --

More detail would be helpful here.  Perhaps "Clusters installed via the 
Ambari management pack (default)" and "Manual installation"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #627: METRON-1007 ambari integration for metron-management

2017-07-01 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/metron/pull/627
  
+1 (inspection). Nice one, Otto, thanks. Just bumped into this yesterday. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #627: METRON-1007 ambari integration for metron-management

2017-07-01 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/627
  
@JonZeolla the name should be all set.  Any other feedback?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---