[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/883
  
@JonZeolla Yes, I did. No idea what I was thinking, in all honesty.

@nickwallen You're the actual person I wanted here.




---

Re: [DISCUSS] Removing Markdown files from rat exclusion

[Justin Leet]

I've updated the PR to add the header to a new MD file that went in.

I've also commented on all PRs that I saw that would potentially be
problematic were they to go into master if they weren't merged first.

Once the updated PR gets the +1's reaffirmed, it will be merged into master
and Markdown headers will be enforced properly going forwad.

On Sun, Dec 24, 2017 at 8:09 PM, Justin Leet  wrote:

> I'm gonna let this percolate until Wednesday or so, assuming conversation
> doesn't reach a natural tipping point.  I'm inclined to agree with Nick,
> but I also don't want to resolve anything in a way that even potentially
> causes master problems until at least after Christmas has a chance to
> settle down for people.  At that point, assuming current course, I'll take
> a real run through of the PRs (and leave comments as appropriate, before
> merging.
>
> Obviously if anyone has suggestions or alternatives, still feel encouraged
> to respond.
>
> On Sat, Dec 23, 2017 at 11:17 AM, Nick Allen  wrote:
>
>> > This would result in master breaking (although it's a pretty easy fix).
>>
>> I am not concerned and don't think we need to wait on merging PR #883.
>>
>> Can you add a comment to each of the PRs that you identified?  We can make
>> sure that each gets merged with master before they go in.
>>
>>
>>
>> On Sat, Dec 23, 2017 at 11:08 AM, Justin Leet 
>> wrote:
>>
>> > I have a PR currently out (https://github.com/apache/metron/pull/883)
>> that
>> > removes the rat exclusion on Markdown files. There was a discuss thread
>> > awhile back about adding the header and removing the exclusion where it
>> was
>> > agreed that we should do this to meet Apache requirements.
>> Unfortunately,
>> > it didn't get any follow on.
>> >
>> > Right now the PR has two +1s, but it could potentially be problematic
>> with
>> > existing PRs.
>> >
>> > Any PR that meets two conditions could potentially be problematic
>> > 1. It adds a new Markdown file
>> > 2. Travis was run before the exclusion PR was merged.
>> >
>> > This is because whoever does the merge might not realize that master
>> should
>> > be merged in and the markdown file updated with the Apache header.  This
>> > would result in master breaking (although it's a pretty easy fix).
>> >
>> > Are we okay with merging this now/soon, or do we want to take additional
>> > steps to ensure we don't run into issues? If we want, I can run through
>> the
>> > PRs and add comments before merging.  Is this sufficient to at least
>> > mitigate the most obvious problems?
>> >
>> > I took a very quick glance through some of the most recent PRs and only
>> two
>> > really stood out to me (although I'm sure there are older ones that are
>> > still being worked on or looked at)
>> >
>> > METRON-1380 https://github.com/apache/metron/pull/882 - Adds a new
>> > markdown
>> > file, but Travis failed. If it gets fixed before this PR is merged we
>> could
>> > run into the problem
>> > METRON-1351 https://github.com/apache/metron/pull/868 - Adds a new
>> > markdown
>> > file and Travis succeeded. This would break master if merged as-is
>> after my
>> > PR.
>> >
>>
>
>

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/785#discussion_r159122619
  
--- Diff: metron-platform/metron-parsers/3rdPartyParser.md ---
@@ -0,0 +1,306 @@
+# Custom Metron Parsers
--- End diff --

Not sure what the state of this is, but if we're going to merge this as a 
stop-gap to 777, could you add the license header here?

```

```


---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/883
  
Did you mean to tag @nickwallen in that last comment?  I took a quick look 
and it all looks good to me but didn't do any verification that you got all of 
the md files (depending on Travis), and didn't spin up the site-book.


---

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/840#discussion_r159122591
  
--- Diff: metron-deployment/README.md ---
@@ -1,3 +1,16 @@
+# Metron Deployment
--- End diff --

Can you please add the license header to this? 
https://github.com/apache/metron/pull/884 is close to going in and enforcing 
this, so I'm hoping to avoid impact to master.

```

```


---

[GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/865
  
Given that this is a feature branch, I'm sure master will be merged in, but 
as a reminder, markdown file headers will be enforced by rat relatively soon 
(so any new markdown files in here will need it when master is merged.  For 
reference it's:

```

```


---

[GitHub] metron pull request #882: METRON-1380: Create a typosquatting use-case (comm...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/882#discussion_r159122512
  
--- Diff: use-cases/typosquat_detection/README.md ---
@@ -0,0 +1,431 @@
+# Problem Statement
--- End diff --

Can you please add the license header to this? 
https://github.com/apache/metron/pull/884 is close to going in and enforcing 
this, so I'm hoping to avoid impact to master.

```

```


---

[GitHub] metron pull request #884: METRON-1382 Run Stellar in a Zeppelin Notebook

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/884#discussion_r159122504
  
--- Diff: metron-stellar/stellar-zeppelin/README.md ---
@@ -0,0 +1,85 @@
+# Stellar Interpreter for Apache Zeppelin
+
+[Apache Zeppelin](https://zeppelin.apache.org/) is a web-based notebook 
that enables data-driven, interactive data analytics and collaborative 
documents with SQL, Scala and more.  This project provides a means to run the 
Stellar REPL directly within a Zeppelin Notebook.
+
+## Installation
--- End diff --

Can you please add the license header to this? 
https://github.com/apache/metron/pull/884 is close to going in and enforcing 
this, so I'm hoping to avoid impact to master.

```

```


---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/883
  
@ottobackwards @JonZeolla Merged in master and added header to new markdown 
file (the deb deployment one).  Once you two are satisfied with the new commit, 
and I've run through the outstanding PRs for potentially problematic ones, I'm 
good with merging this in.


---