[GitHub] metron pull request #957: METRON-1482: Update REST to work with Solr

[merrimanr]

GitHub user merrimanr opened a pull request:

https://github.com/apache/metron/pull/957

METRON-1482: Update REST to work with Solr

## Contributor Comments
This PR updates the REST start script to properly include the correct 
indexing jar on the classpath depending on the configured indexing writer 
(Elasticsearch or Solr).  To test this:

1. Spin up full dev and follow the instructions for manually installing 
Solr:  
https://github.com/apache/metron/tree/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr#installing.
 
2. Change the Index Writer to "Solr" in Ambari (Metron > Indexing tab) and 
restart the Indexing component.
3. Verify data is landing in the Solr collections
4. Restart the REST component in Ambari
5. You should be able to execute search queries in Swagger

I had to include a stubbed SolrMetaAlertDao class that doesn't do anything 
to get everything to start up.  This will eventually be replaced by the work 
being done in https://issues.apache.org/jira/browse/METRON-1421.  I also fixed 
a bug in the SolrDao that was causing in issue in the Alerts UI.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/merrimanr/incubator-metron solr-rest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #957


commit 6bb30af9d2005414e3ee44c0bdb0ea14540ce13c
Author: cstella 
Date:   2018-02-01T21:33:56Z

METRON-1441: Create complementary Solr schemas for the main sensors

commit f4ff0c401eff23d9c1b2ca3b264bd9b0d4e8f381
Author: cstella 
Date:   2018-02-01T21:47:12Z

Updating dao

commit 7e2ecb0f2f55ea16529128fec14920bc2a546b07
Author: cstella 
Date:   2018-02-02T21:43:38Z

Migrated data to files, renamed test and added yaf and error.

commit 2aacd202ff1a2ebcbeb30300b30d080391cfe1cf
Author: cstella 
Date:   2018-02-02T21:45:08Z

Merge branch 'feature/METRON-1416-upgrade-solr' into SOLR_METRON-1441

commit 

[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...

[merrimanr]

Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/949
  
I still see a SHUFFLE grouping (spout -> enrichmentSplit) in the legacy 
enrichment topology flux file.  Maybe we end up switching to the new enrichment 
topology so not important in that case.


---

[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/946
  
@wardbekker Did you test this with Kibana by chance? I'm seeing 
authentication exceptions in the Kibana UI. Looks like we need additional steps 
for it to work - 
https://www.elastic.co/guide/en/kibana/5.6/installing-xpack-kb.html


---

[GitHub] metron pull request #956: METRON-1474 Add normalizecss

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/956

METRON-1474 Add normalizecss

## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge 
the differences between browsers.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1474](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1474

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #956


commit 61e342b89d8ba7554d3679556969c09a37f575c8
Author: Daniel Toth 
Date:   2018-03-07T21:53:14Z

Add normalize.css to frontend projects




---

[GitHub] metron pull request #955: METRON-1474 Add normalizecss

[xyztdanid4]

Github user xyztdanid4 closed the pull request at:

https://github.com/apache/metron/pull/955


---

[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...

[merrimanr]

Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/949
  
There are also shuffle groupings in the enrichment and profiler topologies. 
 Do we want to update those too?


---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

[merrimanr]

Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/952
  
I think we are on board with switching to yarn so no concerns there.  There 
was a discussion on it but if anyone now feels differently, speak up.

Sounds like we still have a lot of work to do.  I would suggest reviewing 
the metron-config and metron-alerts READMEs and update them appropriately.  In 
fact, I would just search the whole project for npm commands and switch to yarn 
as needed.  You will definitely need to run this up in full dev and verify 
everything works.

Our maven front end plugin will also need to be reviewed and updated:  
https://github.com/eirslett/frontend-maven-plugin.  We use that in 
metron-config and metron-alerts.


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172937150
  
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
 "@angular/platform-browser": "2.0.0",
 "@angular/platform-browser-dynamic": "2.0.0",
 "@angular/router": "3.0.0",
+"@types/ace": "0.0.32",
--- End diff --

No I was just curious.  If Yarn did this automatically we might as well 
leave it that way.  No need to revert.


---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/952
  
@merrimanr 
although it should work with npm as well, cause then it will use the 
package.json to install the dependencies.


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[xyztdanid4]

Github user xyztdanid4 commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172936489
  
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
 "@angular/platform-browser": "2.0.0",
 "@angular/platform-browser-dynamic": "2.0.0",
 "@angular/router": "3.0.0",
+"@types/ace": "0.0.32",
--- End diff --

Yes. I was not enough carefully. Yarn did the rearrangement, but I can move 
the dependencies back to their original place if you would like to.


---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/952
  
@merrimanr 
Yes this is the right way to switch to yarn.
Yes we have install yarn locally.
I did not know that we have so much dependency on npm. But for me it was 
hard to add new dependencies using npm, cause it was constantly failing. And 
yes I would recommend to use yarn, at least for the front end builds. What yarn 
does is that reduces the possibility of version mismatch  of the dependencies 
by importing the dependencies subdependency in the right version. So yes we 
have to use yarn commands if we merge this PR.


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172934046
  
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
 "@angular/platform-browser": "2.0.0",
 "@angular/platform-browser-dynamic": "2.0.0",
 "@angular/router": "3.0.0",
+"@types/ace": "0.0.32",
--- End diff --

What was the reason for rearranging the dependencies?  It's not a big deal 
but it's distracting and makes reviewing harder.


---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/952
  
@merrimanr


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[xyztdanid4]

Github user xyztdanid4 commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172932830
  
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
 "@angular/platform-browser": "2.0.0",
 "@angular/platform-browser-dynamic": "2.0.0",
 "@angular/router": "3.0.0",
+"@types/ace": "0.0.32",
--- End diff --

No there were no changes other than rearrange of the dependencies.
About the main attribute, in our case it will do nothing. It defines the 
entry point of the application if we would SystemJS or requireJS. It is the 
default setting for yarn.


---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

[merrimanr]

Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/952
  
I'm having trouble understanding what this PR actually does.  I see that 
package-lock.json was removed and yarn.lock was added.  Is that all that's 
needed to switch to yarn?  Do we need to also update our build commands to 
match those [here](https://yarnpkg.com/en/docs/usage)?

What considerations are there for development?  Are we supposed to be using 
yarn commands now instead of npm commands?  Do we need to install yarn locally? 
 We probably need to review our documentation and rpm build processes too.  We 
use npm all over the place.


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172927751
  
--- Diff: metron-interface/metron-alerts/package.json ---
@@ -27,8 +27,8 @@
 "core-js": "^2.4.1",
 "font-awesome": "^4.7.0",
 "moment": "^2.18.1",
-"pikaday-time": "^1.6.1",
 "ng2-dragula": "^1.5.0",
+"pikaday-time": "^1.6.1",
--- End diff --

See comment for metron-config/package.json.


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172927486
  
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
 "@angular/platform-browser": "2.0.0",
 "@angular/platform-browser-dynamic": "2.0.0",
 "@angular/router": "3.0.0",
+"@types/ace": "0.0.32",
--- End diff --

Were there any real changes made to this file?  It looks like some 
dependencies were simply rearranged.  I do see the addition of `"main": 
"index.js"`.  What is the purpose of that?


---

[GitHub] metron pull request #947: METRON-1467: Replace guava caches in places where ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/947


---

[GitHub] metron issue #947: METRON-1467: Replace guava caches in places where the key...

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/947
  
+1 LGTM


---

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

[xyztdanid4]

Github user xyztdanid4 commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172879403
  
--- Diff: metron-interface/metron-alerts/package-lock.json ---
@@ -1,6427 +0,0 @@
-{
--- End diff --

I think that was the problem!
Thanks. @cestella 


---

[GitHub] metron issue #945: METRON-1464: Convert schemas to be compatible with Solr 5...

[simonellistonball]

Github user simonellistonball commented on the issue:

https://github.com/apache/metron/pull/945
  
To be fair, my question is probably just as appropriate on a discuss thread 
and a separate ticket out of said thread if it comes to it.


---

[GitHub] metron pull request #947: METRON-1467: Replace guava caches in places where ...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/947#discussion_r172870992
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
 ---
@@ -89,29 +91,25 @@ public void prepare(Map map, TopologyContext 
topologyContext, OutputCollector ou
 if (this.maxTimeRetain == null) {
   throw new IllegalStateException("maxTimeRetain must be specified");
 }
-loader = new CacheLoader>() {
-  @Override
-  public Map load(String key) throws Exception {
-return new HashMap<>();
-  }
-};
-cache = CacheBuilder.newBuilder().maximumSize(maxCacheSize)
-.expireAfterWrite(maxTimeRetain, 
TimeUnit.MINUTES).removalListener(new JoinRemoveListener())
-.build(loader);
+loader = s -> new HashMap<>();
+cache = Caffeine.newBuilder().maximumSize(maxCacheSize)
+ .expireAfterWrite(maxTimeRetain, TimeUnit.MINUTES)
+ .removalListener(new JoinRemoveListener())
--- End diff --

So, I believe this was intentionally done before this PR (I migrated this 
to the new caching strategy) and the idea is that if a removal is happening 
from the join cache under specific circumstances, we want to know about it 
because a message could be being dropped because the cache is being 
overwhelmed.  @merrimanr Can you chime in here on the rationale?


---

[GitHub] metron pull request #947: METRON-1467: Replace guava caches in places where ...

[nickwallen]

Github user nickwallen commented on a diff in the pull request:

https://github.com/apache/metron/pull/947#discussion_r172866140
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
 ---
@@ -89,29 +91,25 @@ public void prepare(Map map, TopologyContext 
topologyContext, OutputCollector ou
 if (this.maxTimeRetain == null) {
   throw new IllegalStateException("maxTimeRetain must be specified");
 }
-loader = new CacheLoader>() {
-  @Override
-  public Map load(String key) throws Exception {
-return new HashMap<>();
-  }
-};
-cache = CacheBuilder.newBuilder().maximumSize(maxCacheSize)
-.expireAfterWrite(maxTimeRetain, 
TimeUnit.MINUTES).removalListener(new JoinRemoveListener())
-.build(loader);
+loader = s -> new HashMap<>();
+cache = Caffeine.newBuilder().maximumSize(maxCacheSize)
+ .expireAfterWrite(maxTimeRetain, TimeUnit.MINUTES)
+ .removalListener(new JoinRemoveListener())
--- End diff --

It seems like we only want notified of a full cache when ERROR logging is 
set. Is that the case? In the `JoinRemoveListener` we end up doing some work 
that we probably don't need to do unless ERROR logging is set.  One easy fix 
would be to only add the "remove listener" if `LOG.isDebugEnabled()`.


---

[GitHub] metron issue #945: METRON-1464: Convert schemas to be compatible with Solr 5...

[cestella]

Github user cestella commented on the issue:

https://github.com/apache/metron/pull/945
  
@merrimanr you ran this up in Solr 5.5 as well as 6.6, right?  If so, then 
I'm content with the change and give a +1 pending (other than holding for an 
answer to Simon's question, which I was wondering as well).



---

[GitHub] metron pull request #952: Metron-1480 Add yarn as default build tool for the...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/952#discussion_r172858774
  
--- Diff: metron-interface/metron-alerts/package-lock.json ---
@@ -1,6427 +0,0 @@
-{
--- End diff --

I suspect the build failure is due to a lack of a license on this file.  
Since JSON cannot take comments, you'll need to adjust the top level pom to add 
an exclusion for `**/package-lock.json` 
[here](https://github.com/apache/metron/blob/master/pom.xml#L304)  Just make a 
quick comment above it and note that this is yarn collateral.


---

[GitHub] metron pull request #944: METRON-1463: Adjust the groupings and shuffles in ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/944


---

[GitHub] metron pull request #940: METRON-1460: Create a complementary non-split-join...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/940


---

[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/952
  
@simonellistonball I am not sure. Probably no.


---

[GitHub] metron issue #955: METRON-1474 Add normalizecss

[simonellistonball]

Github user simonellistonball commented on the issue:

https://github.com/apache/metron/pull/955
  
Have the dependencies, License and Notices files been updated?


---

[GitHub] metron issue #953: Metron-1472 Add stylelint support

[simonellistonball]

Github user simonellistonball commented on the issue:

https://github.com/apache/metron/pull/953
  
Have the dependencies, License and Notices files been updated?


---

[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...

[simonellistonball]

Github user simonellistonball commented on the issue:

https://github.com/apache/metron/pull/952
  
Have the dependencies, License and Notices files been updated?


---

[GitHub] metron pull request #955: METRON-1474 Add normalizecss

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/955

METRON-1474 Add normalizecss

THIS IS WIP. FIRST #952 SHOULD BE MERGED.
## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge 
the differences between browsers.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1474](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1474

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #955


commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth 
Date:   2018-03-07T10:40:01Z

Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth 
Date:   2018-03-07T11:47:50Z

Update ts to avoid 'app module is not an ng module error on build'

commit c4bef1662835051db430d657b479691f137d34ec
Author: Daniel Toth 
Date:   2018-03-07T13:44:29Z

Add normalize css to the frontend




---

[GitHub] metron pull request #954: METRON-1478 Move type definitions to dev-dependenc...

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/954

METRON-1478 Move type definitions to dev-dependencies

## Contributor Comments
Types definitions should not be in dependencies. I moved them to 
dev-dependencies.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1478](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1478

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #954


commit c4c495a6df1ad860bc35b77f7a0f8a48b129d024
Author: Daniel Toth 
Date:   2018-03-07T12:51:51Z

Move type definitions to dev-dependencies




---

[GitHub] metron pull request #953: Metron 1472 Add stylelint support

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/953

Metron 1472 Add stylelint support

THIS IS WIP. FIRST #952 SHOULD MERGED.

Added support for stylelint to be able to validate scss syntax.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1472](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #953


commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth 
Date:   2018-03-07T10:40:01Z

Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth 
Date:   2018-03-07T11:47:50Z

Update ts to avoid 'app module is not an ng module error on build'

commit f5a8521552db0a3f0b5e7c11ff26c42241edf5d4
Author: Daniel Toth 
Date:   2018-03-07T12:30:37Z

Add stlyelint support




---

[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/951
  
@ottobackwards 
In my next PR the build tool will change to yarn. So package.json will be 
gone soon, and replaced by yarn.lock which is smaller of course.


---

[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...

[xyztdanid4]

Github user xyztdanid4 commented on the issue:

https://github.com/apache/metron/pull/951
  
@ottobackwards 
I am not sure, but the I guess this is the normal way of locking 
dependencies.


---

[GitHub] metron pull request #952: Metron-1480 Add yarn as default build tool for the...

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/952

Metron-1480 Add yarn as default build tool for the frontend

Updated the build tool to yarn for the frontend project to avoid npm 
instability during dependency adding.

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1480](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1480

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #952


commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth 
Date:   2018-03-07T10:40:01Z

Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth 
Date:   2018-03-07T11:47:50Z

Update ts to avoid 'app module is not an ng module error on build'




---

[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/951
  
Why are there so many changes to the package locks vs. to the package files 
themselves?


---

[GitHub] metron pull request #951: Metron-1479 Introduce editorconfig, and format all...

[xyztdanid4]

GitHub user xyztdanid4 opened a pull request:

https://github.com/apache/metron/pull/951

Metron-1479 Introduce editorconfig, and format all of the code in alerts 
and config projects

It is necessary to use editorconfig, code should be look like the same in 
all files.

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1479](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xyztdanid4/metron METRON-1479

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #951


commit f9c2a969d359e30cb55b5012757e22c32ce57e78
Author: Daniel Toth 
Date:   2018-03-07T08:34:13Z

Update gitignore

commit b0cfda918e574992c94e0c890b66ce83af772837
Author: Daniel Toth 
Date:   2018-03-07T08:35:03Z

Integrate editorconfig

commit 588ef781295de1b141cef7d4ca12a03a8606f2c5
Author: Daniel Toth 
Date:   2018-03-07T08:59:17Z

Format code of metron alerts

commit e36877357e14bf12ae8ae38a5491dbb6d219f32d
Author: Daniel Toth 
Date:   2018-03-07T10:15:59Z

Format metron config project




---