[GitHub] metron issue #732: METRON-632: Added validation of "shew.enrichmentType" and...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/732 Thank you! ---
[GitHub] metron issue #732: METRON-632: Added validation of "shew.enrichmentType" and...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/732 @cestella Could I possibly get this approved? Cheers ---
[GitHub] metron pull request #732: METRON-632: Added validation of "shew.enrichmentTy...
Github user zezutom commented on a diff in the pull request:
https://github.com/apache/metron/pull/732#discussion_r137960020
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java
---
@@ -134,6 +136,39 @@ public void configure(String sensorName,
WriterConfiguration configuration) {
LOG.debug("Sensor: '{}': {Provider: '{}', Converter: '{}'}",
sensorName, getClassName(provider), getClassName(converter));
}
+
+ private void validateEnrichmentType(String sensorName,
WriterConfiguration configuration) {
+Map sensorConfig =
configuration.getSensorConfig(sensorName);
+Object enrichmentTypeObj =
Configurations.ENRICHMENT_TYPE.get(sensorConfig);
+if (enrichmentTypeObj == null) {
+ throw new IllegalArgumentException(String.format("%s must be
provided", Configurations.ENRICHMENT_TYPE.getKey()));
+}
+
+if (!(enrichmentTypeObj instanceof String)) {
+ throw new IllegalArgumentException(String.format("%s must be a
string", Configurations.ENRICHMENT_TYPE.getKey()));
+}
+
+String enrichmentType = enrichmentTypeObj.toString();
+if (enrichmentType.trim().isEmpty()) {
+ throw new IllegalArgumentException(String.format("%s must not be an
empty string",
+ Configurations.ENRICHMENT_TYPE.getKey()));
+}
+ }
+
+ private void validateKeyColumns(String sensorName, WriterConfiguration
configuration) {
+Map sensorConfig =
configuration.getSensorConfig(sensorName);
+Object keyColumnsObj = Configurations.KEY_COLUMNS.get(sensorConfig);
+
+try {
+ List keyColumns = getColumns(keyColumnsObj, true);
+ if (keyColumns == null || keyColumns.isEmpty()) {
+throw new IllegalArgumentException(String.format("%s must be
provided", Configurations.KEY_COLUMNS.getKey()));
+ }
+} catch (RuntimeException ex) {
+ throw new IllegalArgumentException(ex.getMessage());
--- End diff --
Hi @cestella , thanks for the review. The second arg is now added, and yes
I did check hbase streaming worked in the full-dev cluster.
---
[GitHub] metron pull request #732: METRON-632: Added validation of "shew.enrichmentTy...
GitHub user zezutom opened a pull request:
https://github.com/apache/metron/pull/732
METRON-632: Added validation of "shew.enrichmentType" and "shew.keyCoâ¦
â¦lumns"
## Contributor Comments
[Please place any comments here. A description of the problem/enhancement,
how to reproduce the issue, your testing methodology, etc.]
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zezutom/metron METRON-632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #732
commit 979186f2bf4d3792e320199f96d87b3d1b39c6be
Author: zezutom
Date: 2017-09-03T12:06:18Z
METRON-632: Added validation of "shew.enrichmentType" and "shew.keyColumns"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/572 @justinleet I can't merge this PR, do you mind merging to master yourself? Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/572 @justinleet Will do, thanks for sorting out Travis! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/572 Thank you @cestella and sorry for the delay, now I am back to it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #572: METRON-633: Create better logging for HbaseEnrichm...
Github user zezutom commented on a diff in the pull request:
https://github.com/apache/metron/pull/572#discussion_r119730181
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java
---
@@ -169,16 +188,19 @@ public HTableInterface getTable(Map
config) throws IOException {
private List getColumns(Object keyColumnsObj, boolean allowNull)
{
Object o = keyColumnsObj;
if(allowNull && keyColumnsObj == null) {
+ LOG.debug("No key columns were specified");
return Collections.emptyList();
}
if(o instanceof String) {
+ LOG.debug("Key column: '" + o + "'");
--- End diff --
Thanks everyone for a great feedback! @justinleet I will rebase once #599
is merged, cheers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/572 Hey folks, this one has been open for a while. Could I please get some +1's? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #558: METRON-811: Enforce Maven Version in Top Level POM
Github user zezutom commented on the issue: https://github.com/apache/metron/pull/558 Thanks @ottobackwards. Anyone else, can I please get one more thumb up to get this PR over the line? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #572: METRON-633: Create better logging for Hb...
GitHub user zezutom opened a pull request: https://github.com/apache/incubator-metron/pull/572 METRON-633: Create better logging for HbaseEnrichmentWriter ## Contributor Comments I have added logging to critical paths, so that issues can be tracked down more easily. ## Pull Request Checklist In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zezutom/incubator-metron METRON-633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/572.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #572 commit d31ff93b24922341b6443a2e881973406d15bccc Author: zezutom Date: 2017-05-08T21:40:47Z Added debug / warn logs to critical paths, unit tests checking format of the captured logs. commit 3dc993e602721844e2c24d1631e61d4d56224375 Author: zezutom Date: 2017-05-08T22:50:16Z Adding license info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #571: METRON-633: Create better logging for Hb...
Github user zezutom closed the pull request at: https://github.com/apache/incubator-metron/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #571: METRON-633: Create better logging for HbaseEnri...
Github user zezutom commented on the issue: https://github.com/apache/incubator-metron/pull/571 The build is timing out for some reason, I will resubmit this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #571: METRON-633: Create better logging for Hb...
GitHub user zezutom reopened a pull request: https://github.com/apache/incubator-metron/pull/571 METRON-633: Create better logging for HbaseEnrichmentWriter ## Contributor Comments I have added logging to critical paths, so that issues can be tracked down more easily. ## Pull Request Checklist ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zezutom/incubator-metron METRON-633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/571.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #571 commit d31ff93b24922341b6443a2e881973406d15bccc Author: zezutom Date: 2017-05-08T21:40:47Z Added debug / warn logs to critical paths, unit tests checking format of the captured logs. commit 3dc993e602721844e2c24d1631e61d4d56224375 Author: zezutom Date: 2017-05-08T22:50:16Z Adding license info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #571: METRON-633: Create better logging for Hb...
Github user zezutom closed the pull request at: https://github.com/apache/incubator-metron/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #571: METRON-633: Create better logging for Hb...
GitHub user zezutom opened a pull request: https://github.com/apache/incubator-metron/pull/571 METRON-633: Create better logging for HbaseEnrichmentWriter ## Contributor Comments I have added logging to critical paths, so that issues can be tracked down more easily. ## Pull Request Checklist ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zezutom/incubator-metron METRON-633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/571.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #558: METRON-811: Enforce Maven Version in Top...
GitHub user zezutom opened a pull request: https://github.com/apache/incubator-metron/pull/558 METRON-811: Enforce Maven Version in Top Level POM ## Contributor Comments Enforcing Maven version >= 3.3.1 and Java 8 ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book bin/generate-md.sh mvn site:site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zezutom/incubator-metron METRON-811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/558.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #558 commit 840b8e361b6257ce735ce81485f58dfe1cb4bbda Author: zezutom Date: 2017-04-29T07:27:20Z Enforcing Maven version >= 3.3.1 and Java 8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #557: METRON-811: Enforce Maven Version in Top...
Github user zezutom closed the pull request at: https://github.com/apache/incubator-metron/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #557: METRON-811: Enforce Maven Version in Top...
GitHub user zezutom opened a pull request: https://github.com/apache/incubator-metron/pull/557 METRON-811: Enforce Maven Version in Top Level POM ## Contributor Comments Enforcing Maven version >= 3.3.1 and Java 8 ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book bin/generate-md.sh mvn site:site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zezutom/incubator-metron METRON-811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #557 commit 6d3309ac6683212ff5c608678bfd41ea287cc079 Author: zezutom Date: 2017-04-28T22:17:50Z Enforcing Maven version >= 3.3.1 and Java 8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
