[GitHub] metron issue #605: Metron-979 markdown errors in site-book

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/605
  
Go for it.  Just trying to make sure it got in under a documentation
related Jira without a ton of overhead.

Jon

On Fri, Jun 2, 2017, 6:23 PM Matt Foley  wrote:

> Hi @JonZeolla  , sorry if I moved too fast.
> I consider your patch to be a valuable contribution in its own right. 
Since
> it's non-intersecting with the changes I made, I hereby give it a +1 👍
> With your permission I'll commit it under the same jira, credited to you.
> If you prefer to do so yourself, let me know.
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>
-- 

Jon



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #605: Metron-979 markdown errors in site-book

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/605
  
@mattf-horton is correct, I am +1 on this. Thanks a lot for working on 
this, it's great to have.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #605: Metron-979 markdown errors in site-book

[mattf-horton]

Github user mattf-horton commented on the issue:

https://github.com/apache/metron/pull/605
  
Thanks, I'm going to take @JonZeolla  and @justinleet 's comments as +1s 
and get this in for 0.4.0.  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron issue #605: Metron-979 markdown errors in site-book

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/605
  
Opened a PR against your branch.  Generated the documentation and did a 
fair amount of manual review and couldn't find any broken code blocks, links, 
etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---