[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 I spun up master and this also occurs there. I'll create a JIRA for it. +1, thanks for the improvement! ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 This happens intermittently for me. An error in the dev tools when hitting `http://node1:4200/api/v1/storm/parser/start/bro` is: ``` (failed) net::ERR_EMPTY_RESPONSE ``` The response timing is "stalled", is it possible that it simply takes too long to come back? ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 Didn't see this happen while trying a second time time, or with snort and the logs don't seem to have anything interesting. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 Spun it up, noticed one other problem. Unfortunately, again, I'm not sure if it's preexisting due to unfamiliarity. I stopped the bro topology (which was successful), then I started it again. I got an error message about startup failing. However, startup succeeded and things appeared to pick up normally. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 @merrimanr You are absolutely right, my bad. Turns out I am illiterate in the morning. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 We don't have e2e tests for the management UI. We do have unit tests and I added tests for these fixes there. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 @merrimanr Are those fixes the sort of thing we can/should add e2e tests for? I know those are flaky, but it seems like we should be able to have semi-automated confirmation on the fixes. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 Yeah, 4 I'm definitely fine with being a separate PR. I'll spin this up again quick and take another look. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 @justinleet 1, 2, and 3 have been addressed with the latest commit. I also added a couple unit tests for good measure. I wasn't able to easily reproduce 4 so I didn't fix that one. It is not related to this at all and would probably make more sense in a separate bug fix PR. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 I believe 2 and 4 are preexisting but I'm happy to fix them here. Will update when I have resolved these issues. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 I took a swing through this, and generally this worked as expected. There were a couple things in full dev that I'm not sure if they were preexisting or not, just from unfamiliarity with how it worked before. If these things are preexisting, it might be worth a follow on task to clean up. 1. If I try to create a new sensor without a name, I get an error "Unable to save sensor config: Request method 'POST' not supported". We should be able to give a more informative error, and really it should be on the fly like validation like the Kafka topic name. 1. If a field is missing in a new sensor (e.g. topic or GROK statement), I get "Unexpected end of JSON input". This makes me worry there's a structural problem in the request, along with the lack of informative error. 1. The UI will happily let me try to recreate an existing sensor, and apparently executes an update. I would expect it to refuse to let me override an existing sensor. This includes on a running sensor, which is worrisome. 1. If we get a permission denied error while editing a parser (e.g. I tried to edit squid and hit HDFS permissions), we throw a giant stack trace on the screen. ---
[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 @merrimanr Can you deconflict this? This is otherwise ready for review, but it just needs to happen, right? ---
