[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 bump ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 ok, it is MAGIC_TIME! @simonellistonball ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 Plus it lets me get away with ```java public static final String MAGIC_TIME = "%time"; ``` so bonus ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 well, %timing seem to make sense to me, as it is the timing of the last statement. %time didn't occur to me. I don't use Jupyter, and don't time things in the shell that often. I am didn't really canvas other tools. I will change it. ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/873 One question: why %timing? I would vote for %time, but that might just be because I use too much jupyter and like the consistency. Am I missing another reference for the choice of timing? ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 bump ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 see the changes to LambdaExpression and StellarCompiler ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 Timing is integrated into the stellar execution, so it is taken before we execute named functions and lambdas. ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/873 How is the timing handled for nested structures such as `STARTS_WITH(TO_UPPER(DECODE(...)))`? Is the timing for STARTS_WITH exclusive of TO_UPPER and DECODE or inclusive? ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 This has been submitted to Commons Lang : https://github.com/apache/commons-lang/pull/311 The version there is refactored and also java 7 comparable ( so I had to lose Optional and Lambdas ). I will port over the changes later, don't let it stop your review ;) ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 If there are any ideas on improving the tags implementation I would love to here them ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
The last commit adds in the ability to tag timings, and to filter on those
tags in the shell when calling %timing.
LambdaExpressions are now timed as well. When Lambdas are used with
functions, you will see the 'nesting'
I will update the PR description
```
[Stellar]>>> foo:=1
[Stellar]>>> match { foo == 0 => ()-> false, foo == 1 => ()->
TO_UPPER("true"), default => ()-> false }
TRUE
[Stellar]>>> %timing
->execute[] : 4242ms : 4242237640ns
-->match { foo == 0 => ()-> false, foo == 1 => ()-> TO_UPPER("true"),
default => ()-> false }[] : 84ms : 84362570ns
--->lambda[LAMBDA] : 1ms : 1265895ns
>TO_UPPER[FUNCTION] : 0ms : 570672ns
[Stellar]>>> %timing FUNCTION
->execute[] : 7594ms : 7594583655ns
-->match { foo == 0 => ()-> false, foo == 1 => ()-> TO_UPPER("true"),
default => ()-> false }[] : 84ms : 84362570ns
>TO_UPPER[FUNCTION] : 0ms : 570672ns
[Stellar]>>> %timing LAMBDA
->execute[] : 14374ms : 14374556116ns
-->match { foo == 0 => ()-> false, foo == 1 => ()-> TO_UPPER("true"),
default => ()-> false }[] : 84ms : 84362570ns
--->lambda[LAMBDA] : 1ms : 1265895ns
```
NOTE:
---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 One idea for a follow on : add a 'tag' or 'type' similar to log.INFO log.DEBUG to the records, so that you can filter the output. ---
