[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/380 Closing this PR. About to open another one with the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 I think you closed the wrong one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/380 I was not happy with #381 . I will reopen it soon once I have a fix that I am happy with. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/380 Probably a dumb question, but doesn't integration-test run Failsafe? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/380 @JonZeolla - oh yeah, totally in agreement there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user JonZeolla commented on the issue: https://github.com/apache/incubator-metron/pull/380 @dlyle65535 while we slightly disagree on semantics, I agree that this should move forward for the short term. I'm primarily indicating that the dev guide needs updated to account for situations like this. I sent an email out to the [DISCUSS] thread a couple of minutes back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user JonZeolla commented on the issue: https://github.com/apache/incubator-metron/pull/380 Doesn't this conflict with the merge requirements on the draft [Coding Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) page? Specifically: * A patch that breaks tests, or **introduces regressions by changing or removing existing tests** should not be merged. Tests must always be passing on master. This implies that the tests have been run... I understand the current scenario means this isn't straightforward - perhaps that's an indication that the dev guidelines need updated to account for exceptions? Or maybe we take another tact to fix the issue. I'll shoot an email to the current [DISCUSS] thread regarding this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/380 Agreed, this should be changed in the pom. http://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 Configuration only change. So, let's say that there is another pr that changes that test, it can do so without worrying about the commented out code etc. not a big deal, really just curious --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/380 Dunno. What are the advantages to doing it that way? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 can this be done in the pom/surefire? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
