Re: [GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[Otto Fowler]

Actually, I’m going to run it again. disregard


On March 9, 2017 at 21:31:30, Otto Fowler (ottobackwa...@gmail.com) wrote:


Failed tests:

  BasicAsaParserTest.testIp6Addr:151 null

  GrokWebSphereParserTest.testParseLoginLine:60 expected:<14[92278]448000>
but was:<14[60742]448000>

  GrokWebSphereParserTest.testParseMalformedLoginLine:151
expected:<14[92278]448000> but was:<14[60742]448000>

  GrokWebSphereParserTest.tetsParseLogoutLine:84 expected:<14[92279]347000>
but was:<14[60743]347000>

  GrokWebSphereParserTest.tetsParseMalformedLogoutLine:175
expected:<14[92279]347000> but was:<14[60743]347000>

  GrokWebSphereParserTest.tetsParseMalformedOtherLine:220
expected:<14[92276]654000> but was:<14[60740]654000>

  GrokWebSphereParserTest.tetsParseMalformedRBMLine:198
expected:<14[92277]795000> but was:<14[60741]795000>

  GrokWebSphereParserTest.tetsParseOtherLine:129 expected:<14[92276]654000>
but was:<14[60740]654000>

  GrokWebSphereParserTest.tetsParseRBMLine:107 expected:<14[92277]795000>
but was:<14[60741]795000>




On March 9, 2017 at 19:16:24, ottobackwards (g...@git.apache.org) wrote:

Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/405

I will later tonight or first thing tomorrow am


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[Otto Fowler]

Failed tests:

  BasicAsaParserTest.testIp6Addr:151 null

  GrokWebSphereParserTest.testParseLoginLine:60 expected:<14[92278]448000>
but was:<14[60742]448000>

  GrokWebSphereParserTest.testParseMalformedLoginLine:151
expected:<14[92278]448000> but was:<14[60742]448000>

  GrokWebSphereParserTest.tetsParseLogoutLine:84 expected:<14[92279]347000>
but was:<14[60743]347000>

  GrokWebSphereParserTest.tetsParseMalformedLogoutLine:175
expected:<14[92279]347000> but was:<14[60743]347000>

  GrokWebSphereParserTest.tetsParseMalformedOtherLine:220
expected:<14[92276]654000> but was:<14[60740]654000>

  GrokWebSphereParserTest.tetsParseMalformedRBMLine:198
expected:<14[92277]795000> but was:<14[60741]795000>

  GrokWebSphereParserTest.tetsParseOtherLine:129 expected:<14[92276]654000>
but was:<14[60740]654000>

  GrokWebSphereParserTest.tetsParseRBMLine:107 expected:<14[92277]795000>
but was:<14[60741]795000>




On March 9, 2017 at 19:16:24, ottobackwards (g...@git.apache.org) wrote:

Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/405

I will later tonight or first thing tomorrow am


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[Otto Fowler]

Dima, what email do you use for github?

On March 9, 2017 at 19:16:21, ottobackwards (g...@git.apache.org) wrote:

> Github user ottobackwards commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/405
>
> I will later tonight or first thing tomorrow am
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working,
> please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
I will later tonight or first thing tomorrow am


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[Matt Foley]

Thanks David!

On 2/24/17, 5:41 PM, "David Lyle"  wrote:

It's the actual dashboard template in Python pickle format. Belongs in
github.

Re: [GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[David Lyle]

It's the actual dashboard template in Python pickle format. Belongs in
github.

-D...


On Fri, Feb 24, 2017 at 7:18 PM, mattf-horton  wrote:

> Github user mattf-horton commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/405
>
> +1 on the fix btw.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[mattf-horton]

Github user mattf-horton commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
+1 on the fix btw.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[mattf-horton]

Github user mattf-horton commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
@DimDroll , here's what I did to find the answer to your question:  
* I went to github and found 
https://github.com/apache/incubator-metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/4.5.1/package/scripts/dashboard/dashboard.p
* Then I clicked the "Blame" button, which showed me the patch it was 
created by.
* Clicking on that, I found that @dlyle65535 committed it as part of 
METRON-365: Load demo dashboard on Kibana Service install (PR#211).  
* Searching for 'dashboard.p', I find both the file itself, and the use of 
it in line 131 of kibana_master.py. 
* I couldn't recognize the language it's in (but it sure isn't python).  So 
I googled "file format .p" and found it is probably a "python pickle" file, and 
indeed searching for "pickle" in the same commit found in dashboardindex.py 
uses of pickle.load and pickle.dump.

So it's not misnamed, and you were close with the .pyc guess.  The only 
question left is, does it belong there as a constant template file for the 
kibana dashboard?  Or is it an auto-gen file that shouldn't actually be in git? 
 That's a question for @dlyle65535 .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[DimDroll]

Github user DimDroll commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
Oh my, thank you team for such a warm words, I really appreciate it. I have 
made mentioned changes.

Also, as a side note, while I was looking for {} in rest of the code base 
using following command in root:
`grep -R '{}' * | grep -v 
'\.java:\|README.md:\|LICENSE:\|\.json:\|\.js:\|\.jj:' | less`
I have found this guy: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/4.5.1/package/scripts/dashboard/dashboard.p
Unless it is Matlab file I feel like it is misnamed py or most likely pyc 
file. Should I do anything about it?
Please advise.

Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[dlyle65535]

Github user dlyle65535 commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
Here's a fun fact- quick-dev uses 2.6.6. Had to make this exact change 
while unifying Ansible with the MPack, so if nothing else, we'll get it there. 
Still I'd like @DimDroll to get the deserved credit, so I'd be happy for this 
one to get there first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
Hi, thanks for the contribution! Per Matt's comments, we do require Python 
2.7. I don't believe that's in our main README, but it is listed in our 
deployment READMEs, e.g. 
https://github.com/apache/incubator-metron/tree/master/metron-deployment/vagrant/quick-dev-platform

That being said, we have made this exact fix/change in other files in the 
Ambari installation code and it should be here as well. Also agreed with Matt's 
comments about the other 3 braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[dlyle65535]

Github user dlyle65535 commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
Yup, please change the other 3 and we'll get this in, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[mattf-horton]

Github user mattf-horton commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
Let's do this, but need to also fix the other three places in this file 
where '{}' is used with format method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

[mattf-horton]

Github user mattf-horton commented on the issue:

https://github.com/apache/incubator-metron/pull/405
  
I believe this is only an issue with Python 2.6. Don't we require Python 
2.7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---