[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/528
  
No just the appropriate ones you can see.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread bjigmp
Github user bjigmp commented on the issue:

https://github.com/apache/incubator-metron/pull/528
  
Thanks @ottobackwards, Updated this PR. Are all checkboxes must be checked?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/incubator-metron/pull/528
  
Thanks for the contribution!  Also, could you please close and reopen the 
PR?  You hit an intermittent test failure and travis should try again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/528
  
Hi bjigmp!
Thanks for the contribution.
We have a template for our PR's, that help us review and accept them.  This 
PR is missing that,
can you please add it in? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---