[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Li Fangning (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524771#comment-15524771
 ] 

Li Fangning commented on SSHD-700:
--

Hi Goldstein

It still does not work.
I have attached my test code (SshdTest3.java) and the debug output (debug.log).
Please help me out.

The XShell download link:
https://www.netsarang.com/download/down_xsh5.html?token=RUg4aE5iQ2xIaTg1SkVPSnJoR2Vsd0BneE1PS0VSemluU29pN1JTN2xINnRn
OR
http://download.findmysoft.com/2016/09/12/XShell_5.0-Build-1019.exe
We can use it free from home and school.

After install, select Tools > Launch Xagent to start XAgent and manage keys.
When create a SSH connection, make sure the Connection > SSH > Use Xagent (SSH 
agent) for handling passphrase is checked.

Thanks a lot!

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java, SshdTest3.java, debug.log
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Li Fangning (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Li Fangning updated SSHD-700:
-
Attachment: debug.log
SshdTest3.java

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java, SshdTest3.java, debug.log
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SSHD-701) IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1

2016-09-26 Thread Roger Hart (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523829#comment-15523829
 ] 

Roger Hart commented on SSHD-701:
-

The spec is silent on negative values for initial window size, so I think it's 
reasonable and robust to interpret negative values as 0, meaning that no data 
can be sent without adjusting the window. Throwing up your hands with an 
IllegalArgumentException seems unwarranted.

> IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with 
> initial window size of -1
> 
>
> Key: SSHD-701
> URL: https://issues.apache.org/jira/browse/SSHD-701
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Roger Hart
>Priority: Minor
>
> We're using Apache MINA SSHD 1.2.0 successfully except for one server which 
> sends an init window size of -1 in the SSH_MSG_CHANNEL_OPEN_CONFIRMATION 
> message (other servers send 0). This causes SSHD to throw an 
> IllegalArgumentException here: 
> ValidateUtils.checkTrue(window >= 0, "Negative window size: %d", window);
> I'm able to send files to this server using the Win SCP command line client.
> It would be nice if SSHD was more robust and treated a negative window size 
> as 0.
> Here's the SSHD log entries:
> 10:56:13.296 23-Sep-16 -0700 | (ultConfigFileHostEntryResolver) 
> resolveEffectiveHost(@/X.XX.XXX.XX:22) => null
> 10:56:13.296 23-Sep-16 -0700 | (g.apache.sshd.client.SshClient) 
> connect(@/X.XX.XXX.XX:22) no overrides
> 10:56:13.296 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) Connecting to 
> /X.XX.XXX.XX:22
> 10:56:13.297 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) 
> setOption(SO_REUSEADDR)[true] from property=socket-reuseaddr
> 10:56:13.389 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Creating 
> IoSession on /0:0:0:0:0:0:0:0:57579 from /X.XX.XXX.XX:22
> 10:56:13.390 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) Client 
> session created: Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]
> 10:56:13.391 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> ClientUserAuthService(ClientSessionImpl[null@/X.XX.XXX.XX:22]) client 
> methods: [publickey, keyboard-interactive, password]
> 10:56:13.391 23-Sep-16 -0700 | (helpers.SessionTimeoutListener) 
> sessionCreated(ClientSessionImpl[null@/X.XX.XXX.XX:22]) tracking
> 10:56:13.391 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendIdentification(ClientSessionImpl[null@/X.XX.XXX.XX:22]): 
> SSH-2.0-SSHD-CORE-1.2.0
> 10:56:13.391 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 25 
> bytes
> 10:56:13.392 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendKexInit(ClientSessionImpl[null@/X.XX.XXX.XX:22]) Send SSH_MSG_KEXINIT
> 10:56:13.392 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 592 
> bytes
> 10:56:13.393 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> auth(ClientSessionImpl[@/X.XX.XXX.XX:22])[ssh-connection] send 
> SSH_MSG_USERAUTH_REQUEST for 'none'
> 10:56:13.393 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=25
> 10:56:13.395 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> writePacket(ClientSessionImpl[@/X.XX.XXX.XX:22])[SSH_MSG_USERAUTH_REQUEST]
>  Start flagging packets as pending until key exchange is done
> 10:56:13.396 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=592
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) read 568 bytes
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> doReadIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) 
> line='SSH-2.0-mod_sftp/0.9.7'
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> readIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) Server 
> version string: SSH-2.0-mod_sftp/0.9.7
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> handleKexInit(ClientSessionImpl[@/X.XX.XXX.XX:22]) SSH_MSG_KEXINIT
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> server->client aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> client->server aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (he.sshd.client.kex.DHGEXClient) 
> 

[jira] [Commented] (SSHD-701) IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1

2016-09-26 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523660#comment-15523660
 ] 

Goldstein Lyor commented on SSHD-701:
-

According to [RFC 4254 section 
5.1|https://tools.ietf.org/html/rfc4254#section-5.1]:
{quote}
The 'initial window size' specifies how many bytes of channel data can be sent 
to the sender of this message without adjusting the window.  The 'maximum 
packet size' specifies the maximum size of an individual data packet that can 
be sent to the sender.
{quote}
I have not found any indication that negative values mean {{Infinite}} and 
while I have not found any reference explicitly prohibiting this , neither have 
I found any reference as to what "Infinite" means. I am open to suggestion as 
to how intrepret negative values - preferably also some reference 
implementation (in C/C# or whatever language) that shows some reasonable 
handling for this case.

> IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with 
> initial window size of -1
> 
>
> Key: SSHD-701
> URL: https://issues.apache.org/jira/browse/SSHD-701
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Roger Hart
>Priority: Minor
>
> We're using Apache MINA SSHD 1.2.0 successfully except for one server which 
> sends an init window size of -1 in the SSH_MSG_CHANNEL_OPEN_CONFIRMATION 
> message (other servers send 0). This causes SSHD to throw an 
> IllegalArgumentException here: 
> ValidateUtils.checkTrue(window >= 0, "Negative window size: %d", window);
> I'm able to send files to this server using the Win SCP command line client.
> It would be nice if SSHD was more robust and treated a negative window size 
> as 0.
> Here's the SSHD log entries:
> 10:56:13.296 23-Sep-16 -0700 | (ultConfigFileHostEntryResolver) 
> resolveEffectiveHost(@/X.XX.XXX.XX:22) => null
> 10:56:13.296 23-Sep-16 -0700 | (g.apache.sshd.client.SshClient) 
> connect(@/X.XX.XXX.XX:22) no overrides
> 10:56:13.296 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) Connecting to 
> /X.XX.XXX.XX:22
> 10:56:13.297 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) 
> setOption(SO_REUSEADDR)[true] from property=socket-reuseaddr
> 10:56:13.389 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Creating 
> IoSession on /0:0:0:0:0:0:0:0:57579 from /X.XX.XXX.XX:22
> 10:56:13.390 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) Client 
> session created: Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]
> 10:56:13.391 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> ClientUserAuthService(ClientSessionImpl[null@/X.XX.XXX.XX:22]) client 
> methods: [publickey, keyboard-interactive, password]
> 10:56:13.391 23-Sep-16 -0700 | (helpers.SessionTimeoutListener) 
> sessionCreated(ClientSessionImpl[null@/X.XX.XXX.XX:22]) tracking
> 10:56:13.391 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendIdentification(ClientSessionImpl[null@/X.XX.XXX.XX:22]): 
> SSH-2.0-SSHD-CORE-1.2.0
> 10:56:13.391 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 25 
> bytes
> 10:56:13.392 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendKexInit(ClientSessionImpl[null@/X.XX.XXX.XX:22]) Send SSH_MSG_KEXINIT
> 10:56:13.392 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 592 
> bytes
> 10:56:13.393 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> auth(ClientSessionImpl[@/X.XX.XXX.XX:22])[ssh-connection] send 
> SSH_MSG_USERAUTH_REQUEST for 'none'
> 10:56:13.393 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=25
> 10:56:13.395 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> writePacket(ClientSessionImpl[@/X.XX.XXX.XX:22])[SSH_MSG_USERAUTH_REQUEST]
>  Start flagging packets as pending until key exchange is done
> 10:56:13.396 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=592
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) read 568 bytes
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> doReadIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) 
> line='SSH-2.0-mod_sftp/0.9.7'
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> readIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) Server 
> version string: SSH-2.0-mod_sftp/0.9.7
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> handleKexInit(ClientSessionImpl[@/X.XX.XXX.XX:22]) 

[jira] [Updated] (SSHD-701) IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1

2016-09-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor updated SSHD-701:

Issue Type: Improvement  (was: Bug)

> IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with 
> initial window size of -1
> 
>
> Key: SSHD-701
> URL: https://issues.apache.org/jira/browse/SSHD-701
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Roger Hart
>
> We're using Apache MINA SSHD 1.2.0 successfully except for one server which 
> sends an init window size of -1 in the SSH_MSG_CHANNEL_OPEN_CONFIRMATION 
> message (other servers send 0). This causes SSHD to throw an 
> IllegalArgumentException here: 
> ValidateUtils.checkTrue(window >= 0, "Negative window size: %d", window);
> I'm able to send files to this server using the Win SCP command line client.
> It would be nice if SSHD was more robust and treated a negative window size 
> as 0.
> Here's the SSHD log entries:
> 10:56:13.296 23-Sep-16 -0700 | (ultConfigFileHostEntryResolver) 
> resolveEffectiveHost(@/X.XX.XXX.XX:22) => null
> 10:56:13.296 23-Sep-16 -0700 | (g.apache.sshd.client.SshClient) 
> connect(@/X.XX.XXX.XX:22) no overrides
> 10:56:13.296 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) Connecting to 
> /X.XX.XXX.XX:22
> 10:56:13.297 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) 
> setOption(SO_REUSEADDR)[true] from property=socket-reuseaddr
> 10:56:13.389 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Creating 
> IoSession on /0:0:0:0:0:0:0:0:57579 from /X.XX.XXX.XX:22
> 10:56:13.390 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) Client 
> session created: Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]
> 10:56:13.391 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> ClientUserAuthService(ClientSessionImpl[null@/X.XX.XXX.XX:22]) client 
> methods: [publickey, keyboard-interactive, password]
> 10:56:13.391 23-Sep-16 -0700 | (helpers.SessionTimeoutListener) 
> sessionCreated(ClientSessionImpl[null@/X.XX.XXX.XX:22]) tracking
> 10:56:13.391 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendIdentification(ClientSessionImpl[null@/X.XX.XXX.XX:22]): 
> SSH-2.0-SSHD-CORE-1.2.0
> 10:56:13.391 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 25 
> bytes
> 10:56:13.392 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendKexInit(ClientSessionImpl[null@/X.XX.XXX.XX:22]) Send SSH_MSG_KEXINIT
> 10:56:13.392 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 592 
> bytes
> 10:56:13.393 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> auth(ClientSessionImpl[@/X.XX.XXX.XX:22])[ssh-connection] send 
> SSH_MSG_USERAUTH_REQUEST for 'none'
> 10:56:13.393 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=25
> 10:56:13.395 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> writePacket(ClientSessionImpl[@/X.XX.XXX.XX:22])[SSH_MSG_USERAUTH_REQUEST]
>  Start flagging packets as pending until key exchange is done
> 10:56:13.396 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=592
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) read 568 bytes
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> doReadIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) 
> line='SSH-2.0-mod_sftp/0.9.7'
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> readIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) Server 
> version string: SSH-2.0-mod_sftp/0.9.7
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> handleKexInit(ClientSessionImpl[@/X.XX.XXX.XX:22]) SSH_MSG_KEXINIT
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> server->client aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> client->server aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (he.sshd.client.kex.DHGEXClient) 
> init(ClientSessionImpl[@/X.XX.XXX.XX:22]) Send 
> SSH_MSG_KEX_DH_GEX_REQUEST
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 32 
> bytes
> 10:56:13.481 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) 

[jira] [Updated] (SSHD-701) IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1

2016-09-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor updated SSHD-701:

Priority: Minor  (was: Major)

> IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with 
> initial window size of -1
> 
>
> Key: SSHD-701
> URL: https://issues.apache.org/jira/browse/SSHD-701
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Roger Hart
>Priority: Minor
>
> We're using Apache MINA SSHD 1.2.0 successfully except for one server which 
> sends an init window size of -1 in the SSH_MSG_CHANNEL_OPEN_CONFIRMATION 
> message (other servers send 0). This causes SSHD to throw an 
> IllegalArgumentException here: 
> ValidateUtils.checkTrue(window >= 0, "Negative window size: %d", window);
> I'm able to send files to this server using the Win SCP command line client.
> It would be nice if SSHD was more robust and treated a negative window size 
> as 0.
> Here's the SSHD log entries:
> 10:56:13.296 23-Sep-16 -0700 | (ultConfigFileHostEntryResolver) 
> resolveEffectiveHost(@/X.XX.XXX.XX:22) => null
> 10:56:13.296 23-Sep-16 -0700 | (g.apache.sshd.client.SshClient) 
> connect(@/X.XX.XXX.XX:22) no overrides
> 10:56:13.296 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) Connecting to 
> /X.XX.XXX.XX:22
> 10:56:13.297 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) 
> setOption(SO_REUSEADDR)[true] from property=socket-reuseaddr
> 10:56:13.389 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Creating 
> IoSession on /0:0:0:0:0:0:0:0:57579 from /X.XX.XXX.XX:22
> 10:56:13.390 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) Client 
> session created: Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]
> 10:56:13.391 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> ClientUserAuthService(ClientSessionImpl[null@/X.XX.XXX.XX:22]) client 
> methods: [publickey, keyboard-interactive, password]
> 10:56:13.391 23-Sep-16 -0700 | (helpers.SessionTimeoutListener) 
> sessionCreated(ClientSessionImpl[null@/X.XX.XXX.XX:22]) tracking
> 10:56:13.391 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendIdentification(ClientSessionImpl[null@/X.XX.XXX.XX:22]): 
> SSH-2.0-SSHD-CORE-1.2.0
> 10:56:13.391 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 25 
> bytes
> 10:56:13.392 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> sendKexInit(ClientSessionImpl[null@/X.XX.XXX.XX:22]) Send SSH_MSG_KEXINIT
> 10:56:13.392 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 592 
> bytes
> 10:56:13.393 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
> auth(ClientSessionImpl[@/X.XX.XXX.XX:22])[ssh-connection] send 
> SSH_MSG_USERAUTH_REQUEST for 'none'
> 10:56:13.393 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=25
> 10:56:13.395 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> writePacket(ClientSessionImpl[@/X.XX.XXX.XX:22])[SSH_MSG_USERAUTH_REQUEST]
>  Start flagging packets as pending until key exchange is done
> 10:56:13.396 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) finished writing len=592
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> remote=/X.XX.XXX.XX:22]) read 568 bytes
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> doReadIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) 
> line='SSH-2.0-mod_sftp/0.9.7'
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> readIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) Server 
> version string: SSH-2.0-mod_sftp/0.9.7
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> handleKexInit(ClientSessionImpl[@/X.XX.XXX.XX:22]) SSH_MSG_KEXINIT
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> server->client aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
> setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
> client->server aes128-ctr hmac-sha1 none
> 10:56:13.480 23-Sep-16 -0700 | (he.sshd.client.kex.DHGEXClient) 
> init(ClientSessionImpl[@/X.XX.XXX.XX:22]) Send 
> SSH_MSG_KEX_DH_GEX_REQUEST
> 10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 32 
> bytes
> 10:56:13.481 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
> handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
> 

[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523643#comment-15523643
 ] 

Goldstein Lyor commented on SSHD-700:
-

Hi Li,

Please try to clone https://github.com/lgoldstein/mina-sshd/tree/SSHD-700 
compile it and see if it solves your problem. Try debugging it if it doesn't 
and maybe diagnose what is failing - I cannot re-create it.

*Note:* some special initialization may be required similar to what I already 
showed - see {{ChannelAgentForwardingFactory OPENSSH/IETF}} implementations as 
well as {{SshAgentServer.PROXY_CHANNEL_TYPE}} configuration value. I believe 
some kind of combination of the 2 should do the trick.

Is there some way I can re-create your problem ? I cannot download and install 
_XShell_ for various reasons, so I cannot test it locally. If you can suggest 
some way to use _XShell_ that would be a great help - otherwise, I rely on you 
to debug the code and suggest a fix (please make sure that the fix does not 
break backward compatibility)

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SSHD-701) IllegalArgumentException processing SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1

2016-09-26 Thread Roger Hart (JIRA)
Roger Hart created SSHD-701:
---

 Summary: IllegalArgumentException processing 
SSH_MSG_CHANNEL_OPEN_CONFIRMATION with initial window size of -1
 Key: SSHD-701
 URL: https://issues.apache.org/jira/browse/SSHD-701
 Project: MINA SSHD
  Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Roger Hart


We're using Apache MINA SSHD 1.2.0 successfully except for one server which 
sends an init window size of -1 in the SSH_MSG_CHANNEL_OPEN_CONFIRMATION 
message (other servers send 0). This causes SSHD to throw an 
IllegalArgumentException here: 

ValidateUtils.checkTrue(window >= 0, "Negative window size: %d", window);

I'm able to send files to this server using the Win SCP command line client.

It would be nice if SSHD was more robust and treated a negative window size as 
0.

Here's the SSHD log entries:

10:56:13.296 23-Sep-16 -0700 | (ultConfigFileHostEntryResolver) 
resolveEffectiveHost(@/X.XX.XXX.XX:22) => null
10:56:13.296 23-Sep-16 -0700 | (g.apache.sshd.client.SshClient) 
connect(@/X.XX.XXX.XX:22) no overrides
10:56:13.296 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) Connecting to 
/X.XX.XXX.XX:22
10:56:13.297 23-Sep-16 -0700 | (d.common.io.nio2.Nio2Connector) 
setOption(SO_REUSEADDR)[true] from property=socket-reuseaddr
10:56:13.389 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Creating 
IoSession on /0:0:0:0:0:0:0:0:57579 from /X.XX.XXX.XX:22
10:56:13.390 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) Client session 
created: Nio2Session[local=/0:0:0:0:0:0:0:0:57579, remote=/X.XX.XXX.XX:22]
10:56:13.391 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
ClientUserAuthService(ClientSessionImpl[null@/X.XX.XXX.XX:22]) client methods: 
[publickey, keyboard-interactive, password]
10:56:13.391 23-Sep-16 -0700 | (helpers.SessionTimeoutListener) 
sessionCreated(ClientSessionImpl[null@/X.XX.XXX.XX:22]) tracking
10:56:13.391 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
sendIdentification(ClientSessionImpl[null@/X.XX.XXX.XX:22]): 
SSH-2.0-SSHD-CORE-1.2.0
10:56:13.391 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 25 bytes
10:56:13.392 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
sendKexInit(ClientSessionImpl[null@/X.XX.XXX.XX:22]) Send SSH_MSG_KEXINIT
10:56:13.392 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 592 
bytes
10:56:13.393 23-Sep-16 -0700 | (.session.ClientUserAuthService) 
auth(ClientSessionImpl[@/X.XX.XXX.XX:22])[ssh-connection] send 
SSH_MSG_USERAUTH_REQUEST for 'none'
10:56:13.393 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
remote=/X.XX.XXX.XX:22]) finished writing len=25
10:56:13.395 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
writePacket(ClientSessionImpl[@/X.XX.XXX.XX:22])[SSH_MSG_USERAUTH_REQUEST]
 Start flagging packets as pending until key exchange is done
10:56:13.396 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
remote=/X.XX.XXX.XX:22]) finished writing len=592
10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
remote=/X.XX.XXX.XX:22]) read 568 bytes
10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
doReadIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) 
line='SSH-2.0-mod_sftp/0.9.7'
10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
readIdentification(ClientSessionImpl[@/X.XX.XXX.XX:22]) Server version 
string: SSH-2.0-mod_sftp/0.9.7
10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
handleKexInit(ClientSessionImpl[@/X.XX.XXX.XX:22]) SSH_MSG_KEXINIT
10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
server->client aes128-ctr hmac-sha1 none
10:56:13.480 23-Sep-16 -0700 | (ient.session.ClientSessionImpl) 
setNegotiationResult(ClientSessionImpl[@/X.XX.XXX.XX:22]) Kex: 
client->server aes128-ctr hmac-sha1 none
10:56:13.480 23-Sep-16 -0700 | (he.sshd.client.kex.DHGEXClient) 
init(ClientSessionImpl[@/X.XX.XXX.XX:22]) Send 
SSH_MSG_KEX_DH_GEX_REQUEST
10:56:13.480 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) Writing 32 bytes
10:56:13.481 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
handleCompletedWriteCycle(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
remote=/X.XX.XXX.XX:22]) finished writing len=32
10:56:13.575 23-Sep-16 -0700 | (shd.common.io.nio2.Nio2Session) 
handleReadCycleCompletion(Nio2Session[local=/0:0:0:0:0:0:0:0:57579, 
remote=/X.XX.XXX.XX:22]) read 536 bytes
10:56:13.575 23-Sep-16 -0700 | (he.sshd.client.kex.DHGEXClient) 
next(DHGEXClient[diffie-hellman-group-exchange-sha256])[ClientSessionImpl[@/X.XX.XXX.XX:22]]
 process command=SSH_MSG_KEX_DH_GEX_GROUP
10:56:13.731 

Result, was: [VOTE] MINA 2.0.15 release

2016-09-26 Thread Emmanuel Lécharny
Hi,

I'm closing this vote which got 4 binding +1 :
- Ashish
- Jeff (Genender)
- Jeff (Maury)
and me.

I will push the packages and update the web site.


Many thans !


Re: observing hangs after update to MINA 2.0.14

2016-09-26 Thread Emmanuel Lécharny
Le 26/09/16 à 09:01, Christoph John a écrit :
> Until now I could not reproduce the problem reliably. However, I think
> it might not be a "hang" but have to do with the changed behaviour
> regarding flushing that has been fixed in MINA 2.0.14 (DIRMINA-1025/1021)
> E.g. the tests wait for a message to arrive that the other side has
> sent but it doesn't seem to be received.
>
> I guess I'll have to review the closeNow/closeOnFlush calls in
> QuickFIX/J then? Maybe it is only related to the test suite, though.

I think you sent a test case that reproduce the issue (AFAIR). I ran
this test and got a hang, if I try to close both ends, that is what I'd
like to investigate.

Sadly, I have been pretty busy lately, and I had to cut a new release
2.0.15 urgently, due to a big bug in SSL, so I didn't had chance to go
any further. I hope to have time to do that this week.



[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Li Fangning (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522400#comment-15522400
 ] 

Li Fangning commented on SSHD-700:
--

I followed the steps above, but it does not work.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Li Fangning (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522402#comment-15522402
 ] 

Li Fangning commented on SSHD-700:
--

Thanks alot.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

2016-09-26 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522333#comment-15522333
 ] 

Goldstein Lyor commented on SSHD-700:
-

I have made some changes and may have something along these lines soon (on 
version 1.4 though...)

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: SshdTest2.java
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: observing hangs after update to MINA 2.0.14

2016-09-26 Thread Christoph John
Until now I could not reproduce the problem reliably. However, I think it might not be a "hang" but 
have to do with the changed behaviour regarding flushing that has been fixed in MINA 2.0.14 
(DIRMINA-1025/1021)
E.g. the tests wait for a message to arrive that the other side has sent but it doesn't seem to be 
received.


I guess I'll have to review the closeNow/closeOnFlush calls in QuickFIX/J then? Maybe it is only 
related to the test suite, though.


Thanks,
Chris.



On 21/09/16 14:51, Christoph John wrote:
OK, will open a JIRA issue and try to get a test case. It might very well be a race condition, but 
the question is why it is manifesting every time I run the test suite with MINA 2.0.14 and never 
with 2.0.13.

Will keep you updated.

Thanks,
Chris.


On 21/09/16 14:48, Emmanuel Lécharny wrote:

Le 21/09/16 à 13:17, Christoph John a écrit :

Hi,

do you need any more information from my side? Should I create a JIRA
issue? The problem can be reproduced with QuickFIX/J code but I could
check if can condense a MINA-only test case if required.

A test case would be very valuable, and, yes, a JIRA will definitvely help.

My take on this issue is that if both the client and the server close
the session more or less at the same time, one side will hang, due to
some race condition.





--
Christoph John
Development & Support
Direct: +49 241 557080-28
Mailto:christoph.j...@macd.com



http://www.macd.com 



MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
Tel: +49 241 557080-0 | Fax: +49 241 557080-10
 Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663

Geschäftsführer: George Macdonald




take care of the environment - print only if necessary


Re: [VOTE] MINA 2.0.15 release

2016-09-26 Thread Jeff MAURY
+1

Jeff

On Thu, Sep 22, 2016 at 3:08 AM, Ashish  wrote:

> +1
>
> Build works fine. All test cases passed
>
> On Wed, Sep 21, 2016 at 12:11 AM, Emmanuel Lécharny 
> wrote:
> > Hi,
> >
> > Here is a new release, MINA 2.0.15. It fixes one critical SSL issue, and
> a NPE. Javadoc has also been a bit cleaned up.
> >
> > Here are the fixed issues :
> >
> > Bugs :
> > --
> >
> > [DIRMINA-1044 ]
> Non-Secure (no TLS/SSL) based client could successfully send message to
> secure Mina endpoint after second attempt
> > [DIRMINA-1à43 ]
> NullPointerException after upgrade to mina 2.0.14
> >
> >
> >
> > A temporary tag has been created (it can be removed if the vote is not
> approved):
> >
> > Updated Tags:  refs/tags/2.0.15 [created] 0399f97db
> >
> > Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/mina/commit/8bae1d4f
> > Tree: http://git-wip-us.apache.org/repos/asf/mina/tree/8bae1d4f
> > Diff: http://git-wip-us.apache.org/repos/asf/mina/diff/8bae1d4f
> >
> > - Nexus repository: https://repository.apache.org/content/repositories/
> orgapachemina-1025
> >
> > - Binaries and sources: https://dist.apache.org/repos/
> dist/dev/mina/mina/2.0.15/
> >
> > Let us vote :
> > [ ] +1 | Release MINA 2.0.15
> > [ ] ± | Abstain
> > [ ] -1 | Do **NOT**  release MINA 2.0.15
> >
> > Thanks !
> >
>
>
>
> --
> thanks
> ashish
>
> Blog: http://www.ashishpaliwal.com/blog
> My Photo Galleries: http://www.pbase.com/ashishpaliwal
>



-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury


[RESULT] [VOTE] Release SSHD 1.3.0

2016-09-26 Thread Guillaume Nodet
The vote passes with 6 +1s and no other votes.
I'll publish the artifacts asap.

Thx to everyone.
Guillaume

2016-09-19 9:27 GMT+02:00 Guillaume Nodet :

> I've prepared a candidate for SSHD 1.3.0 release at
>   https://repository.apache.org/content/repositories/orgapachemina-1024
>
> Please review and vote.
>
> Release
> notes:
> ** Bug
> * [SSHD-605] - VirtualFileSystemFactory allows escaping from root
> * [SSHD-651] - Add an option to specify read/write Nio2 socket timeouts
> * [SSHD-663] - Wrong if criteria in org.apache.sshd.common.file.
> util.ImmutableList.subList()
> * [SSHD-667] - RootedFileSystemProvider throws
> ProviderMismatchException when calling newByteChannel
> * [SSHD-668] - AccessControlException running under OSGi container
> * [SSHD-671] - Internal hang (timeout) using ScpClient.upload()
> * [SSHD-673] - "sendKexInit() no resolved signatures available" with
> key-type "EC"
> * [SSHD-692] - Cannot repeatedly call ChannelSession#
> executeRemoteCommand
> * [SSHD-695] - Client - support receiving of banner prior to auth()
>
> ** Improvement
> * [SSHD-664] - Provide ReadOnly option in RootedFileSystemProvider
> (sshd-core)
> * [SSHD-665] - allow disable some features in SftpSubsystem (sshd-core)
> * [SSHD-674] - Update minimum required Java version to 1.8
> * [SSHD-675] - Provide default implementations for overloaded
> configuration methods on Client/ServerFactoryManager interfaces
> * [SSHD-676] - Provide command line option for specifying
> client/server key file(s)
> * [SSHD-677] - Provide a quick default implementation for executing a
> single simple command that does not require any input
> * [SSHD-679] - Support (or ignore) IUTF8 terminal mode (42)
> * [SSHD-680] - Provide default implementations for
> ClientAuthenticationManager#getSetUserAuthFactories overloading with
> strings
> * [SSHD-681] - Provide default implementations for
> ServerAuthenticationManager#getSetUserAuthFactories overloading with
> strings
> * [SSHD-682] - Provide PortForwardingEventListener support
> * [SSHD-683] - Provide an auto-closeable implementation for
> establishing and tearing down local/remote port forwards
> * [SSHD-684] - Move checkstyle definitions to external file so it can
> be imported by the IDE
> * [SSHD-686] - Provide configurable option to auto-generate welcome
> banner consisting of the server's keys random art values
> * [SSHD-687] - Provide indication of the negotiated options before
> processing them
> * [SSHD-688] - Attempt to send the welcome banner sooner in the
> authentication protocol
> * [SSHD-689] - Allow providing a file as a welcome banner
> configuration option
> * [SSHD-690] - Use by default the standard file(s) for SSH server
> welcome banner
> * [SSHD-691] - Attempt to create server instance only once per test as
> much as possible
> * [SSHD-694] - Provide README.md file(s) with useful code snippets
> * [SSHD-696] - Allow loading the server's welcome banner from a URL
> * [SSHD-697] - Add read/write methods to SftpClient that enable
> read/write starting from some offset
> * [SSHD-699] - Server receiving 0-length SSH_MSG_IGNORE causes Buffer
> Underflow exception
>
> ** New Feature
> * [SSHD-685] - Provide support for VisualHostKey (a.k.a. randomArt)
>
> ** Task
> * [SSHD-698] - Code cleanup for JDK8
>
>
> Cheers,
> Guillaume Nodet
>
>


-- 

Guillaume Nodet

Red Hat, Open Source Integration

Email: gno...@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/


Re: [VOTE] Release SSHD 1.3.0

2016-09-26 Thread Guillaume Nodet
+1

2016-09-19 9:27 GMT+02:00 Guillaume Nodet :

> I've prepared a candidate for SSHD 1.3.0 release at
>   https://repository.apache.org/content/repositories/orgapachemina-1024
>
> Please review and vote.
>
> Release
> notes:
> ** Bug
> * [SSHD-605] - VirtualFileSystemFactory allows escaping from root
> * [SSHD-651] - Add an option to specify read/write Nio2 socket timeouts
> * [SSHD-663] - Wrong if criteria in org.apache.sshd.common.file.
> util.ImmutableList.subList()
> * [SSHD-667] - RootedFileSystemProvider throws
> ProviderMismatchException when calling newByteChannel
> * [SSHD-668] - AccessControlException running under OSGi container
> * [SSHD-671] - Internal hang (timeout) using ScpClient.upload()
> * [SSHD-673] - "sendKexInit() no resolved signatures available" with
> key-type "EC"
> * [SSHD-692] - Cannot repeatedly call ChannelSession#
> executeRemoteCommand
> * [SSHD-695] - Client - support receiving of banner prior to auth()
>
> ** Improvement
> * [SSHD-664] - Provide ReadOnly option in RootedFileSystemProvider
> (sshd-core)
> * [SSHD-665] - allow disable some features in SftpSubsystem (sshd-core)
> * [SSHD-674] - Update minimum required Java version to 1.8
> * [SSHD-675] - Provide default implementations for overloaded
> configuration methods on Client/ServerFactoryManager interfaces
> * [SSHD-676] - Provide command line option for specifying
> client/server key file(s)
> * [SSHD-677] - Provide a quick default implementation for executing a
> single simple command that does not require any input
> * [SSHD-679] - Support (or ignore) IUTF8 terminal mode (42)
> * [SSHD-680] - Provide default implementations for
> ClientAuthenticationManager#getSetUserAuthFactories overloading with
> strings
> * [SSHD-681] - Provide default implementations for
> ServerAuthenticationManager#getSetUserAuthFactories overloading with
> strings
> * [SSHD-682] - Provide PortForwardingEventListener support
> * [SSHD-683] - Provide an auto-closeable implementation for
> establishing and tearing down local/remote port forwards
> * [SSHD-684] - Move checkstyle definitions to external file so it can
> be imported by the IDE
> * [SSHD-686] - Provide configurable option to auto-generate welcome
> banner consisting of the server's keys random art values
> * [SSHD-687] - Provide indication of the negotiated options before
> processing them
> * [SSHD-688] - Attempt to send the welcome banner sooner in the
> authentication protocol
> * [SSHD-689] - Allow providing a file as a welcome banner
> configuration option
> * [SSHD-690] - Use by default the standard file(s) for SSH server
> welcome banner
> * [SSHD-691] - Attempt to create server instance only once per test as
> much as possible
> * [SSHD-694] - Provide README.md file(s) with useful code snippets
> * [SSHD-696] - Allow loading the server's welcome banner from a URL
> * [SSHD-697] - Add read/write methods to SftpClient that enable
> read/write starting from some offset
> * [SSHD-699] - Server receiving 0-length SSH_MSG_IGNORE causes Buffer
> Underflow exception
>
> ** New Feature
> * [SSHD-685] - Provide support for VisualHostKey (a.k.a. randomArt)
>
> ** Task
> * [SSHD-698] - Code cleanup for JDK8
>
>
> Cheers,
> Guillaume Nodet
>
>


-- 

Guillaume Nodet

Red Hat, Open Source Integration

Email: gno...@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/