[jira] [Comment Edited] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

[Li Fangning (JIRA)]

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069432#comment-16069432
 ] 

Li Fangning edited comment on SSHD-700 at 6/30/17 4:01 AM:
---

Hi Goldstein

We finally solved the issue.
The attachment 'sshd-core.zip' is the source code associated with resolving the 
issue (based on the latest master branch).
Now SSHD can support agent forwarding implementations of both IETF and OpenSSH, 
and the Tomcat APR library is not required.

I am very grateful if it can be merged into the latest release.
Thanks a lot.


was (Author: lfn):
Hi Goldstein

We finally solved the issue.
The attachment 'sshd-core.zip' is the source code associated with resolving the 
issue (based on the latest master branch).
Now SSHD can support agent forwarding implementations of both IETF and OpenSSH, 
and the Tomcat APR library is not required.

I am very grateful if it can be merged into the latest release.
Thanks a log.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: block.png, debug.log, environment.png, log1.txt, 
> log2.txt, sshd-core.zip, SshdTest2.java, SshdTest3.java, stacktrace.png
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

[Li Fangning (JIRA)]

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069432#comment-16069432
 ] 

Li Fangning edited comment on SSHD-700 at 6/30/17 4:01 AM:
---

Hi Goldstein

We finally solved the issue.
The attachment '[^sshd-core.zip]' is the source code associated with resolving 
the issue (based on the latest master branch).
Now SSHD can support agent forwarding implementations of both IETF and OpenSSH, 
and the Tomcat APR library is not required.

I am very grateful if it can be merged into the latest release.
Thanks a lot.


was (Author: lfn):
Hi Goldstein

We finally solved the issue.
The attachment 'sshd-core.zip' is the source code associated with resolving the 
issue (based on the latest master branch).
Now SSHD can support agent forwarding implementations of both IETF and OpenSSH, 
and the Tomcat APR library is not required.

I am very grateful if it can be merged into the latest release.
Thanks a lot.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: block.png, debug.log, environment.png, log1.txt, 
> log2.txt, sshd-core.zip, SshdTest2.java, SshdTest3.java, stacktrace.png
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

[Li Fangning (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Li Fangning updated SSHD-700:
-
Attachment: sshd-core.zip

The changed code to support agent forwarding of both IETF and  OpenSSH.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: block.png, debug.log, environment.png, log1.txt, 
> log2.txt, sshd-core.zip, SshdTest2.java, SshdTest3.java, stacktrace.png
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SSHD-700) SSHD does not suppot agent forwarding for XShell and XAgent

[Li Fangning (JIRA)]

[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069432#comment-16069432
 ] 

Li Fangning commented on SSHD-700:
--

Hi Goldstein

We finally solved the issue.
The attachment 'sshd-core.zip' is the source code associated with resolving the 
issue (based on the latest master branch).
Now SSHD can support agent forwarding implementations of both IETF and OpenSSH, 
and the Tomcat APR library is not required.

I am very grateful if it can be merged into the latest release.
Thanks a log.

> SSHD does not suppot agent forwarding for XShell and XAgent
> ---
>
> Key: SSHD-700
> URL: https://issues.apache.org/jira/browse/SSHD-700
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.2.0
> Environment: Windows 10 and CentOS 7
> XShell 5.0
>Reporter: Li Fangning
>Priority: Minor
> Attachments: block.png, debug.log, environment.png, log1.txt, 
> log2.txt, SshdTest2.java, SshdTest3.java, stacktrace.png
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Apache Mina SSHD 1.6.0

[Jeff Genender]

+1

Jeff


> On Jun 29, 2017, at 3:36 AM, Guillaume Nodet  wrote:
> 
> I've staged a release for SSHD 1.6.0 at:
>  https://repository.apache.org/content/repositories/orgapachemina-1031
> 
> I've moved issues targeted to 1.5.0 to 1.6.0, so we have the overall
> following changes:
> 
> Release Notes - MINA SSHD - Version 1.6.0
> ** Bug
>* [SSHD-85] - Port Forward closes connection before all bytes are sent
>* [SSHD-728] - sshd-core sftp not working with FileZilla sftp client
>* [SSHD-731] - Vulnerability in SimpleAccessControlSftpEventListener
> implementation
>* [SSHD-732] - ClientIdentitiesWatcher should load keys one at a time
>* [SSHD-734] - When ClientSessionImpl construction fails,
> AbstractSessionIoHandler#exceptionCaught may throw NPE
>* [SSHD-749] - SFTP client sends wrong open flags for protocol version 4
>* [SSHD-752] - HostConfigEntry can't parse tabbed SSH config files
>* [SSHD-753] - SSHD cannot read its keyfile through a symlink
> ** Improvement
>* [SSHD-739] - A call to resolvePropertyValue can be very inefficient
>* [SSHD-740] - Add default methods on PropertyResolver to actually do
> the property resolution
>* [SSHD-747] - Add support for non-standard port specification in
> known_hosts file
>* [SSHD-748] - Activate Maven PMD plugin in the project
> ** New Feature
>* [SSHD-656] - Support The PROXY protocol
>* [SSHD-710] - Cannot connect standard OpenSSH client/server using
> ed25519 keys
>* [SSHD-741] - Provide seamless replacement for Spring integation SFTP
> adapter
>* [SSHD-750] - Accept SSH clients advertising vesion 1.99
> ** Task
>* [SSHD-727] - Upgrade used EdDSA artifact version to 1.1
> ** Wish
>* [SSHD-733] - SSHD server displays file symlinks instead of dir
> symlinks
> 
> 
> Please review and vote !
> 
> Cheers,
> Guillaume Nodet

Re: [VOTE] Apache Mina SSHD 1.6.0

[elijah baley]

+1 - if my vote counts since I wrote a lot of the fixes/features


Lyor



From: Guillaume Nodet 
Sent: Thursday, June 29, 2017 12:36 PM
To: dev@mina.apache.org
Subject: [VOTE] Apache Mina SSHD 1.6.0

I've staged a release for SSHD 1.6.0 at:
  https://repository.apache.org/content/repositories/orgapachemina-1031

I've moved issues targeted to 1.5.0 to 1.6.0, so we have the overall
following changes:

Release Notes - MINA SSHD - Version 1.6.0
** Bug
* [SSHD-85] - Port Forward closes connection before all bytes are sent
* [SSHD-728] - sshd-core sftp not working with FileZilla sftp client
* [SSHD-731] - Vulnerability in SimpleAccessControlSftpEventListener
 implementation
* [SSHD-732] - ClientIdentitiesWatcher should load keys one at a time
* [SSHD-734] - When ClientSessionImpl construction fails,
AbstractSessionIoHandler#exceptionCaught may throw NPE
* [SSHD-749] - SFTP client sends wrong open flags for protocol version 4
* [SSHD-752] - HostConfigEntry can't parse tabbed SSH config files
* [SSHD-753] - SSHD cannot read its keyfile through a symlink
** Improvement
* [SSHD-739] - A call to resolvePropertyValue can be very inefficient
* [SSHD-740] - Add default methods on PropertyResolver to actually do
the property resolution
* [SSHD-747] - Add support for non-standard port specification in
known_hosts file
* [SSHD-748] - Activate Maven PMD plugin in the project
** New Feature
* [SSHD-656] - Support The PROXY protocol
* [SSHD-710] - Cannot connect standard OpenSSH client/server using
ed25519 keys
* [SSHD-741] - Provide seamless replacement for Spring integation SFTP
adapter
* [SSHD-750] - Accept SSH clients advertising vesion 1.99
** Task
* [SSHD-727] - Upgrade used EdDSA artifact version to 1.1
** Wish
* [SSHD-733] - SSHD server displays file symlinks instead of dir
symlinks


Please review and vote !

Cheers,
Guillaume Nodet

[VOTE] Apache Mina SSHD 1.6.0

[Guillaume Nodet]

I've staged a release for SSHD 1.6.0 at:
  https://repository.apache.org/content/repositories/orgapachemina-1031

I've moved issues targeted to 1.5.0 to 1.6.0, so we have the overall
following changes:

Release Notes - MINA SSHD - Version 1.6.0
** Bug
* [SSHD-85] - Port Forward closes connection before all bytes are sent
* [SSHD-728] - sshd-core sftp not working with FileZilla sftp client
* [SSHD-731] - Vulnerability in SimpleAccessControlSftpEventListener
 implementation
* [SSHD-732] - ClientIdentitiesWatcher should load keys one at a time
* [SSHD-734] - When ClientSessionImpl construction fails,
AbstractSessionIoHandler#exceptionCaught may throw NPE
* [SSHD-749] - SFTP client sends wrong open flags for protocol version 4
* [SSHD-752] - HostConfigEntry can't parse tabbed SSH config files
* [SSHD-753] - SSHD cannot read its keyfile through a symlink
** Improvement
* [SSHD-739] - A call to resolvePropertyValue can be very inefficient
* [SSHD-740] - Add default methods on PropertyResolver to actually do
the property resolution
* [SSHD-747] - Add support for non-standard port specification in
known_hosts file
* [SSHD-748] - Activate Maven PMD plugin in the project
** New Feature
* [SSHD-656] - Support The PROXY protocol
* [SSHD-710] - Cannot connect standard OpenSSH client/server using
ed25519 keys
* [SSHD-741] - Provide seamless replacement for Spring integation SFTP
adapter
* [SSHD-750] - Accept SSH clients advertising vesion 1.99
** Task
* [SSHD-727] - Upgrade used EdDSA artifact version to 1.1
** Wish
* [SSHD-733] - SSHD server displays file symlinks instead of dir
symlinks


Please review and vote !

Cheers,
Guillaume Nodet

[jira] [Updated] (SSHD-731) Vulnerability in SimpleAccessControlSftpEventListener implementation

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-731:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> Vulnerability in SimpleAccessControlSftpEventListener  implementation
> -
>
> Key: SSHD-731
> URL: https://issues.apache.org/jira/browse/SSHD-731
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Boris Fridland
>Assignee: Goldstein Lyor
>Priority: Minor
> Fix For: 1.6.0
>
>
> After implementing sftp access control by overriding 
> SimpleAccessControlSftpEventListener and adding it to SftpSubsystemFactory:
> Scenario:
> 1.set SimpleAccessControlSftpEventListener.isModificationAllowed to return 
> false
> 2.  Establish connection with WinScp
> 3. try to create new file
> expected result: access denied  message + no influence on file system
> actual: access denied  message, + empty file is written to server disc.
> in addition if existing file is opened, and being saved --> result is that 
> file content of is removed.
> Attached configuration code:
> {code:java}
> SftpSubsystemFactory.Builder builder = new SftpSubsystemFactory.Builder();
> builder.addSftpEventListener(new 
> SimpleAccessControlSftpEventListener() {
> protected boolean isAccessAllowed(ServerSession session, String 
> remoteHandle, Path localPath)
> throws IOException {
> EUserAccessLevel level = 
> authorizationManager.getAccessLevel(session.getUsername());
> return level.hasReadAccess();
> }
> protected boolean isModificationAllowed(ServerSession session, 
> String remoteHandle, Path localPath)
> throws IOException {
> EUserAccessLevel level = 
> authorizationManager.getAccessLevel(session.getUsername());
>return level.hasWriteAccess();
> }
> });
> 
> sshd.setSubsystemFactories(Collections.singletonList(builder.build()));
> sshd.setCommandFactory(new ScpCommandFactory());
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-656) Support The PROXY protocol

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-656:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> Support The PROXY protocol
> --
>
> Key: SSHD-656
> URL: https://issues.apache.org/jira/browse/SSHD-656
> Project: MINA SSHD
>  Issue Type: New Feature
>Reporter: Eugene Petrenko
>Assignee: Goldstein Lyor
>Priority: Minor
> Fix For: 1.6.0
>
>
> Load Balancing and other higher availability services are included between 
> client and SSHD server and works on TCP level. This makes an actual client 
> address shown in the SSHD server to be a load balancer address, not a real 
> client address. This makes it hard to use SSHD for multi-node production 
> scenarios. 
>  
> There are several ways to solve the issue.
> The first one is to include complex TCP routing to have specific packets 
> delivered correctly. This is too hard to setup
> It looks like using {{The PROXY Protocol}} is the possible, easy and more or 
> less standard way to pass actual client/server addresses to the server over 
> TCP.  The protocol is  implemented by a number of TCP-based servers 
> (including nginx, Amazon Load Balancer, Apache, github enterprise, see the 
> link below for details)
> Protocol specification is here 
> http://www.haproxy.org/download/1.6/doc/proxy-protocol.txt



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-733) SSHD server displays file symlinks instead of dir symlinks

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-733:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> SSHD server displays file symlinks instead of dir symlinks
> --
>
> Key: SSHD-733
> URL: https://issues.apache.org/jira/browse/SSHD-733
> Project: MINA SSHD
>  Issue Type: Wish
>Affects Versions: 1.2.0
> Environment: Windows/Linux
>Reporter: Marcin Kozakiewicz
>Assignee: Goldstein Lyor
>Priority: Minor
> Fix For: 1.6.0
>
>
> We use sshd for junit testing of sftp file transfers. 
> Scenario:
> 1.create filesystem:
> {code}
> ├── mem0
> │   └── mem0.txt
> ├── run -> mem0
> └── run2 -> mem0
> {code}
> 2. Start SSh server with given file system.
> code snippet from out project:
> {code}
> _server = SshServer.setUpDefaultServer();
> _server.setHost("localhost");
> _server.setPort(PORT);
> _server.setKeyPairProvider(new SimpleGeneratorHostKeyProvider());
> _server.setPasswordAuthenticator(new PasswordAuthenticator() {
> @Override
> public boolean authenticate(final String username, final String 
> password, final ServerSession session) {
> return USERNAME.equals(username) && PASSWORD.equals(password);
> }
> });
> _server.setSubsystemFactories(singletonList(new 
> SftpSubsystemFactory()));
> _server.setFileSystemFactory(new 
> VirtualFileSystemFactory(fileSystemPath));
> _server.start();
> {code}
> 3. Connect to server with sftp client.
> Result:
> run and run2 symlinks are presented as file symlinks instead of directory 
> symlinks.
> Expected result:
> run and run2 are presented as directory symlinks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-732:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Critical
> Fix For: 1.6.0
>
> Attachments: 
> org.apache.sshd.common.auth.AuthenticationTest-output.txt, 
> org.apache.sshd.common.auth.AuthenticationTest.txt
>
>
> The keys are loaded into a List instead of using an 
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user 
> for passwords which may not be used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-728) sshd-core sftp not working with FileZilla sftp client

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-728:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> sshd-core sftp not working with FileZilla sftp client
> -
>
> Key: SSHD-728
> URL: https://issues.apache.org/jira/browse/SSHD-728
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: tntim96
>Assignee: Goldstein Lyor
> Fix For: 1.6.0
>
>
> I've upgraded from sshd-core 0.14.0 to 1.3.0. FileZilla file download for 
> largish files worked on 0.14.0 but not 1.3.0.
> Steps to reproduce:
> # Set up a server with the code below
> # Make sure there is a largish file to download (I tested with size 1048576)
> # Connect to the server with FileZilla (I tried version 3.9.0.5)
> # Try to download the file
> # The error {noformat}Error:  error while reading: received a short buffer 
> from FXP_READ, but not at EOF
> Error:File transfer failed after transferring 16384 bytes in 1 
> second{noformat} appears in the FileZilla logs
> # Multiple FileZilla popups to overwrite the file appear (obviously connected 
> to the error above)
> # The download fails
> {code:title=Simple configuration to generate error}
> SshServer sshd = SshServer.setUpDefaultServer();
> sshd.setKeyPairProvider(new SimpleGeneratorHostKeyProvider());
> sshd.setPort();
> sshd.setShellFactory(InteractiveProcessShellFactory.INSTANCE);
> sshd.setPasswordAuthenticator((username, password, session) -> 
> Objects.equals(username, password));
> sshd.setPublickeyAuthenticator(AcceptAllPublickeyAuthenticator.INSTANCE);
> sshd.setTcpipForwardingFilter(AcceptAllForwardingFilter.INSTANCE);
> sshd.setCommandFactory(new ScpCommandFactory.Builder().withDelegate(
> command -> new ProcessShellFactory(GenericUtils.split(command, ' 
> ')).create()
> ).build());
> sshd.setSubsystemFactories(Collections.singletonList(new 
> SftpSubsystemFactory()));
> sshd.start();
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-740) Add default methods on PropertyResolver to actually do the property resolution

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-740:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> Add default methods on PropertyResolver to actually do the property resolution
> --
>
> Key: SSHD-740
> URL: https://issues.apache.org/jira/browse/SSHD-740
> Project: MINA SSHD
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 1.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-727) Upgrade used EdDSA artifact version to 1.1

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-727:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> Upgrade used EdDSA artifact version to 1.1
> --
>
> Key: SSHD-727
> URL: https://issues.apache.org/jira/browse/SSHD-727
> Project: MINA SSHD
>  Issue Type: Task
>Affects Versions: 1.4.0
>Reporter: Goldstein Lyor
>Assignee: Goldstein Lyor
>  Labels: features, security
> Fix For: 1.6.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> See if the newer version contains the new security provider as well as 
> renamed signature name and adjust the SSHD code accordingly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-734) When ClientSessionImpl construction fails, AbstractSessionIoHandler#exceptionCaught may throw NPE

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-734:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> When ClientSessionImpl construction fails, 
> AbstractSessionIoHandler#exceptionCaught may throw NPE
> -
>
> Key: SSHD-734
> URL: https://issues.apache.org/jira/browse/SSHD-734
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Grzegorz Grzybek
>Assignee: Guillaume Nodet
> Fix For: 1.6.0
>
>
> # {{org.apache.sshd.common.session.helpers.AbstractSession#sendKexInit()}} is 
> called in {{ClientSessionImpl}} constructor
> # {{org.apache.sshd.common.io.IoSession#write}} is called
> # async write is done with handler created by 
> {{org.apache.sshd.common.io.nio2.Nio2Session#createWriteCycleCompletionHandler()}}
> # if e.g., {{sun.nio.ch.UnixAsynchronousSocketChannelImpl#implWrite()}} 
> fails, it calls 
> {{org.apache.sshd.common.io.nio2.Nio2CompletionHandler#onFailed()}}
> # {{org.apache.sshd.common.io.nio2.Nio2Session#exceptionCaught()}} calls 
> {{org.apache.sshd.common.io.IoHandler#exceptionCaught()}}
> # 
> {{org.apache.sshd.common.session.helpers.AbstractSessionIoHandler#exceptionCaught()}}
>  can't find session in {{AbstractSession.getSession(ioSession, true)}}
> # it throws {{throw new IllegalStateException("No session available", 
> cause)}} instead of something more related to actual problem
> The solution to "No session available" is simply to attach session in 
> {{ClientSessionImpl}} constructor before starting sshd handshake
> There's however more - how to propagate the exception from 
> {{ClientSessionImpl}} constructor?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SSHD-739) A call to resolvePropertyValue can be very inefficient

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated SSHD-739:
-
Fix Version/s: (was: 1.5.0)
   1.6.0

> A call to resolvePropertyValue can be very inefficient
> --
>
> Key: SSHD-739
> URL: https://issues.apache.org/jira/browse/SSHD-739
> Project: MINA SSHD
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 1.6.0
>
>
> Each time a property is retrieved, all system properties names are iterated.
> This is because {{PropertyResolverUtil#resolvePropertyValue}} is calling 
> {{GenericUtils.isEmpty(props)}} on a {{SyspropsMapWrapper}}.
> This can be solved by using {{isNull(props)}} instead of {{isEmpty(props)}} 
> as there's no need to check if the map is empty.
> In the same call, there's also a call to {{System.getProperty}} which seems 
> to be redundant with the {{SyspropsMapWrapper}}.  I think it should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

About ProxyAgent

[suzl]

Hi guys.

I need your help. In class 
"org.apache.sshd.agent.local.ProxyAgentFactory" function 
"getChannelForwardingFactories", it returns 
UnixAgentFactory.DEFAULT_FORWARDING_CHANNELS, and I think it should 
return LocalAgentFactory.DEFAULT_FORWARDING_CHANNELS. Is it a mistake or 
has some special purpose?


thx.

--
苏振亮
齐治科技—运维堡垒机的缔造者和领导者！
-
浙江齐治科技股份有限公司
移动电话：15158013429
电子邮箱：s...@shterm.com
公司网站：www.shterm.com
服务热线：400-880-2393
办公地址：杭州市滨江区滨盛路1505号银丰大厦2504室
邮政编码：310052