[GitHub] [mina-sshd] tomaswolf commented on issue #293: Performance problems in tests (NIO2 and MINA, Linux only)

2023-01-02 Thread GitBox


tomaswolf commented on issue #293:
URL: https://github.com/apache/mina-sshd/issues/293#issuecomment-1369168078

   This is also reproducible for me in a CentOS 7 virtual machine running 
locally. From the logs I see that with NIO2 and MINA, there is a 40ms delay for 
getting these extra 1kB chunks, which isn't present in the Netty logs. But I 
have no idea yet where these 40ms come from.
   
   Bisecting did not yield any insights.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[GitHub] [mina-sshd] tomaswolf commented on issue #283: Client:Sent SSH_MSG_USERAUTH_REQUEST twice even PASSWORD_PROMPTS=1

2023-01-02 Thread GitBox


tomaswolf commented on issue #283:
URL: https://github.com/apache/mina-sshd/issues/283#issuecomment-1369166287

   Absent an answer, I've pushed a fix to PR #284. It implements 
`CoreModuleProperties.PASSWORD_PROMPTS`as the equivalent of the OpenSSH config 
`NumberOfPasswordPrompts`. Only interactive authentication attempts count 
towards the limit.
   
   There is no special guard against a server that keeps sending challenges in 
keyboard-interactive authentication. Normally such behavior would be caught by 
either of the following:
   * supplied passwords for non-interactively authenticating being exhausted,
   * the user cancelling authentication on the umpteenth interactive dialog for 
a challenge,
   * or the client's authentication time-out expiring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[GitHub] [mina-sshd] tomaswolf closed issue #300: The variable sender of channelOpenConfirmation is possibly negative

2023-01-02 Thread GitBox


tomaswolf closed issue #300: The variable sender of channelOpenConfirmation is 
possibly negative
URL: https://github.com/apache/mina-sshd/issues/300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[GitHub] [mina-sshd] tomaswolf merged pull request #305: GH-300: SSH_MSG_CHANNEL_OPEN_CONFIRMATION: channel ID is unsigned

2023-01-02 Thread GitBox


tomaswolf merged PR #305:
URL: https://github.com/apache/mina-sshd/pull/305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[GitHub] [mina-sshd] tomaswolf opened a new pull request, #305: GH-300: SSH_MSG_CHANNEL_OPEN_CONFIRMATION: channel ID is unsigned

2023-01-02 Thread GitBox


tomaswolf opened a new pull request, #305:
URL: https://github.com/apache/mina-sshd/pull/305

   Fix reading the id from the message, and add a test in which the server uses 
artificially high channel IDs beyond Integer.MAX_VALUE.
   
   Fixes #300.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org