[GitHub] mina-sshd pull request #83: [SSHD-876] Look through the resolvable class loa...

2018-12-15 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/83


---

[GitHub] mina-sshd pull request #82: [SSHD-708] Fixed support for OpenSSH encrypted p...

2018-12-13 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/82


---

[GitHub] mina-sshd pull request #83: [SSHD-876] Look through the resolvable class loa...

2018-12-13 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/83

[SSHD-876] Look through the resolvable class loaders hierarchy when looking 
for the 'sshd-version.properties' file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-876

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit dedefa3ed1535a6ed5556e27ecce277e6712bf3d
Author: Lyor Goldstein 
Date:   2018-12-13T12:55:17Z

[SSHD-876] Look through the resolvable class loaders hierarchy when looking 
for the 'sshd-version.properties' file




---

[GitHub] mina-sshd pull request #82: [SSHD-708] Fixed support for OpenSSH encrypted p...

2018-12-12 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/82

[SSHD-708] Fixed support for OpenSSH encrypted private keys decoding when 
'bcrypt' KDF is used

* Increased the limit on `MAX_ROUNDS`
* Made the limitation configurable via system property
* Updated `README.md` file about the `bcrypt` settings and behavior 
regarding the `MAX_ROUNDS`
* Removed dangerous constructor/initializer of the KDF options


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-708

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #82


commit 687571f6f4c6c448d56deb98eb76d87ad622d7ff
Author: Lyor Goldstein 
Date:   2018-12-12T13:23:04Z

[SSHD-708] Fixed support for OpenSSH encrypted private keys decoding when 
'bcrypt' KDF is used




---

[GitHub] mina-sshd pull request #72: [SSHD-849] Using a ClientChannelPendingMessagesQ...

2018-10-30 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/72


---

[GitHub] mina-sshd pull request #72: [SSHD-849] Using a ClientChannelPendingMessagesQ...

2018-10-18 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/72

[SSHD-849] Using a ClientChannelPendingMessagesQueue to regulate messages 
order while forwarding channel is being set up



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-849

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #72


commit 9e4493768917613d6394ad8d170e03806001ac65
Author: Lyor Goldstein 
Date:   2018-10-18T14:34:53Z

[SSHD-849] Using a ClientChannelPendingMessagesQueue to regulate messages 
order while forwarding channel is being set up




---

[GitHub] mina-sshd pull request #71: OpenSSH client creates hash with port, mina shou...

2018-10-18 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/71


---

[GitHub] mina-sshd pull request #71: OpenSSH client creates hash with port, mina shou...

2018-10-17 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/71

OpenSSH client creates hash with port, mina should be able to verify …

…that hash

Compare hash with `[host]:port` if port is non-standard

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NLeSC/mina-sshd hashed-known-host-port

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #71


commit 5c380939b3af687619514d378a6fab43cf6ae585
Author: Stefan Verhoeven 
Date:   2018-10-17T17:32:16Z

OpenSSH client creates hash with port, mina should be able to verify that 
hash

Compare hash with `[host]:port` if port is non-standard




---

[GitHub] mina-sshd pull request #57: [SSHD-721] Close only SSH channel and not the se...

2018-05-21 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/57


---

[GitHub] mina-sshd pull request #57: [SSHD-721] Close only SSH channel and not the se...

2018-05-06 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/57

[SSHD-721] Close only SSH channel and not the session if error encountered 
during tunnel data read/write

See attached

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-721

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit c6fac3a56fcc813e182767aafe393247d06b6b76
Author: Goldstein Lyor <lyor@...>
Date:   2018-05-06T06:53:56Z

[SSHD-721] Close only SSH channel and not the session if error encountered 
during read/write of data through a forwarding tunnel




---

[GitHub] mina-sshd pull request #50: [SSHD-812] Made SftpSubsystem more thread-safe

2018-04-23 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/50


---

[GitHub] mina-sshd pull request #54: [SSHD-816] Provide some way for the SSHD command...

2018-04-17 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/54


---

[GitHub] mina-sshd pull request #54: [SSHD-816] Provide some way for the SSHD command...

2018-04-17 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/54

[SSHD-816] Provide some way for the SSHD command line server to detect and 
configure the (split) SFTP subsystem

I would appreciate some feedback before I merge it into _master_

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-816

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 9c053c8397c9f7f1ff54ec2a6e5cb1cee0dcb2eb
Author: Goldstein Lyor <lyor@...>
Date:   2018-04-17T07:13:01Z

[SSHD-816] Moved all 'main' code for client commands to sshd-cli module

commit fdd7a461ef8f682f1e2318d40c003e88646413ad
Author: Goldstein Lyor <lyor@...>
Date:   2018-04-17T09:15:54Z

[SSHD-816] Provide some way for the SSHD command line server to detect and 
configure the (split) SFTP subsystem




---

[GitHub] mina-sshd pull request #50: [SSHD-812] Made SftpSubsystem more thread-safe

2018-04-11 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/50

[SSHD-812] Made SftpSubsystem more thread-safe

Attached is my suggestion for the code changes:

* Split the `SftpSubsystem` functionality further to 
`AbstractSftpSubsystemExecutor` by leaving the decision how to run it to the 
concrete implementation.
* All "dangerous" access protected via _synchronized_ blocks
* Many _protected_ hooks for concrete classes - with concurrency in mind

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-812

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 01157272ac94739d0f980d2ddd3246f9f40b3270
Author: Goldstein Lyor <lyor@...>
Date:   2018-04-08T14:12:35Z

[SSHD-812] Made SftpSubsystem more thread-safe




---

[GitHub] mina-sshd pull request #41: [SSHD-779] Attach pending packets write-completi...

2017-12-20 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/41


---

[GitHub] mina-sshd pull request #40: [SSHD-786] Clients can't authenticate after unex...

2017-12-19 Thread lgoldstein 
Github user lgoldstein closed the pull request at:

https://github.com/apache/mina-sshd/pull/40


---

[GitHub] mina-sshd pull request #41: [SSHD-779] Attach pending packets write-completi...

2017-12-17 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/41

[SSHD-779] Attach pending packets write-completion listeners to their 
respective write-future(s) outside the encode locking block

Avoid possible deadlock in {{handleNewKeys}} invocation

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-779

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit ad3219496a418be3c5ef9e46165a4f3bc74474d3
Author: Goldstein Lyor <l...@c-b4.com>
Date:   2017-12-17T05:59:04Z

[SSHD-779] Attach pending packets write-completion listeners to their 
respective write-future(s) outside the encode locking block




---

[GitHub] mina-sshd pull request #40: [SSHD-786] Clients can't authenticate after unex...

2017-12-07 Thread lgoldstein 
GitHub user lgoldstein opened a pull request:

https://github.com/apache/mina-sshd/pull/40

[SSHD-786] Clients can't authenticate after unexpected exception in 
Nio2Acceptor

I have decide to along with _Guillaume_'s suggestion but with a minor twist 
- if the attempt to re-accept fails we do not call _fail_ in order to avoid 
infinite recursion.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lgoldstein/mina-sshd SSHD-786

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 947840027e9a110d13686d18240b64659988a326
Author: Goldstein Lyor <l...@c-b4.com>
Date:   2017-12-07T06:30:33Z

[SSHD-786] Mark Nio2Service correctly as disposing when dispose() called

commit 91074db17be498c0870affa4991f4a2a9e0f0fbb
Author: Goldstein Lyor <l...@c-b4.com>
Date:   2017-12-07T07:02:35Z

[SSHD-786] Clients can't authenticate after unexpected exception in 
Nio2Acceptor




---