[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory commented on PR #12: URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1099081289 Closing: Done in git master and more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1067086711
> Hi @garydgregor,
>
> sure enough, but I reversed the {{SslConfiguration}} interface to what it
was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary compatibility.
>
> Sorry if that sounds dumb, I'm a bit overloaded atm...
Hi @elecharny
1.1.4 is ok 1.2.0 is broken, please see my explanation in Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory commented on pull request #12: URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102 Hello @elecharny , The code you quote is completely irrelevant. What matters is that a public interface breaks binary compatibility. Since user can implement the public interface, those implementations no longer complie! The fix is simple and provides both binary and source compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
