[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249423#comment-16249423
]
masc edited comment on SSHD-743 at 11/13/17 11:35 AM:
--
ok. I can't further comment on this without digging deeper, but from my current
perspective, expecting and handling the exception in this particular spot by
merely logging the incident would be the right choice. I do not believe that
adjusting {{startWrite}} to not throw would be the right solution here, but
it's your choice of course.
was (Author: masc3d):
ok. I can't further comment on this without digging deeper, but from my current
perspective, expecting and handling the exception in this particular spot by
merely logging the incident would be the right choice. I do not believe that
adjusting {startWrite} to not throw would be the right solution here, but it's
your choice of course.
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246092#comment-16246092
]
masc edited comment on SSHD-743 at 11/9/17 5:22 PM:
actually I don't think it makes sense at all to start writing when the writing
actually failed and the reason/crucial part {{finishWrite}} is called for
during write failure is.
{code}
writes.remove(future);
currentWrite.compareAndSet(future, null);
{code}
was (Author: masc3d):
actually I don't think it makes sense at all to start writing when the writing
actually failed and the reason/crucial part {finishWrite} is called for during
write failure is.
{code}
writes.remove(future);
currentWrite.compareAndSet(future, null);
{code}
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245747#comment-16245747
]
masc edited comment on SSHD-743 at 11/9/17 2:40 PM:
as I see it, {{finishWrite}} is ok and should actually throw. it's just, that
it should be expected to fail when being called while handling a write failure.
so I would still prefer the exception being handled and merely logged in
{{handleWriteCycleFailure}}, which is probably also the most defensive
implementation without side-effects.
was (Author: masc3d):
as I see it, {finishWrite} is ok and should actually throw. it's just, that it
should be expected to fail when being called while handling a write failure. so
I would still prefer the exception being handled and merely logged in
{handleWriteCycleFailure}, which is probably also the most defensive
implementation without side-effects.
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235781#comment-16235781
]
masc edited comment on SSHD-743 at 11/2/17 2:04 PM:
I believe {{finishWrite}} should be allowed to throw at all times.
t's only fatal within the failure handle, so I would go with the following,
which is also safe not to break anything else.
{code}
try {
finishWrite(future);
} catch(Throwable e) {
log.trace("handleWriteCycleFailure() finishWrite failed: " +
e.getMessage());
}
{code}
was (Author: masc3d):
I believe {{finsihWrite}} should be allowed to throw at all times.
t's only fatal within the failure handle, so I would go with the following,
which is also safe not to break anything else.
{code}
try {
finishWrite(future);
} catch(Throwable e) {
log.trace("handleWriteCycleFailure() finishWrite failed: " +
e.getMessage());
}
{code}
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235781#comment-16235781
]
masc edited comment on SSHD-743 at 11/2/17 2:04 PM:
I believe {{finishWrite}} should be allowed to throw at all times.
t's only fatal within the failure handler, so I would go with the following,
which is also safe not to break anything else.
{code}
try {
finishWrite(future);
} catch(Throwable e) {
log.trace("handleWriteCycleFailure() finishWrite failed: " +
e.getMessage());
}
{code}
was (Author: masc3d):
I believe {{finishWrite}} should be allowed to throw at all times.
t's only fatal within the failure handle, so I would go with the following,
which is also safe not to break anything else.
{code}
try {
finishWrite(future);
} catch(Throwable e) {
log.trace("handleWriteCycleFailure() finishWrite failed: " +
e.getMessage());
}
{code}
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235735#comment-16235735
]
Goldstein Lyor edited comment on SSHD-743 at 11/2/17 1:42 PM:
--
[~gnt] Can you take at look at [this
commit|https://github.com/lgoldstein/mina-sshd/commit/64ec06c0fcee0180f7f97f7de1f7e43365c90281]
and tell me if you think it is an appropriate fix ? I am not that familiar
with this part of the code and would appreciate your review
was (Author: lgoldstein):
[~gnt] Can you take at look at [this
commit|https://github.com/lgoldstein/mina-sshd/commit/e46c3a80d75733975ec8f02487ec37e31ea3147c]
and tell me if you think it is an appropriate fix ? I am not that familiar
with this part of the code and would appreciate your review
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0, 1.6.0
>Reporter: masc
>Assignee: Goldstein Lyor
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235634#comment-16235634
]
masc edited comment on SSHD-743 at 11/2/17 12:19 PM:
-
the issue seems to be {{Nio2Session.handleWriteCycleFailure}} calling into
{{finishWrite}} without expecting failure.
was (Author: masc3d):
the issue seems to be {Nio2Session.handleWriteCycleFailure} calling into
{finishWrite} without expecting failure.
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0
> Environment: Windows
>Reporter: masc
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981468#comment-15981468
]
masc edited comment on SSHD-743 at 4/24/17 4:43 PM:
* The issue occurs since `1.3.0` but `1.4.0` was tested as well and didn't make
a difference.
* Yes, it breaks the client connection plus the exception is leaking from the
thread (that we don't own) terminating the entire host process.
* Yes we are primarily tunnelling rsync. We set the idle timeout for ssh
tunnels to 3 minutes on the host side and leave write timeouts at their
defaults. Those settings work fine with `1.2.0`.
was (Author: masc3d):
* The issue occurs since `1.3.0` but `1.4.0` was tested as well and didn't make
a difference.
* Yes, it breaks the client connection plus the exception is leaking from the
thread (that we don't own) terminating the entire process.
* Yes we are primarily tunnelling rsync. We set the idle timeout for ssh
tunnels to 3 minutes on the host side and leave write timeouts at their
defaults. Those settings work fine with `1.2.0`.
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0
> Environment: Windows
>Reporter: masc
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981468#comment-15981468
]
masc edited comment on SSHD-743 at 4/24/17 4:39 PM:
* The issue occurs since `1.3.0` but `1.4.0` was tested as well and didn't make
a difference.
* Yes, it breaks the client connection plus the exception is leaking from the
thread (that we don't own) terminating the entire process.
* Yes we are primarily tunnelling rsync. We set the idle timeout for ssh
tunnels to 3 minutes on the host side and leave write timeouts at their
defaults. Those settings work fine with `1.2.0`.
was (Author: masc3d):
* The issue occurs since `1.3.0` but `1.4.0` was tested as well and didn't make
a difference.
* Yes, it breaks the client connection plus the exception is leaking from the
thread (that we don't own), thus terminates the entire process.
* Yes we are primarily tunnelling rsync. We set the idle timeout for ssh
tunnels to 3 minutes on the host side and leave write timeouts at their
defaults. Those settings work fine with `1.2.0`.
> Nio2Session sporadically leaks exceptions from nio2 threads
> ---
>
> Key: SSHD-743
> URL: https://issues.apache.org/jira/browse/SSHD-743
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.4.0
> Environment: Windows
>Reporter: masc
>Priority: Critical
>
> We are using {{sshd-core}} for tcp forwarding/tunnelling.
> Since updating to {{1.3.0}} we see sporadic process terminations caused by
> exceptions leaking from nio2 threads.
> I had to downgrade to {{1.2.0}} to stabilise.
> {code}
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.apache.sshd.server.session.ServerSessionImpl WARN -
> exceptionCaught(ServerSessionImpl[leoz@/185.17.206.254:21464])[state=Opened]
> InterruptedByTimeoutException: null
> 2017-04-21 18:56:28,606 1245641365 sshd-SshServer[4be7acd9]-nio2-thread-3
> org.deku.leoz.node.Application ERROR - Writing not allowed due to timeout or
> cancellation
> java.lang.IllegalStateException: Writing not allowed due to timeout or
> cancellation
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:350)
> at
> sun.nio.ch.AsynchronousSocketChannelImpl.write(AsynchronousSocketChannelImpl.java:399)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.doWriteCycle(Nio2Session.java:334)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.startWriting(Nio2Session.java:318)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.finishWrite(Nio2Session.java:393)
> at
> org.apache.sshd.common.io.nio2.Nio2Session.handleWriteCycleFailure(Nio2Session.java:387)
> at
> org.apache.sshd.common.io.nio2.Nio2Session$2.onFailed(Nio2Session.java:348)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$failed$1(Nio2CompletionHandler.java:46)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.sshd.common.io.nio2.Nio2CompletionHandler.failed(Nio2CompletionHandler.java:45)
> at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:128)
> at sun.nio.ch.Invoker$2.run(Invoker.java:218)
> at
> sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
