[jira] [Assigned] (SSHD-749) SFTP client sends wrong open flags for protocol version 4

2017-05-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor reassigned SSHD-749:
---

Assignee: Goldstein Lyor

> SFTP client sends wrong open flags for protocol version 4
> -
>
> Key: SSHD-749
> URL: https://issues.apache.org/jira/browse/SSHD-749
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Christian Leiner
>Assignee: Goldstein Lyor
> Attachments: AbstractSftpClient_open_flags.patch, 
> SftpVersionsTest_open_flags.patch
>
>
> While trying to create a file on a remote server using {{SftpClient}}, I 
> always received {{SSH_FX_NO_SUCH_FILE}}. However, there were no problems with 
> the server when using another client.
> Debugging the issue, I discovered that {{AbstractSftpClient.open()}} doesn't 
> handle the {{OpenMode}} options according to the spec when using protocol 
> version 4 (https://tools.ietf.org/html/draft-ietf-secsh-filexfer-04) and 
> diverges from SSHD's server implementation as well (i.e. 
> {{SftpSubsystem.doOpen()}}).
> I have attached a test case to reproduce the problem 
> ({{SftpVersionsTest_open_flags.patch}}). There's also a simple patch that 
> should fix the issue ({{AbstractSftpClient_open_flags.patch}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Work started] (SSHD-749) SFTP client sends wrong open flags for protocol version 4

2017-05-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on SSHD-749 started by Goldstein Lyor.
---
> SFTP client sends wrong open flags for protocol version 4
> -
>
> Key: SSHD-749
> URL: https://issues.apache.org/jira/browse/SSHD-749
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Christian Leiner
>Assignee: Goldstein Lyor
> Attachments: AbstractSftpClient_open_flags.patch, 
> SftpVersionsTest_open_flags.patch
>
>
> While trying to create a file on a remote server using {{SftpClient}}, I 
> always received {{SSH_FX_NO_SUCH_FILE}}. However, there were no problems with 
> the server when using another client.
> Debugging the issue, I discovered that {{AbstractSftpClient.open()}} doesn't 
> handle the {{OpenMode}} options according to the spec when using protocol 
> version 4 (https://tools.ietf.org/html/draft-ietf-secsh-filexfer-04) and 
> diverges from SSHD's server implementation as well (i.e. 
> {{SftpSubsystem.doOpen()}}).
> I have attached a test case to reproduce the problem 
> ({{SftpVersionsTest_open_flags.patch}}). There's also a simple patch that 
> should fix the issue ({{AbstractSftpClient_open_flags.patch}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SSHD-749) SFTP client sends wrong open flags for protocol version 4

2017-05-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor resolved SSHD-749.
-
   Resolution: Fixed
Fix Version/s: 1.6.0

Thanks for the diangosis and patch - merged with appropriate credit.

> SFTP client sends wrong open flags for protocol version 4
> -
>
> Key: SSHD-749
> URL: https://issues.apache.org/jira/browse/SSHD-749
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Christian Leiner
>Assignee: Goldstein Lyor
> Fix For: 1.6.0
>
> Attachments: AbstractSftpClient_open_flags.patch, 
> SftpVersionsTest_open_flags.patch
>
>
> While trying to create a file on a remote server using {{SftpClient}}, I 
> always received {{SSH_FX_NO_SUCH_FILE}}. However, there were no problems with 
> the server when using another client.
> Debugging the issue, I discovered that {{AbstractSftpClient.open()}} doesn't 
> handle the {{OpenMode}} options according to the spec when using protocol 
> version 4 (https://tools.ietf.org/html/draft-ietf-secsh-filexfer-04) and 
> diverges from SSHD's server implementation as well (i.e. 
> {{SftpSubsystem.doOpen()}}).
> I have attached a test case to reproduce the problem 
> ({{SftpVersionsTest_open_flags.patch}}). There's also a simple patch that 
> should fix the issue ({{AbstractSftpClient_open_flags.patch}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] mina-sshd pull request #31: Allow SSH 1.99 in addition to 2.0 for SSHD

2017-05-26 Thread nu11ptr
GitHub user nu11ptr opened a pull request:

https://github.com/apache/mina-sshd/pull/31

Allow SSH 1.99 in addition to 2.0 for SSHD

Several versions ago, SSH 1.99 support was added to the client to allow it 
to connect to Cisco devices. I'm now proposing the same be done to allow Cisco 
devices still using 1.99 to connect to SSHD.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nu11ptr/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mina-sshd/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit f105ac9c82bb32ae3a8f064ca19caeb7aed4d94b
Author: Scott Meeuwsen 
Date:   2017-05-26T18:36:57Z

Allow SSH 1.99 in addition to 2.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (SSHD-710) Cannot connect standard OpenSSH client/server using ed25519 keys

2017-05-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor updated SSHD-710:

Issue Type: New Feature  (was: Bug)

> Cannot connect standard OpenSSH client/server using ed25519 keys
> 
>
> Key: SSHD-710
> URL: https://issues.apache.org/jira/browse/SSHD-710
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.4.0
>Reporter: Goldstein Lyor
>Assignee: Goldstein Lyor
>  Labels: security
>
> It seems that if the SSHD client is using an _ed25519_ identity or the SSHD 
> server presents an _ed25519_ key, then the generated signature is wrong 
> either when (client) public key authentication is executed or (server) KEX.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Work stopped] (SSHD-710) Cannot connect standard OpenSSH client/server using ed25519 keys

2017-05-26 Thread Goldstein Lyor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on SSHD-710 stopped by Goldstein Lyor.
---
> Cannot connect standard OpenSSH client/server using ed25519 keys
> 
>
> Key: SSHD-710
> URL: https://issues.apache.org/jira/browse/SSHD-710
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Goldstein Lyor
>Assignee: Goldstein Lyor
>  Labels: security
>
> It seems that if the SSHD client is using an _ed25519_ identity or the SSHD 
> server presents an _ed25519_ key, then the generated signature is wrong 
> either when (client) public key authentication is executed or (server) KEX.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)