[jira] [Created] (SSHD-809) Upgrade used unit tests version to jUnit 5

[Goldstein Lyor (JIRA)]

Goldstein Lyor created SSHD-809:
---

 Summary: Upgrade used unit tests version to jUnit 5
 Key: SSHD-809
 URL: https://issues.apache.org/jira/browse/SSHD-809
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 1.7.0
Reporter: Goldstein Lyor


See if it is easy to maintain backward compatibility - especially

* _getCurrentTestName()_
* {{@RunWith(JUnit4SingleInstanceClassRunner.class)}}
* {{@UseParametersRunnerFactory(JUnit4ClassRunnerWithParametersFactory.class)}}
* {{@Category(\{ NoIoTestCase.class \})}}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Apache MINA 2.0.17

[Guillaume Nodet]

+1

2018-03-06 15:09 GMT+01:00 Emmanuel Lécharny :

> Hi,
>
>
>
> Here is the list of fixed issues :
>
> Bugs :
> --
>
> [DIRMINA-844] - Http Proxy Authentication failed to complete (see
> description for exact point of failure)
> [DIRMINA-1002] - Mina IoHandlerEvents missing inputClosed enum item.
> [DIRMINA-1051] - The MD5withRSA cipher is not anymore supported by
> Java 8, and our tests certificates have been generated with it.
> [DIRMINA-1052] - Fix the mvn-site command
> [DIRMINA-1056] - IllegalArgumentException when setting max and
> minReadBufferSize > 65536 (default)
> [DIRMINA-1057] - AbstractIoSession getScheduledWriteMessages always
> -negative?
> [DIRMINA-1059] - NioProcessor's selector is synchronized but
> accessed outside
> [DIRMINA-1060] - Handle the spinning selectors in Socket/Datagram
> Acceptor and Connector
> [DIRMINA-1072] - SslFilter does not account for SSLEngine runtime
> exceptions
> [DIRMINA-1073] - NioSocketSession#isSecured does not comply with
> interface contract
> [DIRMINA-1076] - Leaking NioProcessors/NioSocketConnectors hanging
> in call to dispose
> [DIRMINA-1077] - Threads hanging in dispose() on SSLHandshakeException
>
> Improvement :
> -
>
> [DIRMINA-1061] - When AbstractPollingIoProcessor read nothing, free
> the temporary buffer should be better
>
> Task :
> --
>
> [DIRMINA-1058] - Add the missing Javadoc
>
>
> Here's the Jira link for this version if you'd like to review issues in
> more details:
>
> https://issues.apache.org/jira/projects/DIRMINA/versions/12338623
>
> A temporary tag has been created (it can be removed if the vote is not
> approved)
>
> The newly approved Nexus has been used for the preparation of this
> release and all final artifacts are stored
> in a staging repository:
> https://repository.apache.org/content/repositories/orgapachemina-1034/
>
>
> The distributions are available for download on :
> https://dist.apache.org/repos/dist/dev/mina/mina/2.0.17/
>
> Let us vote :
> [ ] +1 | Release MINA 2.0.17
> [ ] +/- | Abstain
> [ ] -1 | Do *NOT*  release MINA 2.0.17
>
> Thanks !
>
> --
> Emmanuel Lecharny
>
> Symas.com
> directory.apache.org
>
>


-- 

Guillaume Nodet

Re: [VOTE] Apache MINA 2.0.17

[Jeff MAURY]

+1
ᐧ

On Mon, Mar 12, 2018 at 7:59 AM, Guillaume Nodet  wrote:

> +1
>
> 2018-03-06 15:09 GMT+01:00 Emmanuel Lécharny :
>
> > Hi,
> >
> >
> >
> > Here is the list of fixed issues :
> >
> > Bugs :
> > --
> >
> > [DIRMINA-844] - Http Proxy Authentication failed to complete (see
> > description for exact point of failure)
> > [DIRMINA-1002] - Mina IoHandlerEvents missing inputClosed enum item.
> > [DIRMINA-1051] - The MD5withRSA cipher is not anymore supported by
> > Java 8, and our tests certificates have been generated with it.
> > [DIRMINA-1052] - Fix the mvn-site command
> > [DIRMINA-1056] - IllegalArgumentException when setting max and
> > minReadBufferSize > 65536 (default)
> > [DIRMINA-1057] - AbstractIoSession getScheduledWriteMessages always
> > -negative?
> > [DIRMINA-1059] - NioProcessor's selector is synchronized but
> > accessed outside
> > [DIRMINA-1060] - Handle the spinning selectors in Socket/Datagram
> > Acceptor and Connector
> > [DIRMINA-1072] - SslFilter does not account for SSLEngine runtime
> > exceptions
> > [DIRMINA-1073] - NioSocketSession#isSecured does not comply with
> > interface contract
> > [DIRMINA-1076] - Leaking NioProcessors/NioSocketConnectors hanging
> > in call to dispose
> > [DIRMINA-1077] - Threads hanging in dispose() on
> SSLHandshakeException
> >
> > Improvement :
> > -
> >
> > [DIRMINA-1061] - When AbstractPollingIoProcessor read nothing, free
> > the temporary buffer should be better
> >
> > Task :
> > --
> >
> > [DIRMINA-1058] - Add the missing Javadoc
> >
> >
> > Here's the Jira link for this version if you'd like to review issues in
> > more details:
> >
> > https://issues.apache.org/jira/projects/DIRMINA/versions/12338623
> >
> > A temporary tag has been created (it can be removed if the vote is not
> > approved)
> >
> > The newly approved Nexus has been used for the preparation of this
> > release and all final artifacts are stored
> > in a staging repository:
> > https://repository.apache.org/content/repositories/orgapachemina-1034/
> >
> >
> > The distributions are available for download on :
> > https://dist.apache.org/repos/dist/dev/mina/mina/2.0.17/
> >
> > Let us vote :
> > [ ] +1 | Release MINA 2.0.17
> > [ ] +/- | Abstain
> > [ ] -1 | Do *NOT*  release MINA 2.0.17
> >
> > Thanks !
> >
> > --
> > Emmanuel Lecharny
> >
> > Symas.com
> > directory.apache.org
> >
> >
>
>
> --
> 
> Guillaume Nodet
>



-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury

[jira] [Resolved] (SSHD-808) Run client/server unit tests with MINA IO

[Goldstein Lyor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SSHD-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor resolved SSHD-808.
-
   Resolution: Fixed
Fix Version/s: 1.8.0

> Run client/server unit tests with MINA IO
> -
>
> Key: SSHD-808
> URL: https://issues.apache.org/jira/browse/SSHD-808
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 1.7.0
>Reporter: Goldstein Lyor
>Assignee: Goldstein Lyor
>Priority: Major
>  Labels: mina, sshd, unit-test
> Fix For: 1.8.0
>
>
> Following the split of the MINA IO to its own artifact (SSHD-806) we need to 
> make sure that the client/server related unit-tests succeed with this session 
> factory as well. However, we do not want to run all the tests again - 
> especially those that do not involve I/O (e.g., MAC vectors validations, 
> load/save key-pairs, etc.).
> In order to do that perhaps we should use a _jUnit_ category marker for the 
> tests to be excluded (or included - depending which group is smaller) and 
> then run the tests with MINA IO, but only on the specified category.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved

[Anton Novikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anton Novikov updated DIRMINA-1079:
---
Attachment: DIRMINA-1079.patch

> MINA fails to connect from behind a proxy if endpoint is not resolved
> -
>
> Key: DIRMINA-1079
> URL: https://issues.apache.org/jira/browse/DIRMINA-1079
> Project: MINA
>  Issue Type: Bug
>  Components: Handler
>Affects Versions: 2.0.16
>Reporter: Anton Novikov
>Priority: Major
> Attachments: DIRMINA-1079.patch
>
>
> MINA fails to connect from behind a proxy if endpoint address is not 
> resolved. This happens for both HTTP and SOCKS proxy and it seems that the 
> reason for this are typos in HttpProxyRequest and SocksProxyRequest. The 
> following changes seem to fix the issue:
> HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} 
> with {{if (endpointAddress.isUnresolved()) {}}
> SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) 
> {}} with {{if (adr != null && adr.isUnresolved()) {}}
> Note the negation is gone in both cases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved

[Anton Novikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395785#comment-16395785
 ] 

Anton Novikov commented on DIRMINA-1079:


Here you go: [^DIRMINA-1079.patch]

> MINA fails to connect from behind a proxy if endpoint is not resolved
> -
>
> Key: DIRMINA-1079
> URL: https://issues.apache.org/jira/browse/DIRMINA-1079
> Project: MINA
>  Issue Type: Bug
>  Components: Handler
>Affects Versions: 2.0.16
>Reporter: Anton Novikov
>Priority: Major
> Attachments: DIRMINA-1079.patch
>
>
> MINA fails to connect from behind a proxy if endpoint address is not 
> resolved. This happens for both HTTP and SOCKS proxy and it seems that the 
> reason for this are typos in HttpProxyRequest and SocksProxyRequest. The 
> following changes seem to fix the issue:
> HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} 
> with {{if (endpointAddress.isUnresolved()) {}}
> SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) 
> {}} with {{if (adr != null && adr.isUnresolved()) {}}
> Note the negation is gone in both cases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)