Re: [DISCUSS] About the PR merging policy
I think it is fine as long as we act on good faith. I will normally respect code review comments from anyone who might be able to give reasonable comments, and beg to differ with good technical reasoning. Normally contributions happen in a way that things won't get blocked in small features. For major changes, RFC discussion would be helpful to resolve the case Tianqi On Tue, Dec 11, 2018 at 4:18 PM Qing Lan wrote: > Hi all, > > Recently I self-merged my PR without getting approvals from other > committers https://github.com/apache/incubator-mxnet/pull/13617 and only > contributors approval. I apologize to the community and thank Marco for > pointing out the problem. I took a lesson that we should at least have one > committer’s approval to merge the code. However, I just found this section > is missing in the CWiki > https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+%28incubating%29+Committer+and+PPMC+Member. > So I would like to discuss in here: > > How to conduct the PR reviewing/merging. How many approvals (Committers > and Contributors) we should get in order to merge? > > How to deal with disagreement in the discussion (e.g a > contributor/committer request a change)? > > Please don’t hesitate to share your thoughts! > > Thanks, > Qing >
[DISCUSS] About the PR merging policy
Hi all, Recently I self-merged my PR without getting approvals from other committers https://github.com/apache/incubator-mxnet/pull/13617 and only contributors approval. I apologize to the community and thank Marco for pointing out the problem. I took a lesson that we should at least have one committer’s approval to merge the code. However, I just found this section is missing in the CWiki https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+%28incubating%29+Committer+and+PPMC+Member. So I would like to discuss in here: How to conduct the PR reviewing/merging. How many approvals (Committers and Contributors) we should get in order to merge? How to deal with disagreement in the discussion (e.g a contributor/committer request a change)? Please don’t hesitate to share your thoughts! Thanks, Qing
Re: Slack invite hotlink
I am not sure honestly. I read that as the token expires in the 30 days and the shortened URL is permanent and will always point to the token even after it expires. There has been some discussion in the #asfinfra channel on slack[1]. If I figure anything out I'll report back. [1] https://the-asf.slack.com/archives/CBX4TSBQ8/p1544485682181600 On Tue, Dec 11, 2018 at 2:31 PM Marco de Abreu wrote: > Hi Mike, > > thanks for the heads up and linking the ticket. In there, Chris stated that > he converted the link to a permanent one: > > The link in your shortened URL is now permanent. > > Does that address your concerns? > > Best regards, > Marco > > On Tue, Dec 11, 2018 at 6:19 PM Michael Wall wrote: > > > Marco, > > > > Seems like that link is only good for 30 days. See > > https://issues.apache.org/jira/browse/INFRA-17152. > > > > Mike > > > > > > On Tue, Dec 11, 2018 at 12:01 PM Marco de Abreu > > > wrote: > > > > > Hey everyone, > > > > > > there's a hotlink [1] that allows people to join Apaches Slack server > > > directly, I found it here [2]. They would then still have to join the > > > #mxnet channel though. Should we maybe add this to the instructions on > > the > > > website? > > > > > > Best regards, > > > Marco > > > > > > [1]: https://s.apache.org/slack-invite > > > [2]: https://beam.apache.org/community/contact-us/ > > > > > >
LabelBot Predictions
Hey all, I am looking forward to moving the predictions of labels into production. This an effort to reduce the number of issues that go unlabelled by the community. Labelling these issues provides a better way to serve MXNet users. Currently there are about 10 labels which we can predict with over 90% accuracy. If the bot is able to predict for an issue with a high enough accuracy then we should label this issue appropriately - in the off chance the label prediction is incorrect labels can be removed. One of these labels is Question, so it would be nice for the bot to provide a welcoming message to users if it believes a question has been submitted. ( https://cwiki.apache.org/confluence/display/MXNET/Label+Prediction+by+the+@mxnet-label-bot ). Best, -Harsh
Re: Slack invite hotlink
Hi Mike, thanks for the heads up and linking the ticket. In there, Chris stated that he converted the link to a permanent one: > The link in your shortened URL is now permanent. Does that address your concerns? Best regards, Marco On Tue, Dec 11, 2018 at 6:19 PM Michael Wall wrote: > Marco, > > Seems like that link is only good for 30 days. See > https://issues.apache.org/jira/browse/INFRA-17152. > > Mike > > > On Tue, Dec 11, 2018 at 12:01 PM Marco de Abreu > wrote: > > > Hey everyone, > > > > there's a hotlink [1] that allows people to join Apaches Slack server > > directly, I found it here [2]. They would then still have to join the > > #mxnet channel though. Should we maybe add this to the instructions on > the > > website? > > > > Best regards, > > Marco > > > > [1]: https://s.apache.org/slack-invite > > [2]: https://beam.apache.org/community/contact-us/ > > >
Re: Include MKLDNN into default mxnet pip package
Great effort Alex and also folks from Intel. +1 to make MKLDNN default. On Tue, Dec 11, 2018 at 9:10 AM Kumar, Vikas wrote: > +1 > > On 12/10/18, 8:01 PM, "Zhao, Patric" wrote: > > +1, thanks for the efforts, Alex. > > > > > -Original Message- > > From: Alex Zai [mailto:aza...@gmail.com] > > Sent: Tuesday, December 11, 2018 8:00 AM > > To: dev@mxnet.incubator.apache.org > > Subject: Include MKLDNN into default mxnet pip package > > > > Continuation from the following thread: > > > https://lists.apache.org/thread.html/bcb1bd5046ff51049a0556098e756578f > > 6fa6564831d77fddb56432f@%3Cdev.mxnet.apache.org%3E > > > > I am also +1 for making it on master and testing until 1.5.0. We can > decide > > later on (before 1.5.0) to enable mkldnn as default for the nightly > build (pip > > install --pre build) to try to get more feedback if needed. > > > > - What the story is like when there's no AVX instructions present on > CPUs. > > Do we get an illegal instruction error, or does it fallback > gracefully? > > According to this issue ( > > https://github.com/apache/incubator-mxnet/issues/11911), AVX2 is the > > minimum requirement for pre-build binaries. > > > > - Are there any outstanding issues when MKLDNN is enabled? > > -There is one issues with quantization int8 of mkldnn (will create > issue about > > it when team gives me reproducible code snippet). Additionally, we > are > > waiting to merge the PR to build mkldnn statically with mac/linux > when > > building from source after MKL is added to the CI. > > > > > > - MKLDNN is a submodule dependency, are we pulling the latest commit > or > > releases? If not we should move to releases before we make it a > default I > > agree. We should tag mxnet only to releases from now on. Currently > it is > > tagged to 0.17.1 > > > > Please let me know if there any other outstanding issues, else we > are going > > to make mkldnn / cmake default in the Make/CMakefile. > > > > Alex > > >
Re: Slack invite hotlink
Marco, Seems like that link is only good for 30 days. See https://issues.apache.org/jira/browse/INFRA-17152. Mike On Tue, Dec 11, 2018 at 12:01 PM Marco de Abreu wrote: > Hey everyone, > > there's a hotlink [1] that allows people to join Apaches Slack server > directly, I found it here [2]. They would then still have to join the > #mxnet channel though. Should we maybe add this to the instructions on the > website? > > Best regards, > Marco > > [1]: https://s.apache.org/slack-invite > [2]: https://beam.apache.org/community/contact-us/ >
Re: Include MKLDNN into default mxnet pip package
+1 On 12/10/18, 8:01 PM, "Zhao, Patric" wrote: +1, thanks for the efforts, Alex. > -Original Message- > From: Alex Zai [mailto:aza...@gmail.com] > Sent: Tuesday, December 11, 2018 8:00 AM > To: dev@mxnet.incubator.apache.org > Subject: Include MKLDNN into default mxnet pip package > > Continuation from the following thread: > https://lists.apache.org/thread.html/bcb1bd5046ff51049a0556098e756578f > 6fa6564831d77fddb56432f@%3Cdev.mxnet.apache.org%3E > > I am also +1 for making it on master and testing until 1.5.0. We can decide > later on (before 1.5.0) to enable mkldnn as default for the nightly build (pip > install --pre build) to try to get more feedback if needed. > > - What the story is like when there's no AVX instructions present on CPUs. > Do we get an illegal instruction error, or does it fallback gracefully? > According to this issue ( > https://github.com/apache/incubator-mxnet/issues/11911), AVX2 is the > minimum requirement for pre-build binaries. > > - Are there any outstanding issues when MKLDNN is enabled? > -There is one issues with quantization int8 of mkldnn (will create issue about > it when team gives me reproducible code snippet). Additionally, we are > waiting to merge the PR to build mkldnn statically with mac/linux when > building from source after MKL is added to the CI. > > > - MKLDNN is a submodule dependency, are we pulling the latest commit or > releases? If not we should move to releases before we make it a default I > agree. We should tag mxnet only to releases from now on. Currently it is > tagged to 0.17.1 > > Please let me know if there any other outstanding issues, else we are going > to make mkldnn / cmake default in the Make/CMakefile. > > Alex
Slack invite hotlink
Hey everyone, there's a hotlink [1] that allows people to join Apaches Slack server directly, I found it here [2]. They would then still have to join the #mxnet channel though. Should we maybe add this to the instructions on the website? Best regards, Marco [1]: https://s.apache.org/slack-invite [2]: https://beam.apache.org/community/contact-us/
GitHub CI status update not stable
Dear MXNet community, Currently the CI system is experiencing issues with GitHub verification status updates. If your PR is stuck with a status that looks like: ci/jenkins/mxnet-validation/centos-cpu Expected — Waiting for status to be reported ci/jenkins/mxnet-validation/centos-gpu Expected — Waiting for status to be reported Try to make an empty commit to retrigger the build. You can find the current status of your PR in Jenkins if you look for the PR id: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwindows-gpu/detail/PR-13576/5/pipeline We are working on resolving the issue and will update you once it will get resolved. Best regards, Anton Chernov
