Re: [DISCUSS] About the PR merging policy

[Carin Meier]

Qing - thanks for bringing this up.

I think it would be a good thing to have a document on the wiki to help
with these sorts of questions.

In fact, since the project is growing with more new committers, maybe we
could use a "New Committer Guide" with the process of how to get going and
any FAQ like this one ...

Would you be interested in getting a rough draft going of your recent
experience? Then others can help collaborate on it.

It would be nice to make the path smoother for other new committers to the
project.

Best,
Carin

On Tue, Dec 11, 2018 at 7:18 PM Qing Lan  wrote:

> Hi all,
>
> Recently I self-merged my PR without getting approvals from other
> committers https://github.com/apache/incubator-mxnet/pull/13617 and only
> contributors approval. I apologize to the community and thank Marco for
> pointing out the problem. I took a lesson that we should at least have one
> committer’s approval to merge the code. However, I just found this section
> is missing in the CWiki
> https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+%28incubating%29+Committer+and+PPMC+Member.
> So I would like to discuss in here:
>
> How to conduct the PR reviewing/merging. How many approvals (Committers
> and Contributors) we should get in order to merge?
>
> How to deal with disagreement in the discussion (e.g a
> contributor/committer request a change)?
>
> Please don’t hesitate to share your thoughts!
>
> Thanks,
> Qing
>

Re: [DISCUSS] About the PR merging policy

[Anton Chernov]

There was no policy setup before for this as far as I know.

Personally, I don't see any value in introducing another blocker for enough
slow process of PR merges. The best value / burden ratio one gets from
lightweight 'another pair of eyes' approach.

Anton

ср, 12 дек. 2018 г. в 01:24, Tianqi Chen :

> I think it is fine as long as we act on good faith. I will normally respect
> code review comments from anyone who might be able to give reasonable
> comments, and beg to differ with good technical reasoning. Normally
> contributions happen in a way that things won't get blocked in small
> features.
>
> For major changes, RFC discussion would be  helpful to resolve the case
>
> Tianqi
>
> On Tue, Dec 11, 2018 at 4:18 PM Qing Lan  wrote:
>
> > Hi all,
> >
> > Recently I self-merged my PR without getting approvals from other
> > committers https://github.com/apache/incubator-mxnet/pull/13617 and only
> > contributors approval. I apologize to the community and thank Marco for
> > pointing out the problem. I took a lesson that we should at least have
> one
> > committer’s approval to merge the code. However, I just found this
> section
> > is missing in the CWiki
> >
> https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+%28incubating%29+Committer+and+PPMC+Member
> .
> > So I would like to discuss in here:
> >
> > How to conduct the PR reviewing/merging. How many approvals (Committers
> > and Contributors) we should get in order to merge?
> >
> > How to deal with disagreement in the discussion (e.g a
> > contributor/committer request a change)?
> >
> > Please don’t hesitate to share your thoughts!
> >
> > Thanks,
> > Qing
> >
>