Re: MXNet 1.6.0 release
Dear MXNet Community, This morning I updated the 1.6.x branch and so the code freeze is in effect. I would like to thank everyone who helped in preparing and reviewing pull requests to meet this deadline. Unfortunately, nightly tests do not currently pass (I created an issue about this: [1]). Another issue [2] was raised to my attention as potential release blocker. Please help in fixing those issues and also tag me on other issues that you believe must be fixed before release. Thank you Przemek [1] https://github.com/apache/incubator-mxnet/issues/16704 [2] https://github.com/apache/incubator-mxnet/issues/16647 On 2019/10/25 14:24:49, Przemys��aw Tr��dak wrote: > Dear MXNet Community > > Last night I updated 1.6.x branch to point to current master. The code freeze > is now in effect. > > That said, since most of the features intended for 1.6 release are still not > fully finished (a few PRs for BERT GPU performance, multiple MKLDNN PRs, > multiple PRs tagged NumPy etc.) we decided to go with a "soft" code freeze > approach. Only the PRs that are in the scope of 1.6 release will now be > accepted into 1.6.x branch. The hard code freeze is planned next week, Oct > 31st. > > While contributors of those in-scope PRs and their reviewers work to meet > that deadline, I would like to call for action for the rest of the MXNet > Community to test, raise issues and fix the bugs in the release. > > Thank you > Przemek > > On 2019/10/11 00:00:34, Przemys��aw Tr��dak wrote: > > Hi MXNet Community, > > > > As the 1.5.1 patch release is done (many thanks Tao!), it is time to > > prepare for the next minor release of MXNet - 1.6.0. > > > > I (ptrendx@github / ptredak@mxnet Slack) would like to manage the release > > of 1.6.0. As it will be the first time for me to manage a release, Sam > > (samskalicky) and Lin (apeforest) agreed to help guiding me through the > > process. > > > > Thanks to Sheng there is a GitHub issue[1] listing major features that > > should go into the 1.6.0, please add any features that you want included > > there. > > > > That said, as we target November for the release, to accommodate for > > extensive testing and bugfixing, the code freeze date is set to October > > 24th 23:59PST. Please reach out to me as soon as possible if you feel that > > you will need an extension of that deadline for your feature. > > > > Sheng created a page on cwiki[2] about the release, I will populate it with > > the information and tracked issues and PRs. > > > > Thank you and let's make the great 1.6.0 release together! > > Przemek > > > > [1] https://github.com/apache/incubator-mxnet/issues/15589 > > [2] > > https://cwiki.apache.org/confluence/display/MXNET/1.6.0+Release+Plan+and+Status > > >
Re: RE: RE: MXNet 1.6.0 release
The nightly tests unfortunately still do not pass, but not because of MKLDNN. There is an error "Cannot find TVM op config". I opened an issue about this today: https://github.com/apache/incubator-mxnet/issues/16704 Thank you for the quick fix to the previous problem :-) Przemek On 2019/11/01 23:21:42, "Zhao, Patric" wrote: > The issue is fixed by https://github.com/apache/incubator-mxnet/pull/16693 > > Does the last nightly build and tests pass? > > Thanks, > > --Patric > > > -Original Message- > > From: Zhao, Patric > > Sent: Friday, November 1, 2019 12:13 PM > > To: dev@mxnet.incubator.apache.org; d...@mxnet.apache.org > > Subject: RE: RE: MXNet 1.6.0 release > > > > Sure, I will see the issue. > > > > > -Original Message- > > > From: Przemysław Trędak > > > Sent: Friday, November 1, 2019 11:27 AM > > > To: d...@mxnet.apache.org > > > Subject: Re: RE: MXNet 1.6.0 release > > > > > > Hi Patric, > > > > > > Actually the nightly tests show some problems with machines not being > > > able to find libmkldnn.so.1 (see e.g. here: > > > http://jenkins.mxnet-ci.amazon- > > > ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/maste > > > r/4 92/pipeline). I'm not sure if this is just a problem with > > > configuration of CI machines for nightly tests, but please take a look > > > at this. > > > > > > Przemek > > > > > > On 2019/11/01 02:41:01, "Zhao, Patric" wrote: > > > > Hi Przemek, > > > > > > > > The MKLDNN upgrade PR was merged in Oct 31. Please double check the > > > nightly build and going forward for the release progress. > > > > > > > > Feel free to ping me if anything we can help. > > > > > > > > Thanks, > > > > > > > > --Patric > > > > > > > > > -Original Message- > > > > > From: Przemysław Trędak > > > > > Sent: Friday, October 25, 2019 10:25 PM > > > > > To: d...@mxnet.apache.org > > > > > Subject: Re: MXNet 1.6.0 release > > > > > > > > > > Dear MXNet Community > > > > > > > > > > Last night I updated 1.6.x branch to point to current master. The > > > > > code freeze is now in effect. > > > > > > > > > > That said, since most of the features intended for 1.6 release are > > > > > still not fully finished (a few PRs for BERT GPU performance, > > > > > multiple MKLDNN PRs, multiple PRs tagged NumPy etc.) we decided to > > > > > go with a "soft" code freeze approach. Only the PRs that are in > > > > > the scope of 1.6 release will now be accepted into 1.6.x branch. > > > > > The hard code freeze is planned next week, Oct 31st. > > > > > > > > > > While contributors of those in-scope PRs and their reviewers work > > > > > to meet that deadline, I would like to call for action for the > > > > > rest of the MXNet Community to test, raise issues and fix the bugs in > > > > > the > > release. > > > > > > > > > > Thank you > > > > > Przemek > > > > > > > > > > On 2019/10/11 00:00:34, Przemys aw Tr dak > > > > > wrote: > > > > > > Hi MXNet Community, > > > > > > > > > > > > As the 1.5.1 patch release is done (many thanks Tao!), it is > > > > > > time to prepare > > > > > for the next minor release of MXNet - 1.6.0. > > > > > > > > > > > > I (ptrendx@github / ptredak@mxnet Slack) would like to manage > > > > > > the > > > > > release of 1.6.0. As it will be the first time for me to manage a > > > > > release, Sam > > > > > (samskalicky) and Lin (apeforest) agreed to help guiding me > > > > > through the process. > > > > > > > > > > > > Thanks to Sheng there is a GitHub issue[1] listing major > > > > > > features that > > > > > should go into the 1.6.0, please add any features that you want > > > > > included there. > > > > > > > > > > > > That said, as we target November for the release, to accommodate > > > > > > for > > > > > extensive testing and bugfixing, the code freeze date is set to > > > > > October 24th 23:59PST. Please reach out to me as soon as possible > > > > > if you feel that you will need an extension of that deadline for your > > > > > feature. > > > > > > > > > > > > Sheng created a page on cwiki[2] about the release, I will > > > > > > populate it with > > > > > the information and tracked issues and PRs. > > > > > > > > > > > > Thank you and let's make the great 1.6.0 release together! > > > > > > Przemek > > > > > > > > > > > > [1] https://github.com/apache/incubator-mxnet/issues/15589 > > > > > > [2] > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.6.0+Release+Pl > > > > > an > > > > > +a > > > > > nd+Status > > > > > > > > > > >
Re: MXNet 1.6.0 release
Since vast majority of the commits pushed to master since last Thursday were in scope, I just updated 1.6.x branch to match master this morning. That commit is included. On 2019/11/02 00:55:11, "Lausen, Leonard" wrote: > Hi Przemek, > > https://github.com/apache/incubator-mxnet/issues/16049 was fixed in master > branch yesterday. Can we include it for the 1.6 release? > > Thank you > Leonard > > On Fri, 2019-10-25 at 14:24 +, Przemysław Trędak wrote: > > Dear MXNet Community > > > > Last night I updated 1.6.x branch to point to current master. The code > > freeze > > is now in effect. > > > > That said, since most of the features intended for 1.6 release are still not > > fully finished (a few PRs for BERT GPU performance, multiple MKLDNN PRs, > > multiple PRs tagged NumPy etc.) we decided to go with a "soft" code freeze > > approach. Only the PRs that are in the scope of 1.6 release will now be > > accepted into 1.6.x branch. The hard code freeze is planned next week, Oct > > 31st. > > > > While contributors of those in-scope PRs and their reviewers work to meet > > that > > deadline, I would like to call for action for the rest of the MXNet > > Community > > to test, raise issues and fix the bugs in the release. > > > > Thank you > > Przemek > > > > On 2019/10/11 00:00:34, Przemys��aw Tr��dak wrote: > > > Hi MXNet Community, > > > > > > As the 1.5.1 patch release is done (many thanks Tao!), it is time to > > > prepare > > > for the next minor release of MXNet - 1.6.0. > > > > > > I (ptrendx@github / ptredak@mxnet Slack) would like to manage the release > > > of > > > 1.6.0. As it will be the first time for me to manage a release, Sam > > > (samskalicky) and Lin (apeforest) agreed to help guiding me through the > > > process. > > > > > > Thanks to Sheng there is a GitHub issue[1] listing major features that > > > should go into the 1.6.0, please add any features that you want included > > > there. > > > > > > That said, as we target November for the release, to accommodate for > > > extensive testing and bugfixing, the code freeze date is set to October > > > 24th > > > 23:59PST. Please reach out to me as soon as possible if you feel that you > > > will need an extension of that deadline for your feature. > > > > > > Sheng created a page on cwiki[2] about the release, I will populate it > > > with > > > the information and tracked issues and PRs. > > > > > > Thank you and let's make the great 1.6.0 release together! > > > Przemek > > > > > > [1] https://github.com/apache/incubator-mxnet/issues/15589 > > > [2] > > > https://cwiki.apache.org/confluence/display/MXNET/1.6.0+Release+Plan+and+Status > > > >
Re: MXNet 1.6.0 release
Hi Przemek, https://github.com/apache/incubator-mxnet/issues/16049 was fixed in master branch yesterday. Can we include it for the 1.6 release? Thank you Leonard On Fri, 2019-10-25 at 14:24 +, Przemysław Trędak wrote: > Dear MXNet Community > > Last night I updated 1.6.x branch to point to current master. The code freeze > is now in effect. > > That said, since most of the features intended for 1.6 release are still not > fully finished (a few PRs for BERT GPU performance, multiple MKLDNN PRs, > multiple PRs tagged NumPy etc.) we decided to go with a "soft" code freeze > approach. Only the PRs that are in the scope of 1.6 release will now be > accepted into 1.6.x branch. The hard code freeze is planned next week, Oct > 31st. > > While contributors of those in-scope PRs and their reviewers work to meet that > deadline, I would like to call for action for the rest of the MXNet Community > to test, raise issues and fix the bugs in the release. > > Thank you > Przemek > > On 2019/10/11 00:00:34, Przemys��aw Tr��dak wrote: > > Hi MXNet Community, > > > > As the 1.5.1 patch release is done (many thanks Tao!), it is time to prepare > > for the next minor release of MXNet - 1.6.0. > > > > I (ptrendx@github / ptredak@mxnet Slack) would like to manage the release of > > 1.6.0. As it will be the first time for me to manage a release, Sam > > (samskalicky) and Lin (apeforest) agreed to help guiding me through the > > process. > > > > Thanks to Sheng there is a GitHub issue[1] listing major features that > > should go into the 1.6.0, please add any features that you want included > > there. > > > > That said, as we target November for the release, to accommodate for > > extensive testing and bugfixing, the code freeze date is set to October 24th > > 23:59PST. Please reach out to me as soon as possible if you feel that you > > will need an extension of that deadline for your feature. > > > > Sheng created a page on cwiki[2] about the release, I will populate it with > > the information and tracked issues and PRs. > > > > Thank you and let's make the great 1.6.0 release together! > > Przemek > > > > [1] https://github.com/apache/incubator-mxnet/issues/15589 > > [2] > > https://cwiki.apache.org/confluence/display/MXNET/1.6.0+Release+Plan+and+Status > >
Requesting Slack Invite
thank you
RE: RE: MXNet 1.6.0 release
The issue is fixed by https://github.com/apache/incubator-mxnet/pull/16693 Does the last nightly build and tests pass? Thanks, --Patric > -Original Message- > From: Zhao, Patric > Sent: Friday, November 1, 2019 12:13 PM > To: dev@mxnet.incubator.apache.org; d...@mxnet.apache.org > Subject: RE: RE: MXNet 1.6.0 release > > Sure, I will see the issue. > > > -Original Message- > > From: Przemysław Trędak > > Sent: Friday, November 1, 2019 11:27 AM > > To: d...@mxnet.apache.org > > Subject: Re: RE: MXNet 1.6.0 release > > > > Hi Patric, > > > > Actually the nightly tests show some problems with machines not being > > able to find libmkldnn.so.1 (see e.g. here: > > http://jenkins.mxnet-ci.amazon- > > ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/maste > > r/4 92/pipeline). I'm not sure if this is just a problem with > > configuration of CI machines for nightly tests, but please take a look > > at this. > > > > Przemek > > > > On 2019/11/01 02:41:01, "Zhao, Patric" wrote: > > > Hi Przemek, > > > > > > The MKLDNN upgrade PR was merged in Oct 31. Please double check the > > nightly build and going forward for the release progress. > > > > > > Feel free to ping me if anything we can help. > > > > > > Thanks, > > > > > > --Patric > > > > > > > -Original Message- > > > > From: Przemysław Trędak > > > > Sent: Friday, October 25, 2019 10:25 PM > > > > To: d...@mxnet.apache.org > > > > Subject: Re: MXNet 1.6.0 release > > > > > > > > Dear MXNet Community > > > > > > > > Last night I updated 1.6.x branch to point to current master. The > > > > code freeze is now in effect. > > > > > > > > That said, since most of the features intended for 1.6 release are > > > > still not fully finished (a few PRs for BERT GPU performance, > > > > multiple MKLDNN PRs, multiple PRs tagged NumPy etc.) we decided to > > > > go with a "soft" code freeze approach. Only the PRs that are in > > > > the scope of 1.6 release will now be accepted into 1.6.x branch. > > > > The hard code freeze is planned next week, Oct 31st. > > > > > > > > While contributors of those in-scope PRs and their reviewers work > > > > to meet that deadline, I would like to call for action for the > > > > rest of the MXNet Community to test, raise issues and fix the bugs in > > > > the > release. > > > > > > > > Thank you > > > > Przemek > > > > > > > > On 2019/10/11 00:00:34, Przemys aw Tr dak > > > > wrote: > > > > > Hi MXNet Community, > > > > > > > > > > As the 1.5.1 patch release is done (many thanks Tao!), it is > > > > > time to prepare > > > > for the next minor release of MXNet - 1.6.0. > > > > > > > > > > I (ptrendx@github / ptredak@mxnet Slack) would like to manage > > > > > the > > > > release of 1.6.0. As it will be the first time for me to manage a > > > > release, Sam > > > > (samskalicky) and Lin (apeforest) agreed to help guiding me > > > > through the process. > > > > > > > > > > Thanks to Sheng there is a GitHub issue[1] listing major > > > > > features that > > > > should go into the 1.6.0, please add any features that you want > > > > included there. > > > > > > > > > > That said, as we target November for the release, to accommodate > > > > > for > > > > extensive testing and bugfixing, the code freeze date is set to > > > > October 24th 23:59PST. Please reach out to me as soon as possible > > > > if you feel that you will need an extension of that deadline for your > > > > feature. > > > > > > > > > > Sheng created a page on cwiki[2] about the release, I will > > > > > populate it with > > > > the information and tracked issues and PRs. > > > > > > > > > > Thank you and let's make the great 1.6.0 release together! > > > > > Przemek > > > > > > > > > > [1] https://github.com/apache/incubator-mxnet/issues/15589 > > > > > [2] > > > > https://cwiki.apache.org/confluence/display/MXNET/1.6.0+Release+Pl > > > > an > > > > +a > > > > nd+Status > > > > > > > >
