[jira] Updated: (TOMAHAWK-1155) Arabizing the Tomahawk Calendar
[ https://issues.apache.org/jira/browse/TOMAHAWK-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hazem Saleh updated TOMAHAWK-1155: -- Status: Patch Available (was: Open) > Arabizing the Tomahawk Calendar > --- > > Key: TOMAHAWK-1155 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1155 > Project: MyFaces Tomahawk > Issue Type: New Feature > Components: Calendar >Affects Versions: 1.1.7-SNAPSHOT >Reporter: Hazem Saleh > Fix For: 1.1.7-SNAPSHOT > > > Finally Arabization is done for the Tomahawk Calendar! > This patch arabizes the Tomahawk Calendar component so that if the current > locale is ar; then the Calendar will display Arabic days and months (Please > check the screen shot). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1155) Arabizing the Tomahawk Calendar
Arabizing the Tomahawk Calendar --- Key: TOMAHAWK-1155 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1155 Project: MyFaces Tomahawk Issue Type: New Feature Components: Calendar Affects Versions: 1.1.7-SNAPSHOT Reporter: Hazem Saleh Fix For: 1.1.7-SNAPSHOT Finally Arabization is done for the Tomahawk Calendar! This patch arabizes the Tomahawk Calendar component so that if the current locale is ar; then the Calendar will display Arabic days and months (Please check the screen shot). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-818) Core.js: invalid Javascript in Firefox and XHTML
[ https://issues.apache.org/jira/browse/TRINIDAD-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545215 ] Matthias Weßendorf commented on TRINIDAD-818: - I don't see it. > Core.js: invalid Javascript in Firefox and XHTML > > > Key: TRINIDAD-818 > URL: https://issues.apache.org/jira/browse/TRINIDAD-818 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 1.0.3-core > Environment: Java 6, Windows and Linux environments. >Reporter: Victor S. > > When accessing forms, Core.js uses javascript sentence "document[x]" (where > "x" is the form ID). This works with basic HTML, but not in XHTML documents. > Changing "document[x]" with "document.forms[x]" my application works fine, > both in Firefox and IExplorer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-835) PanelTip content not rendered in content pane
[
https://issues.apache.org/jira/browse/TRINIDAD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Weßendorf resolved TRINIDAD-835.
-
Resolution: Fixed
> PanelTip content not rendered in content pane
> -
>
> Key: TRINIDAD-835
> URL: https://issues.apache.org/jira/browse/TRINIDAD-835
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
>Affects Versions: 1.0.4-core
>Reporter: Tomas Havelka
> Fix For: 1.0.5-core
>
>
> PanelTip renderer maybe renders panelTip content in wrong place. I think it
> has to render panelTip content inside span with style selector
> af|panelTip::content instead of leaving this empty and rendering content
> after it.
> Code fragment from PanelTipRenderer
> // content
> rw.startElement("span", null);
> renderStyleClass(context, rc,
> SkinSelectors.AF_PANEL_TIP_CONTENT_STYLE_CLASS);
> rw.endElement("span");
> encodeAllChildren(context, component);
> should be changed to
> // content
> rw.startElement("span", null);
> renderStyleClass(context, rc,
> SkinSelectors.AF_PANEL_TIP_CONTENT_STYLE_CLASS);
> encodeAllChildren(context, component);
> rw.endElement("span");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-829) error message for validateRegExp does not always show pattern information
[
https://issues.apache.org/jira/browse/TRINIDAD-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Weßendorf resolved TRINIDAD-829.
-
Resolution: Fixed
forgot to close the issue
> error message for validateRegExp does not always show pattern information
> -
>
> Key: TRINIDAD-829
> URL: https://issues.apache.org/jira/browse/TRINIDAD-829
> Project: MyFaces Trinidad
> Issue Type: Bug
>Reporter: Matthias Weßendorf
>Assignee: Matthias Weßendorf
> Fix For: 1.0.5-core
>
>
> Steps
> =
> 1. Create a new page with two input texts and nest Validate Reg Exp
> on both input texts.
> 2. In one of the Validate Reg Exp provide patterns as [0-9]{3} and for the
> second Validate Reg Exp provide [0-9]{5} as patterns
> 3. Run the page and end 1 in both the input text. The inputtext with Validate
> Reg Exp having pattern [0-9]{3} show wrong error message 'The value you
> entered does not match the regular expression pattern "[0-9]".'
> while the input with Validate Reg Exp having pattern [0-9]{5} show correct
> error message 'The value you entered does not match the regular expression
> pattern "[0-9]{5}".'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1628) Migrate Partial State Saving to 1.2
[ https://issues.apache.org/jira/browse/MYFACES-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545207 ] Matthias Weßendorf commented on MYFACES-1628: - can you provide an updated PATCH file ? > Migrate Partial State Saving to 1.2 > --- > > Key: MYFACES-1628 > URL: https://issues.apache.org/jira/browse/MYFACES-1628 > Project: MyFaces Core > Issue Type: New Feature > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT, 1.2.1-SNAPSHOT >Reporter: Martin Haimberger >Assignee: Martin Haimberger > Fix For: 1.2.0-SNAPSHOT > > Attachments: psspatch_MYFACES_1628.tar.gz > > > Migrate Partial State Saving to MyFaces 1.2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-781) NavigationPane should support non-command children for some hints.
[ https://issues.apache.org/jira/browse/TRINIDAD-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545203 ] Matthias Weßendorf commented on TRINIDAD-781: - path :-) not patch. > NavigationPane should support non-command children for some hints. > -- > > Key: TRINIDAD-781 > URL: https://issues.apache.org/jira/browse/TRINIDAD-781 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Components >Affects Versions: 1.0.3-core, 1.2.2-core >Reporter: Abhijit S Ghosh >Priority: Minor > Fix For: 1.0.3-core, 1.2.2-core > > Attachments: NavigationPaneRenderer.patch > > > navigationPane places an unnecessary restriction on it's children in that it > tries to cast all of them into UIXCommand.It would be sometimes useful to > place arbitrary components in the global area navigationPane for some > hints.In this case the navigationPane throws a ClassCastException. > Also the Oracle ADF Faces 10.1.3 navigationPane(panelTabbed etc.) allowed > non-command children inside itself.If this is fixed it would provide an > easier migration path for them to MyFaces Trinidad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-781) NavigationPane should support non-command children for some hints.
[ https://issues.apache.org/jira/browse/TRINIDAD-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545202 ] Matthias Weßendorf commented on TRINIDAD-781: - conflicts with the patch. And.. there is NO patch included... > NavigationPane should support non-command children for some hints. > -- > > Key: TRINIDAD-781 > URL: https://issues.apache.org/jira/browse/TRINIDAD-781 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Components >Affects Versions: 1.0.3-core, 1.2.2-core >Reporter: Abhijit S Ghosh >Priority: Minor > Fix For: 1.0.3-core, 1.2.2-core > > Attachments: NavigationPaneRenderer.patch > > > navigationPane places an unnecessary restriction on it's children in that it > tries to cast all of them into UIXCommand.It would be sometimes useful to > place arbitrary components in the global area navigationPane for some > hints.In this case the navigationPane throws a ClassCastException. > Also the Oracle ADF Faces 10.1.3 navigationPane(panelTabbed etc.) allowed > non-command children inside itself.If this is fixed it would provide an > easier migration path for them to MyFaces Trinidad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-331) JDev plugin
[
https://issues.apache.org/jira/browse/TRINIDAD-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545199
]
Matthias Weßendorf commented on TRINIDAD-331:
-
what is the status of this patch?
> JDev plugin
> ---
>
> Key: TRINIDAD-331
> URL: https://issues.apache.org/jira/browse/TRINIDAD-331
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Plugins
>Reporter: Matthias Weßendorf
> Attachments: patch.txt, patch2.txt
>
>
> Hello,
> Been trying to use the maven-jdev-plugin plugin. It seems to work except
> (for jdeveloper 10.1.3.36.73) munging the fully-qualified directories on all
> the jarpaths, they were all being preceeded with the project home directory
> (the bad was happening after jdeveloper munged and then saved the project
> file, and was not entirely with the project file produced by the maven
> plugin) :
> Eg. Bad:
>
> Eg. Good:
>
> Note that for some reason jdeveloper (by whatever weak definition it has of
> an "absolute" directory) was thinking the path was not absolute so it was
> prepending the project root. Also in the case that the repository was on a
> different drive than the project home, it did not convert the \ slashes to /
> slasges (as the other clauses already did) which was my initial problem.
> This was not enough to fix for my version of jdeveloper though, the jar
> business needed to change also.
> Cheers
> Brett
> D:\DEVELO~1\svnwork\adffaces\plugins\maven-jdev-plugin>svn diff
> Index:
> src/main/java/org/apache/myfaces/trinidadbuild/plugin/jdeveloper/JDeveloperMojo.java
> ===
> ---
> src/main/java/org/apache/myfaces/trinidadbuild/plugin/jdeveloper/JDeveloperMojo.java
> (revision 426771)
> +++
> src/main/java/org/apache/myfaces/trinidadbuild/plugin/jdeveloper/JDeveloperMojo.java
> (working copy)
> @@ -555,7 +555,7 @@
> //
> //
> //
> -//
> +//
> //
> //
> //
> @@ -589,8 +589,8 @@
> listDOM.setAttribute("n", "classPath");
> Xpp3Dom urlDOM = new Xpp3Dom("url");
> -urlDOM.setAttribute("path", path);
> -urlDOM.setAttribute("jar-entry", "");
> +urlDOM.setAttribute("path", "file:/" + path + "!/");
> +urlDOM.setAttribute("protocol", "jar");
> listDOM.addChild(urlDOM);
> hashDOM.addChild(listDOM);
> @@ -976,7 +976,7 @@
> }
> else
> {
> -return targetPath;
> +return targetPath.replace(File.separatorChar, '/');
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-177) JDev plugin - compiler configuration
[ https://issues.apache.org/jira/browse/TRINIDAD-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545201 ] Matthias Weßendorf commented on TRINIDAD-177: - what is the status of this patch? > JDev plugin - compiler configuration > > > Key: TRINIDAD-177 > URL: https://issues.apache.org/jira/browse/TRINIDAD-177 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Plugins >Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT > Environment: Windows XP, JDeveloper 10.1.3.1 (.0.3984) >Reporter: Aino Andriessen > Fix For: 1.0.1-incubating-plugins-SNAPSHOT > > Attachments: project.xml.10.1.3.0.4.patch > > > The compiler configuration of the plugin conflicts with the business > components wizard. > The jdev plugin configures a reverse filter on the 'Copy File Types to Output > Directory' and only adds .java on this list. > However, when you create a new business component (actually only the first in > a project), a bunch of extensions are added to this list that now contains > the following entries: > .java;.xml;.jpx;.xcfg;.xml;.xml;.xml;.xml;.xml;.xml;.xml > When you try to test the model application an exception is raised (I am sorry > for the french text) that it cannot find the Model.jpx file: > JBO-30003: Le pool d'applications (.10F6E9C218F) n'a pas réussi à extraire > (check out) un module d'application en raison de l'exception suivante : > oracle.jbo.JboException: JBO-29000: JBO-29000: JBO-25222: Impossible de créer > le module dapplication. > ... > javax.naming.NamingException [Root exception is > oracle.jbo.NoXMLFileException: JBO-26001: Fichier XML introuvable pour le > conteneur /Model.jpx] > This is as expected, because that file is not copied to the classpath (due to > the Reverse Filter), but highly unwanted. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-268) EditableValueRenderer does not handle EvaluationException in method getReadOnly
[ https://issues.apache.org/jira/browse/TRINIDAD-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545200 ] Matthias Weßendorf commented on TRINIDAD-268: - what is the status of this patch? > EditableValueRenderer does not handle EvaluationException in method > getReadOnly > --- > > Key: TRINIDAD-268 > URL: https://issues.apache.org/jira/browse/TRINIDAD-268 > Project: MyFaces Trinidad > Issue Type: Bug > Environment: JSF RI 1.1_02 > JSF RI 1.2_02 >Reporter: Martin Koci > Attachments: EditableValueRenderer.java.patch > > > EditableValueRenderer.getReadOnly tries to get read-only state of > valueBinding. But if expression cannot be resolved a exception is thrown. > Note: there is a bug in myfaces 1.1.4 - its valueBinding.isReadOnly return > true in this case. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-413) ValueMap is a Bidirectional reversible map. It is a useful utility class, make it public
[ https://issues.apache.org/jira/browse/TRINIDAD-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545198 ] Matthias Weßendorf commented on TRINIDAD-413: - what is the status of this patch? > ValueMap is a Bidirectional reversible map. It is a useful utility class, > make it public > > > Key: TRINIDAD-413 > URL: https://issues.apache.org/jira/browse/TRINIDAD-413 > Project: MyFaces Trinidad > Issue Type: New Feature >Reporter: Arjuna Wijeyekoon >Priority: Minor > Attachments: rename_valueMap_to_BidiMap.patch > > > ValueMap is a Bidirectional reversible map. It is a useful utility class, so > we should make it public. > I'd like to call it: > org.apache.myfaces.trinidad.util.BidiHashMap > commons-collections has a similar class: > http://jakarta.apache.org/commons/collections/apidocs/org/apache/commons/collections/BidiMap.html > but we can't introduce a dependency on commons-collections in trinidad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-513) adding styles to panelLabelAndMessage Help-facet
[ https://issues.apache.org/jira/browse/TRINIDAD-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545195 ] Matthias Weßendorf commented on TRINIDAD-513: - what is the status of this patch? > adding styles to panelLabelAndMessage Help-facet > > > Key: TRINIDAD-513 > URL: https://issues.apache.org/jira/browse/TRINIDAD-513 > Project: MyFaces Trinidad > Issue Type: Improvement > Environment: PDAs >Reporter: Piyush Hari >Priority: Minor > Attachments: > patch_dec21_2_14PM_panelLabelAndMessage_help_facet_styling.patch > > > panelLAbelAndMessage help-facet is not styled. I will add a styling class for > it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-483) Allow the date picker to restrict the selectable days to only business days (e.g Mon-Fri)
[ https://issues.apache.org/jira/browse/TRINIDAD-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545197 ] Matthias Weßendorf commented on TRINIDAD-483: - what is the status of this patch? > Allow the date picker to restrict the selectable days to only business days > (e.g Mon-Fri) > - > > Key: TRINIDAD-483 > URL: https://issues.apache.org/jira/browse/TRINIDAD-483 > Project: MyFaces Trinidad > Issue Type: Improvement >Reporter: Danny Robinson >Priority: Minor > Attachments: CalendarUtils.patch, CalendarUtils.patch, > ChooseDateRenderer.patch, ChooseDateRenderer.patch, ChooseDateRenderer.patch, > CoreChooseDate.patch, trunk_patch92.patch > > > Provide the ability for the date picker to display/enable only business-days > (e.g. Mon-Fri), and hide/disable non-business days. > When the date picker is used for appointment booking or for selecting a > payment date, then it is not valid to select non-working days. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-493) fix 'panelChoice' component on a PDA
[ https://issues.apache.org/jira/browse/TRINIDAD-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545196 ] Matthias Weßendorf commented on TRINIDAD-493: - what is the status of this patch? > fix 'panelChoice' component on a PDA > > > Key: TRINIDAD-493 > URL: https://issues.apache.org/jira/browse/TRINIDAD-493 > Project: MyFaces Trinidad > Issue Type: Improvement > Environment: PDA >Reporter: Piyush Hari >Priority: Minor > Attachments: patch_sept20_4_40PM_panelChoice.patch, > patch_sept27_4_58PM_panelChoice.patch > > > The panelChoice control is used to display a group of contents belonging to a > showDetailItem. A choice control with each individual option representing a > showDetailItem child is displayed. An option within choice control > corresponding to showDetailItem that is disclosed is shown as selected and > contents of selected showDetailItem is displayed. If none of the > showDetailItem children are selected, the first showDetailItem that is > enabled is considered to be selected. > This attribute is currently not supported on PDAs. Although it displays on a > PDA, selecting any choices does not perorm an action. However, it works fine > for desktop applications. > Thus, I propose fixing "panelChoice" component in trinidad for PDAs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-533) enable indentation of a nested panelHeader on a PDA device
[ https://issues.apache.org/jira/browse/TRINIDAD-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545194 ] Matthias Weßendorf commented on TRINIDAD-533: - what is the satus of this patch? > enable indentation of a nested panelHeader on a PDA device > -- > > Key: TRINIDAD-533 > URL: https://issues.apache.org/jira/browse/TRINIDAD-533 > Project: MyFaces Trinidad > Issue Type: Improvement > Environment: PDA >Reporter: Piyush Hari >Priority: Minor > Attachments: patch_oct05_12_53PM_panelHeaderIndent_pda.patch > > > A nested panelHeader (panelHeader within a panelHeader) is indented by 5 px > spaces on a desktop. However, on a PDA it is not. I propose to fix this > disparity by indenting a nested panelHeader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-581) JDev Plugins
[ https://issues.apache.org/jira/browse/TRINIDAD-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545193 ] Matthias Weßendorf commented on TRINIDAD-581: - what is the status of this patch? > JDev Plugins > > > Key: TRINIDAD-581 > URL: https://issues.apache.org/jira/browse/TRINIDAD-581 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Plugins >Reporter: Sylvain Deschênes >Priority: Minor > Attachments: newFeature > > > We use the plugin in our development environment, it works really fine. But, > there's three things we've changed to make it better. > First the security in our webapp is JAAS-based, so we must explicitly specify > the webapp-name and the j2ee-context. So I modified the jdev plugin to use > the finalName specified in the POM by default. You have the choice to use it > by specifying : > > false > > Secondly, we encountered a problem when we run our webapp with the embedded > OC4J. We made some research and saw it was caused by the useJavac option in > the compiler. So, I added the the possibility to disable the use of javac > with a parameter in your POM. > > false > > And Third, I don't know why you added the list of resources in the classpath, > the code to put it in the resource was there so I reactivated it. And by the > way, I made the change to put the correct path in the replaceLibrary > function. > The attachment is the svn diff file -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-551) Added demo for XMLMenuModel
[ https://issues.apache.org/jira/browse/TRINIDAD-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545192 ] Matthias Weßendorf commented on TRINIDAD-551: - Is this patch still needed? There are some "issues", like adffaces as packages etc. > Added demo for XMLMenuModel > --- > > Key: TRINIDAD-551 > URL: https://issues.apache.org/jira/browse/TRINIDAD-551 > Project: MyFaces Trinidad > Issue Type: Improvement > Environment: software platform >Reporter: Gary Kind > Attachments: adf-faces-demo.patch > > > Added a demo to adf-faces-demo to demonstrate simple usage of the XMLMenuModel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-796) TrinidadELResolver::setValue support
[ https://issues.apache.org/jira/browse/TRINIDAD-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf updated TRINIDAD-796: Resolution: Fixed Fix Version/s: 1.2.4-core Status: Resolved (was: Patch Available) thx to Jesper Pedersen fo the patch > TrinidadELResolver::setValue support > > > Key: TRINIDAD-796 > URL: https://issues.apache.org/jira/browse/TRINIDAD-796 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Components >Affects Versions: 1.2.3-core > Environment: Trinidad-1.2 + Tomcat 6 >Reporter: Jesper Pedersen >Assignee: Matthias Weßendorf > Fix For: 1.2.4-core > > Attachments: elresolver.patch > > > It would be nice to be able to set values inside the pageFlowScope using the > TrinidadELResolver. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-773) Inefficient way to create faces ben in FacesBeanFactory
[
https://issues.apache.org/jira/browse/TRINIDAD-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545187
]
Adam Winer commented on TRINIDAD-773:
-
At a quick glance, this checkin has a big thread-safety problem:
FacesBeanFactory can be called from multiple threads, but you're using a
non-threadsafe data structure.
Switch that HashMap to a ConcurrentHashMap and it'll be safe.
> Inefficient way to create faces ben in FacesBeanFactory
> ---
>
> Key: TRINIDAD-773
> URL: https://issues.apache.org/jira/browse/TRINIDAD-773
> Project: MyFaces Trinidad
> Issue Type: Bug
>Reporter: Stevan Malesevic
>Assignee: Jeanne Waldman
> Fix For: 1.0.5-core
>
>
> It seems that the way FacesBeanFactory::createFacesBean creates faces bean is
> were inefficient. The problem is that for the case where we have deep
> subclass structure and root class defines the bean we will make a numerouse
> calls to createFacesBean before we find out the type for the bean. This will
> burn the CPU and use memory to create all the keys. One possible optimization
> might be to create a map between ownerClass|rendererType and calss for the
> bean at the top level where the createFacesBean is called. So, next call will
> find it right away. I played with the dirty prototype for this and I was able
> to see memory improvement of about 140K per request (I have not measure CPU
> improvement).
> The prototype I had looked like (were dirty but it works):
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing,
> * software distributed under the License is distributed on an
> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> * KIND, either express or implied. See the License for the
> * specific language governing permissions and limitations
> * under the License.
> */
> package org.apache.myfaces.trinidad.bean;
> import java.io.InputStream;
> import java.io.IOException;
> import java.net.URL;
> import java.util.ArrayList;
> import java.util.Collections;
> import java.util.Enumeration;
> import java.util.HashMap;
> import java.util.List;
> import java.util.Map;
> import java.util.Properties;
> import org.apache.myfaces.trinidad.logging.TrinidadLogger;
> /**
> * Base interface for FacesBean storage.
> *
> */
> public class FacesBeanFactory
> {
> /**
>* Create a FacesBean for a component class.
>*/
> // TODO change from ownerClass to componentFamily?
> static public FacesBean createFacesBean(
> Class ownerClass,
> String rendererType)
> {
> if (ownerClass == null)
> return null;
> String className = ownerClass.getName();
> FacesBean bean = createFacesBean(className, rendererType);
> if (bean == null && rendererType != null)
> {
> bean = createFacesBean(className, null);
>
> if(bean != null)
> {
> String typeKey = (rendererType != null)
> ? new
> StringBuilder(className).append("|").append(rendererType).toString()
> : className;
> _TYPES_CLASS.put(typeKey, bean.getClass());
> }
> }
>
> if (bean == null)
> {
> bean = createFacesBean(ownerClass.getSuperclass(), rendererType);
>
> if(bean != null)
> {
> String typeKey = (rendererType != null)
> ? new
> StringBuilder(className).append("|").append(rendererType).toString()
> : className;
> _TYPES_CLASS.put(typeKey, bean.getClass());
> }
> }
> return bean;
> }
> static public FacesBean createFacesBean(
> String beanType,
> String rendererType)
> {
> String typeKey = (rendererType != null)
> ? new
> StringBuilder(beanType).append("|").append(rendererType).toString()
> : beanType;
>
> Class type = _TYPES_CLASS.get(typeKey);
>
> if(type == null)
> {
> String className = (String) _TYPES_MAP.get(typeKey);
> if (className == null)
> return null;
>
> try
> {
> type = _getClassLoader().loadClass(className);
> _TYPES_CLASS.put(typeKey, type);
> }
> catch (ClassNotFoundException cnfe)
> {
> _LOG.severe("CANNOT_FI
[jira] Updated: (TRINIDAD-809) StampState for UIXShowDetail does not handle EL-bound "disclosed" property
[ https://issues.apache.org/jira/browse/TRINIDAD-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf updated TRINIDAD-809: Resolution: Fixed Fix Version/s: (was: 1.2.4-core) 1.0.5-core Status: Resolved (was: Patch Available) > StampState for UIXShowDetail does not handle EL-bound "disclosed" property > -- > > Key: TRINIDAD-809 > URL: https://issues.apache.org/jira/browse/TRINIDAD-809 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Components >Affects Versions: 1.2.3-core >Reporter: Max Starets > Fix For: 1.0.5-core > > Attachments: SDState.patch > > > org.apache.myfaces.trinidad.component.StampState.SDState assumes that the > "disclosed" value is always local. When the initial state is saved, > getDisclosed() is called. The boolean return value then used as a local > override for showDetail in each row. We need to check whether the value is > local before putting it into the state. > This needs to be fixed in 1.2.4 release -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-798) StateManagerImpl extends StateManager rather then StateManagerWrapper
[ https://issues.apache.org/jira/browse/TRINIDAD-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545186 ] Matthias Weßendorf commented on TRINIDAD-798: - scotty, I see some related commits, but issue is still open > StateManagerImpl extends StateManager rather then StateManagerWrapper > - > > Key: TRINIDAD-798 > URL: https://issues.apache.org/jira/browse/TRINIDAD-798 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Portlet >Affects Versions: 1.2.3-core > Environment: JSR-168 >Reporter: Scott O'Bryan >Assignee: Scott O'Bryan > Fix For: 1.2.4-core > > Attachments: trinidad-798.patch > > > In JSF 1.1, there was no StageManagerWrapper provided by JSF so we were > extending the base StateManager. In 1.2 this class was provided in order to > support the delegation chain. This delegation chain is important to support > the JSR-301's portlet bridge. > Trinidad's StateManagerImpl should be changed to extend JSF1.2's > StateManagerWrapper class in order to support this delegation chain. The > mechanism used in 1.1 is not sufficient for 1.2 extensions which may require > a StateManager. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-793) HTML tag errors in documentation
[ https://issues.apache.org/jira/browse/TRINIDAD-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf updated TRINIDAD-793: Resolution: Fixed Fix Version/s: (was: 1.0.4-core) (was: 1.2.4-core) 1.0.5-core Status: Resolved (was: Patch Available) > HTML tag errors in documentation > > > Key: TRINIDAD-793 > URL: https://issues.apache.org/jira/browse/TRINIDAD-793 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Documentation >Affects Versions: 1.0.3-core, 1.2.1-core, 1.2.2-core >Reporter: Bud Osterberg >Assignee: Matthias Weßendorf >Priority: Minor > Fix For: 1.0.5-core > > Attachments: trindoc.patch > > > The description tag of the mode property in > trinidad-build/src/main/resources/META-INF/maven-faces-plugin/components/trinidad/core/includes/CommonDocumentAttrs.xml > has a CDATA block with embedded html. In this block there are and > tags which are not closed leading to a parsing error. > The fix is simple: just add immediately before the end of the > block. > Similarly there is an extra in src/site/xdoc/release-notes.xml > immediately prior to The xOffset/yOffset... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-823) Maven-xrts-plugin should generate stub ResourceBundles for default locale
[ https://issues.apache.org/jira/browse/TRINIDAD-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf updated TRINIDAD-823: Resolution: Fixed Status: Resolved (was: Patch Available) thx to Bud for his patch > Maven-xrts-plugin should generate stub ResourceBundles for default locale > - > > Key: TRINIDAD-823 > URL: https://issues.apache.org/jira/browse/TRINIDAD-823 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 1.2.3-plugins >Reporter: Bud Osterberg >Assignee: Matthias Weßendorf > Fix For: 1.2.5-plugins > > Attachments: xrtsStubs2.patch > > > The base string resource files are written in English. Translations are done > from there. Unfortunately this leads to a weird bug when the server is in a > non-English locale (say ja). When American English (en-US) resources are > requested, Java RescourceBundle will do a lookup in this order: > 1. Res_en_US > 2. Res_en > 3. Res_ja (according to default locale, say this is Japanese here) > 4. Res > In this case, #3 gets a hit and returns, where we were really expecting #4. > A simple fix is to generate stub _en ResourceBundles which simply extend the > base (English) bundle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [Trinidad] open issues
hello matthias, that's great! for the mentioned issue there is no patch available (at the moment) - this issue i would like to discuss (there are different possible solutions). i was referencing my other issues - at these issues you will find patches: https://issues.apache.org/jira/browse/TRINIDAD-768 https://issues.apache.org/jira/browse/TRINIDAD-812 https://issues.apache.org/jira/browse/TRINIDAD-830 regards, gerhard 2007/11/24, Matthias Wessendorf <[EMAIL PROTECTED]>: > > Gerhard- > > I am not seeing a patch attached. > > -M > > On Nov 24, 2007 1:50 PM, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > Glad you pointed that out. > > my goal for the patch day is: > > -apply Trinidad patches > > -apply MyFaces 1.2 patches (did some already yestrday) > > > > I'll take a look at yours! > > > > -Matthias > > > > > > On Nov 24, 2007 1:49 PM, Gerhard Petracek <[EMAIL PROTECTED]> > wrote: > > > hello, > > > > > > i've provided some patches for trinidad. is there already a planned > version > > > for these patches? > > > > > > furthermore, there is an open issue i would like to discuss. > > > ( https://issues.apache.org/jira/browse/TRINIDAD-782) > > > > > > regards, > > > gerhard > > > > > > -- > > > > > > http://www.irian.at > > > > > > Your JSF powerhouse - > > > JSF Consulting, Development and > > > Courses in English and German > > > > > > Professional Support for Apache MyFaces > > > > > > > > -- > > Matthias Wessendorf > > > > further stuff: > > blog: http://matthiaswessendorf.wordpress.com/ > > sessions: http://www.slideshare.net/mwessendorf > > mail: matzew-at-apache-dot-org > > > > > > -- > Matthias Wessendorf > > further stuff: > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > mail: matzew-at-apache-dot-org > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: [Trinidad] open issues
Gerhard- I am not seeing a patch attached. -M On Nov 24, 2007 1:50 PM, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > Glad you pointed that out. > my goal for the patch day is: > -apply Trinidad patches > -apply MyFaces 1.2 patches (did some already yestrday) > > I'll take a look at yours! > > -Matthias > > > On Nov 24, 2007 1:49 PM, Gerhard Petracek <[EMAIL PROTECTED]> wrote: > > hello, > > > > i've provided some patches for trinidad. is there already a planned version > > for these patches? > > > > furthermore, there is an open issue i would like to discuss. > > ( https://issues.apache.org/jira/browse/TRINIDAD-782) > > > > regards, > > gerhard > > > > -- > > > > http://www.irian.at > > > > Your JSF powerhouse - > > JSF Consulting, Development and > > Courses in English and German > > > > Professional Support for Apache MyFaces > > > > -- > Matthias Wessendorf > > further stuff: > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > mail: matzew-at-apache-dot-org > -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
Re: [Trinidad] open issues
Glad you pointed that out. my goal for the patch day is: -apply Trinidad patches -apply MyFaces 1.2 patches (did some already yestrday) I'll take a look at yours! -Matthias On Nov 24, 2007 1:49 PM, Gerhard Petracek <[EMAIL PROTECTED]> wrote: > hello, > > i've provided some patches for trinidad. is there already a planned version > for these patches? > > furthermore, there is an open issue i would like to discuss. > ( https://issues.apache.org/jira/browse/TRINIDAD-782) > > regards, > gerhard > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
[Trinidad] open issues
hello, i've provided some patches for trinidad. is there already a planned version for these patches? furthermore, there is an open issue i would like to discuss. (https://issues.apache.org/jira/browse/TRINIDAD-782) regards, gerhard -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Updated: (MYFACES-1775) attribute "value" in tag "f:param" should not be required
[ https://issues.apache.org/jira/browse/MYFACES-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf updated MYFACES-1775: Resolution: Fixed Fix Version/s: 1.2.1-SNAPSHOT Status: Resolved (was: Patch Available) > attribute "value" in tag "f:param" should not be required > - > > Key: MYFACES-1775 > URL: https://issues.apache.org/jira/browse/MYFACES-1775 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 1.2.0 >Reporter: Thomas Fischer >Assignee: Matthias Weßendorf > Fix For: 1.2.1-SNAPSHOT > > Attachments: myfaces_core_tld.patch > > > According to > http://java.sun.com/javaee/javaserverfaces/1.2/docs/tlddocs/index.html, the > value attribute of the f:param tag should not be required. > But in myfaces_core.tld, it is: > # snip start > > ... > param > ... > > The value of this parameter. > value > true > > > ... > > # snip end > Note: in JSF 1.1 the value attribute was required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1775) attribute "value" in tag "f:param" should not be required
[ https://issues.apache.org/jira/browse/MYFACES-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated MYFACES-1775: Status: Patch Available (was: Open) > attribute "value" in tag "f:param" should not be required > - > > Key: MYFACES-1775 > URL: https://issues.apache.org/jira/browse/MYFACES-1775 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 1.2.0 >Reporter: Thomas Fischer > Attachments: myfaces_core_tld.patch > > > According to > http://java.sun.com/javaee/javaserverfaces/1.2/docs/tlddocs/index.html, the > value attribute of the f:param tag should not be required. > But in myfaces_core.tld, it is: > # snip start > > ... > param > ... > > The value of this parameter. > value > true > > > ... > > # snip end > Note: in JSF 1.1 the value attribute was required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
