[jira] [Commented] (MYFACES-4098) Implement ResourceHandler.getViewResources(...)

[Leonardo Uribe (JIRA)]

[ 
https://issues.apache.org/jira/browse/MYFACES-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895237#comment-15895237
 ] 

Leonardo Uribe commented on MYFACES-4098:
-

Committed part 2, which is the algorithm body and some tests. There are still 
some things to do, for example review each loader has the proper filters to 
avoid unauthorized access to resources and so on, but the solution proposed is 
good.

There are some methods to implement in ViewHandler ( getViews(...) ). It is 
getting long to solve this point, but there are some considerations with the 
solution. In the past we have had problems with scanning jar files, because 
server applications could do some tricks there. So, we need to study here if it 
is necessary an SPI interface for this kind of tree traversing. The solution 
committed works but solve this point is far from over.

> Implement ResourceHandler.getViewResources(...)
> ---
>
> Key: MYFACES-4098
> URL: https://issues.apache.org/jira/browse/MYFACES-4098
> Project: MyFaces Core
>  Issue Type: New Feature
>  Components: JSR-372
>Reporter: Leonardo Uribe
>Assignee: Leonardo Uribe
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Checkstyle Rules version 7

[Leonardo Uribe]

+1

2017-03-03 3:37 GMT-05:00 Bernd Bohmann :

> Here is my
>
> +1
>
> Regards
>
> Bernd
>
> On Thu, Mar 2, 2017 at 4:56 PM, Dennis Kieselhorst  wrote:
>
>> +1
>>
>> We should release a new version of myfaces-master-pom with reference to
>> the
>> updated rules afterwards.
>>
>>
>>
>> --
>> View this message in context: http://myfaces.10567.n7.nabble
>> .com/VOTE-Checkstyle-Rules-version-6-tp49990p123069.html
>> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>>
>
>

[jira] [Commented] (TOBAGO-1703) No ID for tc:out with labelLayout=skip

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893932#comment-15893932
 ] 

Hudson commented on TOBAGO-1703:


SUCCESS: Integrated in Jenkins build Tobago Trunk #791 (See 
[https://builds.apache.org/job/Tobago%20Trunk/791/])
TOBAGO-1703: No ID for tc:out with labelLayout=skip
* an outer DIV with the ID is now always rendered, even for labelLayout=skip
* this commit also resolve TOBAGO-1707
[developed by hnoeth] (deki: 
[http://svn.apache.org/viewvc/?view=rev=1785228])
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIInput.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectManyListbox.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectManyShuttle.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java


> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: 1703___1707.patch, 
> TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and 
> thus also the ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TOBAGO-1707) No ID for tc:selectManyCheckbox and tc:selectOneRadio with labelLayout=skip

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/TOBAGO-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893933#comment-15893933
 ] 

Hudson commented on TOBAGO-1707:


SUCCESS: Integrated in Jenkins build Tobago Trunk #791 (See 
[https://builds.apache.org/job/Tobago%20Trunk/791/])
TOBAGO-1703: No ID for tc:out with labelLayout=skip
* an outer DIV with the ID is now always rendered, even for labelLayout=skip
* this commit also resolve TOBAGO-1707
[developed by hnoeth] (deki: 
[http://svn.apache.org/viewvc/?view=rev=1785228])
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIFile.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIInput.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectManyListbox.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectManyShuttle.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java


> No ID for tc:selectManyCheckbox and tc:selectOneRadio with labelLayout=skip
> ---
>
> Key: TOBAGO-1707
> URL: https://issues.apache.org/jira/browse/TOBAGO-1707
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Attachments: 
> TOBAGO_1707_No_ID_for_tc_selectManyCheckbox_and_tc_selectOneRadio_with_labelLayout_skip.patch
>
>
> ID is not rendered for:
> {code:xml}{code}
> or
> {code:xml}{code}
> Currently only the ID for the select-items is available.
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and 
> thus also the ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Checkstyle Rules version 7

[Bernd Bohmann]

Here is my

+1

Regards

Bernd

On Thu, Mar 2, 2017 at 4:56 PM, Dennis Kieselhorst  wrote:

> +1
>
> We should release a new version of myfaces-master-pom with reference to the
> updated rules afterwards.
>
>
>
> --
> View this message in context: http://myfaces.10567.n7.
> nabble.com/VOTE-Checkstyle-Rules-version-6-tp49990p123069.html
> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>

[jira] [Updated] (TOBAGO-1703) No ID for tc:out with labelLayout=skip

[Dennis Kieselhorst (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst updated TOBAGO-1703:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Patch applied with some additional cleanups.

> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: 1703___1707.patch, 
> TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and 
> thus also the ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TOBAGO-1703) No ID for tc:out with labelLayout=skip

[Dennis Kieselhorst (JIRA)]

[ 
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893883#comment-15893883
 ] 

Dennis Kieselhorst commented on TOBAGO-1703:


Please check if AbstractUISelectManyShuttle also needs to be adapted.

> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: 1703___1707.patch, 
> TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and 
> thus also the ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)