MYFACES-4244 Discussion
Hello all, I've made some performance improvements to MyFaces here: https://issues.apache.org/jira/browse/MYFACES-4244 I've put together a Pull Request here with the changes: https://github.com/apache/myfaces/pull/10 I know that Thomas had some concerns with using a StringBuilder here and I think I've addressed those concerns in the description of the JIRA issue. Doing some profiling of an application with some JSF in it we saw performance improvements with these changes and as a result I wanted to commit them. Please let me know if you have any questions or concerns. Thanks, Paul
[GitHub] pnicolucci opened a new pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times
pnicolucci opened a new pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10 Creating this PR for discussion on the dev list for MYFACES-4244: https://issues.apache.org/jira/browse/MYFACES-4244 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[ https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540163#comment-16540163 ] ASF GitHub Bot commented on MYFACES-4244: - pnicolucci opened a new pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10 Creating this PR for discussion on the dev list for MYFACES-4244: https://issues.apache.org/jira/browse/MYFACES-4244 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Use StringBuilder rather than calling write many times to increase > performance > - > > Key: MYFACES-4244 > URL: https://issues.apache.org/jira/browse/MYFACES-4244 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
