[jira] [Commented] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022677#comment-17022677
]
Leonardo Uribe commented on MYFACES-4318:
-
The example provided will never work, because c:forEach is a tag that only
works on build view time. The value inside "current" var is lost on render
response time, because c:forEach does not have a counterpart at that time.
In other words, c:forEach just does not play well with JSF lifecycle. So, this
is not a bug, the example provided is not correct, and there is no valid
workaround for it.
Don't waste time trying to fix it, it is pointless and you will end up chasing
you own tail. The answer is simple, use other iteration component that has a
JSF component counterpart.
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022642#comment-17022642
]
Bill Lucy commented on MYFACES-4318:
[~volosied] I don't think we should bother with checking the state saving
method here - as I understand the flow here (and like you said) the swap should
work all cases.
[~tandraschko] I agree I'm not completely happy with this patch, but so far
I've struggled to come up with something more generic. The legacy TagHandler
for this - LegacyForEachHandler - is a lot simpler, and closer to what Mojarra
does in its default ForEach implementation. The LegacyForEachHandler doesn't
keep track of the iteration state as closely as ForEachHandler does (and that's
what causes the behavior/problem I've reported here.) [~lu4242] hinted at the
complexity of keeping track of all of this state in MYFACES-3811.
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [myfaces] volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x URL: https://github.com/apache/myfaces/pull/79#issuecomment-577884352 @pnicolucci In that case, I can close this PR then without merging it in. As for your question, I saw comments saying those 4 parameters were deprecated, but after taking a closer look, I believe their functionality was removed. (Since I don't see mentions of the them anywhere else in the code.) They aren't in the MyFacesConfig, but in the following files: org.apache.myfaces.HANDLE_STATE_CACHING_MECHANICS impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java org.apache.myfaces.SAVE_STATE_WITH_VISIT_TREE_ON_PSS impl/src/main/java/org/apache/myfaces/view/facelets /DefaultFaceletsStateManagementStrategy.java org.apache.myfaces.ERROR_HANDLER api/src/main/java/javax/faces/webapp/PreJsf2ExceptionHandlerFactory.java org.apache.myfaces.CACHE_OLD_VIEWS_IN_SESSION_MODE impl/src/main/java/org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [myfaces] volosied opened a new pull request #82: Myfaces-3822 remove RENDER_FORM_SUBMIT_SCRIPT_INLINE param
volosied opened a new pull request #82: Myfaces-3822 remove RENDER_FORM_SUBMIT_SCRIPT_INLINE param URL: https://github.com/apache/myfaces/pull/82 Majority of parameters were already removed except for this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [myfaces] volosied opened a new pull request #81: MYFACES-3822-remove-unsued-parameters-2.3
volosied opened a new pull request #81: MYFACES-3822-remove-unsued-parameters-2.3 URL: https://github.com/apache/myfaces/pull/81 Please let me know if I should change the logging in the AbstractFacesInitializer.java or remove it entirely. I don't see references to any of the parameters anywhere in the code, and all the tests pass, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022485#comment-17022485
]
Thomas Andraschko commented on MYFACES-4318:
It feels bit hacky.
How does it work in the non-legay TagHandlers and how does it work in Mojarra?
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022310#comment-17022310
]
Volodymyr Siedlecki edited comment on MYFACES-4318 at 1/23/20 5:45 PM:
---
I like your patch. However, since this issue only occurs with serialization,
should you also check if client state saving is on or whether server side
serialization is enabled if the two objects don't match? Then again, I'm not
sure that is necessary (since the restored instance _should_ be the same as in
server saving case) and might create performance issues with those checks.
was (Author: volosied):
I like your patch. However, since this issue only occurs with serialization,
should you also check if client state saving is on or whether server side
serialization is enabled if the two objects don't match? Then again, I'm not
sure that is necessary (since the restored instance _should_ be the same as in
server saving case) and might create performance issues with those checks.
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022310#comment-17022310
]
Volodymyr Siedlecki commented on MYFACES-4318:
--
I like your patch. However, since this issue only occurs with serialization,
should you also check if client state saving is on or whether server side
serialization is enabled if the two objects don't match? Then again, I'm not
sure that is necessary (since the restored instance _should_ be the same as in
server saving case) and might create performance issues with those checks.
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
