[GitHub] [myfaces] tandraschko merged pull request #272: MYFACES-4417: Cookie SameSite=Strict
tandraschko merged PR #272: URL: https://github.com/apache/myfaces/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release of MyFaces Core 4.0.0-RC1
I fixed it - can you give it a second try? Am Do., 16. Juni 2022 um 13:45 Uhr schrieb Melloware : > I think we need to change CDI from 2.0 to 4.0 to match the EE 10 spec > right?... > > > org.apache.geronimo.specs > geronimo-jcdi_2.0_spec > 1.2 > provided > jakarta > > > > To... > > > jakarta.enterprise > jakarta.enterprise.cdi-api > 4.0.1 > provided > > > > On 6/16/2022 5:36 AM, Thomas Andraschko wrote: > > Hi, > > i always tested with OWB and this is CDI 2.0 with jakarta namespace. > We need to make sure that this methods are not used anymore: > https://github.com/jakartaee/cdi/pull/473 > After this, it should work fine on CDI 4.0 or later. > > Best regards, > Thomas > > > > Am Mi., 15. Juni 2022 um 20:49 Uhr schrieb Volodymyr Siedlecki < > volos...@apache.org>: > >> Can someone check my work, because it looks I discovered a problem in >> this release. I tried running a JSF-CDI Application on Tomcat 10.1.0, but >> encountered the following exception: >> >> Caused by: java.lang.NoSuchMethodError: >> 'jakarta.enterprise.inject.spi.InjectionTarget >> jakarta.enterprise.inject.spi.BeanManager.createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)' >> at >> org.apache.myfaces.cdi.CDIInjectionProviderImpl.inject(CDIInjectionProviderImpl.java:48) >> at >> org.apache.myfaces.spi.impl.CDIAnnotationDelegateInjectionProvider.inject(CDIAnnotationDelegateInjectionProvider.java:49) >> ... 55 more >> >> Problematic Line: >> https://github.com/apache/myfaces/blob/myfaces-core-module-4.0.0-RC1/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java#L48 >> >> The exception occurs with org.jboss.weld.servlet : weld-servlet-shaded : >> version 5.0.0. >> >> I found that BeanManager#createInjectionTarget was removed from CDI API >> 4.0.0: >> >> >> https://github.com/jakartaee/cdi/commit/efba672d65d41f87b3cb2fb2b3e00778cdaccc31 >> >> Am I looking at this correctly? Can one verify this? Additionally, what >> CDI dependency are using in our poms? >> >> Thanks, >> >> Volodymyr >> >> On 2022/06/10 19:25:03 Volodymyr Siedlecki wrote: >> > Hi, >> > >> > I was running the needed tasks to get the 4.0.0-RC1 release of Apache >> > MyFaces core out. >> > >> > Please note that this vote concerns all of the following parts: >> >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC1 [1] >> > >> > The artifacts were deployed on nexus repo [1] for binary and source >> > packages. >> > >> > The release notes could be found at [4]. Out of all the issues for >> > 4.0.0-RC1, I believe the two below may have work left and can be fixed >> in >> > 4.0.0-RC2. Please see the comments (or move them back to 4.0.0-RC1 >> target >> > if you disagree). >> > >> > https://issues.apache.org/jira/browse/MYFACES-4385 >> > >> > https://issues.apache.org/jira/browse/MYFACES-4387 >> > >> > The japicmp tool shows numerous binary incompatibilities with 4.0.0-RC1 >> and >> > the jakarta.faces-api-4.0.0.jar. Please take a look at the attached >> > 4.0.0-results.html. >> > >> > Once we get the TCK and the signature tests to run, we can identify >> changes >> > which should be addressed. >> > >> > Please take a look at the "4.0.0-RC1" artifacts and vote! (see [3]) >> > >> > Please note: This vote is "majority approval" with a minimum of three +1 >> > votes (see [2]). >> > >> > >> > [ ] +1 for community members who have reviewed the bits >> > [ ] +0 >> > [ ] -1 for fatal flaws that should cause these bits not to be released, >> and >> > why. >> > >> > >> > Thanks, >> > >> > Volodymyr >> > >> > [1] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1204/org/apache/myfaces/core/ >> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes >> > [3] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1204/org/apache/myfaces/core/myfaces-core-assembly/ >> > [4] >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12349323 >> > >> >
[jira] [Commented] (MYFACES-4437) CDI 4.0 Compatibility
[
https://issues.apache.org/jira/browse/MYFACES-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556249#comment-17556249
]
Thomas Andraschko commented on MYFACES-4437:
i didnt upgrade the dependency because some other libs still use
addAnnotatedType()
> CDI 4.0 Compatibility
> -
>
> Key: MYFACES-4437
> URL: https://issues.apache.org/jira/browse/MYFACES-4437
> Project: MyFaces Core
> Issue Type: Task
>Affects Versions: 4.0.0-RC1
>Reporter: Melloware
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 4.0.0-RC1
>
>
> When compiling with CDI 4.0 the build fails with the following errors as it
> looks like some CDI BeanManager methods are missing.
> {code:xml}
>
> jakarta.enterprise
> jakarta.enterprise.cdi-api
> 4.0.1
> provided
> {code}
> Compilation errors...
>
> {code:sh}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project myfaces-impl: Compilation failure: Compilation
> failure:
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/push/EndpointImpl.java:[79,24]
> cannot find symbol
> [ERROR] symbol: method
> fireEvent(jakarta.faces.event.WebsocketEvent,jakarta.enterprise.util.AnnotationLiteral)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/push/EndpointImpl.java:[114,24]
> cannot find symbol
> [ERROR] symbol: method
> fireEvent(jakarta.faces.event.WebsocketEvent,jakarta.enterprise.util.AnnotationLiteral)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/util/AbstractDynamicProducer.java:[124,5]
> method does not override or implement a method from a supertype
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[48,45]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[60,45]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[70,49]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MYFACES-4437) CDI 4.0 Compatibility
[
https://issues.apache.org/jira/browse/MYFACES-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4437.
Resolution: Fixed
> CDI 4.0 Compatibility
> -
>
> Key: MYFACES-4437
> URL: https://issues.apache.org/jira/browse/MYFACES-4437
> Project: MyFaces Core
> Issue Type: Task
>Affects Versions: 4.0.0-RC1
>Reporter: Melloware
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 4.0.0-RC1
>
>
> When compiling with CDI 4.0 the build fails with the following errors as it
> looks like some CDI BeanManager methods are missing.
> {code:xml}
>
> jakarta.enterprise
> jakarta.enterprise.cdi-api
> 4.0.1
> provided
> {code}
> Compilation errors...
>
> {code:sh}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project myfaces-impl: Compilation failure: Compilation
> failure:
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/push/EndpointImpl.java:[79,24]
> cannot find symbol
> [ERROR] symbol: method
> fireEvent(jakarta.faces.event.WebsocketEvent,jakarta.enterprise.util.AnnotationLiteral)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/push/EndpointImpl.java:[114,24]
> cannot find symbol
> [ERROR] symbol: method
> fireEvent(jakarta.faces.event.WebsocketEvent,jakarta.enterprise.util.AnnotationLiteral)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/util/AbstractDynamicProducer.java:[124,5]
> method does not override or implement a method from a supertype
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[48,45]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[60,45]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager
> [ERROR]
> /C:/dev/melloware-git/myfaces/impl/src/main/java/org/apache/myfaces/cdi/CDIInjectionProviderImpl.java:[70,49]
> cannot find symbol
> [ERROR] symbol: method
> createInjectionTarget(jakarta.enterprise.inject.spi.AnnotatedType)
> [ERROR] location: variable beanManager of type
> jakarta.enterprise.inject.spi.BeanManager {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
