[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

[via GitHub]

volosied commented on PR #492:
URL: https://github.com/apache/myfaces/pull/492#issuecomment-1404185814

   Need to check on more edge case before merging 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Tobago 5.5.0 and checkstyle-rules 21

[Henning Nöth]

+1

Am 24.01.23 um 23:30 schrieb Udo Schnurpfeil:

Hello,

we would like to release:
* Tobago 5.5.0
* checkstyle-rules 21

The artifacts were deployed on nexus repository for binary and source
packages:
* Tobago 5.5.0 [1] & checkstyle-rules 21 [2]

The release notes are in Jira:
* Tobago 5.5.0 [3]

The artifacts are available at the staging repository (Nexus) at:

* Tobago 5.5.0 [4] (sha-256 
eddd3525cd7588078eb9a470e20ccc6f815d3435031783a6942461c57de621e9)
* checkstyle-rules 21 [5] (sha-256 
4cd46e160afc8e8687e20153410042566bde0c04d2dc256836490af2dc4b5935)


Please vote now! (The vote is open for 72h.)

[ ] +1
[ ] +0
[ ] -1

Regards,

Udo

[1] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1221
[1] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1220

[2] https://issues.apache.org/jira/projects/TOBAGO/versions/12352597
[3] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1221/org/apache/myfaces/tobago/tobago/5.5.0/tobago-5.5.0-source-release.zip
[4] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1220/org/apache/myfaces/buildtools/checkstyle-rules/21/checkstyle-rules-21-source-release.zip

[GitHub] [myfaces] volosied commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

[via GitHub]

volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1087077197


##
api/src/main/java/jakarta/faces/component/UISelectOne.java:
##
@@ -90,37 +91,43 @@ public void processValidators(FacesContext context)
 @Override
 public VisitResult visit(VisitContext visitContext, 
UIComponent target) 
 {
+// check they they are of the same group
 if (target instanceof UISelectOne  && ((UISelectOne) 
target).getGroup().equals(group)) 
 {
-UISelectOne radio = (UISelectOne) target;
-
-// if target is an instance of UISelectOne then get 
all the UISelectItem children
-// and verify if the submitted value exists
-for (Iterator iter = 
radio.getChildren().iterator(); iter.hasNext(); ) 
-{
-UIComponent component = iter.next();
-if (component instanceof UISelectItem) 
-{
-UISelectItem item = (UISelectItem) component;
-if 
(item.getItemValue().equals(submittedValue)) 
-{
-selectItemValueFound = true;
-return VisitResult.COMPLETE;
-}
-}
-
-}
-return VisitResult.REJECT;

Review Comment:
   Additionally, the current code causes a failure with the Spec329 test: 
   
   
   ```
   Caused by: java.lang.ClassCastException: class java.lang.String cannot be 
cast to class ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity 
(java.lang.String is in module java.base of loader 'bootstrap'; 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity is in unnamed module of 
loader com.ibm.ws.classloading.internal.AppClassLoader @e7d2dc5)
at 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity.equals(Spec329Entity.java:33)
at jakarta.faces.component.UISelectOne$1.visit(UISelectOne.java:105)
at 
org.apache.myfaces.component.visit.FullVisitContext.invokeVisitCallback(FullVisitContext.java:140)
at jakarta.faces.component.UIComponent.visitTree(UIComponent.java:873)
at 
jakarta.faces.component.UIComponentBase.visitTree(UIComponentBase.java:1120)
at jakarta.faces.component.UIData.visitTree(UIData.java:2234)
at jakarta.faces.component.UIForm.visitTree(UIForm.java:343)
at 
jakarta.faces.component.UISelectOne.processValidators(UISelectOne.java:88)
   ```
   
   The new code works fine for me and if you submit some other value in the 
form (other than the available options), you'll just get this type of error.
   ```inDataTableWithEntityList:table:0:radio: Validation Error: Value is not 
valid```
   
   
   As far as I can tell, this code is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

[via GitHub]

volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1087077197


##
api/src/main/java/jakarta/faces/component/UISelectOne.java:
##
@@ -90,37 +91,43 @@ public void processValidators(FacesContext context)
 @Override
 public VisitResult visit(VisitContext visitContext, 
UIComponent target) 
 {
+// check they they are of the same group
 if (target instanceof UISelectOne  && ((UISelectOne) 
target).getGroup().equals(group)) 
 {
-UISelectOne radio = (UISelectOne) target;
-
-// if target is an instance of UISelectOne then get 
all the UISelectItem children
-// and verify if the submitted value exists
-for (Iterator iter = 
radio.getChildren().iterator(); iter.hasNext(); ) 
-{
-UIComponent component = iter.next();
-if (component instanceof UISelectItem) 
-{
-UISelectItem item = (UISelectItem) component;
-if 
(item.getItemValue().equals(submittedValue)) 
-{
-selectItemValueFound = true;
-return VisitResult.COMPLETE;
-}
-}
-
-}
-return VisitResult.REJECT;

Review Comment:
   Additionally, the current code causes a failure with the Spec329 test: 
   
   
   ```
   Caused by: java.lang.ClassCastException: class java.lang.String cannot be 
cast to class ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity 
(java.lang.String is in module java.base of loader 'bootstrap'; 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity is in unnamed module of 
loader com.ibm.ws.classloading.internal.AppClassLoader @e7d2dc5)
at 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity.equals(Spec329Entity.java:33)
at jakarta.faces.component.UISelectOne$1.visit(UISelectOne.java:105)
at 
org.apache.myfaces.component.visit.FullVisitContext.invokeVisitCallback(FullVisitContext.java:140)
at jakarta.faces.component.UIComponent.visitTree(UIComponent.java:873)
at 
jakarta.faces.component.UIComponentBase.visitTree(UIComponentBase.java:1120)
at jakarta.faces.component.UIData.visitTree(UIData.java:2234)
at jakarta.faces.component.UIForm.visitTree(UIForm.java:343)
at 
jakarta.faces.component.UISelectOne.processValidators(UISelectOne.java:88)
   ```
   
   The new work works fine for me and if you use submit some other value in the 
form (other than the available options), you'll just get this type of error.
   ```inDataTableWithEntityList:table:0:radio: Validation Error: Value is not 
valid```
   
   
   As far as I can tell, this code is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

[via GitHub]

volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1087077197


##
api/src/main/java/jakarta/faces/component/UISelectOne.java:
##
@@ -90,37 +91,43 @@ public void processValidators(FacesContext context)
 @Override
 public VisitResult visit(VisitContext visitContext, 
UIComponent target) 
 {
+// check they they are of the same group
 if (target instanceof UISelectOne  && ((UISelectOne) 
target).getGroup().equals(group)) 
 {
-UISelectOne radio = (UISelectOne) target;
-
-// if target is an instance of UISelectOne then get 
all the UISelectItem children
-// and verify if the submitted value exists
-for (Iterator iter = 
radio.getChildren().iterator(); iter.hasNext(); ) 
-{
-UIComponent component = iter.next();
-if (component instanceof UISelectItem) 
-{
-UISelectItem item = (UISelectItem) component;
-if 
(item.getItemValue().equals(submittedValue)) 
-{
-selectItemValueFound = true;
-return VisitResult.COMPLETE;
-}
-}
-
-}
-return VisitResult.REJECT;

Review Comment:
   Additionally, the current code causes a failure with the Spec329 test: 
   
   
   ```
   Caused by: java.lang.ClassCastException: class java.lang.String cannot be 
cast to class ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity 
(java.lang.String is in module java.base of loader 'bootstrap'; 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity is in unnamed module of 
loader com.ibm.ws.classloading.internal.AppClassLoader @e7d2dc5)
   at 
ee.jakarta.tck.faces.test.javaee8.uiinput.Spec329Entity.equals(Spec329Entity.java:33)
   ```
   
   The new work works fine for me and if you use submit some other value in the 
form (other than the available options), you'll just get this type of error.
   ```inDataTableWithEntityList:table:0:radio: Validation Error: Value is not 
valid```
   
   
   As far as I can tell, this code is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied merged pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

[via GitHub]

volosied merged PR #484:
URL: https://github.com/apache/myfaces/pull/484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied commented on pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

[via GitHub]

volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1404009715

   Added check for development stage -- merging 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (TOBAGO-2191) In special case: Unproper HTML replacement after AJAX

[Udo Schnurpfeil (Jira)]

[ 
https://issues.apache.org/jira/browse/TOBAGO-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680630#comment-17680630
 ] 

Udo Schnurpfeil commented on TOBAGO-2191:
-

Seems to be a problem in the jsf_js_ts lib DomQuery.fromMarkup function.

> In special case: Unproper HTML replacement after AJAX
> -
>
> Key: TOBAGO-2191
> URL: https://issues.apache.org/jira/browse/TOBAGO-2191
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: JavaScript
>Reporter: Udo Schnurpfeil
>Priority: Minor
>
> If the fragment loaded by AJAX contains a  tag, there will be an 
> html-block around the fragment like:
> {code}
> 
>   
>   
> replacement
>   
> 
> {code}
> exprected:
> {code}
> replacement
> {code}
> It occurs e.g. on the page 
> https://tobago-demo.apache.org/demo-5-snapshot/content/080-sheet/30-event/Sheet_Event.xhtml
> Click the radio select to change the sheet below. After the request the 
>  tag is inside a 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (TOBAGO-2191) In special case: Unproper HTML replacement after AJAX

[Udo Schnurpfeil (Jira)]

Udo Schnurpfeil created TOBAGO-2191:
---

 Summary: In special case: Unproper HTML replacement after AJAX
 Key: TOBAGO-2191
 URL: https://issues.apache.org/jira/browse/TOBAGO-2191
 Project: MyFaces Tobago
  Issue Type: Bug
Reporter: Udo Schnurpfeil


If the fragment loaded by AJAX contains a  tag, there will be an 
html-block around the fragment like:

{code}

  
  
replacement
  

{code}

exprected:

{code}
replacement
{code}

It occurs e.g. on the page 
https://tobago-demo.apache.org/demo-5-snapshot/content/080-sheet/30-event/Sheet_Event.xhtml
Click the radio select to change the sheet below. After the request the 
 tag is inside a 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release of MyFaces Core 4.0.0-RC4

[Melloware]

+1 from me it looks like all the Quarkus JARS are there this time!


On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote:

Hi,

I was running the needed tasks to get the 4.0.0-RC4 release of Apache 
MyFaces core out.


Please note that this vote concerns all of the following parts:
   1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4  [1]

The artifacts were deployed on nexus repo [1] for binary and source 
packages.


The release notes could be found at [4].

The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 when 
compared to 4.0.0-RC3. Please take a look at the attached results.html.


This release has not yet been run against the TCK.

Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3])

Please note: This vote is "majority approval" with a minimum of three 
+1 votes (see [2]).



[ ] +1 for community members who have reviewed the bits
[ ] +0
[ ] -1 for fatal flaws that should cause these bits not to be 
released, and why.



Thanks,

Volodymyr

[1] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/

[2] http://www.apache.org/foundation/voting.html#ReleaseVotes
[3] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/
[4] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692