[jira] [Commented] (MYFACES-4554) PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
[
https://issues.apache.org/jira/browse/MYFACES-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681594#comment-17681594
]
Thomas Andraschko commented on MYFACES-4554:
yeah, GOOD logging is not easy as you also need to take care of ProjectStages
in this case, its not related to project-stages and may be a important log
so finest is not good i think
we can sure make better messages for such a case or even write a article about
this feature but lets see
> PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
> --
>
> Key: MYFACES-4554
> URL: https://issues.apache.org/jira/browse/MYFACES-4554
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M7, 4.0.0-RC4
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Trivial
>
> The following INFO message can be seen in the logs when MyFaces reverts back
> to using PropertyDescriptors:
>
> {code:java}
> catch (IllegalAccessException e)
> {
> LOG.log(Level.FINEST,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...");
> }
> catch (Throwable e)
> {
> LOG.log(Level.INFO,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...",
> e);
> }
> {code}
> There is nothing for a user to do about using PropertyDescriptors in this
> case. I argue that this should be a FINEST message instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] pnicolucci merged pull request #507: Revert "MYFACES-4554: log FINEST rather than INFO"
pnicolucci merged PR #507: URL: https://github.com/apache/myfaces/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4554) PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
[
https://issues.apache.org/jira/browse/MYFACES-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681592#comment-17681592
]
Paul Nicolucci commented on MYFACES-4554:
-
[~tandraschko] usually INFO messages are usually translated so another reason
to not be INFO in the current state. However, I can understand the argument
around being opt in now vs opt out. I do think we need some work in MyFaces
when it comes to INFO messages not being translated. I'll leave this as - is
for now and close this.
> PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
> --
>
> Key: MYFACES-4554
> URL: https://issues.apache.org/jira/browse/MYFACES-4554
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M7, 4.0.0-RC4
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Trivial
> Fix For: 2.3-next-M8, 4.0.0-RC5
>
>
> The following INFO message can be seen in the logs when MyFaces reverts back
> to using PropertyDescriptors:
>
> {code:java}
> catch (IllegalAccessException e)
> {
> LOG.log(Level.FINEST,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...");
> }
> catch (Throwable e)
> {
> LOG.log(Level.INFO,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...",
> e);
> }
> {code}
> There is nothing for a user to do about using PropertyDescriptors in this
> case. I argue that this should be a FINEST message instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
+1 txs and LieGrue, strub > Am 26.01.2023 um 15:33 schrieb Volodymyr Siedlecki : > > +1 from me. > > We have the required number of votes for this release, so I'll conclude > voting now and finalize this release. > > Thank you all! > > On 2023/01/26 12:54:08 Paul Nicolucci wrote: >> +1 >> >> Regards, >> Paul Nicolucci >> >> On Thu, Jan 26, 2023, 7:41 AM Werner Punz wrote: >> >>> +1 >>> >>> >>> >>> Am Do., 26. Jan. 2023 um 11:19 Uhr schrieb Thomas Andraschko < >>> andraschko.tho...@gmail.com>: >>> +1 Bernd Bohmann schrieb am Do., 26. Jan. 2023, 10:25: > Here is my +1 > > Regards Bernd > > > > > Melloware schrieb am Mi., 25. Jan. 2023, 13:57: > >> +1 from me it looks like all the Quarkus JARS are there this time! >> >> >> On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: >>> Hi, >>> >>> I was running the needed tasks to get the 4.0.0-RC4 release of Apache >>> MyFaces core out. >>> >>> Please note that this vote concerns all of the following parts: >>> 1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] >>> >>> The artifacts were deployed on nexus repo [1] for binary and source >>> packages. >>> >>> The release notes could be found at [4]. >>> >>> The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 >> when >>> compared to 4.0.0-RC3. Please take a look at the attached >> results.html. >>> >>> This release has not yet been run against the TCK. >>> >>> Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) >>> >>> Please note: This vote is "majority approval" with a minimum of three >>> +1 votes (see [2]). >>> >>> >>> [ ] +1 for community members who have reviewed the bits >>> [ ] +0 >>> [ ] -1 for fatal flaws that should cause these bits not to be >>> released, and why. >>> >>> >>> Thanks, >>> >>> Volodymyr >>> >>> [1] >>> >> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ >>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes >>> [3] >>> >> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ >>> [4] >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352692 >>> < >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352692 >>> >> > >>
[GitHub] [myfaces] pnicolucci closed pull request #506: MYFACES-4554: log FINEST rather than INFO - 2.3-next
pnicolucci closed pull request #506: MYFACES-4554: log FINEST rather than INFO - 2.3-next URL: https://github.com/apache/myfaces/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #507: Revert "MYFACES-4554: log FINEST rather than INFO"
pnicolucci opened a new pull request, #507: URL: https://github.com/apache/myfaces/pull/507 Reverts apache/myfaces#505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #505: MYFACES-4554: log FINEST rather than INFO
tandraschko commented on PR #505: URL: https://github.com/apache/myfaces/pull/505#issuecomment-1407422721 Please see my jira comment, doesnt make sense IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #506: MYFACES-4554: log FINEST rather than INFO - 2.3-next
pnicolucci opened a new pull request, #506: URL: https://github.com/apache/myfaces/pull/506 https://issues.apache.org/jira/browse/MYFACES-4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci merged pull request #505: MYFACES-4554: log FINEST rather than INFO
pnicolucci merged PR #505: URL: https://github.com/apache/myfaces/pull/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #505: MYFACES-4554: log FINEST rather than INFO
pnicolucci opened a new pull request, #505: URL: https://github.com/apache/myfaces/pull/505 https://issues.apache.org/jira/browse/MYFACES-4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4554) PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
[
https://issues.apache.org/jira/browse/MYFACES-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681586#comment-17681586
]
Thomas Andraschko commented on MYFACES-4554:
TBH this is a optional feature now and a user should know if this doesnt work
for some cases. And most cases can be fixed by the user, by setting e.g. JVM
options or fixing method Signatures.
> PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
> --
>
> Key: MYFACES-4554
> URL: https://issues.apache.org/jira/browse/MYFACES-4554
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M7, 4.0.0-RC4
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Trivial
>
> The following INFO message can be seen in the logs when MyFaces reverts back
> to using PropertyDescriptors:
>
> {code:java}
> catch (IllegalAccessException e)
> {
> LOG.log(Level.FINEST,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...");
> }
> catch (Throwable e)
> {
> LOG.log(Level.INFO,
> "Could not generate LambdaPropertyDescriptor for "
> + target.getName() + ". Use
> PropertyDescriptor...",
> e);
> }
> {code}
> There is nothing for a user to do about using PropertyDescriptors in this
> case. I argue that this should be a FINEST message instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4554) PropertyDescriptorUtils logs an INFO message, this should be a FINEST message.
Paul Nicolucci created MYFACES-4554:
---
Summary: PropertyDescriptorUtils logs an INFO message, this should
be a FINEST message.
Key: MYFACES-4554
URL: https://issues.apache.org/jira/browse/MYFACES-4554
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 4.0.0-RC4, 2.3-next-M7
Reporter: Paul Nicolucci
Assignee: Paul Nicolucci
The following INFO message can be seen in the logs when MyFaces reverts back to
using PropertyDescriptors:
{code:java}
LOG.log(Level.FINEST,
"Could not generate LambdaPropertyDescriptor for "
+ target.getName() + ". Use
PropertyDescriptor...",
e);{code}
There is nothing for a user to do about using PropertyDescriptors in this case.
I argue that this should be a FINEST message instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] melloware commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier
melloware commented on PR #504: URL: https://github.com/apache/myfaces/pull/504#issuecomment-1407390932 I wonder if this is a question for BalusC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
