[GitHub] [myfaces] melloware commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

2023-01-30 Thread via GitHub


melloware commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1409810671

   Congratulations!!  I know you have been fighting this one!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

2023-01-30 Thread via GitHub


volosied commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1409727137

   GREEN GREEN GREEN!     Never been so happy to see a "BUILD SUCCESSFUL". 
   
   Still need do some more testing and refactor the changes a bit, but I think 
I've fixed this without causing any regressions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4425) Input value not saved/restored in state when inside UIRepeat

2023-01-30 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682221#comment-17682221
 ] 

Volodymyr Siedlecki commented on MYFACES-4425:
--

marked as no fix

Challenge accepted: https://github.com/jakartaee/faces/issues/1757

> Input value not saved/restored in state when inside UIRepeat
> 
>
> Key: MYFACES-4425
> URL: https://issues.apache.org/jira/browse/MYFACES-4425
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Thomas Andraschko
>Priority: Major
>
> https://github.com/eclipse-ee4j/mojarra/issues/4957
> reproducer:
> click "1", message should say "null -> 1"
> click "3", message should say "null -> 3"
> click "2", message should say "1 -> 2", but MyFaces said "null -> 2"
> click "4", message should say "3 -> 4", but MyFaces said "null -> 4"
> {code:html}
> 
> 
>  size="2">
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> {code:java}
> @Named
> @RequestScoped
> public class Issue3833Bean {
> private static List list1 = Arrays.asList("1", "2");
> private static List list2 = Arrays.asList("3", "4");
> private static List> lists = Arrays.asList(list1, list2);
> private String message;
> public void listener(ValueChangeEvent e) {
> message = (e.getOldValue() + " -> " + e.getNewValue());
> }
> public List> getLists() {
>   return lists;
> }
> public String getMessage() {
> return message;
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MYFACES-4425) Input value not saved/restored in state when inside UIRepeat

2023-01-30 Thread Volodymyr Siedlecki (Jira)


 [ 
https://issues.apache.org/jira/browse/MYFACES-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Volodymyr Siedlecki resolved MYFACES-4425.
--
Resolution: Won't Fix

> Input value not saved/restored in state when inside UIRepeat
> 
>
> Key: MYFACES-4425
> URL: https://issues.apache.org/jira/browse/MYFACES-4425
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Thomas Andraschko
>Priority: Major
>
> https://github.com/eclipse-ee4j/mojarra/issues/4957
> reproducer:
> click "1", message should say "null -> 1"
> click "3", message should say "null -> 3"
> click "2", message should say "1 -> 2", but MyFaces said "null -> 2"
> click "4", message should say "3 -> 4", but MyFaces said "null -> 4"
> {code:html}
> 
> 
>  size="2">
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> {code:java}
> @Named
> @RequestScoped
> public class Issue3833Bean {
> private static List list1 = Arrays.asList("1", "2");
> private static List list2 = Arrays.asList("3", "4");
> private static List> lists = Arrays.asList(list1, list2);
> private String message;
> public void listener(ValueChangeEvent e) {
> message = (e.getOldValue() + " -> " + e.getNewValue());
> }
> public List> getLists() {
>   return lists;
> }
> public String getMessage() {
> return message;
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-30 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162
 ] 

Werner Punz commented on MYFACES-4533:
--

I will have another look at the server implementation tomorrow, maybe I can 
figure the missing part out.

We are so close, I probably just have missed a minor thing, to get it right on 
the server.

 

> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed 
> with naming container id 
> -
>
> Key: MYFACES-4533
> URL: https://issues.apache.org/jira/browse/MYFACES-4533
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2023-01-19-08-44-48-874.png, 
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
>  5
> Generated Viewstate: 
> {code:java}
>  id="j_id__v_0:jakarta.faces.ViewState:1" 
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My 
> understanding is this should only apply when the view root is an instance of 
> a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[ANNOUNCE] MyFaces Core v4.0.0-RC4 Release

2023-01-30 Thread Volodymyr Siedlecki
The Apache MyFaces team is pleased to announce the release of MyFaces Core
4.0.0-RC4

MyFaces Core is a Jakarta Faces Server implementation as specified by
Jakarta Faces 4.0 Specification (1).

Jakarta Faces Server (Faces) is a Jakarta specification for building
component-based user interfaces for web applications.

MyFaces Core 4.0.0-RC4 is available in both binary and source distributions.

* https://myfaces.apache.org/#/core40

MyFaces Core is also available in the central Maven repository under Group
ID "org.apache.myfaces.core".

Release Notes - MyFaces Core - Version 4.0.0-RC4 can be found in the
following link:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692

Regards,
The MyFaces Team

1) https://jakarta.ee/specifications/faces/4.0/


[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-30 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682107#comment-17682107
 ] 

Volodymyr Siedlecki commented on MYFACES-4533:
--

Hi, not yet. I focused on a few other things (including MYFACES-4553).

But I think we're basically down to just this JIRA & MYFACES-4553 for us to 
pass the TCK (excluding all the ajax / HTMLUnit problems which shouldn't be an 
issue now with you selenium PR and our team is working to update the old  tck 
to newer HTMLUnit libraries to avoid ajax issues there)

> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed 
> with naming container id 
> -
>
> Key: MYFACES-4533
> URL: https://issues.apache.org/jira/browse/MYFACES-4533
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2023-01-19-08-44-48-874.png, 
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
>  5
> Generated Viewstate: 
> {code:java}
>  id="j_id__v_0:jakarta.faces.ViewState:1" 
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My 
> understanding is this should only apply when the view root is an instance of 
> a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-30 Thread via GitHub


werpu commented on PR #502:
URL: https://github.com/apache/myfaces/pull/502#issuecomment-1408553953

   Answered... yes it very likely is a similar isse, the code affected probably 
uses valid Ecmascript constructs, which Rhino simply cannot handle anymore!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-30 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682048#comment-17682048
 ] 

Werner Punz commented on MYFACES-4533:
--

Hi... sorry, for being absent, but I had to help out in another project for a 
few days... any news on the issue?

 

> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed 
> with naming container id 
> -
>
> Key: MYFACES-4533
> URL: https://issues.apache.org/jira/browse/MYFACES-4533
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2023-01-19-08-44-48-874.png, 
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
>  5
> Generated Viewstate: 
> {code:java}
>  id="j_id__v_0:jakarta.faces.ViewState:1" 
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My 
> understanding is this should only apply when the view root is an instance of 
> a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MYFACES-4555) Annotation @FacesConfig instance cannot be created

2023-01-30 Thread Thomas Andraschko (Jira)


 [ 
https://issues.apache.org/jira/browse/MYFACES-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Andraschko resolved MYFACES-4555.

Resolution: Fixed

> Annotation @FacesConfig instance cannot be created
> --
>
> Key: MYFACES-4555
> URL: https://issues.apache.org/jira/browse/MYFACES-4555
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 4.0.0-RC5
>
>
> See
> https://github.com/jakartaee/faces/issues/1784
> https://github.com/eclipse-ee4j/mojarra/pull/5210



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4555) Annotation @FacesConfig instance cannot be created

2023-01-30 Thread Thomas Andraschko (Jira)
Thomas Andraschko created MYFACES-4555:
--

 Summary: Annotation @FacesConfig instance cannot be created
 Key: MYFACES-4555
 URL: https://issues.apache.org/jira/browse/MYFACES-4555
 Project: MyFaces Core
  Issue Type: Bug
Reporter: Thomas Andraschko






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] Release Tobago 5.5.0 and checkstyle-rules 21

2023-01-30 Thread Werner Punz
+1

Am Mo., 30. Jan. 2023 um 08:21 Uhr schrieb Udo Schnurpfeil <
lof...@apache.org>:

> Hi,
>
> thank you for checking and voting for the releases. The result is
>
> +1
>
> Henning Nöth
> Volker Weber
> Bernd Bohmann
>
> so I will proceed with the next steps for the releases.
>
> Regards,
>
> Udo
>
> Am 26.01.23 um 10:24 schrieb Bernd Bohmann:
>
> Here my +1
>
> Regards Bernd
>
>
>
>
>
>
> Volker Weber  schrieb am Do., 26. Jan. 2023, 09:18:
>
>> Hi,
>>
>> +1
>>
>> Regards,
>>
>> Volker
>>
>> Am Mi., 25. Jan. 2023 um 20:54 Uhr schrieb Henning Nöth <
>> henning.no...@irian.eu>:
>>
>>> +1
>>>
>>> Am 24.01.23 um 23:30 schrieb Udo Schnurpfeil:
>>> > Hello,
>>> >
>>> > we would like to release:
>>> > * Tobago 5.5.0
>>> > * checkstyle-rules 21
>>> >
>>> > The artifacts were deployed on nexus repository for binary and source
>>> > packages:
>>> > * Tobago 5.5.0 [1] & checkstyle-rules 21 [2]
>>> >
>>> > The release notes are in Jira:
>>> > * Tobago 5.5.0 [3]
>>> >
>>> > The artifacts are available at the staging repository (Nexus) at:
>>> >
>>> > * Tobago 5.5.0 [4] (sha-256
>>> > eddd3525cd7588078eb9a470e20ccc6f815d3435031783a6942461c57de621e9)
>>> > * checkstyle-rules 21 [5] (sha-256
>>> > 4cd46e160afc8e8687e20153410042566bde0c04d2dc256836490af2dc4b5935)
>>> >
>>> > Please vote now! (The vote is open for 72h.)
>>> >
>>> > [ ] +1
>>> > [ ] +0
>>> > [ ] -1
>>> >
>>> > Regards,
>>> >
>>> > Udo
>>> >
>>> > [1]
>>> >
>>> https://repository.apache.org/content/repositories/orgapachemyfaces-1221
>>> > [1]
>>> >
>>> https://repository.apache.org/content/repositories/orgapachemyfaces-1220
>>> > [2] https://issues.apache.org/jira/projects/TOBAGO/versions/12352597
>>> > [3]
>>> >
>>> https://repository.apache.org/content/repositories/orgapachemyfaces-1221/org/apache/myfaces/tobago/tobago/5.5.0/tobago-5.5.0-source-release.zip
>>> > [4]
>>> >
>>> https://repository.apache.org/content/repositories/orgapachemyfaces-1220/org/apache/myfaces/buildtools/checkstyle-rules/21/checkstyle-rules-21-source-release.zip
>>> >
>>> >
>>> >
>>>
>>
>>
>> --
>> inexso - information exchange solutions GmbH
>> Ofener Straße 30 | 26121 Oldenburg
>> www.inexso.de
>>
>