[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState
[
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735918#comment-17735918
]
Volodymyr Siedlecki edited comment on MYFACES-4605 at 6/21/23 10:29 PM:
Looks like the new viewstate id is caused by
_fetchUniqueId: function(prefix, identifier) {
var cnt = 0;
var retVal = prefix + identifier + jsf.separatorchar + cnt;
while(this._Dom.byId(retVal) != null)
{ cnt++; retVal = prefix + identifier +
jsf.separatorchar + cnt; }
return retVal;
},
The count starts at 0, and the evaluation sees that 0 is available, so it uses
it.
The Java code starts the id with 1 :
{color:#dcdcaa}see HtmlResponseStateManager{color}
if (count == null)
{ count = Integer.valueOf(0); }
count += 1;
I think we should keep this consistent and have both start with 0 or 1?
Otherwise, I agree with Werner. We just need a unique id, per the spec, and we
do.
was (Author: volosied):
Looks like the new viewstate id is caused by
_fetchUniqueId: function(prefix, identifier) {
var cnt = 0;
var retVal = prefix + identifier + jsf.separatorchar + cnt;
while(this._Dom.byId(retVal) != null) {
cnt++;
retVal = prefix + identifier + jsf.separatorchar + cnt;
}
return retVal;
},
The count starts at 0, and the evaluation sees that 0 is available, so it uses
it.
The Java code starts the id with 1 :
{color:#dcdcaa}HtmlResponseStateManager{color}
if (count == null)
{
count = Integer.valueOf(0);
}
count += 1;
> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as
> discussed here
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the
> workaround outlined by the first link fixes the issue. I believe the same is
> true for the jsf-2.3 feature as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState
[
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735918#comment-17735918
]
Volodymyr Siedlecki commented on MYFACES-4605:
--
Looks like the new viewstate id is caused by
_fetchUniqueId: function(prefix, identifier) {
var cnt = 0;
var retVal = prefix + identifier + jsf.separatorchar + cnt;
while(this._Dom.byId(retVal) != null) {
cnt++;
retVal = prefix + identifier + jsf.separatorchar + cnt;
}
return retVal;
},
The count starts at 0, and the evaluation sees that 0 is available, so it uses
it.
The Java code starts the id with 1 :
{color:#dcdcaa}HtmlResponseStateManager{color}
if (count == null)
{
count = Integer.valueOf(0);
}
count += 1;
> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as
> discussed here
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the
> workaround outlined by the first link fixes the issue. I believe the same is
> true for the jsf-2.3 feature as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState
[ https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735872#comment-17735872 ] Werner Punz commented on MYFACES-4605: -- Ok now I have gotten it, this is a server side "issue", I was only looking on my part, the ajax code. The behavior is not incorrect per se, but might not be ideal for some cases, better for others. First of all the view state is not embedded but it is handled as its own response tag. This is allowed by the spec, in a multiform case the executing form and the form containing the rendered elements get updated viewstates. To handle this is basically that you pass the viewstate as separate response tag and let the client resolve this in the javascript code. Theoretically you also could render the viewstate in the form in the response, but you need to pass it separately anyway because also the issuing form needs to be updated. I guess myfaces simply has skipped this to avoid double view state definitions in the reponse. Again I don´t think this is a bug, because the post processing must be done anyway, you wont lose any performance. Second: The reason why the id changes is simply following: The id is not important except for some internal processing, but must be unique, at submit the jakarta.faces.ViewState name is passed as key. But the id must be set and must include the viewroot identifier, the number at the end is just basically an incrementing number so that the id is unique in the entire page. Again the spec leaves it open what you do with this number in the end, the end result must be simply a unique id! Either way, in the end you will have a proper consistent state after rendering with the viewstates being updated in both forms, but if you look into the response you might not have the viewstates embedded in the form. Again I think this is correct behavior! Someone else might chime in and correct me on this. > Cross form rending via ajax, form is missing ViewState > -- > > Key: MYFACES-4605 > URL: https://issues.apache.org/jira/browse/MYFACES-4605 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.1, 2.3.10 >Reporter: Joe Crichton >Assignee: Werner Punz >Priority: Major > Fix For: 2.3.11, 3.0.3 > > Attachments: image-2023-06-20-21-22-50-593.png > > > Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as > discussed here > [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),] > and [https://github.com/jakartaee/faces/issues/790] > Using openliberty with jsf-3.0 feature still has this occurring. Using the > workaround outlined by the first link fixes the issue. I believe the same is > true for the jsf-2.3 feature as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #4133: build(deps): bump xml-maven-plugin from 1.0.2 to 1.1.0
dependabot[bot] opened a new pull request, #4133: URL: https://github.com/apache/myfaces-tobago/pull/4133 Bumps [xml-maven-plugin](https://github.com/mojohaus/xml-maven-plugin) from 1.0.2 to 1.1.0. Release notes Sourced from https://github.com/mojohaus/xml-maven-plugin/releases;>xml-maven-plugin's releases. 1.1.0 New features and improvements Require Maven 3.5.4+ and updates (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/89;>#89) https://github.com/slawekjaranowski;>@slawekjaranowski fixed https://redirect.github.com/mojohaus/xml-maven-plugin/issues/47;>#47. (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/49;>#49) https://github.com/rosslamont;>@rosslamont Bug Fixes Fix pBase on Windows (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/67;>#67) https://github.com/pzygielo;>@pzygielo Do not validate catalog itself (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/65;>#65) https://github.com/pzygielo;>@pzygielo Dependency updates Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/81;>#81) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/82;>#82) https://github.com/dependabot;>@dependabot Bump mojo-parent from 74 to 75 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/86;>#86) https://github.com/dependabot;>@dependabot Upgrade to Mojo Parent 74 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/85;>#85) https://github.com/snicoll;>@snicoll Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/79;>#79) https://github.com/dependabot;>@dependabot Bump plexus-io from 3.4.0 to 3.4.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/78;>#78) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/75;>#75) https://github.com/dependabot;>@dependabot Bump plexus-io from 2.6.1 to 3.4.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/73;>#73) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.0.22 to 3.4.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/72;>#72) https://github.com/dependabot;>@dependabot Bump parent from 40 to 70 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/66;>#66) https://github.com/pzygielo;>@pzygielo Bump xalan from 2.7.1 to 2.7.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/63;>#63) https://github.com/dependabot;>@dependabot Maintenance Add since tag for goals parameters (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/91;>#91) https://github.com/slawekjaranowski;>@slawekjaranowski Enable spotless for code formatting (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/90;>#90) https://github.com/slawekjaranowski;>@slawekjaranowski Refresh project build (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/88;>#88) https://github.com/slawekjaranowski;>@slawekjaranowski Build Add Release Drafter (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/87;>#87) https://github.com/slawekjaranowski;>@slawekjaranowski Use Maven 3.9.2 and 3.6.3 for builds (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/83;>#83) https://github.com/slawekjaranowski;>@slawekjaranowski Added GitHub actions (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/64;>#64) https://github.com/pzygielo;>@pzygielo Commits https://github.com/mojohaus/xml-maven-plugin/commit/51b1df4f59bc0a80c31166134448d9cab8db4ec9;>51b1df4 [maven-release-plugin] prepare release 1.1.0 https://github.com/mojohaus/xml-maven-plugin/commit/20f4ade20e041d88e83448fc79845b0217b80017;>20f4ade Add since tag for goals parameters https://github.com/mojohaus/xml-maven-plugin/commit/94074267f38355392fd43a62d472459712a5cd97;>9407426 Ignore code reformat from git blame https://github.com/mojohaus/xml-maven-plugin/commit/5b98282791881a45736f44272e05f22a15b65627;>5b98282 Reformat code with spotless https://github.com/mojohaus/xml-maven-plugin/commit/9773f116803ae4495f616b3c3d5377a8751d7e5a;>9773f11 Enable spotless for code formatting https://github.com/mojohaus/xml-maven-plugin/commit/f53e81bb78004dffb65039ec1adb9160b4db;>f53e81b Add me as developer https://github.com/mojohaus/xml-maven-plugin/commit/c027cfd06a25a92db8b2c1d9fc07344078720f78;>c027cfd Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/81;>#81) https://github.com/mojohaus/xml-maven-plugin/commit/b59ba61705a6fd6c62ba6505e3d130418168b7a7;>b59ba61 Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/82;>#82)
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #4132: build(deps): bump xml-maven-plugin from 1.0.2 to 1.1.0
dependabot[bot] opened a new pull request, #4132: URL: https://github.com/apache/myfaces-tobago/pull/4132 Bumps [xml-maven-plugin](https://github.com/mojohaus/xml-maven-plugin) from 1.0.2 to 1.1.0. Release notes Sourced from https://github.com/mojohaus/xml-maven-plugin/releases;>xml-maven-plugin's releases. 1.1.0 New features and improvements Require Maven 3.5.4+ and updates (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/89;>#89) https://github.com/slawekjaranowski;>@slawekjaranowski fixed https://redirect.github.com/mojohaus/xml-maven-plugin/issues/47;>#47. (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/49;>#49) https://github.com/rosslamont;>@rosslamont Bug Fixes Fix pBase on Windows (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/67;>#67) https://github.com/pzygielo;>@pzygielo Do not validate catalog itself (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/65;>#65) https://github.com/pzygielo;>@pzygielo Dependency updates Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/81;>#81) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/82;>#82) https://github.com/dependabot;>@dependabot Bump mojo-parent from 74 to 75 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/86;>#86) https://github.com/dependabot;>@dependabot Upgrade to Mojo Parent 74 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/85;>#85) https://github.com/snicoll;>@snicoll Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/79;>#79) https://github.com/dependabot;>@dependabot Bump plexus-io from 3.4.0 to 3.4.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/78;>#78) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/75;>#75) https://github.com/dependabot;>@dependabot Bump plexus-io from 2.6.1 to 3.4.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/73;>#73) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.0.22 to 3.4.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/72;>#72) https://github.com/dependabot;>@dependabot Bump parent from 40 to 70 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/66;>#66) https://github.com/pzygielo;>@pzygielo Bump xalan from 2.7.1 to 2.7.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/63;>#63) https://github.com/dependabot;>@dependabot Maintenance Add since tag for goals parameters (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/91;>#91) https://github.com/slawekjaranowski;>@slawekjaranowski Enable spotless for code formatting (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/90;>#90) https://github.com/slawekjaranowski;>@slawekjaranowski Refresh project build (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/88;>#88) https://github.com/slawekjaranowski;>@slawekjaranowski Build Add Release Drafter (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/87;>#87) https://github.com/slawekjaranowski;>@slawekjaranowski Use Maven 3.9.2 and 3.6.3 for builds (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/83;>#83) https://github.com/slawekjaranowski;>@slawekjaranowski Added GitHub actions (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/64;>#64) https://github.com/pzygielo;>@pzygielo Commits https://github.com/mojohaus/xml-maven-plugin/commit/51b1df4f59bc0a80c31166134448d9cab8db4ec9;>51b1df4 [maven-release-plugin] prepare release 1.1.0 https://github.com/mojohaus/xml-maven-plugin/commit/20f4ade20e041d88e83448fc79845b0217b80017;>20f4ade Add since tag for goals parameters https://github.com/mojohaus/xml-maven-plugin/commit/94074267f38355392fd43a62d472459712a5cd97;>9407426 Ignore code reformat from git blame https://github.com/mojohaus/xml-maven-plugin/commit/5b98282791881a45736f44272e05f22a15b65627;>5b98282 Reformat code with spotless https://github.com/mojohaus/xml-maven-plugin/commit/9773f116803ae4495f616b3c3d5377a8751d7e5a;>9773f11 Enable spotless for code formatting https://github.com/mojohaus/xml-maven-plugin/commit/f53e81bb78004dffb65039ec1adb9160b4db;>f53e81b Add me as developer https://github.com/mojohaus/xml-maven-plugin/commit/c027cfd06a25a92db8b2c1d9fc07344078720f78;>c027cfd Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/81;>#81) https://github.com/mojohaus/xml-maven-plugin/commit/b59ba61705a6fd6c62ba6505e3d130418168b7a7;>b59ba61 Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/82;>#82)
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #4130: build(deps): bump xml-maven-plugin from 1.0.2 to 1.1.0
dependabot[bot] opened a new pull request, #4130: URL: https://github.com/apache/myfaces-tobago/pull/4130 Bumps [xml-maven-plugin](https://github.com/mojohaus/xml-maven-plugin) from 1.0.2 to 1.1.0. Release notes Sourced from https://github.com/mojohaus/xml-maven-plugin/releases;>xml-maven-plugin's releases. 1.1.0 New features and improvements Require Maven 3.5.4+ and updates (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/89;>#89) https://github.com/slawekjaranowski;>@slawekjaranowski fixed https://redirect.github.com/mojohaus/xml-maven-plugin/issues/47;>#47. (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/49;>#49) https://github.com/rosslamont;>@rosslamont Bug Fixes Fix pBase on Windows (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/67;>#67) https://github.com/pzygielo;>@pzygielo Do not validate catalog itself (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/65;>#65) https://github.com/pzygielo;>@pzygielo Dependency updates Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/81;>#81) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/82;>#82) https://github.com/dependabot;>@dependabot Bump mojo-parent from 74 to 75 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/86;>#86) https://github.com/dependabot;>@dependabot Upgrade to Mojo Parent 74 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/85;>#85) https://github.com/snicoll;>@snicoll Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/79;>#79) https://github.com/dependabot;>@dependabot Bump plexus-io from 3.4.0 to 3.4.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/78;>#78) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/75;>#75) https://github.com/dependabot;>@dependabot Bump plexus-io from 2.6.1 to 3.4.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/73;>#73) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.0.22 to 3.4.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/72;>#72) https://github.com/dependabot;>@dependabot Bump parent from 40 to 70 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/66;>#66) https://github.com/pzygielo;>@pzygielo Bump xalan from 2.7.1 to 2.7.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/63;>#63) https://github.com/dependabot;>@dependabot Maintenance Add since tag for goals parameters (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/91;>#91) https://github.com/slawekjaranowski;>@slawekjaranowski Enable spotless for code formatting (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/90;>#90) https://github.com/slawekjaranowski;>@slawekjaranowski Refresh project build (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/88;>#88) https://github.com/slawekjaranowski;>@slawekjaranowski Build Add Release Drafter (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/87;>#87) https://github.com/slawekjaranowski;>@slawekjaranowski Use Maven 3.9.2 and 3.6.3 for builds (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/83;>#83) https://github.com/slawekjaranowski;>@slawekjaranowski Added GitHub actions (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/64;>#64) https://github.com/pzygielo;>@pzygielo Commits https://github.com/mojohaus/xml-maven-plugin/commit/51b1df4f59bc0a80c31166134448d9cab8db4ec9;>51b1df4 [maven-release-plugin] prepare release 1.1.0 https://github.com/mojohaus/xml-maven-plugin/commit/20f4ade20e041d88e83448fc79845b0217b80017;>20f4ade Add since tag for goals parameters https://github.com/mojohaus/xml-maven-plugin/commit/94074267f38355392fd43a62d472459712a5cd97;>9407426 Ignore code reformat from git blame https://github.com/mojohaus/xml-maven-plugin/commit/5b98282791881a45736f44272e05f22a15b65627;>5b98282 Reformat code with spotless https://github.com/mojohaus/xml-maven-plugin/commit/9773f116803ae4495f616b3c3d5377a8751d7e5a;>9773f11 Enable spotless for code formatting https://github.com/mojohaus/xml-maven-plugin/commit/f53e81bb78004dffb65039ec1adb9160b4db;>f53e81b Add me as developer https://github.com/mojohaus/xml-maven-plugin/commit/c027cfd06a25a92db8b2c1d9fc07344078720f78;>c027cfd Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/81;>#81) https://github.com/mojohaus/xml-maven-plugin/commit/b59ba61705a6fd6c62ba6505e3d130418168b7a7;>b59ba61 Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/82;>#82)
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #4131: build(deps): bump xml-maven-plugin from 1.0.2 to 1.1.0
dependabot[bot] opened a new pull request, #4131: URL: https://github.com/apache/myfaces-tobago/pull/4131 Bumps [xml-maven-plugin](https://github.com/mojohaus/xml-maven-plugin) from 1.0.2 to 1.1.0. Release notes Sourced from https://github.com/mojohaus/xml-maven-plugin/releases;>xml-maven-plugin's releases. 1.1.0 New features and improvements Require Maven 3.5.4+ and updates (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/89;>#89) https://github.com/slawekjaranowski;>@slawekjaranowski fixed https://redirect.github.com/mojohaus/xml-maven-plugin/issues/47;>#47. (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/49;>#49) https://github.com/rosslamont;>@rosslamont Bug Fixes Fix pBase on Windows (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/67;>#67) https://github.com/pzygielo;>@pzygielo Do not validate catalog itself (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/65;>#65) https://github.com/pzygielo;>@pzygielo Dependency updates Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/81;>#81) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/82;>#82) https://github.com/dependabot;>@dependabot Bump mojo-parent from 74 to 75 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/86;>#86) https://github.com/dependabot;>@dependabot Upgrade to Mojo Parent 74 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/85;>#85) https://github.com/snicoll;>@snicoll Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/79;>#79) https://github.com/dependabot;>@dependabot Bump plexus-io from 3.4.0 to 3.4.1 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/78;>#78) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/75;>#75) https://github.com/dependabot;>@dependabot Bump plexus-io from 2.6.1 to 3.4.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/73;>#73) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.0.22 to 3.4.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/72;>#72) https://github.com/dependabot;>@dependabot Bump parent from 40 to 70 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/66;>#66) https://github.com/pzygielo;>@pzygielo Bump xalan from 2.7.1 to 2.7.2 (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/63;>#63) https://github.com/dependabot;>@dependabot Maintenance Add since tag for goals parameters (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/91;>#91) https://github.com/slawekjaranowski;>@slawekjaranowski Enable spotless for code formatting (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/90;>#90) https://github.com/slawekjaranowski;>@slawekjaranowski Refresh project build (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/88;>#88) https://github.com/slawekjaranowski;>@slawekjaranowski Build Add Release Drafter (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/87;>#87) https://github.com/slawekjaranowski;>@slawekjaranowski Use Maven 3.9.2 and 3.6.3 for builds (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/83;>#83) https://github.com/slawekjaranowski;>@slawekjaranowski Added GitHub actions (https://redirect.github.com/mojohaus/xml-maven-plugin/pull/64;>#64) https://github.com/pzygielo;>@pzygielo Commits https://github.com/mojohaus/xml-maven-plugin/commit/51b1df4f59bc0a80c31166134448d9cab8db4ec9;>51b1df4 [maven-release-plugin] prepare release 1.1.0 https://github.com/mojohaus/xml-maven-plugin/commit/20f4ade20e041d88e83448fc79845b0217b80017;>20f4ade Add since tag for goals parameters https://github.com/mojohaus/xml-maven-plugin/commit/94074267f38355392fd43a62d472459712a5cd97;>9407426 Ignore code reformat from git blame https://github.com/mojohaus/xml-maven-plugin/commit/5b98282791881a45736f44272e05f22a15b65627;>5b98282 Reformat code with spotless https://github.com/mojohaus/xml-maven-plugin/commit/9773f116803ae4495f616b3c3d5377a8751d7e5a;>9773f11 Enable spotless for code formatting https://github.com/mojohaus/xml-maven-plugin/commit/f53e81bb78004dffb65039ec1adb9160b4db;>f53e81b Add me as developer https://github.com/mojohaus/xml-maven-plugin/commit/c027cfd06a25a92db8b2c1d9fc07344078720f78;>c027cfd Bump xalan from 2.7.2 to 2.7.3 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/81;>#81) https://github.com/mojohaus/xml-maven-plugin/commit/b59ba61705a6fd6c62ba6505e3d130418168b7a7;>b59ba61 Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/xml-maven-plugin/issues/82;>#82)
[jira] [Commented] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState
[
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735808#comment-17735808
]
Joe Crichton commented on MYFACES-4605:
---
Here is a simple two form two button case:
{noformat}
http://www.w3.org/1999/xhtml;
xmlns:f="http://xmlns.jcp.org/jsf/core;
xmlns:h="http://xmlns.jcp.org/jsf/html;
xmlns:ui="http://xmlns.jcp.org/jsf/facelets;
xmlns:jsf="http://xmlns.jcp.org/jsf;
xmlns:c="http://java.sun.com/jsp/jstl/core;
xmlns:o="http://omnifaces.org/ui;
xmlns:pt="http://xmlns.jcp.org/jsf/passthrough;>
Carbon Title
http://www.w3.org/1999/xhtml;
xmlns:carbon="http://java.sun.com/jsf/composite/carbon;>
if(window.PrimeFaces){PrimeFaces.settings.locale='en_US';PrimeFaces.settings.viewId='/joetest.xhtml';PrimeFaces.settings.contextPath='/technologyconnect';PrimeFaces.settings.cookiesSecure=false;}
Carbon Title
myfaces.config._autoeval = true;
{noformat}
When I press the first button, this is what I see come back from the post, so
it actually updates j_id__v_0:jakarta.faces.ViewState:1, and does not include
the viewstate in the 2nd form being rendered
{noformat}
{noformat}
However, after the jsf update completes, the 2nd form DOES have a viewstate
value listed with id of j_id__v_0:jakarta.faces.ViewState:0 (different than
anything seen thus far).
{noformat}
{noformat}
So maybe a wild goose chase (sorry). The original issue was an error case I had
caused during the conversion to Jakarta JSF 3.0 dealing with Omnifaces. When I
fixed my name space issue, the code was working, using the Balusc workaround
for 2nd form viewstate fixup.
> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as
> discussed here
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the
> workaround outlined by the first link fixes the issue. I believe the same is
> true for the jsf-2.3 feature as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4608) FACELETS_REFRESH_PERIOD Settings
[
https://issues.apache.org/jira/browse/MYFACES-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735794#comment-17735794
]
Paul Nicolucci commented on MYFACES-4608:
-
The spec doesn't mention what to do if the ProjectStage is Development:
[https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/application/viewhandler#FACELETS_REFRESH_PERIOD_PARAM_NAME]
It does however list a default for Production if the parameter isn't specified:
"If ProjectStage is set to Production and this value is not otherwise
specified, the runtime must act as if it is set to -1."
The application looks to have been explicitly setting the parameter to "-1" in
the web.xml:
[https://github.com/gesker/sub-module-reload-page-fail-demonstrator/blob/main/www/src/main/resources/META-INF/web.xml#L60],
so even if we changed our Default in Development it would not have mattered
unless we always ignore the specified parameter when ProjectStage is set to
Development which would not be obvious to a user.
Mojarra looks to use the parameter specified, if not specified, and in
Production it uses "-1" otherwise it uses a default value of "2" it looks:
1)
[https://github.com/eclipse-ee4j/mojarra/blob/8fe7baef662c7b8be28b80e3506b7c7a5b8cd0ce/impl/src/main/java/com/sun/faces/application/ApplicationAssociate.java#L625]
2)
[https://github.com/eclipse-ee4j/mojarra/blob/master/impl/src/main/java/com/sun/faces/config/WebConfiguration.java#L767]
Myfaces:
1)
[https://github.com/apache/myfaces/blob/main/api/src/main/java/jakarta/faces/application/ViewHandler.java#L125]
looks to always default to "-1"
I agree with Vlad, that a specification issue is a good path forward. It would
allow us to discuss at the spec level and ensure consistent implementation.
I'd propose we offer the following: "If ProjectStage is Development and the
parameter is not explicitly set, the default value should be 0."
> FACELETS_REFRESH_PERIOD Settings
>
>
> Key: MYFACES-4608
> URL: https://issues.apache.org/jira/browse/MYFACES-4608
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Melloware
>Priority: Major
>
> Original issue came up in Quarkus conversation:
> [https://github.com/quarkiverse/quarkus-primefaces/issues/75]
> User had this setting in web.xml and was wondering why he could not hot
> reload pages in DEV Mode
> {code:java}
>
> jakarta.faces.FACELETS_REFRESH_PERIOD
> -1
>
> {code}
> Question for the team based on what Mojarra is doing.
> # In PRODUCTION mode should we force it to -1 and ignore the user setting
> like Mojarra does?
> # If the value is not a positive number in DEV mode should we ignore it or
> log a warning?
>
> Any other ideas?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4608) FACELETS_REFRESH_PERIOD Settings
[
https://issues.apache.org/jira/browse/MYFACES-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735780#comment-17735780
]
Volodymyr Siedlecki commented on MYFACES-4608:
--
I would like to see a spec issue just to have consistency. I think having the
spec define 0 for development would be appropriate. Maybe hold off any
changes for now until it's discussed in the community?
The developer can just remove/change context-param for now at least?
> FACELETS_REFRESH_PERIOD Settings
>
>
> Key: MYFACES-4608
> URL: https://issues.apache.org/jira/browse/MYFACES-4608
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Melloware
>Priority: Major
>
> Original issue came up in Quarkus conversation:
> [https://github.com/quarkiverse/quarkus-primefaces/issues/75]
> User had this setting in web.xml and was wondering why he could not hot
> reload pages in DEV Mode
> {code:java}
>
> jakarta.faces.FACELETS_REFRESH_PERIOD
> -1
>
> {code}
> Question for the team based on what Mojarra is doing.
> # In PRODUCTION mode should we force it to -1 and ignore the user setting
> like Mojarra does?
> # If the value is not a positive number in DEV mode should we ignore it or
> log a warning?
>
> Any other ideas?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState
[
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735435#comment-17735435
]
Werner Punz edited comment on MYFACES-4605 at 6/21/23 2:01 PM:
---
Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder
{code}
The test runs 100 times an alternative click either click1 or click2
and then processes the ajax response:
!image-2023-06-20-21-22-50-593.png|width=661,height=159!
In the end I am getting a properly updated viewstate which is identical on both
forms.
The behavor looks correct to me! I also walked through the code, the viewstate
of the executing form is updated as well as the viewstate of the forms in the
render area.
This is correct behavior, as per spec!
Testcase was run against
MyFaces 3.0.3-SNAPSHOT
Can you give me a concrete example where your code fails?
As far as I can see the behavior is correct according to the spec (even takes
the viewroot id into consideration in the code), but I might have missed
something here.
was (Author: werpu):
Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder
{code}
The test runs 100 times an alternative click either click1 or click2
and then processes the ajax response:
!image-2023-06-20-21-22-50-593.png|width=661,height=159!
In the end I am getting a properly updated viewstate which is identical on both
forms.
The behavor looks correct to me! I also walked through the code, the viewstate
of the executing form is updated as well as the viewstate of the forms in the
render area.
This is correct behavior, as per spec!
Testcase was run against
MyFaces 3.0.3-SNAPSHOT
Can you give me a concrete example where your code fails?
As far as I can see the behavior is correct according to the spec (even takes
the viewroot id into consideration in the code), but I might have missed
something here.
> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as
> discussed here
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the
> workaround outlined by the first link fixes the issue. I believe the same is
> true for the jsf-2.3 feature as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4608) FACELETS_REFRESH_PERIOD Settings
[
https://issues.apache.org/jira/browse/MYFACES-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735707#comment-17735707
]
Thomas Andraschko edited comment on MYFACES-4608 at 6/21/23 12:45 PM:
--
AFAICS Mojarra does never ignore the user setting.
IMO we should ignore the setting in DEVELOPMENT and always set it to 0;
Default is -1 anyway
and also make sure that EL is supported in the param
WDYT [~volosied] [~paulnicolucci] ?
was (Author: tandraschko):
AFAICS Mojarra does never ignore the user setting.
IMO we should ignore the setting in DEVELOPMENT and always set it to 0
and also make sure that EL is supported in the param
WDYT [~volosied] [~paulnicolucci] ?
> FACELETS_REFRESH_PERIOD Settings
>
>
> Key: MYFACES-4608
> URL: https://issues.apache.org/jira/browse/MYFACES-4608
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Melloware
>Priority: Major
>
> Original issue came up in Quarkus conversation:
> [https://github.com/quarkiverse/quarkus-primefaces/issues/75]
> User had this setting in web.xml and was wondering why he could not hot
> reload pages in DEV Mode
> {code:java}
>
> jakarta.faces.FACELETS_REFRESH_PERIOD
> -1
>
> {code}
> Question for the team based on what Mojarra is doing.
> # In PRODUCTION mode should we force it to -1 and ignore the user setting
> like Mojarra does?
> # If the value is not a positive number in DEV mode should we ignore it or
> log a warning?
>
> Any other ideas?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4608) FACELETS_REFRESH_PERIOD Settings
[
https://issues.apache.org/jira/browse/MYFACES-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735707#comment-17735707
]
Thomas Andraschko commented on MYFACES-4608:
AFAICS Mojarra does never ignore the user setting.
IMO we should ignore the setting in DEVELOPMENT and always set it to 0
and also make sure that EL is supported in the param
WDYT [~volosied] [~paulnicolucci] ?
> FACELETS_REFRESH_PERIOD Settings
>
>
> Key: MYFACES-4608
> URL: https://issues.apache.org/jira/browse/MYFACES-4608
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Melloware
>Priority: Major
>
> Original issue came up in Quarkus conversation:
> [https://github.com/quarkiverse/quarkus-primefaces/issues/75]
> User had this setting in web.xml and was wondering why he could not hot
> reload pages in DEV Mode
> {code:java}
>
> jakarta.faces.FACELETS_REFRESH_PERIOD
> -1
>
> {code}
> Question for the team based on what Mojarra is doing.
> # In PRODUCTION mode should we force it to -1 and ignore the user setting
> like Mojarra does?
> # If the value is not a positive number in DEV mode should we ignore it or
> log a warning?
>
> Any other ideas?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4608) FACELETS_REFRESH_PERIOD Settings
Melloware created MYFACES-4608:
--
Summary: FACELETS_REFRESH_PERIOD Settings
Key: MYFACES-4608
URL: https://issues.apache.org/jira/browse/MYFACES-4608
Project: MyFaces Core
Issue Type: New Feature
Components: General
Affects Versions: 4.0.1, 2.3-next-M8, 3.0.2, 2.3.10
Reporter: Melloware
Original issue came up in Quarkus conversation:
[https://github.com/quarkiverse/quarkus-primefaces/issues/75]
User had this setting in web.xml and was wondering why he could not hot reload
pages in DEV Mode
{code:java}
jakarta.faces.FACELETS_REFRESH_PERIOD
-1
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2234) Tobago 2: DuplicateIdException with TabGroup navigation Menu
[ https://issues.apache.org/jira/browse/TOBAGO-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Weber resolved TOBAGO-2234. -- Resolution: Fixed > Tobago 2: DuplicateIdException with TabGroup navigation Menu > > > Key: TOBAGO-2234 > URL: https://issues.apache.org/jira/browse/TOBAGO-2234 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 2.5.0 >Reporter: Volker Weber >Assignee: Volker Weber >Priority: Major > > In some cases we got duplicate Ids in TabGroup navigation Menu components. > It seems that ViewRoot.createUniqueId() sometimes fails to create unique ids. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TOBAGO-2234) Tobago 2: DuplicateIdException with TabGroup navigation Menu
Volker Weber created TOBAGO-2234: Summary: Tobago 2: DuplicateIdException with TabGroup navigation Menu Key: TOBAGO-2234 URL: https://issues.apache.org/jira/browse/TOBAGO-2234 Project: MyFaces Tobago Issue Type: Bug Components: Themes Affects Versions: 2.5.0 Reporter: Volker Weber Assignee: Volker Weber In some cases we got duplicate Ids in TabGroup navigation Menu components. It seems that ViewRoot.createUniqueId() sometimes fails to create unique ids. -- This message was sent by Atlassian Jira (v8.20.10#820010)
