Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.14.0 to 4.14.1 [myfaces-tobago]
henningn merged PR #4380: URL: https://github.com/apache/myfaces-tobago/pull/4380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774670#comment-17774670
]
Werner Punz commented on MYFACES-4606:
--
Ok I checked the old code, the old code does not have this problem because only
buttons and submits are appended (we might add hrefs in the long run if
requested)
So I can roll a new jsf_ts release tomorrow and pull the changes in.
The fix is more or less that I basically do not append a checkbox or radio
button as issuing element if it is unchecked (hence the value is not appended
then)
Since the mechanism is needed mostly for buttons anyway (and hrefs), it should
be ok to have this behavior!
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 [myfaces-tobago]
dependabot[bot] closed pull request #4375: build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 URL: https://github.com/apache/myfaces-tobago/pull/4375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 [myfaces-tobago]
dependabot[bot] commented on PR #4375: URL: https://github.com/apache/myfaces-tobago/pull/4375#issuecomment-1759936965 Superseded by #4381. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.1 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4381: URL: https://github.com/apache/myfaces-tobago/pull/4381 Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.13.0 to 4.14.1. Release notes Sourced from https://github.com/SeleniumHQ/selenium/releases";>org.seleniumhq.selenium:selenium-java's releases. Selenium 4.14 Changelog For each component's detailed changelog, please check: https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES";>Ruby https://github.com/SeleniumHQ/selenium/blob/trunk/py/CHANGES";>Python https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/CHANGES.md";>JavaScript https://github.com/SeleniumHQ/selenium/blob/trunk/java/CHANGELOG";>Java https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/CHANGELOG";>DotNet https://github.com/SeleniumHQ/selenium/blob/trunk/cpp/iedriverserver/CHANGELOG";>IEDriverServer Commits in this release https://github.com/seleniumhq/selenium/commit/b6700329dbb822149642bd443a50216ed381e855";>b6700329db - update selenium manager files :: titusfortner https://github.com/seleniumhq/selenium/commit/a0e04e15f17ed3f12373f61c363a296d4e06a976";>a0e04e15f1 - update changelogs for 4.14 :: titusfortner https://github.com/seleniumhq/selenium/commit/49a59a09d09cbe9dfd4924ad538b57ee2a70aaa6";>49a59a09d0 - update pinned edge drivers to a version that works :: titusfortner https://github.com/seleniumhq/selenium/commit/5e6428610e28bb9d5e1ef4288e58679856a4a49b";>5e6428610e - [rust] Include webview2 in Edge module (https://redirect.github.com/SeleniumHQ/selenium/issues/12904";>#12904) :: Boni García https://github.com/seleniumhq/selenium/commit/2a54d3cb63f841a9d04e38c7386a577af8937a00";>2a54d3cb63 - [java] ignore test that breaks in 119 :: titusfortner https://github.com/seleniumhq/selenium/commit/8401a7e5f1750d54b5a7f770dca137208c7e1321";>8401a7e5f1 - [cdp] add Chrome 118 and remove 115 :: titusfortner https://github.com/seleniumhq/selenium/commit/c595b7a688f75e6cddb15680bdf4df9af8d52bbc";>c595b7a688 - [cdp][dotnet] add Chrome 118 and remove 115 :: titusfortner https://github.com/seleniumhq/selenium/commit/c04855fd432d0dbb2dde565fb9a76b1b42eee8b9";>c04855fd43 - [cdp][java] add Chrome 118 and remove 115 :: titusfortner https://github.com/seleniumhq/selenium/commit/d7d1b4efcd971c5daed2fbc6b801a48d7a28dfe8";>d7d1b4efcd - [cdp] fix script tags :: titusfortner https://github.com/seleniumhq/selenium/commit/17835d2ad32a47926ee37eb38ccd4d89fde5125c";>17835d2ad3 - [cdp] add Chrome 118 files and remove Chrome 115 :: titusfortner https://github.com/seleniumhq/selenium/commit/d8b0ae16fbc25e2ec3ee09c2626972a3af5d7b2d";>d8b0ae16fb - update pinned browsers to use Early Stable Chrome 118 :: titusfortner https://github.com/seleniumhq/selenium/commit/7408a5a41dc8d4d27c2b506652650d20bdcc8d6c";>7408a5a41d - [bazel] Bump contrib_rules_jvm to 0.19.0 :: Simon Mavi Stewart https://github.com/seleniumhq/selenium/commit/e7babc9b4160557ceb70ad007c815a2cb222f0e6";>e7babc9b41 - [dotnet] Make sure we can repin deps :: Simon Mavi Stewart https://github.com/seleniumhq/selenium/commit/c8d121e712588dd8d0373405e7dcd0f823ed46ca";>c8d121e712 - [rust] Capture Rust backtrace in case of error (displayed at DEBUG level) (https://redirect.github.com/SeleniumHQ/selenium/issues/12852";>#12852) :: Boni García https://github.com/seleniumhq/selenium/commit/bceee4e33098ed063dbadf8e94c881993bed0ccd";>bceee4e330 - Refactor frame method to use isEmpty for list check and String check. (https://redirect.github.com/SeleniumHQ/selenium/issues/12894";>#12894) :: Manuel Blanco https://github.com/seleniumhq/selenium/commit/c64e41edd2f5389630b26356e8836e1bad07eef7";>c64e41edd2 - [dotnet] Remove tools folder not related to selenium (https://redirect.github.com/SeleniumHQ/selenium/issues/12899";>#12899) :: Nikolay Borisenko https://github.com/seleniumhq/selenium/commit/42796da27c9c4a0334c93f29004cba93cbde8977";>42796da27c - [java] do not need to check for non-w3c capability javascriptEnabled :: titusfortner https://github.com/seleniumhq/selenium/commit/023a0d52f106321838ab1c0997e76693f4dcbdf6";>023a0d52f1 - [IEDriver] Fix potential null pointer access in CookieManager :: Jim Evans https://github.com/seleniumhq/selenium/commit/0f8e018ad7be07127b8b45e9f6894e36762e8b14";>0f8e018ad7 - [rust] Automated Edge management (https://redirect.github.com/SeleniumHQ/selenium/issues/11681";>#11681 and https://redirect.github.com/SeleniumHQ/selenium/issues/11683";>#11683) (https://redirect.github.com/SeleniumHQ/selenium/issues/12835";>#12835) :: Boni García https://github.com/seleniumhq/selenium/commit/73cfa2284e42122a1c7d2ec3dbd9d1f966556c6e";>73cfa2284e - [rust] Support for Chromium (https://redirect.github.com/SeleniumHQ/selenium/issues/12511";>#12511) (https://redirect.github.com/SeleniumHQ/selenium/issues/12890";>#12890
[PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.14.0 to 4.14.1 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4380: URL: https://github.com/apache/myfaces-tobago/pull/4380 Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.14.0 to 4.14.1. Commits See full diff in https://github.com/SeleniumHQ/selenium/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
tandraschko commented on PR #629: URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759887857 +1 we need a base class in 5.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
volosied commented on PR #629: URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759864375 Updated the PR, but I reused many methods from UIData. This shows the necessity to create a super class to share all the overlapping methods, perhaps it can be accomplished in 5.0. All's that is left to add a junit test and pass the TCK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
tandraschko commented on PR #629: URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759779763 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
volosied commented on PR #629: URL: https://github.com/apache/myfaces/pull/629#issuecomment-1759761299 I think I'd rather just add the new field rather than make a whole new class. Current UIIterate work will be saved on the `spec1263-uiiterate` branch. I'll update this just to add rowStatePreserved to UIRepeat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
henningn merged PR #4378: URL: https://github.com/apache/myfaces-tobago/pull/4378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
henningn merged PR #4377: URL: https://github.com/apache/myfaces-tobago/pull/4377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
henningn merged PR #4379: URL: https://github.com/apache/myfaces-tobago/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
