[PR] fix: https for Tobago 6 demo [myfaces-homepage]
henningn opened a new pull request, #65: URL: https://github.com/apache/myfaces-homepage/pull/65 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: https for Tobago 6 demo [myfaces-homepage]
henningn merged PR #65: URL: https://github.com/apache/myfaces-homepage/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782520#comment-17782520 ] Thomas Andraschko commented on MYFACES-4636: 2.3 works fine > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Assignee: Thomas Andraschko >Priority: Major > Fix For: 3.0.3, 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4636. Resolution: Fixed > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 3.0.3, 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782508#comment-17782508 ] Werner Punz commented on MYFACES-4636: -- No I dont think so, but we have to double check this! > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 3.0.3, 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix(sheet): Selector All Checkbox is not synchronized with selector C… [myfaces-tobago]
bohmber merged PR #4406: URL: https://github.com/apache/myfaces-tobago/pull/4406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782498#comment-17782498 ] Thomas Andraschko commented on MYFACES-4636: [~werpu] did you change it also for old JS base in past? > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2253) Npm build is not working under Windows OS
[ https://issues.apache.org/jira/browse/TOBAGO-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2253. -- Fix Version/s: 5.8.0 6.0.0 Resolution: Fixed > Npm build is not working under Windows OS > - > > Key: TOBAGO-2253 > URL: https://issues.apache.org/jira/browse/TOBAGO-2253 > Project: MyFaces Tobago > Issue Type: Bug > Components: JavaScript >Affects Versions: 5.7.2, 6.0.0-beta-1 > Environment: Windows >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 5.8.0, 6.0.0 > > > for example mkdir is not available for Windows OS > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix(npm): Npm build is not working under windows OS [myfaces-tobago]
henningn merged PR #4452: URL: https://github.com/apache/myfaces-tobago/pull/4452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(npm): Npm build is not working under windows OS [myfaces-tobago]
henningn merged PR #4405: URL: https://github.com/apache/myfaces-tobago/pull/4405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
tandraschko commented on PR #637: URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792029872 fixed it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782455#comment-17782455 ] Werner Punz edited comment on MYFACES-4636 at 11/3/23 8:18 AM: --- Looks ok to me, the test reconfirms the result anyway, I wonder why the +colon was added, probably a misunderstanding of the mechanism, but we will see! This might not only affect 2.3 but also the other branches, this needs to be reconfirmed! Thanks for fixing this [~tandraschko] was (Author: werpu): Looks ok to me, the test reconfirms the result anyway, I wonder why the +colon was added, probably a misunderstanding of the mechanism, but we will see! Thanks for fixing this [~tandraschko] > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782455#comment-17782455 ] Werner Punz commented on MYFACES-4636: -- Looks ok to me, the test reconfirms the result anyway, I wonder why the +colon was added, probably a misunderstanding of the mechanism, but we will see! Thanks for fixing this [~tandraschko] > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
tandraschko commented on PR #637: URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792023607 yep not sure what happening i added a unittest yesterday and everything was broken, needed to upgrade OWB because of nullpointers in ASM and now this exception... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1792016552 Give it a shot, we can merge it, from my side it works! (tested it with my it test suite) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #637: URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792015711 Build broken for branch: java.lang.NullPointerException at aQute.bnd.header.OSGiHeader.quote(OSGiHeader.java:153) at aQute.bnd.header.Attrs.append(Attrs.java:424) at aQute.bnd.header.Attrs.append(Attrs.java:404) at aQute.bnd.header.Parameters.append(Parameters.java:175) at aQute.bnd.header.Parameters.toString(Parameters.java:164) at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:789) at aQute.bnd.osgi.Builder.build(Builder.java:104) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #638: URL: https://github.com/apache/myfaces/pull/638 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
werpu commented on PR #634: URL: https://github.com/apache/myfaces/pull/634#issuecomment-1792006256 I have issued a pull request for 2.3-next, will also issue one for 3.0, please see: https://github.com/apache/myfaces/pull/637 my integration tests pass, it is basically a backport from 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #637: URL: https://github.com/apache/myfaces/pull/637 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
werpu commented on PR #634: URL: https://github.com/apache/myfaces/pull/634#issuecomment-1791975218 Hi I will work on the issue today! Sorry was not aware that it is so urgent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org