Re: [PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub


volosied commented on PR #650:
URL: https://github.com/apache/myfaces/pull/650#issuecomment-1831172683

   Oh, I see. It's all resolving to `ProgrammaticViewBean$$OwbNormalScopeProxy` 
in the tests
   
   https://github.com/apache/myfaces/assets/5934310/05a1a9ab-daa0-4878-b91e-e944dee40424;>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub


volosied commented on PR #650:
URL: https://github.com/apache/myfaces/pull/650#issuecomment-1831169515

   I had been testing on 4.0 without the NonBinding attribute, but, then when I 
added it for 4.1 / 5.0, the tests start failing due to the NPE. 
   
   @tandraschko  Any idea here? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MYFACES-4644) Automatic extensionless mapping does not work on Java Facelet

2023-11-28 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790755#comment-17790755
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4644 at 11/28/23 9:33 PM:


4.1: [https://github.com/apache/myfaces/pull/649]

4.0: [https://github.com/apache/myfaces/pull/648]

5.0: https://github.com/apache/myfaces/pull/650


was (Author: volosied):
4.1: [https://github.com/apache/myfaces/pull/649]

 

4.0: https://github.com/apache/myfaces/pull/648

> Automatic extensionless mapping does not work on Java Facelet
> -
>
> Key: MYFACES-4644
> URL: https://issues.apache.org/jira/browse/MYFACES-4644
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.1, 4.1.0, 5.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Reported against Mojarra, but also affects MyFaces.
> https://github.com/eclipse-ee4j/mojarra/issues/5362
> MyFaces fails to find the page:
> ```
> Error 404: java.io.FileNotFoundException: SRVE0190E: File not found: 
> /hello-facelet 
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790761#comment-17790761
 ] 

Volodymyr Siedlecki commented on MYFACES-4641:
--

That said, I don't know when that 3.0 release will occur.

> MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" 
> imports
> 
>
> Key: MYFACES-4641
> URL: https://issues.apache.org/jira/browse/MYFACES-4641
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2
>Reporter: Maxime Leur
>Priority: Major
>
> Hi,
> In MyFaces web site, version "3.0.x" is supposed to be compatible with:
> * Java 1.8
> * Servlet 5.0
> * EL 4.0
> * CDI 3.0 (optional)
> * JSTL 2.0 (optional)
> * BV 2.0 (optional)
> But I see that in "MyFaces bundle" the MANIFEST file contains 
> "jakarta.servlet.*;version="[3,5)" imports:
> {noformat}
>  jakarta.servlet.annotation;version="[3,5)";resolution:=optional
>  jakarta.servlet.http;version="[3,5)"
>  jakarta.servlet.jsp.jstl.core;version="[1.1.2,2.0.0)"
>  jakarta.servlet.jsp.jstl.sql
>  jakarta.servlet.jsp.tagext;version="[2.1.0,3.1)"
>  jakarta.servlet.jsp;version="[2.1.0,3.1)"
>  jakarta.servlet;version="[3,5)"
> {noformat}
> So it seems not compatible on OSGI environment with "Servlet 5.0".
> Regards,
> Maxime



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790759#comment-17790759
 ] 

Volodymyr Siedlecki commented on MYFACES-4641:
--

I still would like to create one more 3.x release since we've made a lot of 
improvements since the last release (1 or 2 years ago) and I still see 
businesses (who slow to migrate to newer technologies) using 3.0 as a stepping 
stone for 4.0.

> MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" 
> imports
> 
>
> Key: MYFACES-4641
> URL: https://issues.apache.org/jira/browse/MYFACES-4641
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2
>Reporter: Maxime Leur
>Priority: Major
>
> Hi,
> In MyFaces web site, version "3.0.x" is supposed to be compatible with:
> * Java 1.8
> * Servlet 5.0
> * EL 4.0
> * CDI 3.0 (optional)
> * JSTL 2.0 (optional)
> * BV 2.0 (optional)
> But I see that in "MyFaces bundle" the MANIFEST file contains 
> "jakarta.servlet.*;version="[3,5)" imports:
> {noformat}
>  jakarta.servlet.annotation;version="[3,5)";resolution:=optional
>  jakarta.servlet.http;version="[3,5)"
>  jakarta.servlet.jsp.jstl.core;version="[1.1.2,2.0.0)"
>  jakarta.servlet.jsp.jstl.sql
>  jakarta.servlet.jsp.tagext;version="[2.1.0,3.1)"
>  jakarta.servlet.jsp;version="[2.1.0,3.1)"
>  jakarta.servlet;version="[3,5)"
> {noformat}
> So it seems not compatible on OSGI environment with "Servlet 5.0".
> Regards,
> Maxime



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Myfaces 4644 5.0 [myfaces]

2023-11-28 Thread via GitHub


volosied opened a new pull request, #650:
URL: https://github.com/apache/myfaces/pull/650

   Not building locally, so I'll create a PR here to verify after all. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4644) Automatic extensionless mapping does not work on Java Facelet

2023-11-28 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790755#comment-17790755
 ] 

Volodymyr Siedlecki commented on MYFACES-4644:
--

4.1: [https://github.com/apache/myfaces/pull/649]

 

4.0: https://github.com/apache/myfaces/pull/648

> Automatic extensionless mapping does not work on Java Facelet
> -
>
> Key: MYFACES-4644
> URL: https://issues.apache.org/jira/browse/MYFACES-4644
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.1, 4.1.0, 5.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Reported against Mojarra, but also affects MyFaces.
> https://github.com/eclipse-ee4j/mojarra/issues/5362
> MyFaces fails to find the page:
> ```
> Error 404: java.io.FileNotFoundException: SRVE0190E: File not found: 
> /hello-facelet 
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Myfaces 4644 [4.1.x] [myfaces]

2023-11-28 Thread via GitHub


volosied opened a new pull request, #649:
URL: https://github.com/apache/myfaces/pull/649

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Enable extensionless requests for programmatic views [myfaces]

2023-11-28 Thread via GitHub


volosied commented on PR #648:
URL: https://github.com/apache/myfaces/pull/648#issuecomment-1830745578

   I'll see if I can add a test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4641) MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" imports

2023-11-28 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790731#comment-17790731
 ] 

Melloware commented on MYFACES-4641:


[~volosied] i think we should close this ticket if the other versions are OK 
and we are not doing any 3.0 releases. Not worth the time to fix.

> MyFaces bundle MANIFEST file contains "jakarta.servlet.*;version="[3,5)" 
> imports
> 
>
> Key: MYFACES-4641
> URL: https://issues.apache.org/jira/browse/MYFACES-4641
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2
>Reporter: Maxime Leur
>Priority: Major
>
> Hi,
> In MyFaces web site, version "3.0.x" is supposed to be compatible with:
> * Java 1.8
> * Servlet 5.0
> * EL 4.0
> * CDI 3.0 (optional)
> * JSTL 2.0 (optional)
> * BV 2.0 (optional)
> But I see that in "MyFaces bundle" the MANIFEST file contains 
> "jakarta.servlet.*;version="[3,5)" imports:
> {noformat}
>  jakarta.servlet.annotation;version="[3,5)";resolution:=optional
>  jakarta.servlet.http;version="[3,5)"
>  jakarta.servlet.jsp.jstl.core;version="[1.1.2,2.0.0)"
>  jakarta.servlet.jsp.jstl.sql
>  jakarta.servlet.jsp.tagext;version="[2.1.0,3.1)"
>  jakarta.servlet.jsp;version="[2.1.0,3.1)"
>  jakarta.servlet;version="[3,5)"
> {noformat}
> So it seems not compatible on OSGI environment with "Servlet 5.0".
> Regards,
> Maxime



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] build(deps): bump logback.version from 1.4.12 to 1.4.13 [myfaces-tobago]

2023-11-28 Thread via GitHub


dependabot[bot] opened a new pull request, #4560:
URL: https://github.com/apache/myfaces-tobago/pull/4560

   Bumps `logback.version` from 1.4.12 to 1.4.13.
   Updates `ch.qos.logback:logback-classic` from 1.4.12 to 1.4.13
   
   Commits
   
   https://github.com/qos-ch/logback/commit/7ee000a0a359d239c60bb93a2f4f4ea467c38395;>7ee000a
 prepare release 1.4.13
   https://github.com/qos-ch/logback/commit/867bf581b678a2eed60d56f257f328284e14ad45;>867bf58
 remove superflus system.out call
   See full diff in https://github.com/qos-ch/logback/compare/v_1.4.12...v_1.4.13;>compare 
view
   
   
   
   
   Updates `ch.qos.logback:logback-core` from 1.4.12 to 1.4.13
   
   Commits
   
   https://github.com/qos-ch/logback/commit/7ee000a0a359d239c60bb93a2f4f4ea467c38395;>7ee000a
 prepare release 1.4.13
   https://github.com/qos-ch/logback/commit/867bf581b678a2eed60d56f257f328284e14ad45;>867bf58
 remove superflus system.out call
   See full diff in https://github.com/qos-ch/logback/compare/v_1.4.12...v_1.4.13;>compare 
view
   
   
   
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[VOTE] Release Tobago 6.1.0 and Tobago 5.9.0

2023-11-28 Thread Henning Nöth

Hello,

we would like to release:
* Tobago 6.1.0
* Tobago 5.9.0

The artifacts were deployed on nexus repository for binary and source 
packages:

* Tobago 6.1.0 [1]
* Tobago 5.9.0 [1]

The release notes are in Jira:
* Tobago 6.1.0 [2]
* Tobago 5.9.0 [3]

The artifacts are available at the staging repository (Nexus) at:
* Tobago 6.1.0 [4] (sha-256 
0b80ef319aceda65cfbfc1bf9e9c6f8b13b43f11e783e584c7bfc6e1eb6f36e5)
* Tobago 5.9.0 [5] (sha-256 
0840ac0689ee41d41a3af78fd2b86d0b4acfe50e934dc84318639a8a6fa30930)


Please vote now! (The vote is open for 72h.)

[ ] +1
[ ] +0
[ ] -1

Regards,
Henning

[1] https://repository.apache.org/content/repositories/orgapachemyfaces-1238
[2] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353821
[3] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353822
[4] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1238/org/apache/myfaces/tobago/tobago/6.1.0/tobago-6.1.0-source-release.zip
[5] 
https://repository.apache.org/content/repositories/orgapachemyfaces-1238/org/apache/myfaces/tobago/tobago/5.9.0/tobago-5.9.0-source-release.zip


Re: [PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn merged PR #4559:
URL: https://github.com/apache/myfaces-tobago/pull/4559


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn opened a new pull request, #4559:
URL: https://github.com/apache/myfaces-tobago/pull/4559

   * don't overwrite JAVA_HOME variables


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ci(github action): Docker integration tests [myfaces-tobago]

2023-11-28 Thread via GitHub


bohmber commented on PR #4543:
URL: https://github.com/apache/myfaces-tobago/pull/4543#issuecomment-1830031931

   Our jasmine test are not stable enough for integration in the ci workflow.
   I would suggest a manual trigger via `workflow_dispatch` and an own workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn merged PR #4558:
URL: https://github.com/apache/myfaces-tobago/pull/4558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn merged PR #4557:
URL: https://github.com/apache/myfaces-tobago/pull/4557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn opened a new pull request, #4558:
URL: https://github.com/apache/myfaces-tobago/pull/4558

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] build(theme): rebuild [myfaces-tobago]

2023-11-28 Thread via GitHub


henningn opened a new pull request, #4557:
URL: https://github.com/apache/myfaces-tobago/pull/4557

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ci(github action): Docker integration tests [myfaces-tobago]

2023-11-28 Thread via GitHub


bohmber commented on PR #4543:
URL: https://github.com/apache/myfaces-tobago/pull/4543#issuecomment-1829829839

   I can see it's downloading snapshots during build. I think we should switch 
off the apache snapshot repository.
   
   Can you add this to the root pom?
   
   ```
   
   
 
   false
 
 
   false
 
 apache.snapshots
 Apache Snapshot Repository
 https://repository.apache.org/snapshots
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org