[jira] Updated: (MYFACES-1775) attribute "value" in tag "f:param" should not be required
[ https://issues.apache.org/jira/browse/MYFACES-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated MYFACES-1775: Status: Patch Available (was: Open) > attribute "value" in tag "f:param" should not be required > - > > Key: MYFACES-1775 > URL: https://issues.apache.org/jira/browse/MYFACES-1775 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 1.2.0 >Reporter: Thomas Fischer > Attachments: myfaces_core_tld.patch > > > According to > http://java.sun.com/javaee/javaserverfaces/1.2/docs/tlddocs/index.html, the > value attribute of the f:param tag should not be required. > But in myfaces_core.tld, it is: > # snip start > > ... > param > ... > > The value of this parameter. > value > true > > > ... > > # snip end > Note: in JSF 1.1 the value attribute was required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1153) t:messages style attribute is ignored and styleClass attribute is rendered as style attribute in output
[ https://issues.apache.org/jira/browse/TOMAHAWK-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_1251 ] David Brainard commented on TOMAHAWK-1153: -- Both t:messages and h:messages use the same files, shared files(MyFacesShared). so fixing at one place will reflect in both the places. > t:messages style attribute is ignored and styleClass attribute is rendered > as style attribute in output > - > > Key: TOMAHAWK-1153 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1153 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Message(s) >Affects Versions: 1.1.7-SNAPSHOT > Environment: Sun jsf RI 1.2_05 ; tomcat 6 ; java version "1.6.0_03" >Reporter: Bogdan Sava >Assignee: Cagatay Civici > Fix For: 1.1.7-SNAPSHOT > > > 1. t:messages style attribute is ignored > 2. t:messages styleClass attribute is rendered as style attribute in output -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1153) t:messages style attribute is ignored and styleClass attribute is rendered as style attribute in output
[ https://issues.apache.org/jira/browse/TOMAHAWK-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544404 ] David Brainard commented on TOMAHAWK-1153: -- i think this is already fixed. this was a simple typo and i had provided a patch for that(now it is resolved). MYFACES-1767 > t:messages style attribute is ignored and styleClass attribute is rendered > as style attribute in output > - > > Key: TOMAHAWK-1153 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1153 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Message(s) >Affects Versions: 1.1.7-SNAPSHOT > Environment: Sun jsf RI 1.2_05 ; tomcat 6 ; java version "1.6.0_03" >Reporter: Bogdan Sava >Assignee: Cagatay Civici > Fix For: 1.1.7-SNAPSHOT > > > 1. t:messages style attribute is ignored > 2. t:messages styleClass attribute is rendered as style attribute in output -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1772) How to apply style/styleclass by calling getStyle() or getstyleclass()
[ https://issues.apache.org/jira/browse/MYFACES-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544011 ] David Brainard commented on MYFACES-1772: - These methods are hooks provided in case if you want to provide a different implementation. I think these comments are correct. I request you to discuss these type of questions in the mailing list before creating an issue in Jira. regards, David > How to apply style/styleclass by calling getStyle() or getstyleclass() > -- > > Key: MYFACES-1772 > URL: https://issues.apache.org/jira/browse/MYFACES-1772 > Project: MyFaces Core > Issue Type: Bug > Components: Extension Feature >Affects Versions: 1.1.5 >Reporter: Raghunandan Sapre > > Hi The source code for many renderer classes say that style of button etc, > can be overriden by overriding getStyle method. > I wanted to know how to do that. I was thinking it should be setStyle method > and not get method? > Thanks > Raghu > /** > * Can be overwritten by derived classes to overrule the style to be used. > */ > protected String getStyle(FacesContext facesContext, UIComponent link) { > if (link instanceof HtmlCommandLink) { > return ((HtmlCommandLink) link).getStyle(); > } > else { > return (String) link.getAttributes().get(HTML.STYLE_ATTR); > } > } > /** > * Can be overwritten by derived classes to overrule the style class to be > used. > */ > protected String getStyleClass(FacesContext facesContext, UIComponent link) { > if (link instanceof HtmlCommandLink) { > return ((HtmlCommandLink) link).getStyleClass(); > } > else { > return (String) link.getAttributes().get(HTML.STYLE_CLASS_ATTR); > } > } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1767) h:messages generates style property as styleClass propery.
[ https://issues.apache.org/jira/browse/MYFACES-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542188 ] David Brainard commented on MYFACES-1767: - it is a simple typo i think so... ;) patch added. > h:messages generates style property as styleClass propery. > --- > > Key: MYFACES-1767 > URL: https://issues.apache.org/jira/browse/MYFACES-1767 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > Attachments: HtmlMessageRendererBase.patch, > HtmlMessagesRendererBase.patch > > > For this fregment: > > layout="table" /> > This is the HTML that is being produced: > > Total % > Audience should be 100% or 0% > Seems like style is sharing same property with styleClass. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Generic Event: (MYFACES-1767) h:messages generates style property as styleClass propery.
[ https://issues.apache.org/jira/browse/MYFACES-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated MYFACES-1767: issue.field.status: Patch Available (was: Open) > h:messages generates style property as styleClass propery. > --- > > common.concepts.key: MYFACES-1767 > common.concepts.url: https://issues.apache.org/jira/browse/MYFACES-1767 >common.concepts.project: MyFaces Core >common.concepts.issuetype: Bug >Affects Versions: 1.1.5 >issue.field.reporter: Guy Bashan > > For this fregment: > > layout="table" /> > This is the HTML that is being produced: > > Total % > Audience should be 100% or 0% > Seems like style is sharing same property with styleClass. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1760) Using "getSelectedValues" of "UISelectMany" seems to be causing "ClassCastException"
[ https://issues.apache.org/jira/browse/MYFACES-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541626 ] David Brainard commented on MYFACES-1760: - Hi Simon, I have added a patch as discussed. Pls look into it. regards, David Brainard Sounthiraraj > Using "getSelectedValues" of "UISelectMany" seems to be causing > "ClassCastException" > > > Key: MYFACES-1760 > URL: https://issues.apache.org/jira/browse/MYFACES-1760 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > Attachments: UISelectMany.patch > > > It seems like calling getSelectedValues method of selectBooleanCheckbox > causes exception. > This is an example for a fregment of code: > - > value="#{test_scope.targetPagePhysicals}" layout="pageDirection" > converter="PagePhysicalConverter" binding="#{test_scope.htmlSelect}"> >value="#{test_scope.pagePhysicals}" /> > > style="width:100px" immediate="true" onclick="submit()" forceId="true" > actionListener="#{test_scope.targetPagesSelectedAction}" /> > In the bean: > > public void targetPagesSelectedAction(ActionEvent event) > { > Object[] xx = htmlSelect.getSelectedValues(); > FacesContext.getCurrentInstance().renderResponse(); > } > Causes the following exception: > --- > javax.servlet.ServletException: Exception while invoking expression > #{test_scope.targetPagesSelectedAction} > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:154) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.ajaxanywhere.AAFilter.doFilter(AAFilter.java:46) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.shale.faces.ShaleApplicationFilter.doFilter(ShaleApplicationFilter.java:285) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > com.amadesa.admin.model.persistence.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:149) > at > com.amadesa.admin.model.persistence.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:56) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:216) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > at > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:634) > at > org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445) > at java.lang.Thread.run(Thread.java:619) > Caused by: javax.faces.el.EvaluationException: Exception while invoking > expression #{test_scope.targetPagesSelectedAction} > at > org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:156) > at javax.faces.component.UICommand.broadcast(UICommand.java:89) > at > javax.faces.component.UIViewRoot._broadcastForPhase(UIViewRoot.java:97) > at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:139) > at > org.apache.myfaces.lifecycle.ApplyRequestValuesExecutor.execute(ApplyRequestValuesExecutor.java:32) > at > org.apache.myf
[jira] Updated: (MYFACES-1760) Using "getSelectedValues" of "UISelectMany" seems to be causing "ClassCastException"
[ https://issues.apache.org/jira/browse/MYFACES-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated MYFACES-1760: Status: Patch Available (was: Open) > Using "getSelectedValues" of "UISelectMany" seems to be causing > "ClassCastException" > > > Key: MYFACES-1760 > URL: https://issues.apache.org/jira/browse/MYFACES-1760 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > > It seems like calling getSelectedValues method of selectBooleanCheckbox > causes exception. > This is an example for a fregment of code: > - > value="#{test_scope.targetPagePhysicals}" layout="pageDirection" > converter="PagePhysicalConverter" binding="#{test_scope.htmlSelect}"> >value="#{test_scope.pagePhysicals}" /> > > style="width:100px" immediate="true" onclick="submit()" forceId="true" > actionListener="#{test_scope.targetPagesSelectedAction}" /> > In the bean: > > public void targetPagesSelectedAction(ActionEvent event) > { > Object[] xx = htmlSelect.getSelectedValues(); > FacesContext.getCurrentInstance().renderResponse(); > } > Causes the following exception: > --- > javax.servlet.ServletException: Exception while invoking expression > #{test_scope.targetPagesSelectedAction} > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:154) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.ajaxanywhere.AAFilter.doFilter(AAFilter.java:46) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.shale.faces.ShaleApplicationFilter.doFilter(ShaleApplicationFilter.java:285) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > com.amadesa.admin.model.persistence.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:149) > at > com.amadesa.admin.model.persistence.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:56) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:216) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > at > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:634) > at > org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445) > at java.lang.Thread.run(Thread.java:619) > Caused by: javax.faces.el.EvaluationException: Exception while invoking > expression #{test_scope.targetPagesSelectedAction} > at > org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:156) > at javax.faces.component.UICommand.broadcast(UICommand.java:89) > at > javax.faces.component.UIViewRoot._broadcastForPhase(UIViewRoot.java:97) > at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:139) > at > org.apache.myfaces.lifecycle.ApplyRequestValuesExecutor.execute(ApplyRequestValuesExecutor.java:32) > at > org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:95) > at > org.apache.myfaces.lifecycle.LifecycleImpl.execute(Lifec
[jira] Commented: (MYFACES-1760) Using "getSelectedValues" of "UISelectMany" seems to be causing "ClassCastException"
[ https://issues.apache.org/jira/browse/MYFACES-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540819 ] David Brainard commented on MYFACES-1760: - Sorry i missed a part: the conversion logic according to the specs(docs in ri) and impl support only array or arraylist. so the getSelectedValues() should support only those two " array and arraylist "(There wont be anything else coz they they are converted properly and set ;) . so any error will be thrown at that point itself so no need to wry) so an else part should be added to the logic which will throw an error since we support only array or an arraylist . > Using "getSelectedValues" of "UISelectMany" seems to be causing > "ClassCastException" > > > Key: MYFACES-1760 > URL: https://issues.apache.org/jira/browse/MYFACES-1760 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > > It seems like calling getSelectedValues method of selectBooleanCheckbox > causes exception. > This is an example for a fregment of code: > - > value="#{test_scope.targetPagePhysicals}" layout="pageDirection" > converter="PagePhysicalConverter" binding="#{test_scope.htmlSelect}"> >value="#{test_scope.pagePhysicals}" /> > > style="width:100px" immediate="true" onclick="submit()" forceId="true" > actionListener="#{test_scope.targetPagesSelectedAction}" /> > In the bean: > > public void targetPagesSelectedAction(ActionEvent event) > { > Object[] xx = htmlSelect.getSelectedValues(); > FacesContext.getCurrentInstance().renderResponse(); > } > Causes the following exception: > --- > javax.servlet.ServletException: Exception while invoking expression > #{test_scope.targetPagesSelectedAction} > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:154) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.ajaxanywhere.AAFilter.doFilter(AAFilter.java:46) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.shale.faces.ShaleApplicationFilter.doFilter(ShaleApplicationFilter.java:285) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > com.amadesa.admin.model.persistence.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:149) > at > com.amadesa.admin.model.persistence.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:56) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:216) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > at > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:634) > at > org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445) > at java.lang.Thread.run(Thread.java:619) > Caused by: javax.faces.el.EvaluationException: Exception while invoking > expression #{test_scope.targetPagesSelectedAction} > at > org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:156) > at javax.faces.component.UICommand.broadcast(
[jira] Commented: (MYFACES-1760) Using "getSelectedValues" of "UISelectMany" seems to be causing "ClassCastException"
[ https://issues.apache.org/jira/browse/MYFACES-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540814 ] David Brainard commented on MYFACES-1760: - this is wat the spec(jsf-1_2-spec) says about Selected values: name :selected Values Type : Object[] or array of primitives Description : The selected item values of this component. This property is a typesafe alias for the value property, so that the actual state to be used can be acquired via a value expression." according to this we have to just obtain the value from the value expression and return a primitive or an object[] So according to me the logic should be as follows: Obtain the value through value binding if the value is an array return the value casting it to Object[] if the value is a ArrayList convert the value to an array, return the array after casting it to Object[] if this is acceptable pls comment i'l add a patch for this tom. Regards, David Brainard Sounthiraraj > Using "getSelectedValues" of "UISelectMany" seems to be causing > "ClassCastException" > > > Key: MYFACES-1760 > URL: https://issues.apache.org/jira/browse/MYFACES-1760 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > > It seems like calling getSelectedValues method of selectBooleanCheckbox > causes exception. > This is an example for a fregment of code: > - > value="#{test_scope.targetPagePhysicals}" layout="pageDirection" > converter="PagePhysicalConverter" binding="#{test_scope.htmlSelect}"> >value="#{test_scope.pagePhysicals}" /> > > style="width:100px" immediate="true" onclick="submit()" forceId="true" > actionListener="#{test_scope.targetPagesSelectedAction}" /> > In the bean: > > public void targetPagesSelectedAction(ActionEvent event) > { > Object[] xx = htmlSelect.getSelectedValues(); > FacesContext.getCurrentInstance().renderResponse(); > } > Causes the following exception: > --- > javax.servlet.ServletException: Exception while invoking expression > #{test_scope.targetPagesSelectedAction} > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:154) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.ajaxanywhere.AAFilter.doFilter(AAFilter.java:46) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.shale.faces.ShaleApplicationFilter.doFilter(ShaleApplicationFilter.java:285) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > com.amadesa.admin.model.persistence.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:149) > at > com.amadesa.admin.model.persistence.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:56) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:216) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > at > org.apache.coyote.http11.Http11Protocol$Http11Connection
[jira] Commented: (MYFACES-1760) Using "getSelectedValues" of "UISelectMany" seems to be causing "ClassCastException"
[ https://issues.apache.org/jira/browse/MYFACES-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540546 ] David Brainard commented on MYFACES-1760: - When we change the value binding from a list to an array this problem does not occur.ie in this value-expression "#{test_scope.targetPagePhysicals}" if targetPagePhysicals is an array this problem wont occur. I checked the impl. The problem is that when the selected values are converted, the type of value binding is checked valueType = vb.getType(facesContext); and if it is an array the selected values are set in a array and if it is a list it is set to an arraylist. so when getSelectedValues() method is called it just resolves the value and casts it to Object[] and we get the prob. I have checked with the Sun RI. the prob is present there also. I have checked the specs.this is wat it is stated in the specs. "This property is a typesafe alias for the value property,so that the actual state to be used can be acquired via a value expression." I think we have to check the type of the value returned by value binding before casting to Object[](Unless it has been implemented like that intentionally for some reason). pls comment if there is any prob. > Using "getSelectedValues" of "UISelectMany" seems to be causing > "ClassCastException" > > > Key: MYFACES-1760 > URL: https://issues.apache.org/jira/browse/MYFACES-1760 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 >Reporter: Guy Bashan > > It seems like calling getSelectedValues method of selectBooleanCheckbox > causes exception. > This is an example for a fregment of code: > - > value="#{test_scope.targetPagePhysicals}" layout="pageDirection" > converter="PagePhysicalConverter" binding="#{test_scope.htmlSelect}"> >value="#{test_scope.pagePhysicals}" /> > > style="width:100px" immediate="true" onclick="submit()" forceId="true" > actionListener="#{test_scope.targetPagesSelectedAction}" /> > In the bean: > > public void targetPagesSelectedAction(ActionEvent event) > { > Object[] xx = htmlSelect.getSelectedValues(); > FacesContext.getCurrentInstance().renderResponse(); > } > Causes the following exception: > --- > javax.servlet.ServletException: Exception while invoking expression > #{test_scope.targetPagesSelectedAction} > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:154) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.ajaxanywhere.AAFilter.doFilter(AAFilter.java:46) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.shale.faces.ShaleApplicationFilter.doFilter(ShaleApplicationFilter.java:285) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > com.amadesa.admin.model.persistence.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:149) > at > com.amadesa.admin.model.persistence.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:56) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:
[jira] Updated: (TOMAHAWK-1110) Action / ActionListener on t:headerLink
[ https://issues.apache.org/jira/browse/TOMAHAWK-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated TOMAHAWK-1110: - Status: Patch Available (was: Open) > Action / ActionListener on t:headerLink > --- > > Key: TOMAHAWK-1110 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1110 > Project: MyFaces Tomahawk > Issue Type: Bug >Affects Versions: 1.1.6 > Environment: Java 5 + Tomcat 6 >Reporter: Jesper Pedersen > > The action and actionListener attributes of t:headerLink are never evaluated. > F.ex. > value="#{b.collapsed}" > title="p1"> > > action="#{b.goMenu}"> > type="org.apache.test.menu.HeaderLinkActionListener" /> > > > > > > > > > Log statements in b.goMenu and processAction() are never displayed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TOMAHAWK-1110) Action / ActionListener on t:headerLink
[ https://issues.apache.org/jira/browse/TOMAHAWK-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539468 ] sdbrain edited comment on TOMAHAWK-1110 at 11/1/07 2:07 PM: --- I had a look into the prob.I think it is due to the following reason: Whenever we add a t:headerLink to the header facet, the id for the link is modified by the following code in the encodeChildren() of the HtmlCollapsiblePanelRenderer class as follows if (linkToReset != null) { resetId = linkToReset.getId(); linkToReset.setId(collapsiblePanel.getId() + LINK_ID); } so while decoding any call to the component.getClientId(facesContext); will result in recalculation of the id(according to the specs) so the clientId obtained by this call will never be equal to the id which is obtained from the form using this code String reqValue = (String) facesContext.getExternalContext().getRequestParameterMap().get( HtmlRendererUtils.getHiddenCommandLinkFieldName(formInfo)); since the clientId and reqValue are not equal, never an action or an actionlistener registered with the link gets called. soln: By writing a renderer for HeaderLink where we override the decode method and change the way the clientId is calculated. Pls correct me if i am wrong. ;) I'll try to add a patch for this soon. was (Author: sdbrain): I had a look into the prob.I think it is due to the following reason: Whenever we add a t:headerLink to the header facet, the id for the link is modified by the following code in the encodeChildren() of the HtmlCollapsiblePanelRenderer class as follows if (linkToReset != null) { resetId = linkToReset.getId(); linkToReset.setId(collapsiblePanel.getId() + LINK_ID); } so while decoding any call to the component.getClientId(facesContext); will result in recalculation of the id(according to the specs) so the clientId obtained by this call will never be equal to the id which is obtained from the form using this code String reqValue = (String) facesContext.getExternalContext().getRequestParameterMap().get( HtmlRendererUtils.getHiddenCommandLinkFieldName(formInfo)); since the clientId and reqValue are not equal, never an action or an actionlistener registered with the link gets called. soln: By writing a renderer for HeaderLink where we override the decode method and change the way the clientId is calculated. I'll try to add a patch for this soon. > Action / ActionListener on t:headerLink > --- > > Key: TOMAHAWK-1110 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1110 > Project: MyFaces Tomahawk > Issue Type: Bug >Affects Versions: 1.1.6 > Environment: Java 5 + Tomcat 6 >Reporter: Jesper Pedersen > > The action and actionListener attributes of t:headerLink are never evaluated. > F.ex. > value="#{b.collapsed}" > title="p1"> > > action="#{b.goMenu}"> > type="org.apache.test.menu.HeaderLinkActionListener" /> > > > > > > > > > Log statements in b.goMenu and processAction() are never displayed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1110) Action / ActionListener on t:headerLink
[ https://issues.apache.org/jira/browse/TOMAHAWK-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539468 ] David Brainard commented on TOMAHAWK-1110: -- I had a look into the prob.I think it is due to the following reason: Whenever we add a t:headerLink to the header facet, the id for the link is modified by the following code in the encodeChildren() of the HtmlCollapsiblePanelRenderer class as follows if (linkToReset != null) { resetId = linkToReset.getId(); linkToReset.setId(collapsiblePanel.getId() + LINK_ID); } so while decoding any call to the component.getClientId(facesContext); will result in recalculation of the id(according to the specs) so the clientId obtained by this call will never be equal to the id which is obtained from the form using this code String reqValue = (String) facesContext.getExternalContext().getRequestParameterMap().get( HtmlRendererUtils.getHiddenCommandLinkFieldName(formInfo)); since the clientId and reqValue are not equal, never an action or an actionlistener registered with the link gets called. soln: By writing a renderer for HeaderLink where we override the decode method and change the way the clientId is calculated. I'll try to add a patch for this soon. > Action / ActionListener on t:headerLink > --- > > Key: TOMAHAWK-1110 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1110 > Project: MyFaces Tomahawk > Issue Type: Bug >Affects Versions: 1.1.6 > Environment: Java 5 + Tomcat 6 >Reporter: Jesper Pedersen > > The action and actionListener attributes of t:headerLink are never evaluated. > F.ex. > value="#{b.collapsed}" > title="p1"> > > action="#{b.goMenu}"> > type="org.apache.test.menu.HeaderLinkActionListener" /> > > > > > > > > > Log statements in b.goMenu and processAction() are never displayed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1744) Validation messages is shown for SelectOneMenu in case first child is not SelectItems or SelectItem
[ https://issues.apache.org/jira/browse/MYFACES-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538119 ] David Brainard commented on MYFACES-1744: - Patch added. > Validation messages is shown for SelectOneMenu in case first child is not > SelectItems or SelectItem > --- > > Key: MYFACES-1744 > URL: https://issues.apache.org/jira/browse/MYFACES-1744 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 > Environment: Windows XP >Reporter: Galina Gavrilo > Attachments: _SelectItemsIterator.patch, SelectItemsIterator.patch > > > If SelectOneMenu has child of another type than SelectItems or SelectItem at > first place in the children list (e.g. itomahawk jsValueChangeListener), > validation of combobox fails with message "Value is not a valid option." > Value range is empty in this case because _SelectItemsIterator hasNext() > method returns false if first child is not of type SelectItems or SelectItem. > It should just skip such children, and should continue looking for values. > Right? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1744) Validation messages is shown for SelectOneMenu in case first child is not SelectItems or SelectItem
[ https://issues.apache.org/jira/browse/MYFACES-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated MYFACES-1744: Status: Patch Available (was: Open) > Validation messages is shown for SelectOneMenu in case first child is not > SelectItems or SelectItem > --- > > Key: MYFACES-1744 > URL: https://issues.apache.org/jira/browse/MYFACES-1744 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 > Environment: Windows XP >Reporter: Galina Gavrilo > Attachments: _SelectItemsIterator.patch, SelectItemsIterator.patch > > > If SelectOneMenu has child of another type than SelectItems or SelectItem at > first place in the children list (e.g. itomahawk jsValueChangeListener), > validation of combobox fails with message "Value is not a valid option." > Value range is empty in this case because _SelectItemsIterator hasNext() > method returns false if first child is not of type SelectItems or SelectItem. > It should just skip such children, and should continue looking for values. > Right? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1744) Validation messages is shown for SelectOneMenu in case first child is not SelectItems or SelectItem
[ https://issues.apache.org/jira/browse/MYFACES-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538114 ] David Brainard commented on MYFACES-1744: - I have checked with the RI impl they dont have this problem. In myfaces if i have any type of component like f:param and f:valuechanelistener etc before f:selectitem or f:selectitems SelectItemsIterator and _SelectItemsIterator does not return correct value for hasNext(). I have added the following patch to both the classes SelectItemsIterator and _SelectItemsIterator so that they ignore the children which are not UISelectItem and UISelectItems. if (_childs.hasNext()) { UIComponent child = (UIComponent) _childs.next(); while(!(child instanceof UISelectItem) && !(child instanceof UISelectItems)) { child = (UIComponent) _childs.next(); } Pls comment if this approach is not suitable. i'll add a patch for this soon. > Validation messages is shown for SelectOneMenu in case first child is not > SelectItems or SelectItem > --- > > Key: MYFACES-1744 > URL: https://issues.apache.org/jira/browse/MYFACES-1744 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 1.1.5 > Environment: Windows XP >Reporter: Galina Gavrilo > > If SelectOneMenu has child of another type than SelectItems or SelectItem at > first place in the children list (e.g. itomahawk jsValueChangeListener), > validation of combobox fails with message "Value is not a valid option." > Value range is empty in this case because _SelectItemsIterator hasNext() > method returns false if first child is not of type SelectItems or SelectItem. > It should just skip such children, and should continue looking for values. > Right? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1116) ColumnClasses styles is ignored
[ https://issues.apache.org/jira/browse/TOMAHAWK-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537721 ] David Brainard commented on TOMAHAWK-1116: -- Patch added. Additional method getColumnStyleIndex() has been added to the HtmlTableRenderer class. This method calculates the correct columnStyleIndex taking the dynamic columns of UIColumns into consideration since uiData.getChildren() doesnt take the dynamic columns into consideration.. -David Brainard > ColumnClasses styles is ignored > --- > > Key: TOMAHAWK-1116 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1116 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Extended Datatable >Affects Versions: 1.1.3 > Environment: Microsoft Windows XP Professional Version 2002 Service > Pack 2, Microsoft Internet Explorer Version > 6.0.2900.2180.xpsp_sp2_gdr.050301-1519, IBM Rational Software Development > Platform Version: 6.0.1 Build id: 20050725_1800, WebSphere Application Server > v6.0 >Reporter: lea vogt >Priority: Blocker > Attachments: HtmlTableRenderer.patch > > > I am using and I am using the attribute columnClasses. > According to (http://myfaces.apache.org/tomahawk/tlddoc/t/dataTable.html) > columnClasses - A comma separated list of CSS class names to apply to td > elements in each column. > But this does not happen, when I define the columnClasses styles to be > applied in each column only the very first class is rendered for all columns. > This is how I did it: > cellspacing="0" columnClasses="columnClassLock,columnClassUnlock" > headerClass="headerClassTopLock" rowClasses="rowOdd,rowEven" > styleClass="dataTable"> > > > > > style="#{myDetailList.columnValue[currentColumn.label]}" rendered="#{not > myDetailList.columnValue[currentColumn.render]}" escape="false"/> > > style="#{myDetailList.columnValue[currentColumn.label]}" > rendered="#{myDetailList.columnValue [currentColumn.render]}" size="6" > maxlength="15"> > > > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1087) datatable dont renders a detail correct if a UIColumns is used
[ https://issues.apache.org/jira/browse/TOMAHAWK-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated TOMAHAWK-1087: - > datatable dont renders a detail correct if a UIColumns is used > -- > > Key: TOMAHAWK-1087 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1087 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Extended Datatable >Affects Versions: 1.1.6 >Reporter: Hartmut Kalk >Priority: Minor > > The detailStamp facet dont use the full size of table because of the > colspan-attribute of the detail-table is not not rendered for all dynamic > uicolumns. > Lets say we have a datatable with 3 UIColumn-Elements and 1 UIColumns-Element > with 3 more dynamic UIColumns, now the renderer will render a colspan of 4 > and not as expected 6. > To solve this problem we changed the method renderDetailRow(..) (line 147) in > HtmlDataTableRenderer as shown below: > //writer.writeAttribute(HTML.COLSPAN_ATTR,new > Integer(uiData.getChildren().size()) ,null); > int count = 0; > List list = uiData.getChildren(); > for (UIComponent component : list) { > if (component instanceof UIColumns) { > UIColumns v = (UIColumns) > component; > count += v.getRowCount(); > } > else{ > count++; > } > } > writer.writeAttribute(HTML.COLSPAN_ATTR,new Integer(count) > ,null); > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1133) Data Scroller doesnt honor dynamic rowclasses during pagination
[ https://issues.apache.org/jira/browse/TOMAHAWK-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535568 ] David Brainard commented on TOMAHAWK-1133: -- Hi Zdenek , According to the API docs "we keep iterating through the list until we reach the end," i.e the list of row classes should be iterated till the end. consider a case in which the no of columns rendered in the first page is less than the size of the the list of rowclasses for e.g: the no of rows rendered in the fist page is 3 but the size of rowclass list is 6 as given in the example above(bug description), Then the behavior should be something like this: the rows in the first page should have the the first three items of the list assigned to them and the 3 rows in the next page should have the next 3 styles assigned to them since we have to iterate till the end of the rowclasses. Now that we have reached the end of the list the next page will have the rowclasses assigned from the starting of the list i.e the pattern of the rowclasses will be repeated for every 2 pages in this case. But the behavior which we have now is something like as follows: the rows in the first page have the classes assigned to them correctly but when we go to the next page we get the same first three rowclasses assigned to them in spite of the fact that we have not iterated till the end of the rowclasses list. The actual problem is that the rowclasses are not iterated till the end. They are just iterated for every page from the starting. I have looked into this problem. The problem is in this piece of code in HtmlTableRendererBase if (nc == 0) { // first column in table, start new row beforeRow(facesContext, uiData); HtmlRendererUtils.writePrettyLineSeparator(facesContext); renderRowStart(facesContext, writer, uiData, styles, nr ); } The rowStyleIndex i.e nr which is passed to the method renderRowStart is the actual problem. Since it is a counter it starts every time from 0 and even when i navigate to the next page it starts from 0 so this causes the table to render the classes corresponding to the first page rather than the good classes. this fails for the particular case where "no of rowclasses" > "no of rows rendered in a particular page". so if we pass the actual row no instead of the counter this will solve the problem. I am looking into it. Thanks and Regards, David Brainard Sounthiraraj. > Data Scroller doesnt honor dynamic rowclasses during pagination > --- > > Key: TOMAHAWK-1133 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1133 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Data Scroller > Environment: Myfaces 1.1.5, Tomahawk 1.1.7snapshot, Tomahawk 1.1.6, > Tomcat 6.0 >Reporter: David Brainard > > While using a data scroller with datatable if we specify the rowclasses > dynamically(through value binding) only the first page gets the rowclasses > assigned properly . When we try to do pagination and go to other page the > same rowclasses which were used in the first page repeats i.e the rowclasses > doesnt get assigned properly. > for e.g; if i have a tag defined like this > value="#{testBean.dataList}" > columnClasses="#{testBean.styleClass}" > headerClass="headerClass" footerClass="footerClass" > rowClasses="#{testBean.rowClass}" > styleClass="dataTable" rows="3" > > and my rowclass returns something like this >public String getRowClass() { > return "rowOdd,rowOdd,rowEven,rowEven,rowEven,rowOdd"; > } > in first page the generated rowclasses are correct which is as follws: > > 1st row:rowOdd, > 2st row:rowOdd, > 3st row: rowEven > but when i navigate to next page the rowclasses assignment remains the same > as first page. > 1st row:rowOdd, > 2st row:rowOdd, > 3st row: rowEven > but it should be as follows: > 1st row:rowEven, > 2st row:rowEven, > 3st row: rowOdd > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1133) Data Scroller doesnt honor dynamic rowclasses during pagination
Data Scroller doesnt honor dynamic rowclasses during pagination --- Key: TOMAHAWK-1133 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1133 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Environment: Myfaces 1.1.5, Tomahawk 1.1.7snapshot, Tomahawk 1.1.6, Tomcat 6.0 Reporter: David Brainard While using a data scroller with datatable if we specify the rowclasses dynamically(through value binding) only the first page gets the rowclasses assigned properly . When we try to do pagination and go to other page the same rowclasses which were used in the first page repeats i.e the rowclasses doesnt get assigned properly. for e.g; if i have a tag defined like this and my rowclass returns something like this public String getRowClass() { return "rowOdd,rowOdd,rowEven,rowEven,rowEven,rowOdd"; } in first page the generated rowclasses are correct which is as follws: 1st row:rowOdd, 2st row:rowOdd, 3st row: rowEven but when i navigate to next page the rowclasses assignment remains the same as first page. 1st row:rowOdd, 2st row:rowOdd, 3st row: rowEven but it should be as follows: 1st row:rowEven, 2st row:rowEven, 3st row: rowOdd -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1116) ColumnClasses styles is ignored
[ https://issues.apache.org/jira/browse/TOMAHAWK-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534680 ] David Brainard commented on TOMAHAWK-1116: -- Hi lea, I have fixed the bug. there was a problem in the columnStyleIndex generation. i.e -In encodeColumnChild() method of the HtmlTableRenderer if the child is a UIColumns then the columnStyleIndex remains the same for all the child components. renderColumnBody(facesContext, writer, uiData, component, styles, columnStyleIndex ); to avoid this i have added counter 'k' to the columnStyleIndex - To manage when both UIColumns and UICoulmn are added to the datatable, the encodeInnerHtml() method in the HtmlTableRendererBase class need to be changed as follows: nc * uiData.getChildCount() + j + childCount-columnsCount I am attaching both the classes(HtmlTableRenderer and HtmlTableRendererBase ) for both 1.1.6 release and the latest snapshot 1.1.7. I AM NEW TO THIS SO CAN ANYONE PLS VALIDATE THIS FIX AND CREATE A PATCH(DIFF) FOR THIS BUG . :-) > ColumnClasses styles is ignored > --- > > Key: TOMAHAWK-1116 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1116 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Extended Datatable >Affects Versions: 1.1.3 > Environment: Microsoft Windows XP Professional Version 2002 Service > Pack 2, Microsoft Internet Explorer Version > 6.0.2900.2180.xpsp_sp2_gdr.050301-1519, IBM Rational Software Development > Platform Version: 6.0.1 Build id: 20050725_1800, WebSphere Application Server > v6.0 >Reporter: lea vogt >Priority: Blocker > > I am using and I am using the attribute columnClasses. > According to (http://myfaces.apache.org/tomahawk/tlddoc/t/dataTable.html) > columnClasses - A comma separated list of CSS class names to apply to td > elements in each column. > But this does not happen, when I define the columnClasses styles to be > applied in each column only the very first class is rendered for all columns. > This is how I did it: > cellspacing="0" columnClasses="columnClassLock,columnClassUnlock" > headerClass="headerClassTopLock" rowClasses="rowOdd,rowEven" > styleClass="dataTable"> > > > > > style="#{myDetailList.columnValue[currentColumn.label]}" rendered="#{not > myDetailList.columnValue[currentColumn.render]}" escape="false"/> > > style="#{myDetailList.columnValue[currentColumn.label]}" > rendered="#{myDetailList.columnValue [currentColumn.render]}" size="6" > maxlength="15"> > > > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1116) ColumnClasses styles is ignored
[ https://issues.apache.org/jira/browse/TOMAHAWK-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Brainard updated TOMAHAWK-1116: - Status: Patch Available (was: Open) > ColumnClasses styles is ignored > --- > > Key: TOMAHAWK-1116 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1116 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Extended Datatable >Affects Versions: 1.1.3 > Environment: Microsoft Windows XP Professional Version 2002 Service > Pack 2, Microsoft Internet Explorer Version > 6.0.2900.2180.xpsp_sp2_gdr.050301-1519, IBM Rational Software Development > Platform Version: 6.0.1 Build id: 20050725_1800, WebSphere Application Server > v6.0 >Reporter: lea vogt >Priority: Blocker > > I am using and I am using the attribute columnClasses. > According to (http://myfaces.apache.org/tomahawk/tlddoc/t/dataTable.html) > columnClasses - A comma separated list of CSS class names to apply to td > elements in each column. > But this does not happen, when I define the columnClasses styles to be > applied in each column only the very first class is rendered for all columns. > This is how I did it: > cellspacing="0" columnClasses="columnClassLock,columnClassUnlock" > headerClass="headerClassTopLock" rowClasses="rowOdd,rowEven" > styleClass="dataTable"> > > > > > style="#{myDetailList.columnValue[currentColumn.label]}" rendered="#{not > myDetailList.columnValue[currentColumn.render]}" escape="false"/> > > style="#{myDetailList.columnValue[currentColumn.label]}" > rendered="#{myDetailList.columnValue [currentColumn.render]}" size="6" > maxlength="15"> > > > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1107) component does not handle submission via the enter key in IE6
[ https://issues.apache.org/jira/browse/TOMAHAWK-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534180 ] David Brainard commented on TOMAHAWK-1107: -- even i am using like that in my project. Do we need a fix in the renderer. > component does not handle submission via the enter key in > IE6 > --- > > Key: TOMAHAWK-1107 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1107 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Calendar >Affects Versions: 1.1.6 > Environment: Windows XP, IE 6, MyFaces 1.1.5, Tomahawk 1.1.6 >Reporter: Todd Gould > > When using a tag such as: > value="#{alertSummaryController.sinceTime}" > popupDateFormat="MM/dd/ HH:mm:ss" > helpText="MM/dd/ HH:mm:ss" > title="MM/dd/ HH:mm:ss" > popupSelectDateMessage="Select [date] as date" > renderAsPopup="true" renderPopupButtonAsImage="true"> > in a JSP, pressing the enter key in the associated text entry field (say > after manually adjusting the date and/or time) does not produce the desired > result in IE6. In Firefox, this does work fine - it submits the form and > applies the specified value. However, in IE 6, this does not result in form > submission for some reason. > A work around to achieve the desired affect is to add the following to the > tag: > onkeypress="if( event.keyCode == 13 ) { this.form.submit(); > return false; }" -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.