[jira] Commented: (TOMAHAWK-754) Expose user role matching algorithm
[ https://issues.apache.org/jira/browse/TOMAHAWK-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486784 ] Steve Peterson commented on TOMAHAWK-754: - This will work for us. Thanks for the heads up on the new feature. Expose user role matching algorithm --- Key: TOMAHAWK-754 URL: https://issues.apache.org/jira/browse/TOMAHAWK-754 Project: MyFaces Tomahawk Issue Type: Improvement Affects Versions: 1.1.3 Reporter: Steve Peterson Attachments: UserRoleUtils.patch The attached patch refactors UserRoleUtils to create a new method: isInUserRole(String userRole) Methods isVisibleOnUserRole(UIComponent component) and isEnabledOnUserRole(UIComponent component) are modified to use the new method. The result of this change allows component writers to test for role membership directly, without having to instantiate a component. This is useful when a component creates a tree of children, and the contents of the tree can vary based on the user's membership in a role. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-730) 1.1.1RC3 jar interferes with Tomcat undeploy
[ http://issues.apache.org/jira/browse/MYFACES-730?page=comments#action_12431079 ] Steve Peterson commented on MYFACES-730: We're still on 1.1.1; I'll try it out on 1.1.3 when I get an opportunity. 1.1.1RC3 jar interferes with Tomcat undeploy Key: MYFACES-730 URL: http://issues.apache.org/jira/browse/MYFACES-730 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.1 Environment: XP SP 2, Tomcat 5.0.28, JDK 1.4.2_08 Reporter: Steve Peterson Did a test upgrade of a MyFaces 1.1.0 based app to 1.1.1 RC3. The app is deployed in Tomcat 5.0.28. After the application is deployed and I use it for a little bit, I try to undeploy it. The undeploy fails because the myfaces-all.jar file is still open after the application is stopped. The only workaround is to stop Tomcat and restart it. The 1.1.0 myfaces-all.jar file did not exhibit this behavior. My experience is that this occurs if there is an open reference to a resource in the jar file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-1290) ServletFacesContextImpl.release() doesn't reset
ServletFacesContextImpl.release() doesn't reset Key: MYFACES-1290 URL: http://issues.apache.org/jira/browse/MYFACES-1290 Project: MyFaces Core Type: Bug Components: General Versions: 1.1.1, 1.1.2 Reporter: Steve Peterson Priority: Minor When resetting the FacesContext, the _maximumSeverity field isn't reset. This causes the getMaximumSeverity() method to provide incorrect results after a release(). I would probably mark this as major if MyFaces pooled ServletFacesContextImpl instances, but they don't seem to be reused. Fix is to add the following line to the release() method: _maximumSeverity = null; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-1286) PanelTabbedPane: selecting tab during rendering can cause exceptions
PanelTabbedPane: selecting tab during rendering can cause exceptions
-
Key: MYFACES-1286
URL: http://issues.apache.org/jira/browse/MYFACES-1286
Project: MyFaces Core
Type: Bug
Components: General
Versions: 1.1.1
Environment: XP/JDK 1.5/Firefox and IE on Windows
Reporter: Steve Peterson
1. Create a tabbed pane layout with several tabs. Have one of the panels
include a boolean field (primitive) in the backing bean, fronted by a
SelectOneMenu. Make the panel with the boolean on it take a little while to
render.
2. Quickly move among the tabs. You will get exceptions of the form:
[[/id-barcode]] Cannot set value for expression
'#{designHandler.design.contrastOutlineText}' to null.
javax.faces.el.EvaluationException: Cannot set value for expression
'#{designHandler.design.contrastOutlineText}' to null.
at org.apache.myfaces.el.ValueBindingImpl.setValue(ValueBindingImpl.java:310)
at javax.faces.component.UIInput.updateModel(UIInput.java:287)
at javax.faces.component.UIInput.processUpdates(UIInput.java:223)
at
javax.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:715)
at
javax.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:715)
at
javax.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:715)
at
javax.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:715)
at javax.faces.component.UIForm.processUpdates(UIForm.java:87)
at
javax.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:715)
at javax.faces.component.UIViewRoot.processUpdates(UIViewRoot.java:158)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-991) equals validator shows text (nit nice by validating passwords...)
[ http://issues.apache.org/jira/browse/MYFACES-991?page=all ] Steve Peterson updated MYFACES-991: --- Attachment: myfaces-991.zip The attachment implements a BaseValidator and BaseValidatorTag that together support new validator tag attributes summaryMessage and detailMessage. These attributes are value bindings that should return a string message to be displayed. The string is presented to MessageFormat using standard locale processing and a validator-defined list of arguments. CreditCardValidator, EqualValidator, EmailValidator, URLValidator, and RegExprValidator are modified to support these tags. This patch targets the Mavenized build structure. equals validator shows text (nit nice by validating passwords...) - Key: MYFACES-991 URL: http://issues.apache.org/jira/browse/MYFACES-991 Project: MyFaces Type: Bug Components: Tomahawk Versions: Nightly Reporter: Matthias Weßendorf Assignee: Matthias Weßendorf Attachments: myfaces-991.zip dave I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side? /dave -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-989) Improved documentation for extended selectOneRadio and radio tags.
Improved documentation for extended selectOneRadio and radio tags. -- Key: MYFACES-989 URL: http://issues.apache.org/jira/browse/MYFACES-989 Project: MyFaces Type: Improvement Components: Tomahawk Versions: 1.1.1 Reporter: Steve Peterson Priority: Minor -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-989) Improved documentation for extended selectOneRadio and radio tags.
[ http://issues.apache.org/jira/browse/MYFACES-989?page=all ] Steve Peterson updated MYFACES-989: --- Attachment: myfaces-989.patch Improved documentation for extended selectOneRadio and radio tags. -- Key: MYFACES-989 URL: http://issues.apache.org/jira/browse/MYFACES-989 Project: MyFaces Type: Improvement Components: Tomahawk Versions: 1.1.1 Reporter: Steve Peterson Priority: Minor Attachments: myfaces-989.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-990) Unhelpful stack trace when tag value binding returns wrong type.
Unhelpful stack trace when tag value binding returns wrong type.
Key: MYFACES-990
URL: http://issues.apache.org/jira/browse/MYFACES-990
Project: MyFaces
Type: Improvement
Components: Implementation
Versions: 1.1.1
Reporter: Steve Peterson
Priority: Minor
In the implementation of each UIComponent, the canonical logic for retrieving a
non-String property is to cast the result
of the valueBinding.getValue() method to the expected type.
public boolean isItemDisabled()
{
if (_itemDisabled != null) return _itemDisabled.booleanValue();
ValueBinding vb = getValueBinding(itemDisabled);
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) : null;
return v != null ? v.booleanValue() : DEFAULT_ITEMDISABLED;
}
Yields an obscure stack trace that doesn't yield the ID of the component or the
property that is being referenced:
ERROR 14:45:28 [[jsp]] Servlet.service() for servlet jsp threw exception
java.lang.ClassCastException: java.lang.String
at
javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:117)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:50)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.renderNormal(HtmlTextRenderer.java:72)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.encodeEnd(HtmlTextRenderer.java:58)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-990) Unhelpful stack trace when tag value binding returns wrong type.
[ http://issues.apache.org/jira/browse/MYFACES-990?page=all ]
Steve Peterson updated MYFACES-990:
---
Attachment: typed-value-binding.patch
This patch modifies every standard component implementation to change the logic
behind typed references to the result of evaluating value bindings. The
evaluation result is tested to determine whether it matches the expected type,
and, if not, an EvaluationException is thrown giving the component's ID, the
binding, the expected type, and the actual returned type. The most common
changes were Boolean, Number, and Converter results. Value bindings that
returned Object or String were not modified.
These changes rely on a new helper method _ComponentUtils.getTypedValue() in
both javax.faces.Component and javax.faces.component.Html to do the work of
testing the resulting type and throw the exception. Note that this code is
identical in both packages, which seems to be the pattern for this helper class.
Unhelpful stack trace when tag value binding returns wrong type.
Key: MYFACES-990
URL: http://issues.apache.org/jira/browse/MYFACES-990
Project: MyFaces
Type: Improvement
Components: Implementation
Versions: 1.1.1
Reporter: Steve Peterson
Priority: Minor
Attachments: typed-value-binding.patch
In the implementation of each UIComponent, the canonical logic for retrieving
a non-String property is to cast the result
of the valueBinding.getValue() method to the expected type.
public boolean isItemDisabled()
{
if (_itemDisabled != null) return _itemDisabled.booleanValue();
ValueBinding vb = getValueBinding(itemDisabled);
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) :
null;
return v != null ? v.booleanValue() : DEFAULT_ITEMDISABLED;
}
Yields an obscure stack trace that doesn't yield the ID of the component or
the property that is being referenced:
ERROR 14:45:28 [[jsp]] Servlet.service() for servlet jsp threw exception
java.lang.ClassCastException: java.lang.String
at
javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:117)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:50)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.renderNormal(HtmlTextRenderer.java:72)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.encodeEnd(HtmlTextRenderer.java:58)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-990) Unhelpful stack trace when tag value binding returns wrong type.
[
http://issues.apache.org/jira/browse/MYFACES-990?page=comments#action_12361446
]
Steve Peterson commented on MYFACES-990:
The new message looks like this:
ERROR 14:57:45 [[jsp]] Servlet.service() for servlet jsp threw exception
javax.faces.el.EvaluationException: Evaluating disabled for
fixedBarcodeNumberLength; expected type java.lang.Boolean but expression
evaluated to java.lang.String
at
javax.faces.component.html._ComponentUtils.getTypedValue(_ComponentUtils.java:67)
at
javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:116)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
Unhelpful stack trace when tag value binding returns wrong type.
Key: MYFACES-990
URL: http://issues.apache.org/jira/browse/MYFACES-990
Project: MyFaces
Type: Improvement
Components: Implementation
Versions: 1.1.1
Reporter: Steve Peterson
Priority: Minor
Attachments: typed-value-binding.patch
In the implementation of each UIComponent, the canonical logic for retrieving
a non-String property is to cast the result
of the valueBinding.getValue() method to the expected type.
public boolean isItemDisabled()
{
if (_itemDisabled != null) return _itemDisabled.booleanValue();
ValueBinding vb = getValueBinding(itemDisabled);
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) :
null;
return v != null ? v.booleanValue() : DEFAULT_ITEMDISABLED;
}
Yields an obscure stack trace that doesn't yield the ID of the component or
the property that is being referenced:
ERROR 14:45:28 [[jsp]] Servlet.service() for servlet jsp threw exception
java.lang.ClassCastException: java.lang.String
at
javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:117)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
at
org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:50)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.renderNormal(HtmlTextRenderer.java:72)
at
org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.encodeEnd(HtmlTextRenderer.java:58)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-971) Updated tag documentation for UI commands
Updated tag documentation for UI commands - Key: MYFACES-971 URL: http://issues.apache.org/jira/browse/MYFACES-971 Project: MyFaces Type: Improvement Versions: Nightly Reporter: Steve Peterson The action attribute accepts a string literal as well as a method binding EL expression. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-971) Updated tag documentation for UI commands
[ http://issues.apache.org/jira/browse/MYFACES-971?page=all ] Steve Peterson updated MYFACES-971: --- Attachment: uic.patch Patch containing updated documentation. Updated tag documentation for UI commands - Key: MYFACES-971 URL: http://issues.apache.org/jira/browse/MYFACES-971 Project: MyFaces Type: Improvement Versions: Nightly Reporter: Steve Peterson Attachments: uic.patch The action attribute accepts a string literal as well as a method binding EL expression. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-787) defining attributes in tomahawk.tld makes it difficult to subclass tomahawk components
[ http://issues.apache.org/jira/browse/MYFACES-787?page=comments#action_12360248 ] Steve Peterson commented on MYFACES-787: I'm +1 on this as well. Considered doing this as part of my big docs patch a while back but decided to focus mostly on the standard tags. This will speed improvements in the tomahawk TLD docs. defining attributes in tomahawk.tld makes it difficult to subclass tomahawk components -- Key: MYFACES-787 URL: http://issues.apache.org/jira/browse/MYFACES-787 Project: MyFaces Type: Improvement Reporter: Simon Kitching Attachments: html_column_attributes.xml, tomahawk.tld.patch The tomahawk.tld file uses xml entities to reference some attributes shared between components. However the attributes for tomahawk components are defined in-line in the tomahawk.tld file. When subclassing a tomahawk component to extend it, all of the text needs to be copied into the tld where the derived component is defined - ugly, esp. for things like HtmlColumn that have dozens of attributes. Attached is a patch to simply move the attributes defined in tomahawk.tld for the HtmlColumn tag into an external entity file, thus allowing derived classes to just reference this entity file. I'm happy to provide patches to move all defined attributes for other tomahawk components into entity files too, though it probably takes more time to apply/commit such patches than it would for a MyFaces committer to make this change directly. One possible variant on this patch is to move the other entity refs which are used by HtmlColumn into the html_column_attributes.xml file, so that the HtmlColumn definition in tomahawk.tld just contains one reference. That makes subclassing even easier, and seems sensible. It's a slightly more adventurous change, though, so I've submitted the simpler approach as the patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-892) Broken date converter
[ http://issues.apache.org/jira/browse/MYFACES-892?page=comments#action_12358938 ] Steve Peterson commented on MYFACES-892: You need to specify the timezone on your tag. 1.1.0 was not spec compliant in converting dates when no timezone was provided. See the most recent discussion on the mailing list at http://marc.theaimsgroup.com/?l=myfaces-userm=113027112310925w=2 Broken date converter - Key: MYFACES-892 URL: http://issues.apache.org/jira/browse/MYFACES-892 Project: MyFaces Type: Bug Environment: IBM Websphere CE, Windows XP, IBM JDK 1.4.2 Reporter: Routis Haralampos Priority: Critical When I use the date converter (my enveronment uses greek locale) f:convertDateTime pattern=dd/MM/ type=date / the inputText or the tomahawk inputCalendar displays one before the date that my managed bean contains. For example if my beans contains a date a) '2005-12-31 00:00:00' the jsp presents a value '30/12/2005' b) '2005-12-31 14:00:00' the jsp presents a value '30/12/2005' MyFaces 1.1.0 works fine -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-895) Doc patch for f:convertDateTime to clarify timezone
Doc patch for f:convertDateTime to clarify timezone --- Key: MYFACES-895 URL: http://issues.apache.org/jira/browse/MYFACES-895 Project: MyFaces Type: Improvement Components: Implementation Versions: 1.1.1 Reporter: Steve Peterson Confusion continues to surround f:convertDateTime and timezone handling. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: faces_attributes.tar Factor out id and binding attributes into separate files. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: faces_attributes.tar, new_files.tar, tld-docs.patch, tomahawk.tld.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: thawk2.patch Update attributes files to refer to new faces id and binding attributes. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: faces_attributes.tar, new_files.tar, thawk2.patch, tld-docs.patch, tomahawk.tld.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: sbox.patch Update sandbox.tld with other changes in this patch. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: faces_attributes.tar, new_files.tar, sbox.patch, thawk.patch, thawk2.patch, tld-docs.patch, tomahawk.tld.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: thawk.patch Update tomahawk.tld to use refactored id and binding attributes. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: faces_attributes.tar, new_files.tar, sbox.patch, thawk.patch, thawk2.patch, tld-docs.patch, tomahawk.tld.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: new_files.tar This attachment contains new files that were not included in the patch. They are necessary to make the patch work. Thanks for considering my contribution. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: new_files.tar, tld-docs.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: tomahawk.tld.patch This patch updates tomahawk/tld/tomahawk.tld to work with the first patch. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: new_files.tar, tld-docs.patch, tomahawk.tld.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-866) Updates to standard tag TLD documentation
Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: tld-docs.patch This patch significantly improves the TLD documentation for the basic h: and f: tag libraries. Major revisions: Every element and every attribute is documented. Deprecated HTML 4.01 tags are documented. Every attribute has its type specified, if it varies from the default of static or value binding EL. Change UIParameter value attribute to required per spec. Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: tld-docs.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-866) Updates to standard tag TLD documentation
[ http://issues.apache.org/jira/browse/MYFACES-866?page=comments#action_12358337 ] Steve Peterson commented on MYFACES-866: Once the tld-docs.patch is accepted and I sync up, I'll be submitting another patch to bring the changes over into the Tomahawk tld files. Can we keep this bug open to handle that patch too? Updates to standard tag TLD documentation - Key: MYFACES-866 URL: http://issues.apache.org/jira/browse/MYFACES-866 Project: MyFaces Type: Improvement Components: General Versions: 1.1.1 Reporter: Steve Peterson Attachments: tld-docs.patch Patch coming shortly with better documented TLD files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-842) Typo in t:htmlTag documentation
Typo in t:htmlTag documentation --- Key: MYFACES-842 URL: http://issues.apache.org/jira/browse/MYFACES-842 Project: MyFaces Type: Bug Components: Tomahawk Versions: Nightly Reporter: Steve Peterson Priority: Trivial Attachments: myfaces-842.patch.txt The syntax section mentions the wrong tag name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-842) Typo in t:htmlTag documentation
[ http://issues.apache.org/jira/browse/MYFACES-842?page=all ] Steve Peterson updated MYFACES-842: --- Attachment: myfaces-842.patch.txt Patch to resolve issue. Typo in t:htmlTag documentation --- Key: MYFACES-842 URL: http://issues.apache.org/jira/browse/MYFACES-842 Project: MyFaces Type: Bug Components: Tomahawk Versions: Nightly Reporter: Steve Peterson Priority: Trivial Attachments: myfaces-842.patch.txt The syntax section mentions the wrong tag name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-730) 1.1.1RC3 jar interferes with Tomcat undeploy
[ http://issues.apache.org/jira/browse/MYFACES-730?page=comments#action_12355674 ] Steve Peterson commented on MYFACES-730: Is code review really the only way to get to this? I'd be willing to help but don't know where to start. I just tried to run it down by expanding the jar into the WEB-INF/classes but, of course, the webapp cleanly deploys in that situation. Note that the problem occurs during initialization; the jar is open at the point that the webapp is initialized, but before the first request is processed. http://tomcat.apache.org/faq/windows.html#lock has some notes on what might cause the problem. 1.1.1RC3 jar interferes with Tomcat undeploy Key: MYFACES-730 URL: http://issues.apache.org/jira/browse/MYFACES-730 Project: MyFaces Type: Bug Components: General Versions: 1.1.1 Environment: XP SP 2, Tomcat 5.0.28, JDK 1.4.2_08 Reporter: Steve Peterson Did a test upgrade of a MyFaces 1.1.0 based app to 1.1.1 RC3. The app is deployed in Tomcat 5.0.28. After the application is deployed and I use it for a little bit, I try to undeploy it. The undeploy fails because the myfaces-all.jar file is still open after the application is stopped. The only workaround is to stop Tomcat and restart it. The 1.1.0 myfaces-all.jar file did not exhibit this behavior. My experience is that this occurs if there is an open reference to a resource in the jar file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-730) 1.1.1RC3 jar interferes with Tomcat undeploy
1.1.1RC3 jar interferes with Tomcat undeploy Key: MYFACES-730 URL: http://issues.apache.org/jira/browse/MYFACES-730 Project: MyFaces Type: Bug Components: General Versions: 1.1.1 Environment: XP SP 2, Tomcat 5.0.28, JDK 1.4.2_08 Reporter: Steve Peterson Did a test upgrade of a MyFaces 1.1.0 based app to 1.1.1 RC3. The app is deployed in Tomcat 5.0.28. After the application is deployed and I use it for a little bit, I try to undeploy it. The undeploy fails because the myfaces-all.jar file is still open after the application is stopped. The only workaround is to stop Tomcat and restart it. The 1.1.0 myfaces-all.jar file did not exhibit this behavior. My experience is that this occurs if there is an open reference to a resource in the jar file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-741) Enhanced exception messages for UIComponentTagUtils
Enhanced exception messages for UIComponentTagUtils --- Key: MYFACES-741 URL: http://issues.apache.org/jira/browse/MYFACES-741 Project: MyFaces Type: Improvement Components: Implementation Versions: 1.1.0 Environment: XP / JDK 1.4.2_09 Reporter: Steve Peterson Priority: Minor The attached patch contains some improved exception messages that provide some context when tag attributes contain bad values. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-741) Enhanced exception messages for UIComponentTagUtils
[ http://issues.apache.org/jira/browse/MYFACES-741?page=all ] Steve Peterson updated MYFACES-741: --- Attachment: patch.txt Enhanced exception messages for UIComponentTagUtils --- Key: MYFACES-741 URL: http://issues.apache.org/jira/browse/MYFACES-741 Project: MyFaces Type: Improvement Components: Implementation Versions: 1.1.0 Environment: XP / JDK 1.4.2_09 Reporter: Steve Peterson Priority: Minor Attachments: patch.txt The attached patch contains some improved exception messages that provide some context when tag attributes contain bad values. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
