[jira] [Commented] (MYFACES-3203) improve h:form problems diagnostics

[Vicente Rossello Jaume (Jira)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Vicente Rossello Jaume commented on  MYFACES-3203  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: improve h:form problems diagnostics   
 

  
 
 
 
 

 
 It's implemented in omnifaces if it can be of any use. See https://github.com/omnifaces/omnifaces/issues/181 and https://github.com/omnifaces/omnifaces/issues/349  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   

Re: [VOTE] release of MyFaces Core 2.3-next-M5

[Vicente Rossello]

+1, tested.


El jue., 11 feb. 2021 8:00, Thomas Andraschko 
escribió:

> +1
>
> Bill Lucy  schrieb am Do., 11. Feb. 2021, 00:46:
>
>> Thanks for running this Paul, looks good to me
>>
>> +1
>>
>> On Wed, Feb 10, 2021 at 3:45 PM Paul Nicolucci 
>> wrote:
>>
>>> Hi,
>>>
>>> I was running the needed tasks to get the 2.3-next-M5 release of Apache
>>> MyFaces core out.
>>>
>>> Please note that this vote concerns all of the following parts:
>>>   1. Maven artifact group "org.apache.myfaces.core" v2.3-next-M5  [1]
>>>
>>> The artifacts were deployed on nexus repo [1] for binary and source
>>> packages.
>>>
>>> The release notes could be found at [4].
>>>
>>> Also the japicmp tool (similar to clirr) shows there are a few new API
>>> clases from 2.3-next-M4 to 2.3-next-M5. I've attached the results to
>>> this email as well (results.html).
>>>
>>> If any concerns with the above let me know.
>>>
>>> Please take a look at the "2.3-next-M5" artifacts and vote! (see [3])
>>>
>>> Please note: This vote is "majority approval" with a minimum of three +1
>>> votes (see [2]).
>>>
>>> 
>>> [ ] +1 for community members who have reviewed the bits
>>> [ ] +0
>>> [ ] -1 for fatal flaws that should cause these bits not to be released,
>>> and why..
>>> 
>>>
>>> Thanks,
>>> Paul Nicolucci
>>>
>>> [1]
>>> *https://repository.apache.org/content/repositories/orgapachemyfaces-1182/*
>>> 
>>> [2] *http://www.apache.org/foundation/voting.html#ReleaseVotes*
>>> 
>>> [3]
>>> *https://repository.apache.org/content/repositories/orgapachemyfaces-1182/org/apache/myfaces/core/myfaces-core-assembly/*
>>> 
>>> [4]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12348727
>>>
>>

Re: [VOTE] release of MyFaces Core 2.3-next-M4

[Vicente Rossello]

Hi,

Tested in our application, everything works.

+1


On Wed, Sep 2, 2020 at 9:17 PM Bill Lucy  wrote:

> +1 from me, thanks Thomas
>
> Regards,
> Bill
>
> On Mon, Aug 31, 2020 at 2:46 AM Czarnecki, Piotr <
> piotr.czarne...@sbb.spk-berlin.de> wrote:
>
>> +1
>>
>>
>>
>> Thanks!
>>
>>
>>
>>
>>
>>
>>
>> *Von:* Thomas Andraschko 
>> *Gesendet:* Samstag, 29. August 2020 11:23
>> *An:* MyFaces Development 
>> *Betreff:* Re: [VOTE] release of MyFaces Core 2.3-next-M4
>>
>>
>>
>> My own +1
>>
>>
>>
>> Thomas Andraschko  schrieb am Mi., 26. Aug.
>> 2020, 18:53:
>>
>> Hi,
>>
>>
>>
>> I was running the needed tasks to get the 2.3-next-M4 release of Apache
>>
>> MyFaces core out.
>>
>>
>>
>> Please note that this vote concerns all of the following parts:
>>
>>1. Maven artifact group "org.apache.myfaces.core" v2.3-next-M4 [1]
>>
>>
>>
>> The artifacts were deployed on nexus repo [1] for binary and source packages.
>>
>>
>>
>> The release notes could be found at [4].
>>
>>
>>
>> Also the japicmp tool (similar to clirr) does not show binary 
>> incompatibilities with myfaces-api.
>>
>>
>>
>> Please take a look at the "2.3-next-M4" artifacts and vote! (see [3])
>>
>>
>>
>> Please note: This vote is "majority approval" with a minimum of three +1 
>> votes (see [2]).
>>
>>
>>
>> 
>>
>> [ ] +1 for community members who have reviewed the bits
>>
>> [ ] +0
>>
>> [ ] -1 for fatal flaws that should cause these bits not to be released, and 
>> why..
>>
>> 
>>
>>
>>
>> Thanks,
>>
>> Thomas Andraschko
>>
>>
>>
>> [1] 
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1170/org/apache/myfaces/core/
>>
>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>>
>> [3] 
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1170/org/apache/myfaces/core/myfaces-core-assembly/
>>
>> [4] 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12348458
>>
>>

Re: "[VOTE] release of MyFaces Core 2.3-next-M3"

[Vicente Rossello]

Hi,

I just tested it.

I've had a few problems with methodHandles (maybe those were not correct
before, but the problem starts with method handles).

1.- We were checking in some case a property class name from within EL and
that does not work with methodHandles. See
https://stackoverflow.com/questions/10314214/instanceof-check-in-el-expression-language
 . We can workaround using of:isIntance (which is probably a better
solution).
2.- We were using java.awt.Dimension to pass image size as 1 attribute and
that fails with  java.lang.IllegalAccessException: module java.desktop does
not open java.awt to unnamed module We can work around this with
--add-opens=java.desktop/java.awt=ALL-UNNAMED
3.- #{someTimezone.ID} also fails with module java.base does not open
sun.util.calendar to unnamed module   , not sure how to open this one
4.- I really don't understand this one but I have:



fails with:

java.lang.NullPointerException: Cannot invoke
"org.apache.myfaces.core.api.shared.lang.LambdaPropertyDescriptor.getPropertyType()"
because the return value of
"org.apache.myfaces.el.resolver.LambdaBeanELResolver.getPropertyDescriptor(Object,
Object)" is null
at 
org.apache.myfaces.el.resolver.LambdaBeanELResolver.getType(LambdaBeanELResolver.java:54)
at javax.el.CompositeELResolver.getType(CompositeELResolver.java:92)
at 
org.primefaces.el.InterceptingResolver.getType(InterceptingResolver.java:67)
at org.apache.el.parser.AstValue.getType(AstValue.java:60)
at 
org.apache.el.ValueExpressionImpl.getType(ValueExpressionImpl.java:174)

base is: "http://localhost;

property is "concat"

If it's not inside an input text it does not fail (just #{
Faces:getRequestBaseURL().concat('questionnaire/')}  )

I understand that 1 to 3 are limitations of MethodHandles and the user
should be responsible for handling those?

Hope it's something useful.

Best regards,
Vicente.

On Tue, Jun 30, 2020 at 2:12 PM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Hi,
>
> I was running the needed tasks to get the 2.3-next-M3 release of Apache
> MyFaces core out.
> It contains new features, performance improvements, bugfixes and provides 
> compatibility with Quarkus 1.5.2.
>
> Please note that this vote concerns all of the following parts:
>1. Maven artifact group "org.apache.myfaces.core" v2.3-next-M3  [1]
>
> The artifacts were deployed on nexus repo [1] for binary and source packages.
>
> The release notes could be found at [4].
>
> Please take a look at the "2.3-next-M3" artifacts and vote! (see [3])
>
> Please note: This vote is "majority approval" with a minimum of three +1 
> votes (see [2]).
>
> 
> [ ] +1 for community members who have reviewed the bits
> [ ] +0
> [ ] -1 for fatal flaws that should cause these bits not to be released, and 
> why..
> 
>
> Thanks,
> Thomas
>
> [1] 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1162/org/apache/myfaces/core/
> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> [3] 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1162/org/apache/myfaces/core/myfaces-core-assembly/
> [4] 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12347873
>
>

Myfaces 2.3-next-M1

[Vicente Rossello]

Hi,

I found another difference between 2.3.6 and 2.3-next-M1, not sure if it's
a bug, but it can impact some users.

I have a custom headRenderer to inject resources:

@ResourceDependency(library = "javax.faces", name = "jsf.js")
public class HeadRenderer extends Renderer {

...

}


And then a simple page with a commandlink:



hello

This link throws js exception in 2.3






(notice there is no  element)


This works in 2.3.6 but throws a js exception in 2.3-next because
jsf.js has not been loaded.

A simple workaround is to declare an empty  element

I have set up an example in https://github.com/cocorossello/tomee-example


(The custom renderer does not make a difference anyway, but the example has it)

Re: Myfaces 2.3-next-M1 question

[Vicente Rossello]

Thanks, I confirm that it works setting org.apache.myfaces.SUPPORT_JSP =
false. I will deploy this build again.

On Tue, Jan 7, 2020 at 2:25 PM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Should better for M2:
>
> https://github.com/apache/myfaces/commit/d2549787f085d9e58e778c682866bcda34b8f942
>
> https://issues.apache.org/jira/browse/MYFACES-4315
> <https://github.com/apache/myfaces/commit/d2549787f085d9e58e778c682866bcda34b8f942>
>
> Am Di., 7. Jan. 2020 um 14:14 Uhr schrieb Thomas Andraschko <
> andraschko.tho...@gmail.com>:
>
>> I think setting
>> org.apache.myfaces.SUPPORT_JSP  = false
>> in web.xml
>> should fix it; we should make it the default actually
>>
>> Am Di., 7. Jan. 2020 um 14:09 Uhr schrieb Thomas Andraschko <
>> andraschko.tho...@gmail.com>:
>>
>>> and thanks for testing! every help is welcome :)
>>> i currently try to build the homepage for 2.3-next and after that
>>> publish the release mail and a blog about the changes
>>>
>>> Am Di., 7. Jan. 2020 um 14:03 Uhr schrieb Thomas Andraschko <
>>> andraschko.tho...@gmail.com>:
>>>
>>>> Hi,
>>>>
>>>> can you post the stacktrace?
>>>>
>>>>
>>>> Am Di., 7. Jan. 2020 um 13:59 Uhr schrieb Vicente Rossello <
>>>> cocorosse...@gmail.com>:
>>>>
>>>>> Hi,
>>>>>
>>>>> I was trying a  bit more myfaces next and I've noticed a behaviour
>>>>> change.
>>>>>
>>>>> If I call the URL http://localhost/somepagenotexists/  I get an error
>>>>> "java.lang.NoClassDefFoundError: javax/servlet/jsp/jstl/core/Config".
>>>>> With version 2.3.6 I get a 404 error.
>>>>>
>>>>> (notice the ending slash in the URL)
>>>>>
>>>>> Is it a bug?
>>>>>
>>>>> Thanks,
>>>>> Vicente.
>>>>>
>>>>

Myfaces 2.3-next-M1 question

[Vicente Rossello]

Hi,

I was trying a  bit more myfaces next and I've noticed a behaviour change.

If I call the URL http://localhost/somepagenotexists/  I get an error
"java.lang.NoClassDefFoundError:
javax/servlet/jsp/jstl/core/Config". With version 2.3.6 I get a 404 error.

(notice the ending slash in the URL)

Is it a bug?

Thanks,
Vicente.

Re: [VOTE] release of MyFaces Core 2.3-next-M1

[Vicente Rossello]

Hi Thomas,

FYI, tested in our project, everything works.

Thank you for the effort

On 2019/12/19 12:43:19, Thomas Andraschko  wrote: 
> Hi,
> 
> I was running the needed tasks to get the 2.3-next-M1 release of Apache
> MyFaces core out.
> 
> 2.3-next contains the following big changes compared to 2.3:
> 
> - big refactoring and cleanup of our codebase!
> - removed FacesEL implementation (API still stays) as its unused since 2.0
> - removed the ManagedBean impl (API still stays) and register all
> found @ManagedBeans as CDI beans
> - reduced myfaces-jar sizes (including dependencies) about 1MB!
>   No commons-* dependencies required anymore
> - up to 15% better performance
> - we have a running quarkus extension
>   there also is a showcase:
> https://github.com/apache/myfaces/tree/master/extensions/quarkus/showcase
>   you can run it via "mvn compile quarkus:dev"
> 
> I will write a blogpost when it's released.
> 
> 
> Please note that this vote concerns all of the following parts:
>1. Maven artifact group "org.apache.myfaces.core" v2.3-next-M1  [1]
> 
> The artifacts were deployed on nexus repo [1] for binary and source packages.
> 
> The release notes could be found at [4].
> 
> Also the japicmp tool (similar to clirr) does not show binary
> incompatibilities with myfaces-api.
> 
> Please take a look at the "2.3-next-M1" artifacts and vote! (see [3])
> 
> Please note: This vote is "majority approval" with a minimum of three
> +1 votes (see [2]).
> 
> 
> [ ] +1 for community members who have reviewed the bits
> [ ] +0
> [ ] -1 for fatal flaws that should cause these bits not to be
> released, and why..
> 
> 
> Thanks,
> Thomas Andraschko
> 
> [1] 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1155/org/apache/myfaces/core/
> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> [3] 
> https://repository.apache.org/service/local/repositories/orgapachemyfaces-1155/org/apache/myfaces/core/myfaces-core-assembly/
> [4] 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12344343
> 

[jira] [Created] (MYFACES-4248) OpenWebBeansELResolverComparator references outdated openwebbeans package

[Vicente Rossello Jaume (JIRA)]

Vicente Rossello Jaume created MYFACES-4248:
---

 Summary: OpenWebBeansELResolverComparator references outdated 
openwebbeans package
 Key: MYFACES-4248
 URL: https://issues.apache.org/jira/browse/MYFACES-4248
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.3.1, 2.2.12
Reporter: Vicente Rossello Jaume


OpenWebBeansELResolverComparator references 
org.apache.webbeans.el.WebBeansELResolver.

I think that the correct one is org.apache.webbeans.el22.WebBeansELResolver , 
at least since openwebbeans 1.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MYFACES-4210) ResponseWriterWrapper does not match spec class

[Vicente Rossello Jaume (JIRA)]

Vicente Rossello Jaume created MYFACES-4210:
---

 Summary: ResponseWriterWrapper does not match spec class 
 Key: MYFACES-4210
 URL: https://issues.apache.org/jira/browse/MYFACES-4210
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Vicente Rossello Jaume


ResponseWriterWrapper in jsf 2.3 spec does not have an abstract getWrapped() 
method. This causes a bug with omnifaces.

https://github.com/omnifaces/omnifaces/issues/448



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)