[GitHub] [myfaces] tandraschko commented on pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions

2023-07-31 Thread via GitHub


tandraschko commented on PR #590:
URL: https://github.com/apache/myfaces/pull/590#issuecomment-1658267004

   i general i think its a nice feature but MyfacesConfig is currently handled 
AppScoped, to correctly support it, we would need to be request scoped (EL can 
change each request)
   i would close it as wont fix for now TBH


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] tandraschko commented on pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions

2023-07-31 Thread via GitHub


tandraschko commented on PR #590:
URL: https://github.com/apache/myfaces/pull/590#issuecomment-1658266092

   why is it not correct use FC? not available yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org